From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: run depmod only if modules directory exists
Date: Wed, 24 Jun 2020 22:17:31 +0200 [thread overview]
Message-ID: <20200624201731.GJ20645@scaer> (raw)
In-Reply-To: <20200623113859.172177-1-paul@crapouillou.net>
Paul, All,
On 2020-06-23 13:38 +0200, Paul Cercueil spake thusly:
> If the modules directory that corresponds to the version of the kernel
> being built has been deleted, don't try to run depmod, which will
> obviously fail.
>
> This can happen for instance when the modules are stripped from the main
> root filesystem, and placed into a separate filesystem image, so that
> the root filesystem and the kernel can be updated separately.
I fail to see how this can happen, sine:
- LINUX_RUN_DEPMOD is run as a TARGET_FINALIZE_HOOKS
- TARGET_FINALIZE_HOOKS are run ultra-early in the target-finalize
step, way before we run post-build scripts.
So, how can you end up with a /lib/modules/VERSIO/ directory missing?
(Note that I find your reason valid, I'm just curious to understand how
this can happen before I apply the patch.)
Regards,
Yann E. MORIN.
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> linux/linux.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index b90b032bb9..d31933fea1 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -490,7 +490,8 @@ endef
> # Run depmod in a target-finalize hook, to encompass modules installed by
> # packages.
> define LINUX_RUN_DEPMOD
> - if grep -q "CONFIG_MODULES=y" $(LINUX_DIR)/.config; then \
> + if test -d $(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED) \
> + && grep -q "CONFIG_MODULES=y" $(LINUX_DIR)/.config; then \
> $(HOST_DIR)/sbin/depmod -a -b $(TARGET_DIR) $(LINUX_VERSION_PROBED); \
> fi
> endef
> --
> 2.27.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-06-24 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 11:38 [Buildroot] [PATCH] linux: run depmod only if modules directory exists Paul Cercueil
2020-06-24 20:17 ` Yann E. MORIN [this message]
2020-06-24 21:20 ` Paul Cercueil
2020-08-29 14:58 ` Yann E. MORIN
2020-08-29 17:43 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624201731.GJ20645@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.