All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image
Date: Wed, 24 Jun 2020 22:21:40 +0200	[thread overview]
Message-ID: <20200624202140.GK20645@scaer> (raw)
In-Reply-To: <LRqYEr-8n8UCFItcyNs3C7MB6QE2qjqOzG6oeXtPjF0qV_bhTXsJ2-mD4NDoS9Ro4UsvpwIh8HK5vcnjj87xxjS8QVNoFCyX9WMEBOu17As=@protonmail.com>

Yair, All,

On 2020-06-23 23:04 +0000, Yair Ben-Avraham spake thusly:
> Signed-off-by: Yair Ben Avraham <yairba@protonmail.com>
> ---
>  boot/uboot/Config.in | 5 +++++
>  boot/uboot/uboot.mk  | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index 8cce9b1bae..310c4f8186 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE
>         help
>           Source file to generate the U-Boot boot script.
> 
> +config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
> +       string "U-Boot boot script image name"
> +       help
> +         Image (*not* file) name.
> +
>  endif
> 
>  if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index 71689207e3..ab945eb159 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
>         $(UBOOT_GENERATE_ENV_IMAGE)
>         $(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
>                 $(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
> +                       -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \

So, when the user does not set the option, we will end up passing:

    -n ""

Is that correct?

Regards,
Yann E. MORIN.

>                         -d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \
>                         $(BINARIES_DIR)/boot.scr)
>  endef
> --
> 2.20.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-06-24 20:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 23:04 [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image Yair Ben-Avraham
2020-06-24 20:21 ` Yann E. MORIN [this message]
2020-07-06  4:11   ` Yair Ben-Avraham
2022-01-09 14:54 ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624202140.GK20645@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.