From: Bruno Meneguele <bmeneg@redhat.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, Petr Vorel <pvorel@suse.cz>,
Maurizio Drocco <maurizio.drocco@ibm.com>
Subject: Re: [PATCH] ima-evm-utils: tests: fix finding the "boot_aggregate" value
Date: Wed, 24 Jun 2020 18:52:06 -0300 [thread overview]
Message-ID: <20200624215206.GD2639@glitch> (raw)
In-Reply-To: <1592964652-30446-1-git-send-email-zohar@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
On Tue, Jun 23, 2020 at 10:10:52PM -0400, Mimi Zohar wrote:
> Searching for the last "boot_aggregate" record in the measurement list
> could inadvertently match a filename containing the string
> "boot_aggregate". Prevent this from happening.
>
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
> tests/boot_aggregate.test | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/boot_aggregate.test b/tests/boot_aggregate.test
> index 3e961ce5f9aa..fe0c9aa1898e 100755
> --- a/tests/boot_aggregate.test
> +++ b/tests/boot_aggregate.test
> @@ -121,7 +121,7 @@ check() {
> if [ "$VERBOSE" != "0" ]; then
> echo "$hash"
> fi
> - if grep -e "boot_aggregate$" -e "boot_aggregate.$" "${ASCII_RUNTIME_MEASUREMENTS}" | tail -n 1 | grep -q "${hash}"; then
> + if grep -e " boot_aggregate$" -e " boot_aggregate.$" "${ASCII_RUNTIME_MEASUREMENTS}" | tail -n 1 | grep -q "${hash}"; then
> echo "${GREEN}SUCCESS: boot_aggregate ${hash} found${NORM}"
> return "$OK"
> fi
> --
> 2.7.5
>
Considering whitespaces in between file name words are translated to "_"
(underscore) in measurement file:
Reviewed-by: Bruno Meneguele <bmeneg@redhat.com>
--
bmeneg
PGP Key: http://bmeneg.com/pubkey.txt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-06-24 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 2:10 [PATCH] ima-evm-utils: tests: fix finding the "boot_aggregate" value Mimi Zohar
2020-06-24 21:52 ` Bruno Meneguele [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624215206.GD2639@glitch \
--to=bmeneg@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=maurizio.drocco@ibm.com \
--cc=pvorel@suse.cz \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.