From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Michal Kubecek <mkubecek@suse.cz>,
netdev <netdev@vger.kernel.org>, Chris Healy <cphealy@gmail.com>
Subject: Re: [ethtool v2 3/6] json_writer: Import the iproute2 helper code for JSON output
Date: Wed, 24 Jun 2020 22:32:02 -0700 [thread overview]
Message-ID: <20200624223202.6ddc891f@hermes.lan> (raw)
In-Reply-To: <20200625001244.503790-4-andrew@lunn.ch>
On Thu, 25 Jun 2020 02:12:41 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> In general, Linux network tools use JSON for machine readable output.
> See for example -json for iproute2 and devlink. In order to support
> JSON output from ethtool, import the iproute2 helper code.
>
> Maybe some time in the future it would make sense to either have a
> shared library, or to merge ethtool into the iproute2 source
> distribution?
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
LGTM
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
A shared library is hard to version and gets to be a chore.
next prev parent reply other threads:[~2020-06-25 5:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 0:12 [ethtool v2 0/6] ethtool(1) cable test support Andrew Lunn
2020-06-25 0:12 ` [ethtool v2 1/6] Add " Andrew Lunn
2020-06-25 0:12 ` [ethtool v2 2/6] Add cable test TDR support Andrew Lunn
2020-06-25 0:12 ` [ethtool v2 3/6] json_writer: Import the iproute2 helper code for JSON output Andrew Lunn
2020-06-25 5:32 ` Stephen Hemminger [this message]
2020-06-25 5:33 ` Stephen Hemminger
2020-06-25 0:12 ` [ethtool v2 4/6] Add --json command line argument parsing Andrew Lunn
2020-06-25 5:32 ` Stephen Hemminger
2020-06-25 14:13 ` Andrew Lunn
2020-06-25 0:12 ` [ethtool v2 5/6] ethtool.8.in: Document the cable test commands Andrew Lunn
2020-06-25 0:12 ` [ethtool v2 6/6] ethtool.8.in: Add --json option Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624223202.6ddc891f@hermes.lan \
--to=stephen@networkplumber.org \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.