From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/sdl2: remove sdl2-config.cmake
Date: Wed, 24 Jun 2020 23:51:11 +0200 [thread overview]
Message-ID: <20200624235111.0e70178b@windsurf> (raw)
In-Reply-To: <20200505184303.609201-1-romain.naour@gmail.com>
On Tue, 5 May 2020 20:43:02 +0200
Romain Naour <romain.naour@gmail.com> wrote:
> We are using autotools build system for sdl2, so the sdl2-config.cmake
> include path are not resolved like for sdl2-config script [1].
> Remove sdl2-config.cmake file and avoid unsafe include path if this
> file is used by a cmake based package.
>
> This trigger an issue with ogre 1.12.6 package that replaced
> FindSDL2.cmake by sdl2-config.cmake [2].
>
> Thanks to Pavel Rojtberg for the help [3].
>
> [1] https://bugzilla.libsdl.org/show_bug.cgi?id=4597
> [2] https://github.com/OGRECave/ogre/commit/6de6f9b4081a07c911932441700c54b72ec1ee1f
> [3] https://github.com/OGRECave/ogre/issues/1568
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> v2: new patch
> ---
> package/sdl2/sdl2.mk | 10 ++++++++++
> 1 file changed, 10 insertions(+)
I've applied to master. However, this would really need to be fixed
upstream: if the sdl2-config.cmake is not "prepared" properly when the
autotools build system is used, then why is it installed by the
autotools build system ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-24 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:43 [Buildroot] [PATCH v2 1/2] package/sdl2: remove sdl2-config.cmake Romain Naour
2020-05-05 18:43 ` [Buildroot] [PATCH v2 2/2] package/orgre: bump to version 1.12.6 Romain Naour
2020-06-24 21:51 ` Thomas Petazzoni [this message]
2020-07-16 16:20 ` [Buildroot] [PATCH v2 1/2] package/sdl2: remove sdl2-config.cmake Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624235111.0e70178b@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.