From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 929D5C433E0 for ; Thu, 25 Jun 2020 02:26:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B640207DD for ; Thu, 25 Jun 2020 02:26:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZFpO/NS7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B640207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joHaZ-00015T-M6 for qemu-devel@archiver.kernel.org; Wed, 24 Jun 2020 22:26:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joHZy-0000Ql-Vi for qemu-devel@nongnu.org; Wed, 24 Jun 2020 22:25:30 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:55507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joHZx-00033G-AY for qemu-devel@nongnu.org; Wed, 24 Jun 2020 22:25:30 -0400 Received: by mail-wm1-x341.google.com with SMTP id g75so4043507wme.5 for ; Wed, 24 Jun 2020 19:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=s86Vq4LNLp8spi7eqnnuOScOxAaNl775IbMfnJGkwxE=; b=ZFpO/NS7FCNXmQSVZz2xGUpB9wf7sAu7MPaVWqG9tx2Hfqb+c3jJWvDQw9UmywaMkL bFJV/IC09yK5ud5r8LR0O2wwAgxEtk42x2idUmaCZpeRRnUYZYwxbOUoLQ0YMmWCBus2 aD/qR+buvYuF/Qw6gudpaPvuIqU7aK51apAAjllTpTAZxktkhxHB5SgBdhVKIhkj0sGO sHcKawGrxRa03WXf/IB/hrVguN6c2L2vVY25rXZMq1ScZR9Ly+UtyFihTOd+E1GnfN85 ojm9EBW0fHZ37qZBWp9aXh/a9qzTs7oTf2LT78ZzxHnCUCJL5SNqP4y1FR+KrstyDC4e GoUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=s86Vq4LNLp8spi7eqnnuOScOxAaNl775IbMfnJGkwxE=; b=ZazdW0zPNtunf67ntO+80PZqfjtuYVAy4e/fZbTnDmq85e6CI8ixbuf07Pykj4nsI0 0C8bCLL+2q1zRou5jlMOpvRO1wMhE0rAw/QUiBg+q3q7AFY/RjbMvbtQDOcSUXPfDCIX fWrhH3CxXOO7L8oZOjWopdEEKsNj667txr82Sip3EgogftxX4Bfo4WAafGWgZJgf1NAe IrXjhUL/S59QWdhUBt7IqCpgMmJotO80DFu1AIDnM+J4P2N5U52JapsJ4fmHLBgDD2Bb xeWx0n9aY3+H955jUBcIDH5hVHlGdaIXWS774dlu/8SKpSOJj7bn0zFZ3Si8wdY6Gcdv KTOg== X-Gm-Message-State: AOAM533CMCZzgIiMD4QjXppdbO0OIq1v8HqOwluDnsE1vL/vCpPdqb1Y n1m3y+TbYoTw3sV8NEQdSEY= X-Google-Smtp-Source: ABdhPJyyg5y3U/+W98TaaL9SHAhNA3IedtrDCZNeyu22NRa3Unqg4iTbwv/lyqI8ryt098b1UtKiHg== X-Received: by 2002:a05:600c:2253:: with SMTP id a19mr754232wmm.136.1593051928016; Wed, 24 Jun 2020 19:25:28 -0700 (PDT) Received: from jondnuc (IGLD-84-229-155-64.inter.net.il. [84.229.155.64]) by smtp.gmail.com with ESMTPSA id v20sm30081956wrb.51.2020.06.24.19.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 19:25:27 -0700 (PDT) Date: Thu, 25 Jun 2020 05:25:26 +0300 From: Jon Doron To: Igor Mammedov Subject: Re: [PATCH v3 3/3] acpi: i386: Move VMBus DSDT entry to SB Message-ID: <20200625022526.GB5487@jondnuc> References: <20200618030027.759594-1-arilou@gmail.com> <20200618030027.759594-4-arilou@gmail.com> <20200623170955.0a4f3ae7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200623170955.0a4f3ae7@redhat.com> Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=arilou@gmail.com; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rvkagan@yandex-team.ru, pbonzini@redhat.com, mail@maciej.szmigiero.name, qemu-devel@nongnu.org, vkuznets@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23/06/2020, Igor Mammedov wrote: >On Thu, 18 Jun 2020 06:00:27 +0300 >Jon Doron wrote: > >> Signed-off-by: Jon Doron >> --- >> hw/i386/acpi-build.c | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c >> index 6d9df38e31..38be9e5a58 100644 >> --- a/hw/i386/acpi-build.c >> +++ b/hw/i386/acpi-build.c >> @@ -1092,7 +1092,6 @@ static Aml *build_vmbus_device_aml(VMBusBridge *vmbus_bridge) >> static void build_isa_devices_aml(Aml *table) >> { >> ISADevice *fdc = pc_find_fdc0(); >> - VMBusBridge *vmbus_bridge = vmbus_bridge_find(); >> bool ambiguous; >> >> Aml *scope = aml_scope("_SB.PCI0.ISA"); >> @@ -1113,10 +1112,6 @@ static void build_isa_devices_aml(Aml *table) >> isa_build_aml(ISA_BUS(obj), scope); >> } >> >> - if (vmbus_bridge) { >> - aml_append(scope, build_vmbus_device_aml(vmbus_bridge)); >> - } >> - >> aml_append(table, scope); >> } >> >> @@ -1661,6 +1656,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, >> PCIBus *bus = NULL; >> TPMIf *tpm = tpm_find(); >> int i; >> + VMBusBridge *vmbus_bridge = vmbus_bridge_find(); >> >> dsdt = init_aml_allocator(); >> >> @@ -1675,6 +1671,9 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, >> aml_append(dev, aml_name_decl("_ADR", aml_int(0))); >> aml_append(dev, aml_name_decl("_UID", aml_int(1))); >> aml_append(sb_scope, dev); >> + if (vmbus_bridge) { >> + aml_append(sb_scope, build_vmbus_device_aml(vmbus_bridge)); >> + } >> aml_append(dsdt, sb_scope); >> >> build_hpet_aml(dsdt); >> @@ -1692,6 +1691,9 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, >> aml_append(dev, aml_name_decl("_UID", aml_int(1))); >> aml_append(dev, build_q35_osc_method()); >> aml_append(sb_scope, dev); >> + if (vmbus_bridge) { >> + aml_append(sb_scope, build_vmbus_device_aml(vmbus_bridge)); >> + } >> aml_append(dsdt, sb_scope); >> >> build_hpet_aml(dsdt); >why are you duplicating instead of putting one if () block after > >if (misc->is_piix4) { >} else { >} > >? > Well it seems like Windows is very "picky" about where you declare the VMBS not sure why if i had moved it to the suggested location as such if (misc->is_piix4) { } else { } if (vmbus_bridge) { aml_append(sb_scope, build_vmbus_device_aml(vmbus_bridge)); aml_append(dsdt, sb_scope); } Windows would BSOD right away with ACPI error. Same goes for declaring it before PCI0 device... -- Jon.