From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Thu, 25 Jun 2020 08:03:37 +0000 Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-Id: <20200625080337.GN954398@dell> List-Id: References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> <20200624154321.GH954398@dell> <20200624162446.GA1815586@ravnborg.org> In-Reply-To: <20200624162446.GA1815586@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Sam Ravnborg Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wed, 24 Jun 2020, Sam Ravnborg wrote: > Hi Lee. > > On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote: > > On Wed, 24 Jun 2020, Sam Ravnborg wrote: > > > > > Hi Lee. > > > > > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > > > > Attempting to clean-up W=1 kernel builds, which are currently > > > > overwhelmingly riddled with niggly little warnings. > > > > > > > > Lee Jones (8): > > > > backlight: lms501kf03: Remove unused const variables > > > > backlight: lcd: Add missing kerneldoc entry for 'struct device parent' > > > > > > > > > > backlight: ili922x: Add missing kerneldoc descriptions for > > > > CHECK_FREQ_REG() args > > > > backlight: ili922x: Remove invalid use of kerneldoc syntax > > > > backlight: ili922x: Add missing kerneldoc description for > > > > ili922x_reg_dump()'s arg > > > I wonder why these warnings show up as nothing pulls in this .c file. > > > Anyway I would suggest to drop using kerneldoc syntax for single drivers > > > like this - and the benefit here is low. > > > Now they are typed, otherwise this ahd been fine in a single patch. > > > > What do you mean by 'nothing pulls it in'? > There are no .rst files that includes any: > .. kernel-doc:: drivers/video/backlight/ili922x.c > > so I do not see how the kernel-doc comments will be used by any > of the generated kernel-docs. Looks like a common problem (if it is actually a problem): $ ./scripts/find-unused-docs.sh . | wc -l 1476 The role of this patch-set is not to eradicate unused kerneldoc headers, but to ensure they are formatted correctly. W=1 builds currently complain of ill formatted kerneldocs, which is currently littering the build-log and masking some more important issues (which I'm also trying to fix en route). > > > > backlight: backlight: Supply description for function args in existing > > > > Kerneldocs > > > > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 > > > > backlight: qcom-wled: Remove unused configs for LED3 and LED4 > > > > > > The other fixes looks good. > > > They are all: > > > Acked-by: Sam Ravnborg > > > > Thanks (although this should be Reviewed-by). > > > > > > drivers/video/backlight/backlight.c | 2 ++ > > > > drivers/video/backlight/ili922x.c | 8 ++++++-- > > > > drivers/video/backlight/lcd.c | 1 + > > > > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > > > > drivers/video/backlight/lms501kf03.c | 8 -------- > > > > drivers/video/backlight/qcom-wled.c | 8 -------- > > > > 6 files changed, 11 insertions(+), 20 deletions(-) > > > > > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C085C433E0 for ; Thu, 25 Jun 2020 08:05:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B8C420720 for ; Thu, 25 Jun 2020 08:05:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zd5p3dmx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KETKesxF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B8C420720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G8WJKTeguKjflaa9Xac5mcp7R/2+2kS+QfsFK/UJCkg=; b=zd5p3dmxYc6A/pvIUC2X4ACoc zUSTwvC2Rp1zZ1Q+h8ucNaOOMIsjzWkUZip8Q9tMSvyY9bMbOQgbVP/uZkKRklvggSPSLzSxGNFth 17qA5fHo6PXM4inKvBsD1pKj4Nw7L080BmWQC1tAFjBIqbb/yNqDOc26ppj3r5OURkEWw28nPB0gJ mloVmtnWm/4NnG0IdKOea+LTcHuEGzWqhU7iDGxXcvXA9KqXsZpduHo4VCsEEf/F2Jtx6e7BUyNuP NynWl87YDJRly+WUUT2rPrVm7j6ZeE274UUfFJbYOTPWp55ovfN+yVrqyrWmfE3IEo3P99SQDI+/Q nLGNSSU2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joMrK-0002Vo-Ph; Thu, 25 Jun 2020 08:03:46 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joMrF-0002Tu-Bs for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 08:03:42 +0000 Received: by mail-wm1-x341.google.com with SMTP id t194so4931470wmt.4 for ; Thu, 25 Jun 2020 01:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=0M8Y/ZNSXHt2pcvJaMnq9jm7EeSpBp7mRNluLRRdmdk=; b=KETKesxFm86ICb2fFOUJiGjNCAEbBZjL92c4QkfD/GqbqjQl7b8TszNs+54WN/0KRt 5P2rS7jWeQWH7wsUV5Br8VFbTyYYVNU6dQTCB3WVg4LBOKKyPu0bSE82xwFjFvLyJVXS 6KcpoeNo1FEyuzpFiFppZXiPNqJ9AOdR9Oom9whl7CwfHHRbdVxTx0nqm6A5cRm5LZd4 PxNoqqBnARQTFofGB+80GKqi+RRVHdJdgrWZQdjpw+lHKX3xoNInpuHUMXBXiUjoIJU5 ER92rajMEoZICS8y4YCEt2/PIAkxL3t7vRLPMkZjZdsi4PZmbEr/jdvbH3OE44Cd+lX7 NzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=0M8Y/ZNSXHt2pcvJaMnq9jm7EeSpBp7mRNluLRRdmdk=; b=k5Srve6ahggU8i9H9GO5gcCxIjar9oyQI82SasNkdpbCf9fkPVWh0rhtlLPoMG2/GU MW/LK9iBuB43B1BRyovsxBAnS481G0MUkmiXykAa2TxPG+m+SKlBFux8DEMQ3wmnORMP o4kJ0fp3Vw11tZLvLSPnmMaEdGrWvowIKulvnFTICQxbM97nmrBCpidxaovlVgMEk3nz /chBeb/TUPFbKou7rY/eifaLMhhLahvykP8yBEKruKCw5ts5aEzcPm1cETIgCFmYtxQi dYGBkdO3tBbr66sg4S85tR7zQ/C0qDm7fhqW4ib1fXvkxu/ZJjXafqmvO3gRK9AXiry5 vGLg== X-Gm-Message-State: AOAM533BdR7FxOZEucQCWX9urw8se+SkPGlceb8iNdOlJiWdr3i4qyYn SdKMlDBod/+JsXgcxhyZEpH7tw== X-Google-Smtp-Source: ABdhPJzyKaUaIlRz/U+g6QVFvU1vbbyn/692EhhXT5aH0828ZYHfpZbkeM3vTyPCoD2vvAXE9IHqFw== X-Received: by 2002:a1c:9e13:: with SMTP id h19mr2031841wme.107.1593072220241; Thu, 25 Jun 2020 01:03:40 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g144sm13671180wme.2.2020.06.25.01.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 01:03:38 -0700 (PDT) Date: Thu, 25 Jun 2020 09:03:37 +0100 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200625080337.GN954398@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> <20200624154321.GH954398@dell> <20200624162446.GA1815586@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624162446.GA1815586@ravnborg.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNCBKdW4gMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBIaSBMZWUuCj4gCj4g T24gV2VkLCBKdW4gMjQsIDIwMjAgYXQgMDQ6NDM6MjFQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+ID4gT24gV2VkLCAyNCBKdW4gMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgo+ID4gCj4gPiA+ IEhpIExlZS4KPiA+ID4gCj4gPiA+IE9uIFdlZCwgSnVuIDI0LCAyMDIwIGF0IDAzOjU3OjEzUE0g KzAxMDAsIExlZSBKb25lcyB3cm90ZToKPiA+ID4gPiBBdHRlbXB0aW5nIHRvIGNsZWFuLXVwIFc9 MSBrZXJuZWwgYnVpbGRzLCB3aGljaCBhcmUgY3VycmVudGx5Cj4gPiA+ID4gb3ZlcndoZWxtaW5n bHkgcmlkZGxlZCB3aXRoIG5pZ2dseSBsaXR0bGUgd2FybmluZ3MuCj4gPiA+ID4gCj4gPiA+ID4g TGVlIEpvbmVzICg4KToKPiA+ID4gPiAgIGJhY2tsaWdodDogbG1zNTAxa2YwMzogUmVtb3ZlIHVu dXNlZCBjb25zdCB2YXJpYWJsZXMKPiA+ID4gPiAgIGJhY2tsaWdodDogbGNkOiBBZGQgbWlzc2lu ZyBrZXJuZWxkb2MgZW50cnkgZm9yICdzdHJ1Y3QgZGV2aWNlIHBhcmVudCcKPiA+ID4gCj4gPiA+ IAo+ID4gPiA+ICAgYmFja2xpZ2h0OiBpbGk5MjJ4OiBBZGQgbWlzc2luZyBrZXJuZWxkb2MgZGVz Y3JpcHRpb25zIGZvcgo+ID4gPiA+ICAgICBDSEVDS19GUkVRX1JFRygpIGFyZ3MKPiA+ID4gPiAg IGJhY2tsaWdodDogaWxpOTIyeDogUmVtb3ZlIGludmFsaWQgdXNlIG9mIGtlcm5lbGRvYyBzeW50 YXgKPiA+ID4gPiAgIGJhY2tsaWdodDogaWxpOTIyeDogQWRkIG1pc3Npbmcga2VybmVsZG9jIGRl c2NyaXB0aW9uIGZvcgo+ID4gPiA+ICAgICBpbGk5MjJ4X3JlZ19kdW1wKCkncyBhcmcKPiA+ID4g SSB3b25kZXIgd2h5IHRoZXNlIHdhcm5pbmdzIHNob3cgdXAgYXMgbm90aGluZyBwdWxscyBpbiB0 aGlzIC5jIGZpbGUuCj4gPiA+IEFueXdheSBJIHdvdWxkIHN1Z2dlc3QgdG8gZHJvcCB1c2luZyBr ZXJuZWxkb2Mgc3ludGF4IGZvciBzaW5nbGUgZHJpdmVycwo+ID4gPiBsaWtlIHRoaXMgLSBhbmQg dGhlIGJlbmVmaXQgaGVyZSBpcyBsb3cuCj4gPiA+IE5vdyB0aGV5IGFyZSB0eXBlZCwgb3RoZXJ3 aXNlIHRoaXMgYWhkIGJlZW4gZmluZSBpbiBhIHNpbmdsZSBwYXRjaC4KPiA+IAo+ID4gV2hhdCBk byB5b3UgbWVhbiBieSAnbm90aGluZyBwdWxscyBpdCBpbic/Cj4gVGhlcmUgYXJlIG5vIC5yc3Qg ZmlsZXMgdGhhdCBpbmNsdWRlcyBhbnk6Cj4gLi4ga2VybmVsLWRvYzo6IGRyaXZlcnMvdmlkZW8v YmFja2xpZ2h0L2lsaTkyMnguYwo+IAo+IHNvIEkgZG8gbm90IHNlZSBob3cgdGhlIGtlcm5lbC1k b2MgY29tbWVudHMgd2lsbCBiZSB1c2VkIGJ5IGFueQo+IG9mIHRoZSBnZW5lcmF0ZWQga2VybmVs LWRvY3MuCgpMb29rcyBsaWtlIGEgY29tbW9uIHByb2JsZW0gKGlmIGl0IGlzIGFjdHVhbGx5IGEg cHJvYmxlbSk6CgogJCAuL3NjcmlwdHMvZmluZC11bnVzZWQtZG9jcy5zaCAuIHwgd2MgLWwKIDE0 NzYKClRoZSByb2xlIG9mIHRoaXMgcGF0Y2gtc2V0IGlzIG5vdCB0byBlcmFkaWNhdGUgdW51c2Vk IGtlcm5lbGRvYwpoZWFkZXJzLCBidXQgdG8gZW5zdXJlIHRoZXkgYXJlIGZvcm1hdHRlZCBjb3Jy ZWN0bHkuICBXPTEgYnVpbGRzCmN1cnJlbnRseSBjb21wbGFpbiBvZiBpbGwgZm9ybWF0dGVkIGtl cm5lbGRvY3MsIHdoaWNoIGlzIGN1cnJlbnRseQpsaXR0ZXJpbmcgdGhlIGJ1aWxkLWxvZyBhbmQg bWFza2luZyBzb21lIG1vcmUgaW1wb3J0YW50IGlzc3VlcyAod2hpY2gKSSdtIGFsc28gdHJ5aW5n IHRvIGZpeCBlbiByb3V0ZSkuCgo+ID4gPiA+ICAgYmFja2xpZ2h0OiBiYWNrbGlnaHQ6IFN1cHBs eSBkZXNjcmlwdGlvbiBmb3IgZnVuY3Rpb24gYXJncyBpbiBleGlzdGluZwo+ID4gPiA+ICAgICBL ZXJuZWxkb2NzCj4gPiA+ID4gICBiYWNrbGlnaHQ6IGxtMzYzMGFfYmw6IFJlbW92ZSBpbnZhbGlk IGNoZWNrcyBmb3IgdW5zaWduZWQgaW50IDwgMAo+ID4gPiA+ICAgYmFja2xpZ2h0OiBxY29tLXds ZWQ6IFJlbW92ZSB1bnVzZWQgY29uZmlncyBmb3IgTEVEMyBhbmQgTEVENAo+ID4gPiAKPiA+ID4g VGhlIG90aGVyIGZpeGVzIGxvb2tzIGdvb2QuCj4gPiA+IFRoZXkgYXJlIGFsbDoKPiA+ID4gQWNr ZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiA+IAo+ID4gVGhhbmtzIChh bHRob3VnaCB0aGlzIHNob3VsZCBiZSBSZXZpZXdlZC1ieSkuCj4gPiAKPiA+ID4gPiAgZHJpdmVy cy92aWRlby9iYWNrbGlnaHQvYmFja2xpZ2h0LmMgIHwgMiArKwo+ID4gPiA+ICBkcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmMgICAgfCA4ICsrKysrKy0tCj4gPiA+ID4gIGRyaXZlcnMv dmlkZW8vYmFja2xpZ2h0L2xjZC5jICAgICAgICB8IDEgKwo+ID4gPiA+ICBkcml2ZXJzL3ZpZGVv L2JhY2tsaWdodC9sbTM2MzBhX2JsLmMgfCA0ICsrLS0KPiA+ID4gPiAgZHJpdmVycy92aWRlby9i YWNrbGlnaHQvbG1zNTAxa2YwMy5jIHwgOCAtLS0tLS0tLQo+ID4gPiA+ICBkcml2ZXJzL3ZpZGVv L2JhY2tsaWdodC9xY29tLXdsZWQuYyAgfCA4IC0tLS0tLS0tCj4gPiA+ID4gIDYgZmlsZXMgY2hh bmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiAKCi0t IApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVy IFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FE0C433E0 for ; Thu, 25 Jun 2020 08:03:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEF0120720 for ; Thu, 25 Jun 2020 08:03:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KETKesxF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEF0120720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5100189C6B; Thu, 25 Jun 2020 08:03:42 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id A01C989C6B for ; Thu, 25 Jun 2020 08:03:41 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id 22so4621764wmg.1 for ; Thu, 25 Jun 2020 01:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=0M8Y/ZNSXHt2pcvJaMnq9jm7EeSpBp7mRNluLRRdmdk=; b=KETKesxFm86ICb2fFOUJiGjNCAEbBZjL92c4QkfD/GqbqjQl7b8TszNs+54WN/0KRt 5P2rS7jWeQWH7wsUV5Br8VFbTyYYVNU6dQTCB3WVg4LBOKKyPu0bSE82xwFjFvLyJVXS 6KcpoeNo1FEyuzpFiFppZXiPNqJ9AOdR9Oom9whl7CwfHHRbdVxTx0nqm6A5cRm5LZd4 PxNoqqBnARQTFofGB+80GKqi+RRVHdJdgrWZQdjpw+lHKX3xoNInpuHUMXBXiUjoIJU5 ER92rajMEoZICS8y4YCEt2/PIAkxL3t7vRLPMkZjZdsi4PZmbEr/jdvbH3OE44Cd+lX7 NzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=0M8Y/ZNSXHt2pcvJaMnq9jm7EeSpBp7mRNluLRRdmdk=; b=eJKn6c2Jzi2IHlMBi7ACdftiJuEFj7UDywIWkSrSvXDVS/1VacTUqniuD5oJMpWXV3 Kqz1EjZ5Rgl8eOYNU5m6J/UOO5+sHtXEtrNoesED/wWgRR4KMGqKNTo5jLMckeXaHUwH DgweC5ry+RubK7kj0CsLBbJW+ko3kOugonbfC1FZWOHoty+TLYK3IrzZH1aOO7puGIma sxUc2rXOagJFPV4dJ324O3hb41ejuCznfQM/8UAbd/1Ia54zfRvsoH+xzb9DcF1gMe9b BWVQT6oD6ENjzSxKaR6rA+1Q0NCe3NYzynklXhGmL/Oa9pM2SZPLY++uAkdvswC0T4ME a58w== X-Gm-Message-State: AOAM532OTwkvvQi6zjGS0n10jF8iJ2xZ/KvVLPl+8XuUIM/SNP8mRGYa NbQEKdSeuMhLzgQvKIr6tUK/6w== X-Google-Smtp-Source: ABdhPJzyKaUaIlRz/U+g6QVFvU1vbbyn/692EhhXT5aH0828ZYHfpZbkeM3vTyPCoD2vvAXE9IHqFw== X-Received: by 2002:a1c:9e13:: with SMTP id h19mr2031841wme.107.1593072220241; Thu, 25 Jun 2020 01:03:40 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g144sm13671180wme.2.2020.06.25.01.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 01:03:38 -0700 (PDT) Date: Thu, 25 Jun 2020 09:03:37 +0100 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200625080337.GN954398@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> <20200624154321.GH954398@dell> <20200624162446.GA1815586@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624162446.GA1815586@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAyNCBKdW4gMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBIaSBMZWUuCj4gCj4g T24gV2VkLCBKdW4gMjQsIDIwMjAgYXQgMDQ6NDM6MjFQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+ID4gT24gV2VkLCAyNCBKdW4gMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgo+ID4gCj4gPiA+ IEhpIExlZS4KPiA+ID4gCj4gPiA+IE9uIFdlZCwgSnVuIDI0LCAyMDIwIGF0IDAzOjU3OjEzUE0g KzAxMDAsIExlZSBKb25lcyB3cm90ZToKPiA+ID4gPiBBdHRlbXB0aW5nIHRvIGNsZWFuLXVwIFc9 MSBrZXJuZWwgYnVpbGRzLCB3aGljaCBhcmUgY3VycmVudGx5Cj4gPiA+ID4gb3ZlcndoZWxtaW5n bHkgcmlkZGxlZCB3aXRoIG5pZ2dseSBsaXR0bGUgd2FybmluZ3MuCj4gPiA+ID4gCj4gPiA+ID4g TGVlIEpvbmVzICg4KToKPiA+ID4gPiAgIGJhY2tsaWdodDogbG1zNTAxa2YwMzogUmVtb3ZlIHVu dXNlZCBjb25zdCB2YXJpYWJsZXMKPiA+ID4gPiAgIGJhY2tsaWdodDogbGNkOiBBZGQgbWlzc2lu ZyBrZXJuZWxkb2MgZW50cnkgZm9yICdzdHJ1Y3QgZGV2aWNlIHBhcmVudCcKPiA+ID4gCj4gPiA+ IAo+ID4gPiA+ICAgYmFja2xpZ2h0OiBpbGk5MjJ4OiBBZGQgbWlzc2luZyBrZXJuZWxkb2MgZGVz Y3JpcHRpb25zIGZvcgo+ID4gPiA+ICAgICBDSEVDS19GUkVRX1JFRygpIGFyZ3MKPiA+ID4gPiAg IGJhY2tsaWdodDogaWxpOTIyeDogUmVtb3ZlIGludmFsaWQgdXNlIG9mIGtlcm5lbGRvYyBzeW50 YXgKPiA+ID4gPiAgIGJhY2tsaWdodDogaWxpOTIyeDogQWRkIG1pc3Npbmcga2VybmVsZG9jIGRl c2NyaXB0aW9uIGZvcgo+ID4gPiA+ICAgICBpbGk5MjJ4X3JlZ19kdW1wKCkncyBhcmcKPiA+ID4g SSB3b25kZXIgd2h5IHRoZXNlIHdhcm5pbmdzIHNob3cgdXAgYXMgbm90aGluZyBwdWxscyBpbiB0 aGlzIC5jIGZpbGUuCj4gPiA+IEFueXdheSBJIHdvdWxkIHN1Z2dlc3QgdG8gZHJvcCB1c2luZyBr ZXJuZWxkb2Mgc3ludGF4IGZvciBzaW5nbGUgZHJpdmVycwo+ID4gPiBsaWtlIHRoaXMgLSBhbmQg dGhlIGJlbmVmaXQgaGVyZSBpcyBsb3cuCj4gPiA+IE5vdyB0aGV5IGFyZSB0eXBlZCwgb3RoZXJ3 aXNlIHRoaXMgYWhkIGJlZW4gZmluZSBpbiBhIHNpbmdsZSBwYXRjaC4KPiA+IAo+ID4gV2hhdCBk byB5b3UgbWVhbiBieSAnbm90aGluZyBwdWxscyBpdCBpbic/Cj4gVGhlcmUgYXJlIG5vIC5yc3Qg ZmlsZXMgdGhhdCBpbmNsdWRlcyBhbnk6Cj4gLi4ga2VybmVsLWRvYzo6IGRyaXZlcnMvdmlkZW8v YmFja2xpZ2h0L2lsaTkyMnguYwo+IAo+IHNvIEkgZG8gbm90IHNlZSBob3cgdGhlIGtlcm5lbC1k b2MgY29tbWVudHMgd2lsbCBiZSB1c2VkIGJ5IGFueQo+IG9mIHRoZSBnZW5lcmF0ZWQga2VybmVs LWRvY3MuCgpMb29rcyBsaWtlIGEgY29tbW9uIHByb2JsZW0gKGlmIGl0IGlzIGFjdHVhbGx5IGEg cHJvYmxlbSk6CgogJCAuL3NjcmlwdHMvZmluZC11bnVzZWQtZG9jcy5zaCAuIHwgd2MgLWwKIDE0 NzYKClRoZSByb2xlIG9mIHRoaXMgcGF0Y2gtc2V0IGlzIG5vdCB0byBlcmFkaWNhdGUgdW51c2Vk IGtlcm5lbGRvYwpoZWFkZXJzLCBidXQgdG8gZW5zdXJlIHRoZXkgYXJlIGZvcm1hdHRlZCBjb3Jy ZWN0bHkuICBXPTEgYnVpbGRzCmN1cnJlbnRseSBjb21wbGFpbiBvZiBpbGwgZm9ybWF0dGVkIGtl cm5lbGRvY3MsIHdoaWNoIGlzIGN1cnJlbnRseQpsaXR0ZXJpbmcgdGhlIGJ1aWxkLWxvZyBhbmQg bWFza2luZyBzb21lIG1vcmUgaW1wb3J0YW50IGlzc3VlcyAod2hpY2gKSSdtIGFsc28gdHJ5aW5n IHRvIGZpeCBlbiByb3V0ZSkuCgo+ID4gPiA+ICAgYmFja2xpZ2h0OiBiYWNrbGlnaHQ6IFN1cHBs eSBkZXNjcmlwdGlvbiBmb3IgZnVuY3Rpb24gYXJncyBpbiBleGlzdGluZwo+ID4gPiA+ICAgICBL ZXJuZWxkb2NzCj4gPiA+ID4gICBiYWNrbGlnaHQ6IGxtMzYzMGFfYmw6IFJlbW92ZSBpbnZhbGlk IGNoZWNrcyBmb3IgdW5zaWduZWQgaW50IDwgMAo+ID4gPiA+ICAgYmFja2xpZ2h0OiBxY29tLXds ZWQ6IFJlbW92ZSB1bnVzZWQgY29uZmlncyBmb3IgTEVEMyBhbmQgTEVENAo+ID4gPiAKPiA+ID4g VGhlIG90aGVyIGZpeGVzIGxvb2tzIGdvb2QuCj4gPiA+IFRoZXkgYXJlIGFsbDoKPiA+ID4gQWNr ZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiA+IAo+ID4gVGhhbmtzIChh bHRob3VnaCB0aGlzIHNob3VsZCBiZSBSZXZpZXdlZC1ieSkuCj4gPiAKPiA+ID4gPiAgZHJpdmVy cy92aWRlby9iYWNrbGlnaHQvYmFja2xpZ2h0LmMgIHwgMiArKwo+ID4gPiA+ICBkcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmMgICAgfCA4ICsrKysrKy0tCj4gPiA+ID4gIGRyaXZlcnMv dmlkZW8vYmFja2xpZ2h0L2xjZC5jICAgICAgICB8IDEgKwo+ID4gPiA+ICBkcml2ZXJzL3ZpZGVv L2JhY2tsaWdodC9sbTM2MzBhX2JsLmMgfCA0ICsrLS0KPiA+ID4gPiAgZHJpdmVycy92aWRlby9i YWNrbGlnaHQvbG1zNTAxa2YwMy5jIHwgOCAtLS0tLS0tLQo+ID4gPiA+ICBkcml2ZXJzL3ZpZGVv L2JhY2tsaWdodC9xY29tLXdsZWQuYyAgfCA4IC0tLS0tLS0tCj4gPiA+ID4gIDYgZmlsZXMgY2hh bmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiAKCi0t IApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVy IFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91618C433DF for ; Thu, 25 Jun 2020 08:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65AF720720 for ; Thu, 25 Jun 2020 08:03:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KETKesxF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390637AbgFYIDv (ORCPT ); Thu, 25 Jun 2020 04:03:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390587AbgFYIDl (ORCPT ); Thu, 25 Jun 2020 04:03:41 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8853EC0613ED for ; Thu, 25 Jun 2020 01:03:41 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id u26so6130802wmn.1 for ; Thu, 25 Jun 2020 01:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=0M8Y/ZNSXHt2pcvJaMnq9jm7EeSpBp7mRNluLRRdmdk=; b=KETKesxFm86ICb2fFOUJiGjNCAEbBZjL92c4QkfD/GqbqjQl7b8TszNs+54WN/0KRt 5P2rS7jWeQWH7wsUV5Br8VFbTyYYVNU6dQTCB3WVg4LBOKKyPu0bSE82xwFjFvLyJVXS 6KcpoeNo1FEyuzpFiFppZXiPNqJ9AOdR9Oom9whl7CwfHHRbdVxTx0nqm6A5cRm5LZd4 PxNoqqBnARQTFofGB+80GKqi+RRVHdJdgrWZQdjpw+lHKX3xoNInpuHUMXBXiUjoIJU5 ER92rajMEoZICS8y4YCEt2/PIAkxL3t7vRLPMkZjZdsi4PZmbEr/jdvbH3OE44Cd+lX7 NzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=0M8Y/ZNSXHt2pcvJaMnq9jm7EeSpBp7mRNluLRRdmdk=; b=idHuAKtM2uMC1CSAEakLWB8eIc0mx3SIRVobfwtXzQSCUKzzBW4ONv6smM9np2iogD 2tHDIlQd7jkf4TCsTkqbEUSdyCbmi/I1m0jS5+P+R3O8VP0AKQS9840QVJpizWWkMflJ SL2biV2fmnI2p8+Jk5uoqVqQnERcUJFUBTWf/F4X8aFo+y2aXh+3x/LFx4T4V65tvyIa W0XESD5Pu8iyc39Q/38fFgar8l4jGbTb3q0qDJ5wKzOWzWCTnavAaq67UsZO8oG0QQN+ ugAEwlNCqNmv/eekCOEchti21pdMTSjzVkKr7rqa/gIb7WMo8X2LxBdo2xunz5/oDJVI VUJw== X-Gm-Message-State: AOAM531Od3kMWTzvWuiT2GJnVcDCJ33LLa/JTE4XHrCnsV4SR6nGuOiG 68HKu2EVgFs/Zxnqu2fSt7n4Mw== X-Google-Smtp-Source: ABdhPJzyKaUaIlRz/U+g6QVFvU1vbbyn/692EhhXT5aH0828ZYHfpZbkeM3vTyPCoD2vvAXE9IHqFw== X-Received: by 2002:a1c:9e13:: with SMTP id h19mr2031841wme.107.1593072220241; Thu, 25 Jun 2020 01:03:40 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g144sm13671180wme.2.2020.06.25.01.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 01:03:38 -0700 (PDT) Date: Thu, 25 Jun 2020 09:03:37 +0100 From: Lee Jones To: Sam Ravnborg Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200625080337.GN954398@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> <20200624154321.GH954398@dell> <20200624162446.GA1815586@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200624162446.GA1815586@ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Jun 2020, Sam Ravnborg wrote: > Hi Lee. > > On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote: > > On Wed, 24 Jun 2020, Sam Ravnborg wrote: > > > > > Hi Lee. > > > > > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > > > > Attempting to clean-up W=1 kernel builds, which are currently > > > > overwhelmingly riddled with niggly little warnings. > > > > > > > > Lee Jones (8): > > > > backlight: lms501kf03: Remove unused const variables > > > > backlight: lcd: Add missing kerneldoc entry for 'struct device parent' > > > > > > > > > > backlight: ili922x: Add missing kerneldoc descriptions for > > > > CHECK_FREQ_REG() args > > > > backlight: ili922x: Remove invalid use of kerneldoc syntax > > > > backlight: ili922x: Add missing kerneldoc description for > > > > ili922x_reg_dump()'s arg > > > I wonder why these warnings show up as nothing pulls in this .c file. > > > Anyway I would suggest to drop using kerneldoc syntax for single drivers > > > like this - and the benefit here is low. > > > Now they are typed, otherwise this ahd been fine in a single patch. > > > > What do you mean by 'nothing pulls it in'? > There are no .rst files that includes any: > .. kernel-doc:: drivers/video/backlight/ili922x.c > > so I do not see how the kernel-doc comments will be used by any > of the generated kernel-docs. Looks like a common problem (if it is actually a problem): $ ./scripts/find-unused-docs.sh . | wc -l 1476 The role of this patch-set is not to eradicate unused kerneldoc headers, but to ensure they are formatted correctly. W=1 builds currently complain of ill formatted kerneldocs, which is currently littering the build-log and masking some more important issues (which I'm also trying to fix en route). > > > > backlight: backlight: Supply description for function args in existing > > > > Kerneldocs > > > > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 > > > > backlight: qcom-wled: Remove unused configs for LED3 and LED4 > > > > > > The other fixes looks good. > > > They are all: > > > Acked-by: Sam Ravnborg > > > > Thanks (although this should be Reviewed-by). > > > > > > drivers/video/backlight/backlight.c | 2 ++ > > > > drivers/video/backlight/ili922x.c | 8 ++++++-- > > > > drivers/video/backlight/lcd.c | 1 + > > > > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > > > > drivers/video/backlight/lms501kf03.c | 8 -------- > > > > drivers/video/backlight/qcom-wled.c | 8 -------- > > > > 6 files changed, 11 insertions(+), 20 deletions(-) > > > > > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog