All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Maxim Levitsky <mlevitsk@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Search function in xconfig is partially broken after recent changes
Date: Thu, 25 Jun 2020 13:17:58 +0200	[thread overview]
Message-ID: <20200625131758.52dbdab7@coco.lan> (raw)
In-Reply-To: <20200625125906.6b7688eb@coco.lan>

Em Thu, 25 Jun 2020 12:59:15 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:

> Hi Maxim,
> 
> Em Thu, 25 Jun 2020 12:25:10 +0300
> Maxim Levitsky <mlevitsk@redhat.com> escreveu:
> 
> > Hi!
> > 
> > I noticed that on recent kernels the search function in xconfig is partially broken.
> > This means that when you select a found entry, it is not selected in the main window,
> > something that I often do to find some entry near the area I would like to modify,
> > and then use main window to navigate/explore that area.
> > 
> > Reverting these commits helps restore the original behavier:
> > 
> > b311142fcfd37b58dfec72e040ed04949eb1ac86 - kconfig: qconf: fix support for the split view mode
> > cce1faba82645fee899ccef5b7d3050fed3a3d10 - kconfig: qconf: fix the content of the main widget
> > 
> > I have Qt5 5.13.2 from fedora 31 (5.13.2-1.fc31)
> > 
> > Could you explain what these commits are supposed to fix?
> > I mostly use the split view mode too and it does appear to work for me with these commits reverted as well.
> > 
> 
> There are three view modes for qconf:
> 
> 	- Single
> 	- Split
> 	- Full
> 
> those got broken when gconf was converted to use Qt5, back on Kernel 3.14.
> Those patches restore the original behavior.
> 
> > Another question is do you know how to run the qconf standalone? It appears to crash when I attempt to do so,
> > althought I checked that I pass correct command line to it, and use the same current directory.
> > I guess PATH or something is set by the makefile, but I was unable yet to find out what exactly breaks it.
> > 
> > This is what I see:
> > 
> > [mlevitsk@starship ~/UPSTREAM/linux-kernel/src]$./scripts/kconfig/qconf Kconfig
> > sh: /scripts/gcc-version.sh: No such file or directory
> > init/Kconfig:34: syntax error
> > init/Kconfig:33: invalid statement
> > init/Kconfig:34: invalid statement
> > sh: /scripts/ld-version.sh: No such file or directory
> > sh: --version: command not found
> > init/Kconfig:39: syntax error
> > init/Kconfig:38: invalid statement
> > sh: /scripts/clang-version.sh: No such file or directory
> > init/Kconfig:49: syntax error
> > init/Kconfig:48: invalid statement
> > Recursive inclusion detected.
> > Inclusion path:
> 
> It requires some environment vars. This would make it a little better:
> 
> 
> 	export LD=$(which ldd); export CC=$(which gcc); export srctree=$(pwd); scripts/kconfig/gconf Kconfig
> 	Recursive inclusion detected.
> 	Inclusion path:
> 	  current file : arch//Kconfig
> 	  included from: arch//Kconfig:10
> 
> but it seems that something else is also needed.

This worked for me:

	SRCARCH=x86 LD=$(which ldd) CC=$(which gcc) srctree=$(pwd) scripts/kconfig/gconf Kconfig

Thanks,
Mauro

  reply	other threads:[~2020-06-25 11:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25  9:25 Search function in xconfig is partially broken after recent changes Maxim Levitsky
2020-06-25 10:59 ` Mauro Carvalho Chehab
2020-06-25 11:17   ` Mauro Carvalho Chehab [this message]
2020-06-25 12:53     ` Maxim Levitsky
2020-06-25 15:05       ` Mauro Carvalho Chehab
2020-06-28  8:37         ` Maxim Levitsky
2020-06-28 10:54           ` Mauro Carvalho Chehab
2020-06-28 11:20             ` Maxim Levitsky
2020-06-28 11:56               ` Mauro Carvalho Chehab
2020-06-25 13:42   ` Mauro Carvalho Chehab
2020-06-25 14:52     ` [PATCH] kconfig: qconf: Fix find on split mode Mauro Carvalho Chehab
2020-06-28  2:17       ` Masahiro Yamada
2020-06-28  8:40       ` Maxim Levitsky
2020-06-28 14:42         ` Masahiro Yamada
2020-06-30  3:53           ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200625131758.52dbdab7@coco.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlevitsk@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.