From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9584AC433E0 for ; Thu, 25 Jun 2020 13:35:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 630ED20672 for ; Thu, 25 Jun 2020 13:35:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZzRFvO3l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zbnXFjc/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 630ED20672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jU8p3jagP3qah6nHmfQ3ulJQgX6uvroKzKBTkYj7CuY=; b=ZzRFvO3l5M4g/FA2FNhjsJSvC Thn4s/OI7lRCk4ZnZ5nLyL+XKgmnlkogMb7wWTsa7/ErlxhldAipwWKPLhWJqiDNU6WGcVHqlkXV6 yl1HUg1J73VPzbVZzUMsUwWiIr3BOBnJEEWO9BUN8763em4E+fs9D/ncF5xfZK548fx49Fw25l2Po HTEEzEsmqp1CpYXu9pK8EUTp0v8gYEDsocyMxkfHmH+JBaboYwDuMhhTI6d3TVaivKb4diiRRDHKp ImUHVCmx7OyABInkIwc+YoqRMDQ2vcgzYWzD+vzQoP9rJG6UKovHoWwqLJJ73LfehiipnXyiNlUbh dN+J9is+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joS1A-00038A-UU; Thu, 25 Jun 2020 13:34:16 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joS18-00037m-V1 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 13:34:15 +0000 Received: by mail-wr1-x443.google.com with SMTP id g18so5898138wrm.2 for ; Thu, 25 Jun 2020 06:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+en12hbajA2epjn74KKtvunas9oH7o8wq7HKdXNb8M0=; b=zbnXFjc/f3t0HXVoKImkdmg5QD+hfAo/wnHs68LQN6hK956Xp5jO4Zmjk8rLth24Ms D5WOsZFtBh/qkBtEBDygVtDg3e7B6OwSHztlJBclVtWh0qkbSEdG2IPFEEDuwMJ2V0fe EsqlzrSqH1vgbMFtAKRGt7csuDdXUuvPxWACVl4dyaKb2sKbSrRHvtH4IM1gXpX5DEwE ZixSdfhlet1m6v++dZGefh++3rR/ZPWnZspJnBoEyi+1vCo8H4YFpzreLS5YoJZ0rt7Q fLtLGMkIlPKFNcsId/Raezp2iTCENVvdyYaogvEYUoOQGxGVDzdJKH1hs6UdboSAgfsQ I+Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+en12hbajA2epjn74KKtvunas9oH7o8wq7HKdXNb8M0=; b=mxpQGy0biDBLatU1KmrwFvRDPtcOoCbG1T0TTwk6/LFlTZ2pVMeNCyRMFtdGMUZlsz IKGOqYrpDnO+tlUbQIC+x6CAeIGN6Q17LBhvnB80Y07DY7A63fLmN4cAtd/Na7F/3X0E Bn606XhH619Ij0q5CIxrvxqNy9bgRe7VA29zvXIgW3qFuUree4rgbbe4Wp5YSH4Fgyd9 qfdYxwBTMqBxpWsKNwFa/VhRapj5D7gzdzUJzbeie0qJM/oGQBuQdg+slgIrgfg//viM gncI0d21iMXxv4SCszG7MSGVjePyoprlNh8DwDAeFscHO6e4YyUK/nlH3ZuZlExzZ2Zl 4G5A== X-Gm-Message-State: AOAM532iMRuB2Cn0X7Odjsk+GUKX9SLoOVZ+piJ6Hq/t4NEUC/7z4Qj0 jCeLgs4A9c79b49eRmYJQrdP+SN0/x4= X-Google-Smtp-Source: ABdhPJyg90AdzA2eO9xnhupkOpjLo09dHDKK962lpGaGylf28QL380IteVaxf1VIra2P5HiM8rrNvw== X-Received: by 2002:adf:f350:: with SMTP id e16mr34165014wrp.43.1593092053811; Thu, 25 Jun 2020 06:34:13 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f16sm12669678wmh.27.2020.06.25.06.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 06:34:13 -0700 (PDT) Date: Thu, 25 Jun 2020 14:34:11 +0100 From: Lee Jones To: Greg KH Subject: Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args Message-ID: <20200625133411.GP954398@dell> References: <20200625064619.2775707-1-lee.jones@linaro.org> <20200625064619.2775707-2-lee.jones@linaro.org> <20200625065608.GB2789306@kroah.com> <20200625071313.GM954398@dell> <20200625094513.GC3299764@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625094513.GC3299764@kroah.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyNSBKdW4gMjAyMCwgR3JlZyBLSCB3cm90ZToKCj4gT24gVGh1LCBKdW4gMjUsIDIw MjAgYXQgMDg6MTM6MTNBTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gVGh1LCAyNSBK dW4gMjAyMCwgR3JlZyBLSCB3cm90ZToKPiA+IAo+ID4gPiBPbiBUaHUsIEp1biAyNSwgMjAyMCBh dCAwNzo0NjoxMEFNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiA+ID4gS2VybmVsZG9jIHN5 bnRheCBpcyB1c2VkLCBidXQgbm90IGNvbXBsZXRlLiAgRGVzY3JpcHRpb25zIHJlcXVpcmVkLgo+ ID4gPiA+IAo+ID4gPiA+IFByZXZlbnRzIHdhcm5pbmdzIGxpa2U6Cj4gPiA+ID4gCj4gPiA+ID4g IGRyaXZlcnMvbWZkL3dtODM1MC1jb3JlLmM6MTM2OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0 ZXIgb3IgbWVtYmVyICd3bTgzNTAnIG5vdCBkZXNjcmliZWQgaW4gJ3dtODM1MF9yZWdfbG9jaycK PiA+ID4gPiAgZHJpdmVycy9tZmQvd204MzUwLWNvcmUuYzoxNjU6IHdhcm5pbmc6IEZ1bmN0aW9u IHBhcmFtZXRlciBvciBtZW1iZXIgJ3dtODM1MCcgbm90IGRlc2NyaWJlZCBpbiAnd204MzUwX3Jl Z191bmxvY2snCj4gPiA+ID4gCj4gPiA+ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgo+ ID4gPiA+IENjOiBwYXRjaGVzQG9wZW5zb3VyY2UuY2lycnVzLmNvbQo+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiA+ID4gLS0tCj4gPiA+ ID4gIGRyaXZlcnMvbWZkL3dtODM1MC1jb3JlLmMgfCA0ICsrKysKPiA+ID4gPiAgMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL21mZC93bTgzNTAtY29yZS5jIGIvZHJpdmVycy9tZmQvd204MzUwLWNvcmUuYwo+ID4gPiA+ IGluZGV4IDQyYjE2NTAzZTZjZDEuLmZiYzc3YjIxODIxNWMgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEv ZHJpdmVycy9tZmQvd204MzUwLWNvcmUuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvbWZkL3dtODM1 MC1jb3JlLmMKPiA+ID4gPiBAQCAtMTMxLDYgKzEzMSw4IEBAIEVYUE9SVF9TWU1CT0xfR1BMKHdt ODM1MF9ibG9ja193cml0ZSk7Cj4gPiA+ID4gICAqIFRoZSBXTTgzNTAgaGFzIGEgaGFyZHdhcmUg bG9jayB3aGljaCBjYW4gYmUgdXNlZCB0byBwcmV2ZW50IHdyaXRlcyB0bwo+ID4gPiA+ICAgKiBz b21lIHJlZ2lzdGVycyAoZ2VuZXJhbGx5IHRob3NlIHdoaWNoIGNhbiBjYXVzZSBwYXJ0aWN1bGFy bHkgc2VyaW91cwo+ID4gPiA+ICAgKiBwcm9ibGVtcyBpZiBtaXN1c2VkKS4gIFRoaXMgZnVuY3Rp b24gZW5hYmxlcyB0aGF0IGxvY2suCj4gPiA+ID4gKyAqCj4gPiA+ID4gKyAqIEB3bTgzNTA6IHBv aW50ZXIgdG8gbG9jYWwgZHJpdmVyIGRhdGEgc3RydWN0dXJlCj4gPiA+ID4gICAqLwo+ID4gPiA+ ICBpbnQgd204MzUwX3JlZ19sb2NrKHN0cnVjdCB3bTgzNTAgKndtODM1MCkKPiA+ID4gPiAgewo+ ID4gPiA+IEBAIC0xNjAsNiArMTYyLDggQEAgRVhQT1JUX1NZTUJPTF9HUEwod204MzUwX3JlZ19s b2NrKTsKPiA+ID4gPiAgICogcHJvYmxlbXMgaWYgbWlzdXNlZCkuICBUaGlzIGZ1bmN0aW9uIGRp c2FibGVzIHRoYXQgbG9jayBzbyB1cGRhdGVzCj4gPiA+ID4gICAqIGNhbiBiZSBwZXJmb3JtZWQu ICBGb3IgbWF4aW11bSBzYWZldHkgdGhpcyBzaG91bGQgYmUgZG9uZSBvbmx5IHdoZW4KPiA+ID4g PiAgICogcmVxdWlyZWQuCj4gPiA+ID4gKyAqCj4gPiA+ID4gKyAqIEB3bTgzNTA6IHBvaW50ZXIg dG8gbG9jYWwgZHJpdmVyIGRhdGEgc3RydWN0dXJlCj4gPiA+ID4gICAqLwo+ID4gPiA+ICBpbnQg d204MzUwX3JlZ191bmxvY2soc3RydWN0IHdtODM1MCAqd204MzUwKQo+ID4gPiA+ICB7Cj4gPiA+ IAo+ID4gPiBXaHkgYXJlIGFsbCBvZiB0aGVzZSBkb2N1bWVudGF0aW9uIGZpeGVzIGZvciBzdGFi bGU/Cj4gPiAKPiA+IEJlY2F1c2UgdGhleSBmaXggY29tcGlsZXIgd2FybmluZ3MuCj4gCj4gV2hl biB5b3UgdHlwZSAnbWFrZScgdGhlc2Ugd2FybmluZ3Mgc2hvdyB1cD8gIFdlIGRvbid0IGRvIGRv Y3VtZW50YXRpb24KPiBidWlsZHMgYXMgcGFydCBvZiBhIG5vcm1hbCBidWlsZC4uLgoKJ21ha2Ug Vz0xJyB5ZXMuIDopCgo+IElmIGZvciBzb21lIHJlYXNvbiB3ZSBldmVyIGdldCByaWQgb2YgYWxs IG9mIHRoZSB0aG91c2FuZHMgb2YgY3VycmVudAo+IHdhcm5pbmdzLCB0aGVuIHllcywgSSB3aWxs IGJlIGdsYWQgdG8gY29uc2lkZXIgc3R1ZmYgbGlrZSB0aGlzIHRoZW4uCgpXb3JraW4nIG9uIGl0 IQoKU29ycnkgZm9yIHRoZSBub2lzZSAoZm9yIG5vdykuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzm lq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3Jn IOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFj ZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB97BC433DF for ; Thu, 25 Jun 2020 13:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B18B220781 for ; Thu, 25 Jun 2020 13:34:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zbnXFjc/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405077AbgFYNeQ (ORCPT ); Thu, 25 Jun 2020 09:34:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404887AbgFYNeP (ORCPT ); Thu, 25 Jun 2020 09:34:15 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D627C08C5C1 for ; Thu, 25 Jun 2020 06:34:15 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h15so5855563wrq.8 for ; Thu, 25 Jun 2020 06:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+en12hbajA2epjn74KKtvunas9oH7o8wq7HKdXNb8M0=; b=zbnXFjc/f3t0HXVoKImkdmg5QD+hfAo/wnHs68LQN6hK956Xp5jO4Zmjk8rLth24Ms D5WOsZFtBh/qkBtEBDygVtDg3e7B6OwSHztlJBclVtWh0qkbSEdG2IPFEEDuwMJ2V0fe EsqlzrSqH1vgbMFtAKRGt7csuDdXUuvPxWACVl4dyaKb2sKbSrRHvtH4IM1gXpX5DEwE ZixSdfhlet1m6v++dZGefh++3rR/ZPWnZspJnBoEyi+1vCo8H4YFpzreLS5YoJZ0rt7Q fLtLGMkIlPKFNcsId/Raezp2iTCENVvdyYaogvEYUoOQGxGVDzdJKH1hs6UdboSAgfsQ I+Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+en12hbajA2epjn74KKtvunas9oH7o8wq7HKdXNb8M0=; b=IeT4qEeT4muPg1Xdghgvcb1pA+NHfFFnb911A7Q054OXHZV0+T9+l6MwVCMDIXYJfM f4pSaq/u9gRVRpplH7ZwJhoEWJqBMvrkrvqKZe054BGrILZs1yecFVPuqQDukDaGI6ru vUTO3DNetCypsQhn8JwGQfJE6enHdYv1Kmq+l12jSXL+11i/lkbDKntygQdLrgL2A1Zc Vn32Qgen9xnZOf9iHNQbYNGzbXt/RgaRHb+RvlrhT4ROiu46YihZrH4UfHMqT6ZO2HX5 AHY/hejs5Rj5vHoc09rUFVHCF+WuHo32HSFvn7gBAf/mKOWbPwzrgGmtUvqbd2ybA4kK 5tpg== X-Gm-Message-State: AOAM533P3YA/HO8PCOEDd4gWMOa34yvVW+zUZNvb+wakSp7MBizT+evf MiHAefRsHzKfNdzdtCabxc0neQ== X-Google-Smtp-Source: ABdhPJyg90AdzA2eO9xnhupkOpjLo09dHDKK962lpGaGylf28QL380IteVaxf1VIra2P5HiM8rrNvw== X-Received: by 2002:adf:f350:: with SMTP id e16mr34165014wrp.43.1593092053811; Thu, 25 Jun 2020 06:34:13 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f16sm12669678wmh.27.2020.06.25.06.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 06:34:13 -0700 (PDT) Date: Thu, 25 Jun 2020 14:34:11 +0100 From: Lee Jones To: Greg KH Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args Message-ID: <20200625133411.GP954398@dell> References: <20200625064619.2775707-1-lee.jones@linaro.org> <20200625064619.2775707-2-lee.jones@linaro.org> <20200625065608.GB2789306@kroah.com> <20200625071313.GM954398@dell> <20200625094513.GC3299764@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200625094513.GC3299764@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jun 2020, Greg KH wrote: > On Thu, Jun 25, 2020 at 08:13:13AM +0100, Lee Jones wrote: > > On Thu, 25 Jun 2020, Greg KH wrote: > > > > > On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote: > > > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > > > > > Prevents warnings like: > > > > > > > > drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock' > > > > drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock' > > > > > > > > Cc: > > > > Cc: patches@opensource.cirrus.com > > > > Signed-off-by: Lee Jones > > > > --- > > > > drivers/mfd/wm8350-core.c | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c > > > > index 42b16503e6cd1..fbc77b218215c 100644 > > > > --- a/drivers/mfd/wm8350-core.c > > > > +++ b/drivers/mfd/wm8350-core.c > > > > @@ -131,6 +131,8 @@ EXPORT_SYMBOL_GPL(wm8350_block_write); > > > > * The WM8350 has a hardware lock which can be used to prevent writes to > > > > * some registers (generally those which can cause particularly serious > > > > * problems if misused). This function enables that lock. > > > > + * > > > > + * @wm8350: pointer to local driver data structure > > > > */ > > > > int wm8350_reg_lock(struct wm8350 *wm8350) > > > > { > > > > @@ -160,6 +162,8 @@ EXPORT_SYMBOL_GPL(wm8350_reg_lock); > > > > * problems if misused). This function disables that lock so updates > > > > * can be performed. For maximum safety this should be done only when > > > > * required. > > > > + * > > > > + * @wm8350: pointer to local driver data structure > > > > */ > > > > int wm8350_reg_unlock(struct wm8350 *wm8350) > > > > { > > > > > > Why are all of these documentation fixes for stable? > > > > Because they fix compiler warnings. > > When you type 'make' these warnings show up? We don't do documentation > builds as part of a normal build... 'make W=1' yes. :) > If for some reason we ever get rid of all of the thousands of current > warnings, then yes, I will be glad to consider stuff like this then. Workin' on it! Sorry for the noise (for now). -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog