From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
John Garry <john.garry@huawei.com>,
Don Brace <don.brace@microchip.de>,
Bart van Assche <bvanassche@acm.org>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 06/22] fnic: check for started requests in fnic_wq_copy_cleanup_handler()
Date: Thu, 25 Jun 2020 16:01:08 +0200 [thread overview]
Message-ID: <20200625140124.17201-7-hare@suse.de> (raw)
In-Reply-To: <20200625140124.17201-1-hare@suse.de>
fnic_wq_copy_cleanup_handler() is using scsi_host_find_tag() to
map id to a scsi command. However, as per discussion on the mailinglist
scsi_host_find_tag() might return a non-started request, so we need
to check the returned command with blk_mq_request_started() to avoid
the function tripping over a non-initialized command.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/fnic/fnic_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 04879ced2835..13db2181d3fd 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -1464,7 +1464,7 @@ void fnic_wq_copy_cleanup_handler(struct vnic_wq_copy *wq,
return;
sc = scsi_host_find_tag(fnic->lport->host, id);
- if (!sc)
+ if (!sc || !blk_mq_request_started(sc->request))
return;
io_lock = fnic_io_lock_hash(fnic, sc);
--
2.16.4
next prev parent reply other threads:[~2020-06-25 14:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 14:01 [PATCHv4 00/22] scsi: enable reserved commands for LLDDs Hannes Reinecke
2020-06-25 14:01 ` [PATCH 01/22] scsi: drop gdth driver Hannes Reinecke
2020-06-28 3:38 ` Bart Van Assche
2020-06-25 14:01 ` [PATCH 02/22] block: add flag for internal commands Hannes Reinecke
2020-06-28 3:43 ` Bart Van Assche
2020-06-28 10:13 ` Hannes Reinecke
2020-06-25 14:01 ` [PATCH 03/22] scsi: add scsi_{get,put}_internal_cmd() helper Hannes Reinecke
2020-06-28 3:48 ` Bart Van Assche
2020-06-28 9:02 ` Hannes Reinecke
2020-06-28 15:08 ` Bart Van Assche
2020-06-29 6:32 ` Hannes Reinecke
2020-06-29 14:24 ` John Garry
2020-06-29 14:38 ` Bart Van Assche
2020-06-25 14:01 ` [PATCH 04/22] fnic: use internal commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 05/22] fnic: use scsi_host_busy_iter() to traverse commands Hannes Reinecke
2020-06-25 14:01 ` Hannes Reinecke [this message]
2020-06-25 14:01 ` [PATCH 07/22] csiostor: use internal command for LUN reset Hannes Reinecke
2020-06-25 14:01 ` [PATCH 08/22] scsi: implement reserved command handling Hannes Reinecke
2020-06-25 15:30 ` John Garry
2020-06-25 15:59 ` Hannes Reinecke
2020-06-25 14:01 ` [PATCH 09/22] scsi: use real inquiry data when initialising devices Hannes Reinecke
2020-06-25 14:01 ` [PATCH 10/22] scsi: Use dummy inquiry data for the host device Hannes Reinecke
2020-06-25 14:01 ` [PATCH 11/22] scsi: revamp host device handling Hannes Reinecke
2020-06-25 14:01 ` [PATCH 12/22] snic: use reserved commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 13/22] snic: use tagset iter for traversing commands Hannes Reinecke
2020-06-25 22:55 ` kernel test robot
2020-06-25 14:01 ` [PATCH 14/22] snic: check for started requests in snic_hba_reset_cmpl_handler() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 15/22] hpsa: move hpsa_hba_inquiry after scsi_add_host() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 16/22] hpsa: use reserved commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 17/22] hpsa: use scsi_host_busy_iter() to traverse outstanding commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 18/22] hpsa: drop refcount field from CommandList Hannes Reinecke
2020-06-25 14:01 ` [PATCH 19/22] aacraid: move scsi_add_host() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 20/22] aacraid: store target id in host_scribble Hannes Reinecke
2020-06-25 14:01 ` [PATCH 21/22] aacraid: use scsi_get_internal_cmd() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 22/22] aacraid: use scsi_host_busy_iter() to traverse outstanding commands Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2020-06-29 7:19 [PATCHv5 00/22] scsi: enable reserved commands for LLDDs Hannes Reinecke
2020-06-29 7:20 ` [PATCH 06/22] fnic: check for started requests in fnic_wq_copy_cleanup_handler() Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625140124.17201-7-hare@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=don.brace@microchip.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.