From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression
Date: Thu, 25 Jun 2020 10:31:32 -0400 [thread overview]
Message-ID: <20200625143132.GG8432@bill-the-cat> (raw)
In-Reply-To: <12412f82-7c6b-eb93-9ce6-134af9d3ccc0@denx.de>
On Thu, Jun 25, 2020 at 04:18:00PM +0200, Stefano Babic wrote:
> On 25.06.20 15:55, Fabio Estevam wrote:
> > Hi Tom,
> >
> > On Thu, Jun 25, 2020 at 10:52 AM Soeren Moch <smoch@web.de> wrote:
> >>
> >> On 25.06.20 13:14, Fabio Estevam wrote:
> >>> Since commit:
> >>>
> >>> commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc
> >>> Author: Michael Walle <michael@walle.cc>
> >>> Date: Thu May 7 00:11:58 2020 +0200
> >>>
> >>> phy: atheros: ar8035: remove static clock config
> >>>
> >>> We can configure the clock output in the device tree. Disable the
> >>> hardcoded one in here. This is highly board-specific and should have
> >>> never been enabled in the PHY driver.
> >>>
> >>> If bisecting shows that this commit breaks your board it probably
> >>> depends on the clock output of your Atheros AR8035 PHY. Please have a
> >>> look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set
> >>> "clk-out-frequency = <125000000>" because that value was the hardcoded
> >>> value until this commit.
> >>>
> >>> Signed-off-by: Michael Walle <michael@walle.cc>
> >>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> >>>
> >>> , the clock output setting for the AR803x driver is removed from being
> >>> hardcoded in the PHY driver and should be passed via device tree instead.
> >>>
> >>> Update the device tree with the "qca,clk-out-frequency" property so that
> >>> Ethernet can work again.
> >>>
> >>> Reported-by: Soeren Moch <smoch@web.de>
> >>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> >> Tested-by: Soeren Moch <smoch@web.de>
> >
> > My understanding is that Stefano does not have any other pull requests
> > for 2020.07.
> >
>
> Yes, I do not see (this is an exception) other urgent patches that
> should flow into the release.
>
> > In this case, could you apply this regression fix directly?
> >
>
> +1
OK, will do, thanks for sorting this out so quickly!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200625/3c9869aa/attachment.sig>
next prev parent reply other threads:[~2020-06-25 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 11:14 [PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression Fabio Estevam
2020-06-25 13:52 ` Soeren Moch
2020-06-25 13:55 ` Fabio Estevam
2020-06-25 14:18 ` Stefano Babic
2020-06-25 14:31 ` Tom Rini [this message]
2020-06-25 22:14 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625143132.GG8432@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.