From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00027C433E0 for ; Thu, 25 Jun 2020 14:59:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB37620768 for ; Thu, 25 Jun 2020 14:59:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KKdRu58R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xRA7a7WN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB37620768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qP7eCAJ5njKFm/HZ3igGU+PUhLw9ovOv+7SFpBRyKko=; b=KKdRu58RApFs+xFAKSpRHS+Ko vu41Z8hVrcYSLBvkN34o4y0bVgT0PQlL4YId8AsgIsFWx7eUBf4SnuAXK+30oTtGhT6R8QKjTSQis wNyMUVhoonnF+/pMr+ucF96n5W4TpNNEGDRjyJrRVP90PkxI0KQ0BPrxA+TZ9sLU9kV/7eTN1erIU /rSwCAWC/oKaIKm8CZRH2nNH2t38bq6QP/IbOiv0pgvxSPQTPXf38qecGrpewF8EKniUZNqXSBYov Gd4dICSqOcUQ6H7n9i/2Mtjru3HerMcnIFiWZpwbphajkugXJHmKKavwSXHJJZiO3dLDT3rDaMSOz Rmr94ad9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joTJn-00004s-Aa; Thu, 25 Jun 2020 14:57:35 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joTJj-0008Vz-Oy for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 14:57:32 +0000 Received: by mail-wm1-x344.google.com with SMTP id l17so5889296wmj.0 for ; Thu, 25 Jun 2020 07:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+7QpQs6FhlpOXE9FQrO8BUOl2ttFaq7mxuLw6M5Nym0=; b=xRA7a7WNemF2+ECa311QCcaUwE+ZUu/cj6cIbIvkYviFl2sMvfHdyFQCKmzZaJj+eF 1y6apB3UH2ZKIk+pPcgF+3VuQ5kQAV/ef8ebI/c/UG64L+oWxN7a5hostGrpYOAIUGNw KgNhlasIT2fYmlWzk37PWUYkW5yhZpOx4G0kLwbNn8bFB/lnbabAT8F5usCe9SmQtbKj aaZcDurCTDnB2KpfqoV1ydaJCYASOICfY7fvLQgIqT+743VBmlnjoE2DRPdKk3rL2tm6 wnsoMvlLuITZH9lO8zx3xnUyyqMrODMB+j++YhH7p0BtK4Viv52CaeuXw/D3m3jv6eZB AkHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+7QpQs6FhlpOXE9FQrO8BUOl2ttFaq7mxuLw6M5Nym0=; b=fzeFsGpPGJwNuYklrpOUVZbnW4ONDYhWRd6GAMa0lZPhx4pJkyrufgQ3AMRlQ6d1Kb D7HUG57oT4JDcjByiltAjubvGoBT6vhOwLNIMiq6WfBi8k+cQ+spApI14kIRT/1anBG8 7ihaqyuA02TtBoX01T83MZBpnIARM6rx5UuaUGDgBceEIHB7LyNejbnqrluksSe1uf/X T+sZY5+KIGCplSISyGULhWxqOhJjZgCE2qKorEkSkigODSCsn6D0guwid017NQ8clZwl i4mjm2txjz0f7jEcvHeLJaDNBkNx24cd9K1WvyNcDWOegWo5j08ZOt/6SnZ24l+gUqr0 T3Vw== X-Gm-Message-State: AOAM530o13M3zCf+IjtK0wBkA0JtkEvxsuHCVu/BjwmJC1n+N+pFSA86 ph2HgT2hj4+AQ+80a9Yk26DR62ubDmI= X-Google-Smtp-Source: ABdhPJyFueEyfmUNkHi9WsjhYIRl9UwJEKZQIopHogN7onsTa92/7L3ToUPhcpZZZf5KJVaVQ4gBtg== X-Received: by 2002:a1c:1946:: with SMTP id 67mr3982816wmz.59.1593097050635; Thu, 25 Jun 2020 07:57:30 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z1sm18241248wrh.14.2020.06.25.07.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 07:57:29 -0700 (PDT) Date: Thu, 25 Jun 2020 15:57:26 +0100 From: Lee Jones To: Masahiro Yamada Subject: Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Message-ID: <20200625145726.GT954398@dell> References: <20200623114614.792648-1-yamada.masahiro@socionext.com> <20200623114614.792648-4-yamada.masahiro@socionext.com> <20200623122413.GA954398@dell> <20200624181605.GJ954398@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Rob Herring , Linux Kernel Mailing List , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyNSBKdW4gMjAyMCwgTWFzYWhpcm8gWWFtYWRhIHdyb3RlOgoKPiBPbiBUaHUsIEp1 biAyNSwgMjAyMCBhdCAzOjE2IEFNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+IHdy b3RlOgo+ID4KPiA+IE9uIFRodSwgMjUgSnVuIDIwMjAsIE1hc2FoaXJvIFlhbWFkYSB3cm90ZToK PiA+Cj4gPiA+IE9uIFR1ZSwgSnVuIDIzLCAyMDIwIGF0IDk6MjQgUE0gTGVlIEpvbmVzIDxsZWUu am9uZXNAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBPbiBUdWUsIDIzIEp1biAy MDIwLCBNYXNhaGlybyBZYW1hZGEgd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiA+ICdtYWtlIEFSQ0g9 YXJtIGR0YnNfY2hlY2snIGVtaXRzIHRoZSBmb2xsb3dpbmcgd2FybmluZzoKPiA+ID4gPiA+Cj4g PiA+ID4gPiAgIHN1cHBvcnQtY2FyZEAxLDFmMDAwMDA6ICRub2RlbmFtZTowOiAnc3VwcG9ydC1j YXJkQDEsMWYwMDAwMCcgZG9lcyBub3QgbWF0Y2ggJ14oYnVzfHNvY3xheGl8YWhifGFwYikoQFsw LTlhLWZdKyk/JCcKPiA+ID4gPiA+Cj4gPiA+ID4gPiBNYXliZSwgc2ltcGxlLW1mZCBjb3VsZCBi ZSBhIGJldHRlciBmaXQgZm9yIHRoaXMgZGV2aWNlLgo+ID4gPiA+Cj4gPiA+ID4gVGhlIHR3byBz aG91bGQgYmUgZXF1aXZhbGVudC4KPiA+ID4KPiA+ID4gWWVzLCBJIGtub3cuCj4gPiA+IFRoYXQn cyB3aHkgSSBjYW4gY2hhbmdlICJzaW1wbGUtYnVzIiB0byAic2ltcGxlLW1mZCIKPiA+ID4gd2l0 aCBubyByaXNrLgo+ID4gPgo+ID4gPiBUaGUgZGlmZmVyZW5jZSBpcyBzY2hlbWEtY2hlY2suCj4g PiA+Cj4gPiA+IFRoZSBub2RlIG5hbWUgZm9yICJzaW1wbGUtYnVzIiBpcyBjaGVja2VkIGJ5ICdt YWtlIGR0YnNfY2hlY2snLgo+ID4gPgo+ID4gPiBTZWUgdGhpcyBjb2RlOgo+ID4gPiBodHRwczov L2dpdGh1Yi5jb20vcm9iaGVycmluZy9kdC1zY2hlbWEvYmxvYi92MjAyMC4wNS9zY2hlbWFzL3Np bXBsZS1idXMueWFtbCNMMTcKPiA+ID4KPiA+ID4gRXZlbiBpZiBJIHJlbmFtZSB0aGUgbm9kZSwg aXQgZG9lcyBub3QgYWNjZXB0IHRoZQo+ID4gPiB1bml0IG5hbWUgJzEsMWYwMDAwMCcKPiA+ID4K PiA+ID4gPiBXaGF0IGRvIHlvdSBtZWFuIGJ5ICJtYXliZSI/ICBEb2VzIHRoaXMgc3F1YXNoIHRo ZSB3YXJuaW5nPwo+ID4gPgo+ID4gPiAibWF5YmUiIG1lYW5zIEkgYW0gbm90IHF1aXRlIHN1cmUK PiA+ID4gd2hpY2ggY29tcGF0aWJsZSBpcyBhIGJldHRlciBmaXQKPiA+ID4gdG8gZGVzY3JpYmUg dGhpcyBkZXZpY2UuCj4gPiA+Cj4gPiA+IEFzIG1lbnRpb25lZCBhYm92ZSwgc2ltcGxlLWJ1cyBh bmQgc2ltcGxlLW1mZAo+ID4gPiBhcmUgaW50ZXJjaGFuZ2VhYmxlIGZyb20gYSBkcml2ZXIgcG9p bnQgb2Ygdmlldy4KPiA+ID4KPiA+ID4gVGhpcyBhZGQtb24gYm9hcmQgaXMgaW50ZWdyYXRlZCB3 aXRoIHZhcmlvdXMgcGVyaXBoZXJhbHMKPiA+ID4gc3VjaCBhcyAxNjU1MGEgc2VyaWFsLCBzbXNj OTExNSBldGhlciBldGMuCj4gPiA+IFRoZSBhZGRyZXNzLWRlY29kZSBpcyBpbXBsZW1lbnRlZCBp biBhIENQTEQgZGV2aWNlLgo+ID4gPiBJdCBoYXMgY2hpcCBzZWxlY3RzIGFuZCBsb2NhbCBhZGRy ZXNzZXMsIHdoaWNoIGFyZSBtYXBwZWQgdG8KPiA+ID4gdGhlIHBhcmVudC4KPiA+ID4KPiA+ID4g SXQgY2FuIGJlIGVpdGhlciBzaW1wbGUtYnVzIG9yIHNpbXBsZS1tZmQsIEkgdGhpbmsuCj4gPiA+ Cj4gPiA+Cj4gPiA+IGR0LXNjaGVtYSBjaGVja3MgdGhlIG5vZGUgbmFtZSBvZiBzaW1wbGUtYnVz Lgo+ID4gPiBDdXJyZW50bHksIHRoZXJlIGlzIG5vIGNoZWNrIGZvciBzaW1wbGUtbWZkLgo+ID4g Pgo+ID4gPiBTbywgSSB0aGluayB0aGlzIHBhdGNoIGlzIGFuIGVhc3kgc29sdXRpb24KPiA+ID4g dG8gZml4IHRoZSB3YXJuaW5nLgo+ID4KPiA+IFllcywgbG9va2luZyBhdCB0aGUgZG9jdW1lbnRh dGlvbiBpdCBzZWVtcyBhcyB0aG91Z2ggJ3NpbXBsZS1tZmQnCj4gPiB3b3VsZCBiZSBhIGJldHRl ciBmaXQuICBJcyB0aGUgZGV2aWNlIGEgc2luZ2xlIElQIHdpdGggdmFyaW91cwo+ID4gZGlmZmVy ZW50IGZ1bmN0aW9ucz8KPiAKPiBOb3QgYW4gSVAuCj4gCj4gVGhpcyBpcyBhIHNtYWxsIGJvYXJk IHRoYXQgY29uc2lzdHMgb2YKPiBhIENQTEQgKyBldGhlcm5ldCBjb250cm9sbGVyICsgc2VyaWFs IGNvbnRyb2xsZXIgKyBMRUQsIGV0Yy4KClRoZW4gc2ltcGxlIE1GRCBkb2VzIG5vdCBzZWVtIGxp a2UgYSBnb29kIGZpdC4KCk5laXRoZXIgZG9lcyAnc2ltcGxlLWJ1cycuCgpXaGF0IGlzIGl0IHlv dSdyZSB0cnlpbmcgdG8gZGVzY3JpYmUgaW4gdGhlIGRldmljZSBoaWVyYXJjaHk/Cgo+ID4gPiBS b2IgaXMgaW4gQ2MuIFBsZWFzZSBhZGQgY29tbWVudHMgaWYgYW55Lgo+ID4gPgo+ID4gPiA+IElz bid0IHRoZSBpc3N1ZSBjYXVzZWQgYnkgdGhlICcsJz8KPiA+ID4KPiA+ID4gUmlnaHQuCj4gPiA+ Cj4gPiA+IFRoZSBub2RlIG5hbWUgb2Ygc2ltcGxlLWJ1cwo+ID4gPiBtdXN0IG1lZXQgdGhlIHJl Z3VsYXIgZXhwcmVzc2lvbjoKPiA+ID4gIl4oYnVzfHNvY3xheGl8YWhifGFwYikoQFswLTlhLWZd Kyk/JCIKPiA+ID4KPiA+ID4KPiA+ID4gRXZlbiBpZiBJIHJlbmFtZSB0aGUgbm9kZQo+ID4gPiAi c3VwcG9ydC1jYXJkQDEsMWYwMDAwMCIKPiA+ID4gdG8gImJ1c0AxLDFmMDAwMDAiLCB0aGUgd2Fy bmluZyBpcyBzdGlsbAo+ID4gPiBkaXNwbGF5ZWQgZHVlIHRvICcsJwo+ID4gPgo+ID4gPiAiMSwx ZjAwMDAwIiBtZWFucwo+ID4gPiB0aGUgYWRkcmVzcyAweDAxZjAwMDAwIG9mIGNoaXAgc2VsZWN0 IDEuCj4gPgo+ID4gSXMgdGhpcyBhbiBvZmZpY2lhbGx5IGFjY2VwdGVkIGZvcm1hdD8KPiAKPiBJ IGFtIG5vdCBzdXJlIGlmIGl0IGlzIG9mZmljaWFsLgo+IAo+IFJvYiBzYWlkIHRoZSBkYXRhIGZp ZWxkcyBzaG91bGQgYmUgc2VwYXJhdGVkIGJ5IGNvbW1hcy4KPiBodHRwczovL3d3dy5zcGluaWNz Lm5ldC9saXN0cy9kZXZpY2V0cmVlL21zZzIwMTU2NS5odG1sCgpBcmUgeW91IHN1cmUgaGUgZG9l c24ndCBtZWFuIGluIHRoZSAncmVnJyBwcm9wZXJ0eS4KClJhdGhlciB0aGFuIHRoZSBub2RlLW5h bWVATk5OTk5OTk4gc3ludGF4LgoKQlRXLCBJIHRoaW5rIHRoZSBlcnJvciB5b3UgbGluayB0byBh Ym92ZSBpcyByZWxhdGVkIHRvIHRoZQpub2RlLW5hbWVATk5OTk5OTk4gbm90IG1hdGNoaW5nIHRo ZSB2YWx1ZSBsaXN0ZWQgaW4gdGhlICdyZWcnCnByb3BlcnR5LgoKLS0gCkxlZSBKb25lcyBb5p2O 55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJv Lm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86 IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390FCC433DF for ; Thu, 25 Jun 2020 14:57:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1119F20768 for ; Thu, 25 Jun 2020 14:57:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xRA7a7WN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405599AbgFYO5d (ORCPT ); Thu, 25 Jun 2020 10:57:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405502AbgFYO5c (ORCPT ); Thu, 25 Jun 2020 10:57:32 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFB07C08C5C1 for ; Thu, 25 Jun 2020 07:57:31 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id g75so5858144wme.5 for ; Thu, 25 Jun 2020 07:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+7QpQs6FhlpOXE9FQrO8BUOl2ttFaq7mxuLw6M5Nym0=; b=xRA7a7WNemF2+ECa311QCcaUwE+ZUu/cj6cIbIvkYviFl2sMvfHdyFQCKmzZaJj+eF 1y6apB3UH2ZKIk+pPcgF+3VuQ5kQAV/ef8ebI/c/UG64L+oWxN7a5hostGrpYOAIUGNw KgNhlasIT2fYmlWzk37PWUYkW5yhZpOx4G0kLwbNn8bFB/lnbabAT8F5usCe9SmQtbKj aaZcDurCTDnB2KpfqoV1ydaJCYASOICfY7fvLQgIqT+743VBmlnjoE2DRPdKk3rL2tm6 wnsoMvlLuITZH9lO8zx3xnUyyqMrODMB+j++YhH7p0BtK4Viv52CaeuXw/D3m3jv6eZB AkHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+7QpQs6FhlpOXE9FQrO8BUOl2ttFaq7mxuLw6M5Nym0=; b=st5N7C+r1LOOHAQjjToxx28NVns14LJ77BSEdMh1nFqCObq4csVfkebLOL3l449aXw mM6Z9TKszxK3fzL8vENs2pkt9jDwDEKquZ8emhQGbQdZ7rYDZutoMAqRMZvgcEQ/82Se tCZnpq53jkdF60h0sLeOL8ME1/FPdVsl5mMrDzz84w7LBGas7HlM8d5qEXpsfWnzdbTU XJrbt3OjDELo6SrKFz+FKa4Fft91SJc/eWxgWTSHfsugwKBHZbp0+3cBKQzdZcBjr0RG SfdflK28j8/qJ4b48Zhn3dXRUXk8N+1r6DpA7nlZ6L/6a5pgzr+udxLU8aBgvsn09Lup NMpA== X-Gm-Message-State: AOAM532Pl3WkdPkqs+ZvTIILOvPVfhcomd6wQ9eHakhC+V2kTFiqjmiO Ps7JCU4Wxo5hj1fa/y8CJpUcOw== X-Google-Smtp-Source: ABdhPJyFueEyfmUNkHi9WsjhYIRl9UwJEKZQIopHogN7onsTa92/7L3ToUPhcpZZZf5KJVaVQ4gBtg== X-Received: by 2002:a1c:1946:: with SMTP id 67mr3982816wmz.59.1593097050635; Thu, 25 Jun 2020 07:57:30 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z1sm18241248wrh.14.2020.06.25.07.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 07:57:29 -0700 (PDT) Date: Thu, 25 Jun 2020 15:57:26 +0100 From: Lee Jones To: Masahiro Yamada Cc: linux-arm-kernel , Rob Herring , DTML , Linux Kernel Mailing List Subject: Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Message-ID: <20200625145726.GT954398@dell> References: <20200623114614.792648-1-yamada.masahiro@socionext.com> <20200623114614.792648-4-yamada.masahiro@socionext.com> <20200623122413.GA954398@dell> <20200624181605.GJ954398@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 25 Jun 2020, Masahiro Yamada wrote: > On Thu, Jun 25, 2020 at 3:16 AM Lee Jones wrote: > > > > On Thu, 25 Jun 2020, Masahiro Yamada wrote: > > > > > On Tue, Jun 23, 2020 at 9:24 PM Lee Jones wrote: > > > > > > > > On Tue, 23 Jun 2020, Masahiro Yamada wrote: > > > > > > > > > 'make ARCH=arm dtbs_check' emits the following warning: > > > > > > > > > > support-card@1,1f00000: $nodename:0: 'support-card@1,1f00000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > > > > > > > > > Maybe, simple-mfd could be a better fit for this device. > > > > > > > > The two should be equivalent. > > > > > > Yes, I know. > > > That's why I can change "simple-bus" to "simple-mfd" > > > with no risk. > > > > > > The difference is schema-check. > > > > > > The node name for "simple-bus" is checked by 'make dtbs_check'. > > > > > > See this code: > > > https://github.com/robherring/dt-schema/blob/v2020.05/schemas/simple-bus.yaml#L17 > > > > > > Even if I rename the node, it does not accept the > > > unit name '1,1f00000' > > > > > > > What do you mean by "maybe"? Does this squash the warning? > > > > > > "maybe" means I am not quite sure > > > which compatible is a better fit > > > to describe this device. > > > > > > As mentioned above, simple-bus and simple-mfd > > > are interchangeable from a driver point of view. > > > > > > This add-on board is integrated with various peripherals > > > such as 16550a serial, smsc9115 ether etc. > > > The address-decode is implemented in a CPLD device. > > > It has chip selects and local addresses, which are mapped to > > > the parent. > > > > > > It can be either simple-bus or simple-mfd, I think. > > > > > > > > > dt-schema checks the node name of simple-bus. > > > Currently, there is no check for simple-mfd. > > > > > > So, I think this patch is an easy solution > > > to fix the warning. > > > > Yes, looking at the documentation it seems as though 'simple-mfd' > > would be a better fit. Is the device a single IP with various > > different functions? > > Not an IP. > > This is a small board that consists of > a CPLD + ethernet controller + serial controller + LED, etc. Then simple MFD does not seem like a good fit. Neither does 'simple-bus'. What is it you're trying to describe in the device hierarchy? > > > Rob is in Cc. Please add comments if any. > > > > > > > Isn't the issue caused by the ','? > > > > > > Right. > > > > > > The node name of simple-bus > > > must meet the regular expression: > > > "^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$" > > > > > > > > > Even if I rename the node > > > "support-card@1,1f00000" > > > to "bus@1,1f00000", the warning is still > > > displayed due to ',' > > > > > > "1,1f00000" means > > > the address 0x01f00000 of chip select 1. > > > > Is this an officially accepted format? > > I am not sure if it is official. > > Rob said the data fields should be separated by commas. > https://www.spinics.net/lists/devicetree/msg201565.html Are you sure he doesn't mean in the 'reg' property. Rather than the node-name@NNNNNNNN syntax. BTW, I think the error you link to above is related to the node-name@NNNNNNNN not matching the value listed in the 'reg' property. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog