From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Thu, 25 Jun 2020 18:57:46 +0000 Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-Id: <20200625185746.GA1875182@ravnborg.org> List-Id: References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> <20200624154321.GH954398@dell> <20200624162446.GA1815586@ravnborg.org> <20200625080337.GN954398@dell> In-Reply-To: <20200625080337.GN954398@dell> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lee Jones Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Lee. On Thu, Jun 25, 2020 at 09:03:37AM +0100, Lee Jones wrote: > On Wed, 24 Jun 2020, Sam Ravnborg wrote: > > > Hi Lee. > > > > On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote: > > > On Wed, 24 Jun 2020, Sam Ravnborg wrote: > > > > > > > Hi Lee. > > > > > > > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > > > > > Attempting to clean-up W=1 kernel builds, which are currently > > > > > overwhelmingly riddled with niggly little warnings. > > > > > > > > > > Lee Jones (8): > > > > > backlight: lms501kf03: Remove unused const variables > > > > > backlight: lcd: Add missing kerneldoc entry for 'struct device parent' > > > > > > > > > > > > > backlight: ili922x: Add missing kerneldoc descriptions for > > > > > CHECK_FREQ_REG() args > > > > > backlight: ili922x: Remove invalid use of kerneldoc syntax > > > > > backlight: ili922x: Add missing kerneldoc description for > > > > > ili922x_reg_dump()'s arg > > > > I wonder why these warnings show up as nothing pulls in this .c file. > > > > Anyway I would suggest to drop using kerneldoc syntax for single drivers > > > > like this - and the benefit here is low. > > > > Now they are typed, otherwise this ahd been fine in a single patch. > > > > > > What do you mean by 'nothing pulls it in'? > > There are no .rst files that includes any: > > .. kernel-doc:: drivers/video/backlight/ili922x.c > > > > so I do not see how the kernel-doc comments will be used by any > > of the generated kernel-docs. > > Looks like a common problem (if it is actually a problem): > > $ ./scripts/find-unused-docs.sh . | wc -l > 1476 > > The role of this patch-set is not to eradicate unused kerneldoc > headers, but to ensure they are formatted correctly. W=1 builds > currently complain of ill formatted kerneldocs, which is currently > littering the build-log and masking some more important issues (which > I'm also trying to fix en route). My point is that I do not see why we should maintain correct kernel-doc style comments for files that are not used to to generate kernel-doc. It would serve us better to drop the kernel-doc style comments. But thats just my opinion, feel free to ignore. I digged a little and can see we run kernel-doc on all .c files when we specify W=1 - which was a suprise to me. That explains why I had not seen said warnings in my regular make htmldocs runs. Sam > > > > > > backlight: backlight: Supply description for function args in existing > > > > > Kerneldocs > > > > > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 > > > > > backlight: qcom-wled: Remove unused configs for LED3 and LED4 > > > > > > > > The other fixes looks good. > > > > They are all: > > > > Acked-by: Sam Ravnborg > > > > > > Thanks (although this should be Reviewed-by). > > > > > > > > drivers/video/backlight/backlight.c | 2 ++ > > > > > drivers/video/backlight/ili922x.c | 8 ++++++-- > > > > > drivers/video/backlight/lcd.c | 1 + > > > > > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > > > > > drivers/video/backlight/lms501kf03.c | 8 -------- > > > > > drivers/video/backlight/qcom-wled.c | 8 -------- > > > > > 6 files changed, 11 insertions(+), 20 deletions(-) > > > > > > > > > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA36C433DF for ; Fri, 26 Jun 2020 12:00:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A9E62078D for ; Fri, 26 Jun 2020 12:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c0ugqpFY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hihmwLqD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A9E62078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Nyl9PuHmnJVEjAZfhd2jWZKgnQlaHbNXXeCxexqYSlE=; b=c0ugqpFYFflD6UnkvENPIox9n f4FxEg2pzQZT6cHd9MxKBwr8q77QWojVUtOXmP9+yPSBpyE0892YEzLLPN6maMlPp+xFqmAw3qlTU /u/stNwD9953sVdm81GoY6O8/NVaiiO8t1xaZU0JfEUdTVxMJ0fEyVJm07D5zNXGBFGDMTQb0hbjM cFHleYPwi6cnlNTOKK3uXDxo3fKlZqBWM0BKgoD1Okd4Ioqi0Ae9f8RnVnLWzyK+TWNDnlaav1WL1 sUOG4EiiE+2lbeUD4RyefemPpKM/2AxbQOMhKgYW5XdtZ/J4OJiSIoDEtnbwauoo8Sws95fMcGdMj AvKwD6+hg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomzU-0000Q2-Tw; Fri, 26 Jun 2020 11:57:57 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolPX-0005MW-QJ for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:16:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=vBZZgqwyy4W5L6brXE43yqr42YWGC5JsrQ8oCm+Yb5c=; b=hihmwLqDCpztVTKPZDrRaE0aWm Y8i7ugBxSrp2OtV41mil6NEYETlgDVOt/uIhL34rOZHEC6KRcyTofxGbrZXb76KfXIbl5eL44EsLs 9DPMBkAUJ5WVp6Ngnwdo87rPXIaNyeeAhAz61ZPB6AVpfDlfQvvdcYGRO3kZ4+dr/+7c02r/Hwtwo Bs2z15UOWDUZnzojPmUKwt0VucitRjmRy82VvmEv/cQxcA4anwGi+CYbO+ZBQt2VYKC59XcBIISVK 4Mf//PeH8r3rxu7xnsVsSYD71WW6CUCZq/tsQcrKVpNKHcJcaeOzDP7xWzg8LE1a1m80OvH+iR+fT rAXdn0LA==; Received: from asavdk3.altibox.net ([109.247.116.14]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joX4R-0006WJ-Dr for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 18:58:02 +0000 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 88DBD200DF; Thu, 25 Jun 2020 20:57:47 +0200 (CEST) Date: Thu, 25 Jun 2020 20:57:46 +0200 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200625185746.GA1875182@ravnborg.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> <20200624154321.GH954398@dell> <20200624162446.GA1815586@ravnborg.org> <20200625080337.GN954398@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625080337.GN954398@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=KKAkSRfTAAAA:8 a=dC_rIlIaLDHj5HQ0j38A:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200625_195759_860604_54437E15 X-CRM114-Status: GOOD ( 34.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGVlLgoKT24gVGh1LCBKdW4gMjUsIDIwMjAgYXQgMDk6MDM6MzdBTSArMDEwMCwgTGVlIEpv bmVzIHdyb3RlOgo+IE9uIFdlZCwgMjQgSnVuIDIwMjAsIFNhbSBSYXZuYm9yZyB3cm90ZToKPiAK PiA+IEhpIExlZS4KPiA+IAo+ID4gT24gV2VkLCBKdW4gMjQsIDIwMjAgYXQgMDQ6NDM6MjFQTSAr MDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gPiBPbiBXZWQsIDI0IEp1biAyMDIwLCBTYW0gUmF2 bmJvcmcgd3JvdGU6Cj4gPiA+IAo+ID4gPiA+IEhpIExlZS4KPiA+ID4gPiAKPiA+ID4gPiBPbiBX ZWQsIEp1biAyNCwgMjAyMCBhdCAwMzo1NzoxM1BNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4g PiA+ID4gPiBBdHRlbXB0aW5nIHRvIGNsZWFuLXVwIFc9MSBrZXJuZWwgYnVpbGRzLCB3aGljaCBh cmUgY3VycmVudGx5Cj4gPiA+ID4gPiBvdmVyd2hlbG1pbmdseSByaWRkbGVkIHdpdGggbmlnZ2x5 IGxpdHRsZSB3YXJuaW5ncy4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gTGVlIEpvbmVzICg4KToKPiA+ ID4gPiA+ICAgYmFja2xpZ2h0OiBsbXM1MDFrZjAzOiBSZW1vdmUgdW51c2VkIGNvbnN0IHZhcmlh Ymxlcwo+ID4gPiA+ID4gICBiYWNrbGlnaHQ6IGxjZDogQWRkIG1pc3Npbmcga2VybmVsZG9jIGVu dHJ5IGZvciAnc3RydWN0IGRldmljZSBwYXJlbnQnCj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4g PiAgIGJhY2tsaWdodDogaWxpOTIyeDogQWRkIG1pc3Npbmcga2VybmVsZG9jIGRlc2NyaXB0aW9u cyBmb3IKPiA+ID4gPiA+ICAgICBDSEVDS19GUkVRX1JFRygpIGFyZ3MKPiA+ID4gPiA+ICAgYmFj a2xpZ2h0OiBpbGk5MjJ4OiBSZW1vdmUgaW52YWxpZCB1c2Ugb2Yga2VybmVsZG9jIHN5bnRheAo+ ID4gPiA+ID4gICBiYWNrbGlnaHQ6IGlsaTkyMng6IEFkZCBtaXNzaW5nIGtlcm5lbGRvYyBkZXNj cmlwdGlvbiBmb3IKPiA+ID4gPiA+ICAgICBpbGk5MjJ4X3JlZ19kdW1wKCkncyBhcmcKPiA+ID4g PiBJIHdvbmRlciB3aHkgdGhlc2Ugd2FybmluZ3Mgc2hvdyB1cCBhcyBub3RoaW5nIHB1bGxzIGlu IHRoaXMgLmMgZmlsZS4KPiA+ID4gPiBBbnl3YXkgSSB3b3VsZCBzdWdnZXN0IHRvIGRyb3AgdXNp bmcga2VybmVsZG9jIHN5bnRheCBmb3Igc2luZ2xlIGRyaXZlcnMKPiA+ID4gPiBsaWtlIHRoaXMg LSBhbmQgdGhlIGJlbmVmaXQgaGVyZSBpcyBsb3cuCj4gPiA+ID4gTm93IHRoZXkgYXJlIHR5cGVk LCBvdGhlcndpc2UgdGhpcyBhaGQgYmVlbiBmaW5lIGluIGEgc2luZ2xlIHBhdGNoLgo+ID4gPiAK PiA+ID4gV2hhdCBkbyB5b3UgbWVhbiBieSAnbm90aGluZyBwdWxscyBpdCBpbic/Cj4gPiBUaGVy ZSBhcmUgbm8gLnJzdCBmaWxlcyB0aGF0IGluY2x1ZGVzIGFueToKPiA+IC4uIGtlcm5lbC1kb2M6 OiBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmMKPiA+IAo+ID4gc28gSSBkbyBub3Qg c2VlIGhvdyB0aGUga2VybmVsLWRvYyBjb21tZW50cyB3aWxsIGJlIHVzZWQgYnkgYW55Cj4gPiBv ZiB0aGUgZ2VuZXJhdGVkIGtlcm5lbC1kb2NzLgo+IAo+IExvb2tzIGxpa2UgYSBjb21tb24gcHJv YmxlbSAoaWYgaXQgaXMgYWN0dWFsbHkgYSBwcm9ibGVtKToKPiAKPiAgJCAuL3NjcmlwdHMvZmlu ZC11bnVzZWQtZG9jcy5zaCAuIHwgd2MgLWwKPiAgMTQ3Ngo+IAo+IFRoZSByb2xlIG9mIHRoaXMg cGF0Y2gtc2V0IGlzIG5vdCB0byBlcmFkaWNhdGUgdW51c2VkIGtlcm5lbGRvYwo+IGhlYWRlcnMs IGJ1dCB0byBlbnN1cmUgdGhleSBhcmUgZm9ybWF0dGVkIGNvcnJlY3RseS4gIFc9MSBidWlsZHMK PiBjdXJyZW50bHkgY29tcGxhaW4gb2YgaWxsIGZvcm1hdHRlZCBrZXJuZWxkb2NzLCB3aGljaCBp cyBjdXJyZW50bHkKPiBsaXR0ZXJpbmcgdGhlIGJ1aWxkLWxvZyBhbmQgbWFza2luZyBzb21lIG1v cmUgaW1wb3J0YW50IGlzc3VlcyAod2hpY2gKPiBJJ20gYWxzbyB0cnlpbmcgdG8gZml4IGVuIHJv dXRlKS4KCk15IHBvaW50IGlzIHRoYXQgSSBkbyBub3Qgc2VlIHdoeSB3ZSBzaG91bGQgbWFpbnRh aW4gY29ycmVjdCBrZXJuZWwtZG9jCnN0eWxlIGNvbW1lbnRzIGZvciBmaWxlcyB0aGF0IGFyZSBu b3QgdXNlZCB0byB0byBnZW5lcmF0ZSBrZXJuZWwtZG9jLgpJdCB3b3VsZCBzZXJ2ZSB1cyBiZXR0 ZXIgdG8gZHJvcCB0aGUga2VybmVsLWRvYyBzdHlsZSBjb21tZW50cy4KQnV0IHRoYXRzIGp1c3Qg bXkgb3BpbmlvbiwgZmVlbCBmcmVlIHRvIGlnbm9yZS4KCkkgZGlnZ2VkIGEgbGl0dGxlIGFuZCBj YW4gc2VlIHdlIHJ1biBrZXJuZWwtZG9jIG9uIGFsbCAuYyBmaWxlcwp3aGVuIHdlIHNwZWNpZnkg Vz0xIC0gd2hpY2ggd2FzIGEgc3VwcmlzZSB0byBtZS4KVGhhdCBleHBsYWlucyB3aHkgSSBoYWQg bm90IHNlZW4gc2FpZCB3YXJuaW5ncyBpbiBteSByZWd1bGFyIG1ha2UKaHRtbGRvY3MgcnVucy4K CglTYW0KCj4gCj4gPiA+ID4gPiAgIGJhY2tsaWdodDogYmFja2xpZ2h0OiBTdXBwbHkgZGVzY3Jp cHRpb24gZm9yIGZ1bmN0aW9uIGFyZ3MgaW4gZXhpc3RpbmcKPiA+ID4gPiA+ICAgICBLZXJuZWxk b2NzCj4gPiA+ID4gPiAgIGJhY2tsaWdodDogbG0zNjMwYV9ibDogUmVtb3ZlIGludmFsaWQgY2hl Y2tzIGZvciB1bnNpZ25lZCBpbnQgPCAwCj4gPiA+ID4gPiAgIGJhY2tsaWdodDogcWNvbS13bGVk OiBSZW1vdmUgdW51c2VkIGNvbmZpZ3MgZm9yIExFRDMgYW5kIExFRDQKPiA+ID4gPiAKPiA+ID4g PiBUaGUgb3RoZXIgZml4ZXMgbG9va3MgZ29vZC4KPiA+ID4gPiBUaGV5IGFyZSBhbGw6Cj4gPiA+ ID4gQWNrZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiA+ID4gCj4gPiA+ IFRoYW5rcyAoYWx0aG91Z2ggdGhpcyBzaG91bGQgYmUgUmV2aWV3ZWQtYnkpLgo+ID4gPiAKPiA+ ID4gPiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9iYWNrbGlnaHQuYyAgfCAyICsrCj4gPiA+ ID4gPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvaWxpOTIyeC5jICAgIHwgOCArKysrKystLQo+ ID4gPiA+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xjZC5jICAgICAgICB8IDEgKwo+ID4g PiA+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xtMzYzMGFfYmwuYyB8IDQgKystLQo+ID4g PiA+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xtczUwMWtmMDMuYyB8IDggLS0tLS0tLS0K PiA+ID4gPiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYyAgfCA4IC0tLS0t LS0tCj4gPiA+ID4gPiAgNiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyMCBkZWxl dGlvbnMoLSkKPiA+ID4gPiA+IAo+ID4gPiAKPiAKPiAtLSAKPiBMZWUgSm9uZXMgW+adjueQvOaW r10KPiBTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKPiBMaW5hcm8u b3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKPiBGb2xsb3cgTGluYXJv OiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC36C433E0 for ; Thu, 25 Jun 2020 18:57:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34592204EA for ; Thu, 25 Jun 2020 18:57:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34592204EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21E216E33F; Thu, 25 Jun 2020 18:57:54 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 877386E33F for ; Thu, 25 Jun 2020 18:57:52 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 88DBD200DF; Thu, 25 Jun 2020 20:57:47 +0200 (CEST) Date: Thu, 25 Jun 2020 20:57:46 +0200 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200625185746.GA1875182@ravnborg.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> <20200624154321.GH954398@dell> <20200624162446.GA1815586@ravnborg.org> <20200625080337.GN954398@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625080337.GN954398@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=KKAkSRfTAAAA:8 a=dC_rIlIaLDHj5HQ0j38A:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTGVlLgoKT24gVGh1LCBKdW4gMjUsIDIwMjAgYXQgMDk6MDM6MzdBTSArMDEwMCwgTGVlIEpv bmVzIHdyb3RlOgo+IE9uIFdlZCwgMjQgSnVuIDIwMjAsIFNhbSBSYXZuYm9yZyB3cm90ZToKPiAK PiA+IEhpIExlZS4KPiA+IAo+ID4gT24gV2VkLCBKdW4gMjQsIDIwMjAgYXQgMDQ6NDM6MjFQTSAr MDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gPiBPbiBXZWQsIDI0IEp1biAyMDIwLCBTYW0gUmF2 bmJvcmcgd3JvdGU6Cj4gPiA+IAo+ID4gPiA+IEhpIExlZS4KPiA+ID4gPiAKPiA+ID4gPiBPbiBX ZWQsIEp1biAyNCwgMjAyMCBhdCAwMzo1NzoxM1BNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4g PiA+ID4gPiBBdHRlbXB0aW5nIHRvIGNsZWFuLXVwIFc9MSBrZXJuZWwgYnVpbGRzLCB3aGljaCBh cmUgY3VycmVudGx5Cj4gPiA+ID4gPiBvdmVyd2hlbG1pbmdseSByaWRkbGVkIHdpdGggbmlnZ2x5 IGxpdHRsZSB3YXJuaW5ncy4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gTGVlIEpvbmVzICg4KToKPiA+ ID4gPiA+ICAgYmFja2xpZ2h0OiBsbXM1MDFrZjAzOiBSZW1vdmUgdW51c2VkIGNvbnN0IHZhcmlh Ymxlcwo+ID4gPiA+ID4gICBiYWNrbGlnaHQ6IGxjZDogQWRkIG1pc3Npbmcga2VybmVsZG9jIGVu dHJ5IGZvciAnc3RydWN0IGRldmljZSBwYXJlbnQnCj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4g PiAgIGJhY2tsaWdodDogaWxpOTIyeDogQWRkIG1pc3Npbmcga2VybmVsZG9jIGRlc2NyaXB0aW9u cyBmb3IKPiA+ID4gPiA+ICAgICBDSEVDS19GUkVRX1JFRygpIGFyZ3MKPiA+ID4gPiA+ICAgYmFj a2xpZ2h0OiBpbGk5MjJ4OiBSZW1vdmUgaW52YWxpZCB1c2Ugb2Yga2VybmVsZG9jIHN5bnRheAo+ ID4gPiA+ID4gICBiYWNrbGlnaHQ6IGlsaTkyMng6IEFkZCBtaXNzaW5nIGtlcm5lbGRvYyBkZXNj cmlwdGlvbiBmb3IKPiA+ID4gPiA+ICAgICBpbGk5MjJ4X3JlZ19kdW1wKCkncyBhcmcKPiA+ID4g PiBJIHdvbmRlciB3aHkgdGhlc2Ugd2FybmluZ3Mgc2hvdyB1cCBhcyBub3RoaW5nIHB1bGxzIGlu IHRoaXMgLmMgZmlsZS4KPiA+ID4gPiBBbnl3YXkgSSB3b3VsZCBzdWdnZXN0IHRvIGRyb3AgdXNp bmcga2VybmVsZG9jIHN5bnRheCBmb3Igc2luZ2xlIGRyaXZlcnMKPiA+ID4gPiBsaWtlIHRoaXMg LSBhbmQgdGhlIGJlbmVmaXQgaGVyZSBpcyBsb3cuCj4gPiA+ID4gTm93IHRoZXkgYXJlIHR5cGVk LCBvdGhlcndpc2UgdGhpcyBhaGQgYmVlbiBmaW5lIGluIGEgc2luZ2xlIHBhdGNoLgo+ID4gPiAK PiA+ID4gV2hhdCBkbyB5b3UgbWVhbiBieSAnbm90aGluZyBwdWxscyBpdCBpbic/Cj4gPiBUaGVy ZSBhcmUgbm8gLnJzdCBmaWxlcyB0aGF0IGluY2x1ZGVzIGFueToKPiA+IC4uIGtlcm5lbC1kb2M6 OiBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmMKPiA+IAo+ID4gc28gSSBkbyBub3Qg c2VlIGhvdyB0aGUga2VybmVsLWRvYyBjb21tZW50cyB3aWxsIGJlIHVzZWQgYnkgYW55Cj4gPiBv ZiB0aGUgZ2VuZXJhdGVkIGtlcm5lbC1kb2NzLgo+IAo+IExvb2tzIGxpa2UgYSBjb21tb24gcHJv YmxlbSAoaWYgaXQgaXMgYWN0dWFsbHkgYSBwcm9ibGVtKToKPiAKPiAgJCAuL3NjcmlwdHMvZmlu ZC11bnVzZWQtZG9jcy5zaCAuIHwgd2MgLWwKPiAgMTQ3Ngo+IAo+IFRoZSByb2xlIG9mIHRoaXMg cGF0Y2gtc2V0IGlzIG5vdCB0byBlcmFkaWNhdGUgdW51c2VkIGtlcm5lbGRvYwo+IGhlYWRlcnMs IGJ1dCB0byBlbnN1cmUgdGhleSBhcmUgZm9ybWF0dGVkIGNvcnJlY3RseS4gIFc9MSBidWlsZHMK PiBjdXJyZW50bHkgY29tcGxhaW4gb2YgaWxsIGZvcm1hdHRlZCBrZXJuZWxkb2NzLCB3aGljaCBp cyBjdXJyZW50bHkKPiBsaXR0ZXJpbmcgdGhlIGJ1aWxkLWxvZyBhbmQgbWFza2luZyBzb21lIG1v cmUgaW1wb3J0YW50IGlzc3VlcyAod2hpY2gKPiBJJ20gYWxzbyB0cnlpbmcgdG8gZml4IGVuIHJv dXRlKS4KCk15IHBvaW50IGlzIHRoYXQgSSBkbyBub3Qgc2VlIHdoeSB3ZSBzaG91bGQgbWFpbnRh aW4gY29ycmVjdCBrZXJuZWwtZG9jCnN0eWxlIGNvbW1lbnRzIGZvciBmaWxlcyB0aGF0IGFyZSBu b3QgdXNlZCB0byB0byBnZW5lcmF0ZSBrZXJuZWwtZG9jLgpJdCB3b3VsZCBzZXJ2ZSB1cyBiZXR0 ZXIgdG8gZHJvcCB0aGUga2VybmVsLWRvYyBzdHlsZSBjb21tZW50cy4KQnV0IHRoYXRzIGp1c3Qg bXkgb3BpbmlvbiwgZmVlbCBmcmVlIHRvIGlnbm9yZS4KCkkgZGlnZ2VkIGEgbGl0dGxlIGFuZCBj YW4gc2VlIHdlIHJ1biBrZXJuZWwtZG9jIG9uIGFsbCAuYyBmaWxlcwp3aGVuIHdlIHNwZWNpZnkg Vz0xIC0gd2hpY2ggd2FzIGEgc3VwcmlzZSB0byBtZS4KVGhhdCBleHBsYWlucyB3aHkgSSBoYWQg bm90IHNlZW4gc2FpZCB3YXJuaW5ncyBpbiBteSByZWd1bGFyIG1ha2UKaHRtbGRvY3MgcnVucy4K CglTYW0KCj4gCj4gPiA+ID4gPiAgIGJhY2tsaWdodDogYmFja2xpZ2h0OiBTdXBwbHkgZGVzY3Jp cHRpb24gZm9yIGZ1bmN0aW9uIGFyZ3MgaW4gZXhpc3RpbmcKPiA+ID4gPiA+ICAgICBLZXJuZWxk b2NzCj4gPiA+ID4gPiAgIGJhY2tsaWdodDogbG0zNjMwYV9ibDogUmVtb3ZlIGludmFsaWQgY2hl Y2tzIGZvciB1bnNpZ25lZCBpbnQgPCAwCj4gPiA+ID4gPiAgIGJhY2tsaWdodDogcWNvbS13bGVk OiBSZW1vdmUgdW51c2VkIGNvbmZpZ3MgZm9yIExFRDMgYW5kIExFRDQKPiA+ID4gPiAKPiA+ID4g PiBUaGUgb3RoZXIgZml4ZXMgbG9va3MgZ29vZC4KPiA+ID4gPiBUaGV5IGFyZSBhbGw6Cj4gPiA+ ID4gQWNrZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiA+ID4gCj4gPiA+ IFRoYW5rcyAoYWx0aG91Z2ggdGhpcyBzaG91bGQgYmUgUmV2aWV3ZWQtYnkpLgo+ID4gPiAKPiA+ ID4gPiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9iYWNrbGlnaHQuYyAgfCAyICsrCj4gPiA+ ID4gPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvaWxpOTIyeC5jICAgIHwgOCArKysrKystLQo+ ID4gPiA+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xjZC5jICAgICAgICB8IDEgKwo+ID4g PiA+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xtMzYzMGFfYmwuYyB8IDQgKystLQo+ID4g PiA+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xtczUwMWtmMDMuYyB8IDggLS0tLS0tLS0K PiA+ID4gPiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYyAgfCA4IC0tLS0t LS0tCj4gPiA+ID4gPiAgNiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyMCBkZWxl dGlvbnMoLSkKPiA+ID4gPiA+IAo+ID4gPiAKPiAKPiAtLSAKPiBMZWUgSm9uZXMgW+adjueQvOaW r10KPiBTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKPiBMaW5hcm8u b3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKPiBGb2xsb3cgTGluYXJv OiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A473C433DF for ; Thu, 25 Jun 2020 18:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E3C5204EA for ; Thu, 25 Jun 2020 18:57:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406379AbgFYS5w (ORCPT ); Thu, 25 Jun 2020 14:57:52 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:44052 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403853AbgFYS5w (ORCPT ); Thu, 25 Jun 2020 14:57:52 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 88DBD200DF; Thu, 25 Jun 2020 20:57:47 +0200 (CEST) Date: Thu, 25 Jun 2020 20:57:46 +0200 From: Sam Ravnborg To: Lee Jones Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200625185746.GA1875182@ravnborg.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624153216.GA1814806@ravnborg.org> <20200624154321.GH954398@dell> <20200624162446.GA1815586@ravnborg.org> <20200625080337.GN954398@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200625080337.GN954398@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=KKAkSRfTAAAA:8 a=dC_rIlIaLDHj5HQ0j38A:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee. On Thu, Jun 25, 2020 at 09:03:37AM +0100, Lee Jones wrote: > On Wed, 24 Jun 2020, Sam Ravnborg wrote: > > > Hi Lee. > > > > On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote: > > > On Wed, 24 Jun 2020, Sam Ravnborg wrote: > > > > > > > Hi Lee. > > > > > > > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > > > > > Attempting to clean-up W=1 kernel builds, which are currently > > > > > overwhelmingly riddled with niggly little warnings. > > > > > > > > > > Lee Jones (8): > > > > > backlight: lms501kf03: Remove unused const variables > > > > > backlight: lcd: Add missing kerneldoc entry for 'struct device parent' > > > > > > > > > > > > > backlight: ili922x: Add missing kerneldoc descriptions for > > > > > CHECK_FREQ_REG() args > > > > > backlight: ili922x: Remove invalid use of kerneldoc syntax > > > > > backlight: ili922x: Add missing kerneldoc description for > > > > > ili922x_reg_dump()'s arg > > > > I wonder why these warnings show up as nothing pulls in this .c file. > > > > Anyway I would suggest to drop using kerneldoc syntax for single drivers > > > > like this - and the benefit here is low. > > > > Now they are typed, otherwise this ahd been fine in a single patch. > > > > > > What do you mean by 'nothing pulls it in'? > > There are no .rst files that includes any: > > .. kernel-doc:: drivers/video/backlight/ili922x.c > > > > so I do not see how the kernel-doc comments will be used by any > > of the generated kernel-docs. > > Looks like a common problem (if it is actually a problem): > > $ ./scripts/find-unused-docs.sh . | wc -l > 1476 > > The role of this patch-set is not to eradicate unused kerneldoc > headers, but to ensure they are formatted correctly. W=1 builds > currently complain of ill formatted kerneldocs, which is currently > littering the build-log and masking some more important issues (which > I'm also trying to fix en route). My point is that I do not see why we should maintain correct kernel-doc style comments for files that are not used to to generate kernel-doc. It would serve us better to drop the kernel-doc style comments. But thats just my opinion, feel free to ignore. I digged a little and can see we run kernel-doc on all .c files when we specify W=1 - which was a suprise to me. That explains why I had not seen said warnings in my regular make htmldocs runs. Sam > > > > > > backlight: backlight: Supply description for function args in existing > > > > > Kerneldocs > > > > > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 > > > > > backlight: qcom-wled: Remove unused configs for LED3 and LED4 > > > > > > > > The other fixes looks good. > > > > They are all: > > > > Acked-by: Sam Ravnborg > > > > > > Thanks (although this should be Reviewed-by). > > > > > > > > drivers/video/backlight/backlight.c | 2 ++ > > > > > drivers/video/backlight/ili922x.c | 8 ++++++-- > > > > > drivers/video/backlight/lcd.c | 1 + > > > > > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > > > > > drivers/video/backlight/lms501kf03.c | 8 -------- > > > > > drivers/video/backlight/qcom-wled.c | 8 -------- > > > > > 6 files changed, 11 insertions(+), 20 deletions(-) > > > > > > > > > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog