From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6540DC433DF for ; Fri, 26 Jun 2020 15:25:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3779A20773 for ; Fri, 26 Jun 2020 15:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E9XUBYLD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gwytSsmF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3779A20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cLR52v2YLLYWISR7vk+7o2QB5brUmiuMTRNpMPiqbV0=; b=E9XUBYLDeibV8twQKjKDM4JdK zxm8BfFBlp8ntoTzDOhVJGdmrcGKysq1byervonfSBnELWw60WW9h4YCJktG4yd1kr/yEVh8Rx58X II5rGMpiHHXKGCWLVbHj/wY3SPB8UxjZJYqIA5KlmepaK7fwOHqSkYa7CzCcM3CNhClC3Q1RKDJ+q j4K+E2KYTNdeukzxpU6fl3i2z+tqKCyY1a62WALe7txgnztEQWm59M3/RGmCMqOKxnCgn4mLTXqLF VUo5mPB1PNaeBXlBWrT0aEUj4VdAkpEqAV34nH8656CTcV2X7MxZXmNfqY/XSWmHCG6CnX2oNCypw MEo4tVMhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joqCK-00077L-Cu; Fri, 26 Jun 2020 15:23:24 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joqCF-00076Z-Ii for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 15:23:20 +0000 Received: by mail-pl1-x641.google.com with SMTP id k6so4386471pll.9 for ; Fri, 26 Jun 2020 08:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wzxRCwXrTp9pra+6lnRKOjX9XhXo/vr4ZCsuBD6HuVs=; b=gwytSsmFplYFx5bQzChZW4ZBybTa1p+pyLKIKwAWKhBdGjhOGMxt0cgcRBw0hYw4kK vYd7TzPGAYaSSo+Po7oPlGsEZQLpSUO+QmhcRNnUglYTKYlqXlL3sLY8OY00s/mC/0Sp jEEsCrEs+dn4QvM7AhE7FViVdaJpDyclmVuqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wzxRCwXrTp9pra+6lnRKOjX9XhXo/vr4ZCsuBD6HuVs=; b=skbYrCzIDZxf3XzTtm/OBZBmHhLVb9cjGmFTw/+91FVvkGQ/td4+dz/YSKRaHdnE+v HBitFHb0Wq3blas4WAmUxaEiQDn+XFpAtrU/31Ofec3LCWMDqGahuq3EcXdid76LQd4g h85b2LN8a7aa7bhBdSHpVNG9/CfYZYo6uS4IZ5XfPMSShmPwJgZ8xn4kAKlH8Lv4hNPQ 95f6c06W+b/76+bkOFcopDlr50a3EcR38hx+nJ7FvHL/h+B6YHZMHZdHQffY/r1DmxG+ b2uYZyFJJkeIwnBjptrCPiUuamjs8YyP58WcpYq1NToUSfNANIk0jJOziDJ9LD5Gpl2u a/WQ== X-Gm-Message-State: AOAM532omfxWyoPVpte6syiqrU+47pmyM6yzggHvyA0yHrMbLEJ5PVmu bLd3px2T+OUSlts8VbPyY4TVCg== X-Google-Smtp-Source: ABdhPJx4Wuwe+drzHLg9tLtrReQAK0xHDZIu4jqj+/0+/ZBY18JMJuroUvMk6IoQpbrxVtXyghdoWA== X-Received: by 2002:a17:90a:fcc:: with SMTP id 70mr3926943pjz.106.1593184995653; Fri, 26 Jun 2020 08:23:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u2sm2638273pfl.21.2020.06.26.08.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 08:23:14 -0700 (PDT) Date: Fri, 26 Jun 2020 08:23:14 -0700 From: Kees Cook To: Lee Jones Subject: Re: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT() Message-ID: <202006260821.0079FA827@keescook> References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-6-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200626130525.389469-6-lee.jones@linaro.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMjYsIDIwMjAgYXQgMDI6MDU6MjBQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IGxrZHRtX0RPVUJMRV9GQVVMVCgpIGFscmVhZHkgaGFzIGludGVybmFsIGxvZ2ljIHRvIGhh bmRsZQo+ICFDT05GSUdfWDg2XzMyLiAgQ29tcGlsaW5nIG91dCB0aGUgcHJvdG90eXBlIGFjdHVh bGx5IHByZXZlbnRzCj4gdGhhdCBsb2dpYyBmcm9tIGJlaW5nIHVzZWZ1bC4KPiAKPiBGaXhlcyB0 aGUgZm9sbG93aW5nIFc9MSB3YXJuaW5nOgo+IAo+ICBkcml2ZXJzL21pc2MvbGtkdG0vYnVncy5j OiBBdCB0b3AgbGV2ZWw6Cj4gIGRyaXZlcnMvbWlzYy9sa2R0bS9idWdzLmM6NDIwOjY6IHdhcm5p bmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCYbGtkdG1fRE9VQkxFX0ZBVUxU4oCZIFst V21pc3NpbmctcHJvdG90eXBlc10KPiAgNDIwIHwgdm9pZCBsa2R0bV9ET1VCTEVfRkFVTFQodm9p ZCkKPiAgfCBefn5+fn5+fn5+fn5+fn5+fn4KPiAKPiBDYzogS2VlcyBDb29rIDxrZWVzY29va0Bj aHJvbWl1bS5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJv Lm9yZz4KClRoYW5rcyEgVGhpcyBjaGFuZ2UgaXMgYWN0dWFsbHkgYWxyZWFkeSBwYXJ0IG9mIGFu b3RoZXIKcGF0Y2ggYW5kIGlzIHdhaXRpbmcgZm9yIEdyZWcgdG8gcGljayB1cDoKaHR0cHM6Ly9s b3JlLmtlcm5lbC5vcmcvbGttbC8yMDIwMDUyOTIwMDM0Ny4yNDY0Mjg0LTUta2Vlc2Nvb2tAY2hy b21pdW0ub3JnLwoKLS0gCktlZXMgQ29vawoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67247C433DF for ; Fri, 26 Jun 2020 15:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40EB3207E8 for ; Fri, 26 Jun 2020 15:23:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gwytSsmF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729494AbgFZPXR (ORCPT ); Fri, 26 Jun 2020 11:23:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbgFZPXQ (ORCPT ); Fri, 26 Jun 2020 11:23:16 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23912C03E979 for ; Fri, 26 Jun 2020 08:23:16 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id cv18so1646315pjb.1 for ; Fri, 26 Jun 2020 08:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wzxRCwXrTp9pra+6lnRKOjX9XhXo/vr4ZCsuBD6HuVs=; b=gwytSsmFplYFx5bQzChZW4ZBybTa1p+pyLKIKwAWKhBdGjhOGMxt0cgcRBw0hYw4kK vYd7TzPGAYaSSo+Po7oPlGsEZQLpSUO+QmhcRNnUglYTKYlqXlL3sLY8OY00s/mC/0Sp jEEsCrEs+dn4QvM7AhE7FViVdaJpDyclmVuqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wzxRCwXrTp9pra+6lnRKOjX9XhXo/vr4ZCsuBD6HuVs=; b=a1TP3C97+7Wk5VADrpLnuk7/vcpWroe8byUHRCwyYKcxQXANQ7rVRUv/cpiNAZOZqb 1xEgdqzsmyNiQ+E/dH6FlR3aAl6HQau7gXGQJtXkNUh9iKEygOCCSjVdbPc0Br2BDy7m ng9iNnWSrv+5MWoWH+QGlUm2V6jHjndfu8+b30Baqsp8qRx3aqmJp7hC1w3QdVhJYPv2 6H1iGNvRX+zB1+4jIcAJXbSYSwiWd1Knh6N4FN/McChoP+Bz1OvHJw4yxaTXhvU7ThGR bUwuYsk7Pdw/mgST8kf2uwiVPMlzmaP8+5FmUhMJM7hTKsQxnR8f00ngUcaeQe2wjzMm 2rNA== X-Gm-Message-State: AOAM530/GFeqQ9ORf+Al8gAbcj3SObw3meE+bb+eZ7LTsyCLsq1gmjuR WyhSq54AsuqWmmzPNN9auPNkyA== X-Google-Smtp-Source: ABdhPJx4Wuwe+drzHLg9tLtrReQAK0xHDZIu4jqj+/0+/ZBY18JMJuroUvMk6IoQpbrxVtXyghdoWA== X-Received: by 2002:a17:90a:fcc:: with SMTP id 70mr3926943pjz.106.1593184995653; Fri, 26 Jun 2020 08:23:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u2sm2638273pfl.21.2020.06.26.08.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 08:23:14 -0700 (PDT) Date: Fri, 26 Jun 2020 08:23:14 -0700 From: Kees Cook To: Lee Jones Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT() Message-ID: <202006260821.0079FA827@keescook> References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-6-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200626130525.389469-6-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 02:05:20PM +0100, Lee Jones wrote: > lkdtm_DOUBLE_FAULT() already has internal logic to handle > !CONFIG_X86_32. Compiling out the prototype actually prevents > that logic from being useful. > > Fixes the following W=1 warning: > > drivers/misc/lkdtm/bugs.c: At top level: > drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for ‘lkdtm_DOUBLE_FAULT’ [-Wmissing-prototypes] > 420 | void lkdtm_DOUBLE_FAULT(void) > | ^~~~~~~~~~~~~~~~~~ > > Cc: Kees Cook > Signed-off-by: Lee Jones Thanks! This change is actually already part of another patch and is waiting for Greg to pick up: https://lore.kernel.org/lkml/20200529200347.2464284-5-keescook@chromium.org/ -- Kees Cook