From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E939C433DF for ; Fri, 26 Jun 2020 09:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5368620EDD for ; Fri, 26 Jun 2020 09:16:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726113AbgFZJQz (ORCPT ); Fri, 26 Jun 2020 05:16:55 -0400 Received: from verein.lst.de ([213.95.11.211]:51059 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgFZJQz (ORCPT ); Fri, 26 Jun 2020 05:16:55 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0DF6E68CF0; Fri, 26 Jun 2020 11:16:53 +0200 (CEST) Date: Fri, 26 Jun 2020 11:16:52 +0200 From: Christoph Hellwig To: Javier =?iso-8859-1?Q?Gonz=E1lez?= Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk, Javier =?iso-8859-1?Q?Gonz=E1lez?= , SelvaKumar S , Kanchan Joshi , Nitesh Shetty Subject: Re: [PATCH 6/6] nvme: Add consistency check for zone count Message-ID: <20200626091652.GD26616@lst.de> References: <20200625122152.17359-1-javier@javigon.com> <20200625122152.17359-7-javier@javigon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625122152.17359-7-javier@javigon.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org As a bunch of folks noticed I don't zone_idx does what you think it does. That being said I'm very happy about any kind of validation (except maybe in a supper hot path). So if we want to validate the zone number we can do, just not as in this patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E84C433E0 for ; Fri, 26 Jun 2020 11:08:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD88D2053B for ; Fri, 26 Jun 2020 11:08:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pX21ew05" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD88D2053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ABRy0aT76a1qB3WBBDu0VI23tZ/jKwcts/JIjbaWwdo=; b=pX21ew053DmoCdKBmp7i9tCfX Nx4Z+uyel8WN+YiN0L1mnaRQsFU4zZlOzsdP7iGhmYdP+VxMeut0pOWwTy/YhE3YoNHve818elsNm Q5TTwLtkiyHjjXlp9j5fvIIY0QoBYf6faUslEVC+CBRNBeoI9LlIuJIWm0mzytq1AZv8KnC7CdYOz FvWpWnrwyOXPB9JE2qN60cgWwfC1TAmJqOQSOzG4bDxBiaQoYFkxhs3WSEg3/KNQatJS0YjRx+LwQ V/dt1II6DJnh0dg8LlrbfKyPqaDeDFFy1JmRlKx5/E1t8TDDlbeRB7U724WAXyJNDcHiAT6LDxbie SSfKf+UDw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomDh-0003a5-Ta; Fri, 26 Jun 2020 11:08:33 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jol5z-0005ib-71 for linux-nvme@lists.infradead.org; Fri, 26 Jun 2020 09:56:44 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0DF6E68CF0; Fri, 26 Jun 2020 11:16:53 +0200 (CEST) Date: Fri, 26 Jun 2020 11:16:52 +0200 From: Christoph Hellwig To: Javier =?iso-8859-1?Q?Gonz=E1lez?= Subject: Re: [PATCH 6/6] nvme: Add consistency check for zone count Message-ID: <20200626091652.GD26616@lst.de> References: <20200625122152.17359-1-javier@javigon.com> <20200625122152.17359-7-javier@javigon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625122152.17359-7-javier@javigon.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, SelvaKumar S , sagi@grimberg.me, Kanchan Joshi , linux-nvme@lists.infradead.org, Nitesh Shetty , linux-block@vger.kernel.org, kbusch@kernel.org, Javier =?iso-8859-1?Q?Gonz=E1lez?= , hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org As a bunch of folks noticed I don't zone_idx does what you think it does. That being said I'm very happy about any kind of validation (except maybe in a supper hot path). So if we want to validate the zone number we can do, just not as in this patch. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme