diff for duplicates of <20200626103959.GC314359@mwanda> diff --git a/a/1.txt b/N1/1.txt index caa6d22..d13658e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ These if statements are supposed to be true if we ended the list_for_each_entry() loops without hitting a break statement but they don't work. -In the first loop, we increment "i" after the "if (i = unit)" condition +In the first loop, we increment "i" after the "if (i == unit)" condition so we don't necessarily know that "i" is not equal to unit at the end of the loop. @@ -29,7 +29,7 @@ index 3c97654b5a43..44168a7d7b44 100644 } - if (i != unit) { -+ if (&con->head = &dev_priv->dev->mode_config.connector_list) { ++ if (&con->head == &dev_priv->dev->mode_config.connector_list) { DRM_ERROR("Could not find initial display unit.\n"); ret = -EINVAL; goto out_unlock; @@ -40,7 +40,7 @@ index 3c97654b5a43..44168a7d7b44 100644 - if (mode->type & DRM_MODE_TYPE_PREFERRED) - *p_mode = mode; - else { -+ if (&mode->head = &con->modes) { ++ if (&mode->head == &con->modes) { WARN_ONCE(true, "Could not find initial preferred mode.\n"); *p_mode = list_first_entry(&con->modes, struct drm_display_mode, @@ -52,3 +52,8 @@ index 3c97654b5a43..44168a7d7b44 100644 out_unlock: -- 2.27.0 + +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N1/content_digest index b37dcae..52f4ac3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[PATCH] drm/vmwgfx: Fix two list_for_each loop exit tests\0" - "Date\0Fri, 26 Jun 2020 10:39:59 +0000\0" + "Date\0Fri, 26 Jun 2020 13:39:59 +0300\0" "To\0VMware Graphics <linux-graphics-maintainer@vmware.com>" " Thomas Hellstrom <thellstrom@vmware.com>\0" "Cc\0Sinclair Yeh <syeh@vmware.com>" @@ -14,7 +14,7 @@ "list_for_each_entry() loops without hitting a break statement but they\n" "don't work.\n" "\n" - "In the first loop, we increment \"i\" after the \"if (i = unit)\" condition\n" + "In the first loop, we increment \"i\" after the \"if (i == unit)\" condition\n" "so we don't necessarily know that \"i\" is not equal to unit at the end of\n" "the loop.\n" "\n" @@ -41,7 +41,7 @@ " \t}\n" " \n" "-\tif (i != unit) {\n" - "+\tif (&con->head = &dev_priv->dev->mode_config.connector_list) {\n" + "+\tif (&con->head == &dev_priv->dev->mode_config.connector_list) {\n" " \t\tDRM_ERROR(\"Could not find initial display unit.\\n\");\n" " \t\tret = -EINVAL;\n" " \t\tgoto out_unlock;\n" @@ -52,7 +52,7 @@ "-\tif (mode->type & DRM_MODE_TYPE_PREFERRED)\n" "-\t\t*p_mode = mode;\n" "-\telse {\n" - "+\tif (&mode->head = &con->modes) {\n" + "+\tif (&mode->head == &con->modes) {\n" " \t\tWARN_ONCE(true, \"Could not find initial preferred mode.\\n\");\n" " \t\t*p_mode = list_first_entry(&con->modes,\n" " \t\t\t\t\t struct drm_display_mode,\n" @@ -63,6 +63,11 @@ " \n" " out_unlock:\n" "-- \n" - 2.27.0 + "2.27.0\n" + "\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -18d2cbdcab348a9697ef1022a5ef329c322e83bf93612c9544cc931f7f20fd32 +e963122f9bf578cb6a209b4d9f9e85408c54f943c61f7ad0ad1708be088ca67e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.