From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168C9C433E1 for ; Fri, 26 Jun 2020 11:12:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D638220724 for ; Fri, 26 Jun 2020 11:12:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GpkJ16hN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D638220724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=invisiblethingslab.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jomHB-0007Ak-GV; Fri, 26 Jun 2020 11:12:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jomHA-0007Ae-2Y for xen-devel@lists.xenproject.org; Fri, 26 Jun 2020 11:12:08 +0000 X-Inumbo-ID: df72e8a6-b79d-11ea-b7bb-bc764e2007e4 Received: from out5-smtp.messagingengine.com (unknown [66.111.4.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id df72e8a6-b79d-11ea-b7bb-bc764e2007e4; Fri, 26 Jun 2020 11:12:07 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 645205C00AC; Fri, 26 Jun 2020 07:12:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 26 Jun 2020 07:12:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=o93Cjd 24FOiNLrFwfmBe4LZpL/SrHS+PzUttJQ7s0Lw=; b=GpkJ16hNdCcRf50jEbczC1 PU3RTWEMXSzJk3CGloipMve1OwNWvGEHeOOG0Cc8cNhbn4pY8t2Of6KBt51PQnCW Q9ANI4B/TdNCH9XmPbApLG78yNKlyYXJjJvBEI/6GIQucNCL0bbeLE1n+FF7S3nD jt/6KSwHBWPLxuuqkFmKVB58q1FSGehJ1CSA92ZwbArph87DNfgwa/esRCF0zwYP BhKqefg/ahedGOgRRRGgZCNhz6K5CKnl2xGPHbcfs+wBfLwZr0uRExo112EbVvO0 wh4Kr/FoGg3guUh6XMUDDlg9KOD2rsK7I8MDRZzLwdoWNYONUT5Ml0kBizIHezLw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeluddgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucfkpheple durdeihedrfeegrdeffeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrd gtohhm X-ME-Proxy: Received: from mail-itl (ip5b412221.dynamic.kabel-deutschland.de [91.65.34.33]) by mail.messagingengine.com (Postfix) with ESMTPA id 65CB33067902; Fri, 26 Jun 2020 07:12:06 -0400 (EDT) Date: Fri, 26 Jun 2020 13:12:01 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Wei Liu Subject: Re: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy Message-ID: <20200626111201.GS1197@mail-itl> References: <20200611032936.350657-1-jandryuk@gmail.com> <20200626101807.za6arkdlah7zsjzc@liuwe-devbox-debian-v2> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Zs/RYxT/hKAHzkfQ" Content-Disposition: inline In-Reply-To: <20200626101807.za6arkdlah7zsjzc@liuwe-devbox-debian-v2> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , Ian Jackson , Jason Andryuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --Zs/RYxT/hKAHzkfQ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy On Fri, Jun 26, 2020 at 10:18:07AM +0000, Wei Liu wrote: > On Wed, Jun 10, 2020 at 11:29:26PM -0400, Jason Andryuk wrote: > > This series addresses some Coverity reports. To handle closing FDs, a > > state struct is introduced to track FDs closed in both main() and > > data_loop(). > >=20 > > v2 changes "Ensure UNIX path NUL terminated" to avoid a warning with > > gcc-10. Also, "Move perror() into listen_socket" and "Move perror() > > into connect_socket" are new. > >=20 > > Jason Andryuk (10): > > vchan-socket-proxy: Ensure UNIX path NUL terminated > > vchan-socket-proxy: Move perror() into listen_socket > > vchan-socket-proxy: Move perror() into connect_socket > > vchan-socket-proxy: Check xs_watch return value > > vchan-socket-proxy: Unify main return value > > vchan-socket-proxy: Use a struct to store state > > vchan-socket-proxy: Switch data_loop() to take state > > vchan-socket-proxy: Set closed FDs to -1 > > vchan-socket-proxy: Cleanup resources on exit > > vchan-socket-proxy: Handle closing shared input/output_fd >=20 > Acked-by: Wei Liu >=20 > Cc Paul. V1 of this series was posted back in May. I consider this > series bug fixes, so they should be applied for 4.14. The risk is low > because vchan-socket-proxy is a small utility used by a small number of > users. >=20 > Marek, you gave Review tags in v1. Do they still apply here? Yes. And also for the new patches 2-3. I thought I've posted it here, but must have missed clicking "send"... > >=20 > > tools/libvchan/vchan-socket-proxy.c | 183 ++++++++++++++++++---------- > > 1 file changed, 119 insertions(+), 64 deletions(-) > >=20 > > --=20 > > 2.25.1 > >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --Zs/RYxT/hKAHzkfQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl712AAACgkQ24/THMrX 1yyhigf+NrwGQmd536KPduBKmiC1fSlzBl2dSFnPRaaN6lHsszY4+OC+lcqyoJpo +A9q+YLfY0vZg3VFusksP24bkW0xp/Fn7yOyvTGOnGiYWFZHZa6b5K3NKGaL+7hv dqCChkzzpLSeX+LvBg4vypAiYuILGotqDFyQThuv4/mMrHU2HQfFAwthzlC6bOVR 8fF2tDH3Y/dhjTWTmM2wCLWs9Jin4luwwnEiFvEtowWLNIbjc6x5I0H0MajI7uN0 hDn2wVkIrMDJGDVLww+JS95RjSwPyPfEIQ52VuTQnrDa+25+fIYdDgoqrOVd0X0j 4+X+rrhOPFCNnDnpDiCXmSyKPGuMXA== =k63E -----END PGP SIGNATURE----- --Zs/RYxT/hKAHzkfQ--