All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve McIntyre <steve@einval.com>
To: John Johansen <john.johansen@canonical.com>
Cc: Jann Horn <jannh@google.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>, stable <stable@vger.kernel.org>,
	963493@bugs.debian.org
Subject: Re: Repeatable hard lockup running strace testsuite on 4.19.98+ onwards
Date: Fri, 26 Jun 2020 20:01:18 +0100	[thread overview]
Message-ID: <20200626190118.GA21186@tack.einval.com> (raw)
In-Reply-To: <eed65f58-b63e-bfa4-ac74-1501cef58466@canonical.com>

On Fri, Jun 26, 2020 at 10:29:28AM -0700, John Johansen wrote:
>On 6/26/20 9:50 AM, Steve McIntyre wrote:
>> 
>> OK, will try that second...
>> 
>
>I have not been able to reproduce but
>
>So looking at linux-4.19.y it looks like
>1f8266ff5884 apparmor: don't try to replace stale label in ptrace access check
>
>was picked without
>ca3fde5214e1 apparmor: don't try to replace stale label in ptraceme check
>
>Both of them are marked as
>Fixes: b2d09ae449ced ("apparmor: move ptrace checks to using labels")
>
>so I would expect them to be picked together.
>
>ptraceme is potentially updating the task's cred while the access check is
>running.
>
>Try building after picking
>ca3fde5214e1 apparmor: don't try to replace stale label in ptraceme check

Bingo! With that one change the test suite runs to completion, no lockup.

\o/

Thanks guys, I think we've found the cause here.

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
"The whole problem with the world is that fools and fanatics are
 always so certain of themselves, and wiser people so full of doubts."
   -- Bertrand Russell


  reply	other threads:[~2020-06-26 19:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 11:35 Repeatable hard lockup running strace testsuite on 4.19.98+ onwards Steve McIntyre
2020-06-26 13:41 ` Greg KH
2020-06-26 13:45   ` Steve McIntyre
2020-06-26 15:20     ` Steve McIntyre
2020-06-26 14:25   ` Jann Horn
2020-06-26 16:50     ` Steve McIntyre
2020-06-26 17:29       ` John Johansen
2020-06-26 19:01         ` Steve McIntyre [this message]
2020-06-26 19:57           ` Sasha Levin
2020-06-26 17:52       ` Steve McIntyre
2020-06-26 18:27         ` Jann Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626190118.GA21186@tack.einval.com \
    --to=steve@einval.com \
    --cc=963493@bugs.debian.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jannh@google.com \
    --cc=john.johansen@canonical.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.