Re: [PATCH v4 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4000 bytes --]

Hi Shubhrajyoti,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on staging/staging-testing robh/for-next v5.8-rc2 next-20200626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shubhrajyoti-Datta/clk-clockwizard-Driver-updates/20200626-204459
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: um-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=um 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
   drivers/clk/clk-xlnx-clock-wizard.c: In function 'clk_wzrd_recalc_rate':
>> drivers/clk/clk-xlnx-clock-wizard.c:128:9: error: too few arguments to function 'divider_recalc_rate'
     128 |  return divider_recalc_rate(hw, parent_rate, val, divider->table,
         |         ^~~~~~~~~~~~~~~~~~~
   In file included from drivers/clk/clk-xlnx-clock-wizard.c:14:
   include/linux/clk-provider.h:621:15: note: declared here
     621 | unsigned long divider_recalc_rate(struct clk_hw *hw, unsigned long parent_rate,
         |               ^~~~~~~~~~~~~~~~~~~
   drivers/clk/clk-xlnx-clock-wizard.c: In function 'clk_wzrd_register_divider':
   drivers/clk/clk-xlnx-clock-wizard.c:247:23: error: 'CLK_IS_BASIC' undeclared (first use in this function)
     247 |  init.flags = flags | CLK_IS_BASIC;
         |                       ^~~~~~~~~~~~
   drivers/clk/clk-xlnx-clock-wizard.c:247:23: note: each undeclared identifier is reported only once for each function it appears in
   drivers/clk/clk-xlnx-clock-wizard.c: In function 'clk_wzrd_probe':
   drivers/clk/clk-xlnx-clock-wizard.c:424:4: error: 'flags' undeclared (first use in this function)
     424 |    flags, ctrl_reg, 0, 8, CLK_DIVIDER_ONE_BASED |
         |    ^~~~~
   drivers/clk/clk-xlnx-clock-wizard.c:424:11: error: 'ctrl_reg' undeclared (first use in this function)
     424 |    flags, ctrl_reg, 0, 8, CLK_DIVIDER_ONE_BASED |
         |           ^~~~~~~~
   drivers/clk/clk-xlnx-clock-wizard.c:421:46: error: too many arguments to function 'clk_register_fixed_factor'
     421 |  clk_wzrd->clks_internal[wzrd_clk_mul_div] = clk_register_fixed_factor
         |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/clk/clk-xlnx-clock-wizard.c:14:
   include/linux/clk-provider.h:909:13: note: declared here
     909 | struct clk *clk_register_fixed_factor(struct device *dev, const char *name,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/clk/clk-xlnx-clock-wizard.c: In function 'clk_wzrd_recalc_rate':
>> drivers/clk/clk-xlnx-clock-wizard.c:130:1: warning: control reaches end of non-void function [-Wreturn-type]
     130 | }
         | ^

vim +/divider_recalc_rate +128 drivers/clk/clk-xlnx-clock-wizard.c

   116	
   117	static unsigned long clk_wzrd_recalc_rate(struct clk_hw *hw,
   118						  unsigned long parent_rate)
   119	{
   120		struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
   121		void __iomem *div_addr =
   122				(void __iomem *)((u64)divider->base + divider->offset);
   123		unsigned int val;
   124	
   125		val = readl(div_addr) >> divider->shift;
   126		val &= div_mask(divider->width);
   127	
 > 128		return divider_recalc_rate(hw, parent_rate, val, divider->table,
   129				divider->flags);
 > 130	}
   131	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 22959 bytes --]