From: Greg KH <gregkh@linuxfoundation.org>
To: Brooke Basile <brookebasile@gmail.com>
Cc: Larry.Finger@lwfinger.net, straube.linux@gmail.com,
colin.king@canonical.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] staging: rtl8188eu: Replace function name with __func__
Date: Sat, 27 Jun 2020 07:21:15 +0200 [thread overview]
Message-ID: <20200627052115.GA248307@kroah.com> (raw)
In-Reply-To: <20200626153639.8097-4-brookebasile@gmail.com>
On Fri, Jun 26, 2020 at 11:36:42AM -0400, Brooke Basile wrote:
> Fix the following checkpatch warning:
> WARNING: Prefer using '"%s...", __func__' to using 'rtw_get_bcn_info', this function's name, in a string
>
> Signed-off-by: Brooke Basile <brookebasile@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
> index bf6b2fe9735f..0c43c0dcf95c 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
> @@ -986,10 +986,10 @@ void rtw_get_bcn_info(struct wlan_network *pnetwork)
> if (bencrypt)
> pnetwork->BcnInfo.encryp_protocol = ENCRYP_PROTOCOL_WEP;
> }
> - RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("rtw_get_bcn_info: pnetwork->encryp_protocol is %x\n",
> - pnetwork->BcnInfo.encryp_protocol));
> - RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("rtw_get_bcn_info: pnetwork->encryp_protocol is %x\n",
> - pnetwork->BcnInfo.encryp_protocol));
> + RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("%s: pnetwork->encryp_protocol is %x\n",
> + __func__, pnetwork->BcnInfo.encryp_protocol));
> + RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("%s: pnetwork->encryp_protocol is %x\n",
> + __func__, pnetwork->BcnInfo.encryp_protocol));
> rtw_get_cipher_info(pnetwork);
>
> /* get bwmode and ch_offset */
This patch fails to apply to my latest branch, can you rebase it and
resend if it is still needed?
thanks,
greg k-h
prev parent reply other threads:[~2020-06-27 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 15:36 [PATCH 1/4] staging: rtl8188eu: Fix comment formatting Brooke Basile
2020-06-26 15:36 ` [PATCH 2/4] staging: rtl8188eu: Fix strings split across lines Brooke Basile
2020-06-26 15:36 ` [PATCH 3/4] staging: rtl8188eu: Fix indentation Brooke Basile
2020-06-26 15:36 ` [PATCH 4/4] staging: rtl8188eu: Replace function name with __func__ Brooke Basile
2020-06-27 5:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627052115.GA248307@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=brookebasile@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.