From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Kemnade Subject: Re: [RFC PATCH 04/10] mfd: Add base driver for Netronix embedded controller Date: Sat, 27 Jun 2020 10:17:38 +0200 Message-ID: <20200627101738.2fe4abc3@aktux> References: <20200620224222.1312520-1-j.neuschaefer@gmx.net> <20200620224222.1312520-3-j.neuschaefer@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgF0ISQ (ORCPT ); Sat, 27 Jun 2020 04:18:16 -0400 In-Reply-To: <20200620224222.1312520-3-j.neuschaefer@gmx.net> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= Cc: linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Thierry Reding , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen On Sun, 21 Jun 2020 00:42:15 +0200 Jonathan Neusch=C3=A4fer wrote: > Third-party hardware documentation is available at > https://github.com/neuschaefer/linux/wiki/Netronix-MSP430-embedded-contro= ller >=20 > The EC supports interrupts, but the driver doesn't make use of them so > far. >=20 > Known problems: > - The reboot handler is installed in such a way that it directly calls > into the i2c subsystem to send the reboot command to the EC. This > means that the reboot handler may sleep, which is not allowed. >=20 see https://patchwork.ozlabs.org/project/linux-i2c/patch/20190415213432.8972-3-= contact@stefanchrist.eu/ for a fix of such problems.=20 > Signed-off-by: Jonathan Neusch=C3=A4fer > --- > drivers/mfd/Kconfig | 7 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/ntxec.c | 188 ++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/ntxec.h | 30 ++++++ > 4 files changed, 226 insertions(+) > create mode 100644 drivers/mfd/ntxec.c > create mode 100644 include/linux/mfd/ntxec.h >=20 > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index a37d7d1713820..78410b928648e 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -978,6 +978,13 @@ config MFD_VIPERBOARD > You need to select the mfd cell drivers separately. > The drivers do not support all features the board exposes. >=20 > +config MFD_NTXEC > + bool "Netronix Embedded Controller" > + depends on I2C && OF > + help > + Say yes here if you want to support the embedded controller of > + certain e-book readers designed by the ODM Netronix. > + > config MFD_RETU > tristate "Nokia Retu and Tahvo multi-function device" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 9367a92f795a6..19d9391ed6f32 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -218,6 +218,7 @@ obj-$(CONFIG_MFD_INTEL_MSIC) +=3D intel_msic.o > obj-$(CONFIG_MFD_INTEL_PMC_BXT) +=3D intel_pmc_bxt.o > obj-$(CONFIG_MFD_PALMAS) +=3D palmas.o > obj-$(CONFIG_MFD_VIPERBOARD) +=3D viperboard.o > +obj-$(CONFIG_MFD_NTXEC) +=3D ntxec.o > obj-$(CONFIG_MFD_RC5T583) +=3D rc5t583.o rc5t583-irq.o > obj-$(CONFIG_MFD_RK808) +=3D rk808.o > obj-$(CONFIG_MFD_RN5T618) +=3D rn5t618.o > diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c > new file mode 100644 > index 0000000000000..82adea34ea746 > --- /dev/null > +++ b/drivers/mfd/ntxec.c > @@ -0,0 +1,188 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// Copyright 2020 Jonathan Neusch=C3=A4fer > +// > +// MFD driver for the usually MSP430-based embedded controller used in c= ertain > +// Netronix ebook reader board designs > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > + > +#define NTXEC_VERSION 0x00 > +#define NTXEC_POWEROFF 0x50 > +#define NTXEC_POWERKEEP 0x70 > +#define NTXEC_RESET 0x90 > + > + > +/* Register access */ > + > +int ntxec_read16(struct ntxec *ec, u8 addr) > +{ > + u8 request[1] =3D { addr }; > + u8 response[2]; > + int res; > + > + struct i2c_msg msgs[] =3D { > + { > + .addr =3D ec->client->addr, > + .flags =3D ec->client->flags, > + .len =3D sizeof(request), > + .buf =3D request > + }, { > + .addr =3D ec->client->addr, > + .flags =3D ec->client->flags | I2C_M_RD, > + .len =3D sizeof(response), > + .buf =3D response > + } > + }; > + > + res =3D i2c_transfer(ec->client->adapter, msgs, ARRAY_SIZE(msgs)); > + if (res < 0) > + return res; > + if (res !=3D ARRAY_SIZE(msgs)) > + return -EIO; > + > + return get_unaligned_be16(response); > +} > +EXPORT_SYMBOL(ntxec_read16); > + > +int ntxec_write16(struct ntxec *ec, u8 addr, u16 value) > +{ > + u8 request[3] =3D { addr, }; > + int res; > + > + put_unaligned_be16(value, request + 1); > + > + res =3D i2c_transfer_buffer_flags(ec->client, request, sizeof(request), > + ec->client->flags); > + if (res < 0) > + return res; > + > + return 0; > +} > +EXPORT_SYMBOL(ntxec_write16); > + > +int ntxec_read8(struct ntxec *ec, u8 addr) > +{ > + int res =3D ntxec_read16(ec, addr); > + > + if (res < 0) > + return res; > + > + return (res >> 8) & 0xff; > +} > +EXPORT_SYMBOL(ntxec_read8); > + > +int ntxec_write8(struct ntxec *ec, u8 addr, u8 value) > +{ > + return ntxec_write16(ec, addr, value << 8); > +} > +EXPORT_SYMBOL(ntxec_write8); > + do we really need both 16bit and 8bit accessors? If not, then simply use regmap_i2c_init and set val_bits accordingly. Maybe just doing the << 8 in the constants? > + > +/* Reboot/poweroff handling */ > + > +static struct ntxec *poweroff_restart_instance; > + > +static void ntxec_poweroff(void) > +{ > + ntxec_write8(poweroff_restart_instance, NTXEC_POWEROFF, 0x01); > + msleep(5000); > +} > + > +static int ntxec_restart(struct notifier_block *nb, > + unsigned long action, void *data) > +{ > + /* FIXME: The I2C driver sleeps, but restart handlers may not sleep */ > + ntxec_write8(poweroff_restart_instance, NTXEC_RESET, 0xff); > + /* TODO: delay? */ > + return NOTIFY_DONE; > +} > + > +static struct notifier_block ntxec_restart_handler =3D { > + .notifier_call =3D ntxec_restart, > + .priority =3D 128 > +}; > + > + > +/* Driver setup */ > + > +static int ntxec_probe(struct i2c_client *client, > + const struct i2c_device_id *ids) > +{ > + struct ntxec *ec; > + int res; > + > + ec =3D devm_kmalloc(&client->dev, sizeof(*ec), GFP_KERNEL); > + if (!ec) > + return -ENOMEM; > + > + ec->dev =3D &client->dev; > + ec->client =3D client; > + > + /* Determine the firmware version */ > + res =3D ntxec_read16(ec, NTXEC_VERSION); > + if (res < 0) { > + dev_dbg(ec->dev, "Failed to read firmware version number\n"); > + return res; > + } > + ec->version =3D res; > + > + dev_info(ec->dev, > + "Netronix embedded controller version %04x detected.\n", > + ec->version); > + > + /* For now, we don't support the new register layout. */ > + if (ntxec_has_new_layout(ec)) > + return -EOPNOTSUPP; > + > + if (of_device_is_system_power_controller(ec->dev->of_node)) { > + /* > + * Set the 'powerkeep' bit. This is necessary on some boards > + * in order to keep the system running. > + */ > + res =3D ntxec_write8(ec, NTXEC_POWERKEEP, 0x08); > + if (res < 0) > + return res; > + > + /* Install poweroff handler */ > + WARN_ON(poweroff_restart_instance); > + poweroff_restart_instance =3D ec; > + if (pm_power_off !=3D NULL) > + /* TODO: Refactor among all poweroff drivers */ > + dev_err(ec->dev, "pm_power_off already assigned\n"); > + else > + pm_power_off =3D ntxec_poweroff; > + common pattern, across drivers, so I think doing something else would be a separate cleanup issue. Regards, Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 395D2C433E0 for ; Sat, 27 Jun 2020 08:18:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 139972080C for ; Sat, 27 Jun 2020 08:18:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="CdYOFiAm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726177AbgF0ISQ (ORCPT ); Sat, 27 Jun 2020 04:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgF0ISQ (ORCPT ); Sat, 27 Jun 2020 04:18:16 -0400 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A0CBC03E979; Sat, 27 Jun 2020 01:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4UusXWVmeZslLL0YrXwQifqLxTB7fqL/8w++bVpT1Ek=; b=CdYOFiAmCvnKTyLHBvYOAYYd2F uF2ipBdlMVzJkU/F9iSYsdZ0gtf75hcaUruY15yoJC0DSXLa1aIvjbQ2xUMIKrQB7x3JJ0O3fUqzT rRQTziuSZ7Wc5h91mcUSS9Shp8uDaPOQYAzzCCFemo2attCrUfXoqe7vfD0bdh7wO7Mo=; Received: from p5dcc3098.dip0.t-ipconnect.de ([93.204.48.152] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jp61s-0007Tj-7u; Sat, 27 Jun 2020 10:17:44 +0200 Date: Sat, 27 Jun 2020 10:17:38 +0200 From: Andreas Kemnade To: Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= Cc: linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Thierry Reding , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer Subject: Re: [RFC PATCH 04/10] mfd: Add base driver for Netronix embedded controller Message-ID: <20200627101738.2fe4abc3@aktux> In-Reply-To: <20200620224222.1312520-3-j.neuschaefer@gmx.net> References: <20200620224222.1312520-1-j.neuschaefer@gmx.net> <20200620224222.1312520-3-j.neuschaefer@gmx.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Sun, 21 Jun 2020 00:42:15 +0200 Jonathan Neusch=C3=A4fer wrote: > Third-party hardware documentation is available at > https://github.com/neuschaefer/linux/wiki/Netronix-MSP430-embedded-contro= ller >=20 > The EC supports interrupts, but the driver doesn't make use of them so > far. >=20 > Known problems: > - The reboot handler is installed in such a way that it directly calls > into the i2c subsystem to send the reboot command to the EC. This > means that the reboot handler may sleep, which is not allowed. >=20 see https://patchwork.ozlabs.org/project/linux-i2c/patch/20190415213432.8972-3-= contact@stefanchrist.eu/ for a fix of such problems.=20 > Signed-off-by: Jonathan Neusch=C3=A4fer > --- > drivers/mfd/Kconfig | 7 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/ntxec.c | 188 ++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/ntxec.h | 30 ++++++ > 4 files changed, 226 insertions(+) > create mode 100644 drivers/mfd/ntxec.c > create mode 100644 include/linux/mfd/ntxec.h >=20 > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index a37d7d1713820..78410b928648e 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -978,6 +978,13 @@ config MFD_VIPERBOARD > You need to select the mfd cell drivers separately. > The drivers do not support all features the board exposes. >=20 > +config MFD_NTXEC > + bool "Netronix Embedded Controller" > + depends on I2C && OF > + help > + Say yes here if you want to support the embedded controller of > + certain e-book readers designed by the ODM Netronix. > + > config MFD_RETU > tristate "Nokia Retu and Tahvo multi-function device" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 9367a92f795a6..19d9391ed6f32 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -218,6 +218,7 @@ obj-$(CONFIG_MFD_INTEL_MSIC) +=3D intel_msic.o > obj-$(CONFIG_MFD_INTEL_PMC_BXT) +=3D intel_pmc_bxt.o > obj-$(CONFIG_MFD_PALMAS) +=3D palmas.o > obj-$(CONFIG_MFD_VIPERBOARD) +=3D viperboard.o > +obj-$(CONFIG_MFD_NTXEC) +=3D ntxec.o > obj-$(CONFIG_MFD_RC5T583) +=3D rc5t583.o rc5t583-irq.o > obj-$(CONFIG_MFD_RK808) +=3D rk808.o > obj-$(CONFIG_MFD_RN5T618) +=3D rn5t618.o > diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c > new file mode 100644 > index 0000000000000..82adea34ea746 > --- /dev/null > +++ b/drivers/mfd/ntxec.c > @@ -0,0 +1,188 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// Copyright 2020 Jonathan Neusch=C3=A4fer > +// > +// MFD driver for the usually MSP430-based embedded controller used in c= ertain > +// Netronix ebook reader board designs > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > + > +#define NTXEC_VERSION 0x00 > +#define NTXEC_POWEROFF 0x50 > +#define NTXEC_POWERKEEP 0x70 > +#define NTXEC_RESET 0x90 > + > + > +/* Register access */ > + > +int ntxec_read16(struct ntxec *ec, u8 addr) > +{ > + u8 request[1] =3D { addr }; > + u8 response[2]; > + int res; > + > + struct i2c_msg msgs[] =3D { > + { > + .addr =3D ec->client->addr, > + .flags =3D ec->client->flags, > + .len =3D sizeof(request), > + .buf =3D request > + }, { > + .addr =3D ec->client->addr, > + .flags =3D ec->client->flags | I2C_M_RD, > + .len =3D sizeof(response), > + .buf =3D response > + } > + }; > + > + res =3D i2c_transfer(ec->client->adapter, msgs, ARRAY_SIZE(msgs)); > + if (res < 0) > + return res; > + if (res !=3D ARRAY_SIZE(msgs)) > + return -EIO; > + > + return get_unaligned_be16(response); > +} > +EXPORT_SYMBOL(ntxec_read16); > + > +int ntxec_write16(struct ntxec *ec, u8 addr, u16 value) > +{ > + u8 request[3] =3D { addr, }; > + int res; > + > + put_unaligned_be16(value, request + 1); > + > + res =3D i2c_transfer_buffer_flags(ec->client, request, sizeof(request), > + ec->client->flags); > + if (res < 0) > + return res; > + > + return 0; > +} > +EXPORT_SYMBOL(ntxec_write16); > + > +int ntxec_read8(struct ntxec *ec, u8 addr) > +{ > + int res =3D ntxec_read16(ec, addr); > + > + if (res < 0) > + return res; > + > + return (res >> 8) & 0xff; > +} > +EXPORT_SYMBOL(ntxec_read8); > + > +int ntxec_write8(struct ntxec *ec, u8 addr, u8 value) > +{ > + return ntxec_write16(ec, addr, value << 8); > +} > +EXPORT_SYMBOL(ntxec_write8); > + do we really need both 16bit and 8bit accessors? If not, then simply use regmap_i2c_init and set val_bits accordingly. Maybe just doing the << 8 in the constants? > + > +/* Reboot/poweroff handling */ > + > +static struct ntxec *poweroff_restart_instance; > + > +static void ntxec_poweroff(void) > +{ > + ntxec_write8(poweroff_restart_instance, NTXEC_POWEROFF, 0x01); > + msleep(5000); > +} > + > +static int ntxec_restart(struct notifier_block *nb, > + unsigned long action, void *data) > +{ > + /* FIXME: The I2C driver sleeps, but restart handlers may not sleep */ > + ntxec_write8(poweroff_restart_instance, NTXEC_RESET, 0xff); > + /* TODO: delay? */ > + return NOTIFY_DONE; > +} > + > +static struct notifier_block ntxec_restart_handler =3D { > + .notifier_call =3D ntxec_restart, > + .priority =3D 128 > +}; > + > + > +/* Driver setup */ > + > +static int ntxec_probe(struct i2c_client *client, > + const struct i2c_device_id *ids) > +{ > + struct ntxec *ec; > + int res; > + > + ec =3D devm_kmalloc(&client->dev, sizeof(*ec), GFP_KERNEL); > + if (!ec) > + return -ENOMEM; > + > + ec->dev =3D &client->dev; > + ec->client =3D client; > + > + /* Determine the firmware version */ > + res =3D ntxec_read16(ec, NTXEC_VERSION); > + if (res < 0) { > + dev_dbg(ec->dev, "Failed to read firmware version number\n"); > + return res; > + } > + ec->version =3D res; > + > + dev_info(ec->dev, > + "Netronix embedded controller version %04x detected.\n", > + ec->version); > + > + /* For now, we don't support the new register layout. */ > + if (ntxec_has_new_layout(ec)) > + return -EOPNOTSUPP; > + > + if (of_device_is_system_power_controller(ec->dev->of_node)) { > + /* > + * Set the 'powerkeep' bit. This is necessary on some boards > + * in order to keep the system running. > + */ > + res =3D ntxec_write8(ec, NTXEC_POWERKEEP, 0x08); > + if (res < 0) > + return res; > + > + /* Install poweroff handler */ > + WARN_ON(poweroff_restart_instance); > + poweroff_restart_instance =3D ec; > + if (pm_power_off !=3D NULL) > + /* TODO: Refactor among all poweroff drivers */ > + dev_err(ec->dev, "pm_power_off already assigned\n"); > + else > + pm_power_off =3D ntxec_poweroff; > + common pattern, across drivers, so I think doing something else would be a separate cleanup issue. Regards, Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FAAC433DF for ; Sat, 27 Jun 2020 08:21:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4C2F2074F for ; Sat, 27 Jun 2020 08:21:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="prOK/dYO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="vqGNJgxj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="CdYOFiAm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4C2F2074F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FZ4/nKFFajBjC0kLd6bdTy/Z6ZuUV4vZrG6FVJB+zbs=; b=prOK/dYOUzhqgLh+E+Vn6axKi HoeeJY52OsA1dcHJlCfgN6A/UAp1O3QQSzgvDDdwiFFJ6TTDxrvBm2uXzqYPrzVI9wa2POGXKwmKU 8UUsC0xgmb4YMciJxmy/WfZMmrPnAuSPsOGVdU+L3jO1HkDvqB7XwLECeFeF3FZ8R47A5UM45+dYc VWJ37oJx7Y1G+voRuCLIKyH5Gi8GpphdPRPxv90UXKl0T1Es5oIUGhzDdiuRYE6Vn2InlT+VjLoq0 j1G6Vyu9+vS7G2k6L36KvHE2znqQcc98H/KtEd+EP8fFKTKlQ8daDO2sKLsPGhNezCaVuySGOhRfP mCpdCii2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp62l-0006x1-2q; Sat, 27 Jun 2020 08:18:35 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp62i-0006wd-Qj for linux-arm-kernel@merlin.infradead.org; Sat, 27 Jun 2020 08:18:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description; bh=4UusXWVmeZslLL0YrXwQifqLxTB7fqL/8w++bVpT1Ek=; b=vqGNJgxjFeyiVgFistzf23JJhL ojW+mITOOUj6IKV13214wnob2r67EKm0Im/Oxb8owjuyqfJa/ocEFmn2OdFADamkeNRiNEWEVlDkG a7+bVu8UVXRttZfamLCe5Ir8oZXC3SrGzTY+vldS1TZKsJPGZ30+vaLyxmiWYzbWcrNz2K1FCV8ia Akp0sE5CI4ErTN9cz0L37ylknBJpoZ1XIaNCBaityg6vs7LO+JxfA2b4Qkn+1nP8Mm0UzSGLietDG qi1YSILxg89GNNdvpaYksuOGLRVrcO9ZGIym/tr2ojImjkY4qs3rd76FfbVZyetTi8r+7AHrpbnVU 5gUZWO9A==; Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp62W-0000Ex-9Z for linux-arm-kernel@lists.infradead.org; Sat, 27 Jun 2020 08:18:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4UusXWVmeZslLL0YrXwQifqLxTB7fqL/8w++bVpT1Ek=; b=CdYOFiAmCvnKTyLHBvYOAYYd2F uF2ipBdlMVzJkU/F9iSYsdZ0gtf75hcaUruY15yoJC0DSXLa1aIvjbQ2xUMIKrQB7x3JJ0O3fUqzT rRQTziuSZ7Wc5h91mcUSS9Shp8uDaPOQYAzzCCFemo2attCrUfXoqe7vfD0bdh7wO7Mo=; Received: from p5dcc3098.dip0.t-ipconnect.de ([93.204.48.152] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jp61s-0007Tj-7u; Sat, 27 Jun 2020 10:17:44 +0200 Date: Sat, 27 Jun 2020 10:17:38 +0200 From: Andreas Kemnade To: Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= Subject: Re: [RFC PATCH 04/10] mfd: Add base driver for Netronix embedded controller Message-ID: <20200627101738.2fe4abc3@aktux> In-Reply-To: <20200620224222.1312520-3-j.neuschaefer@gmx.net> References: <20200620224222.1312520-1-j.neuschaefer@gmx.net> <20200620224222.1312520-3-j.neuschaefer@gmx.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200627_091824_715341_2BC2AA88 X-CRM114-Status: GOOD ( 36.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , Fabio Estevam , linux-rtc@vger.kernel.org, Mauro Carvalho Chehab , Sam Ravnborg , NXP Linux Team , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , devicetree@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Lubomir Rintel , Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , linux-kernel@vger.kernel.org, Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAyMSBKdW4gMjAyMCAwMDo0MjoxNSArMDIwMApKb25hdGhhbiBOZXVzY2jDpGZlciA8 ai5uZXVzY2hhZWZlckBnbXgubmV0PiB3cm90ZToKCj4gVGhpcmQtcGFydHkgaGFyZHdhcmUgZG9j dW1lbnRhdGlvbiBpcyBhdmFpbGFibGUgYXQKPiBodHRwczovL2dpdGh1Yi5jb20vbmV1c2NoYWVm ZXIvbGludXgvd2lraS9OZXRyb25peC1NU1A0MzAtZW1iZWRkZWQtY29udHJvbGxlcgo+IAo+IFRo ZSBFQyBzdXBwb3J0cyBpbnRlcnJ1cHRzLCBidXQgdGhlIGRyaXZlciBkb2Vzbid0IG1ha2UgdXNl IG9mIHRoZW0gc28KPiBmYXIuCj4gCj4gS25vd24gcHJvYmxlbXM6Cj4gLSBUaGUgcmVib290IGhh bmRsZXIgaXMgaW5zdGFsbGVkIGluIHN1Y2ggYSB3YXkgdGhhdCBpdCBkaXJlY3RseSBjYWxscwo+ ICAgaW50byB0aGUgaTJjIHN1YnN5c3RlbSB0byBzZW5kIHRoZSByZWJvb3QgY29tbWFuZCB0byB0 aGUgRUMuIFRoaXMKPiAgIG1lYW5zIHRoYXQgdGhlIHJlYm9vdCBoYW5kbGVyIG1heSBzbGVlcCwg d2hpY2ggaXMgbm90IGFsbG93ZWQuCj4gCnNlZQpodHRwczovL3BhdGNod29yay5vemxhYnMub3Jn L3Byb2plY3QvbGludXgtaTJjL3BhdGNoLzIwMTkwNDE1MjEzNDMyLjg5NzItMy1jb250YWN0QHN0 ZWZhbmNocmlzdC5ldS8KCmZvciBhIGZpeCBvZiBzdWNoIHByb2JsZW1zLiAKCj4gU2lnbmVkLW9m Zi1ieTogSm9uYXRoYW4gTmV1c2Now6RmZXIgPGoubmV1c2NoYWVmZXJAZ214Lm5ldD4KPiAtLS0K PiAgZHJpdmVycy9tZmQvS2NvbmZpZyAgICAgICB8ICAgNyArKwo+ICBkcml2ZXJzL21mZC9NYWtl ZmlsZSAgICAgIHwgICAxICsKPiAgZHJpdmVycy9tZmQvbnR4ZWMuYyAgICAgICB8IDE4OCArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4L21mZC9u dHhlYy5oIHwgIDMwICsrKysrKwo+ICA0IGZpbGVzIGNoYW5nZWQsIDIyNiBpbnNlcnRpb25zKCsp Cj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL21mZC9udHhlYy5jCj4gIGNyZWF0ZSBtb2Rl IDEwMDY0NCBpbmNsdWRlL2xpbnV4L21mZC9udHhlYy5oCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvbWZkL0tjb25maWcgYi9kcml2ZXJzL21mZC9LY29uZmlnCj4gaW5kZXggYTM3ZDdkMTcxMzgy MC4uNzg0MTBiOTI4NjQ4ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21mZC9LY29uZmlnCj4gKysr IGIvZHJpdmVycy9tZmQvS2NvbmZpZwo+IEBAIC05NzgsNiArOTc4LDEzIEBAIGNvbmZpZyBNRkRf VklQRVJCT0FSRAo+ICAJICBZb3UgbmVlZCB0byBzZWxlY3QgdGhlIG1mZCBjZWxsIGRyaXZlcnMg c2VwYXJhdGVseS4KPiAgCSAgVGhlIGRyaXZlcnMgZG8gbm90IHN1cHBvcnQgYWxsIGZlYXR1cmVz IHRoZSBib2FyZCBleHBvc2VzLgo+IAo+ICtjb25maWcgTUZEX05UWEVDCj4gKwlib29sICJOZXRy b25peCBFbWJlZGRlZCBDb250cm9sbGVyIgo+ICsJZGVwZW5kcyBvbiBJMkMgJiYgT0YKPiArCWhl bHAKPiArCSAgU2F5IHllcyBoZXJlIGlmIHlvdSB3YW50IHRvIHN1cHBvcnQgdGhlIGVtYmVkZGVk IGNvbnRyb2xsZXIgb2YKPiArCSAgY2VydGFpbiBlLWJvb2sgcmVhZGVycyBkZXNpZ25lZCBieSB0 aGUgT0RNIE5ldHJvbml4Lgo+ICsKPiAgY29uZmlnIE1GRF9SRVRVCj4gIAl0cmlzdGF0ZSAiTm9r aWEgUmV0dSBhbmQgVGFodm8gbXVsdGktZnVuY3Rpb24gZGV2aWNlIgo+ICAJc2VsZWN0IE1GRF9D T1JFCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL01ha2VmaWxlIGIvZHJpdmVycy9tZmQvTWFr ZWZpbGUKPiBpbmRleCA5MzY3YTkyZjc5NWE2Li4xOWQ5MzkxZWQ2ZjMyIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvbWZkL01ha2VmaWxlCj4gKysrIGIvZHJpdmVycy9tZmQvTWFrZWZpbGUKPiBAQCAt MjE4LDYgKzIxOCw3IEBAIG9iai0kKENPTkZJR19NRkRfSU5URUxfTVNJQykJKz0gaW50ZWxfbXNp Yy5vCj4gIG9iai0kKENPTkZJR19NRkRfSU5URUxfUE1DX0JYVCkJKz0gaW50ZWxfcG1jX2J4dC5v Cj4gIG9iai0kKENPTkZJR19NRkRfUEFMTUFTKQkrPSBwYWxtYXMubwo+ICBvYmotJChDT05GSUdf TUZEX1ZJUEVSQk9BUkQpICAgICs9IHZpcGVyYm9hcmQubwo+ICtvYmotJChDT05GSUdfTUZEX05U WEVDKQkJKz0gbnR4ZWMubwo+ICBvYmotJChDT05GSUdfTUZEX1JDNVQ1ODMpCSs9IHJjNXQ1ODMu byByYzV0NTgzLWlycS5vCj4gIG9iai0kKENPTkZJR19NRkRfUks4MDgpCQkrPSByazgwOC5vCj4g IG9iai0kKENPTkZJR19NRkRfUk41VDYxOCkJKz0gcm41dDYxOC5vCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbWZkL250eGVjLmMgYi9kcml2ZXJzL21mZC9udHhlYy5jCj4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi44MmFkZWEzNGVhNzQ2Cj4gLS0tIC9kZXYvbnVs bAo+ICsrKyBiL2RyaXZlcnMvbWZkL250eGVjLmMKPiBAQCAtMCwwICsxLDE4OCBAQAo+ICsvLyBT UERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMC1vbmx5Cj4gKy8vIENvcHlyaWdodCAyMDIw IEpvbmF0aGFuIE5ldXNjaMOkZmVyCj4gKy8vCj4gKy8vIE1GRCBkcml2ZXIgZm9yIHRoZSB1c3Vh bGx5IE1TUDQzMC1iYXNlZCBlbWJlZGRlZCBjb250cm9sbGVyIHVzZWQgaW4gY2VydGFpbgo+ICsv LyBOZXRyb25peCBlYm9vayByZWFkZXIgYm9hcmQgZGVzaWducwo+ICsKPiArI2luY2x1ZGUgPGFz bS91bmFsaWduZWQuaD4KPiArI2luY2x1ZGUgPGxpbnV4L2RlbGF5Lmg+Cj4gKyNpbmNsdWRlIDxs aW51eC9lcnJuby5oPgo+ICsjaW5jbHVkZSA8bGludXgvaTJjLmg+Cj4gKyNpbmNsdWRlIDxsaW51 eC9tZmQvbnR4ZWMuaD4KPiArI2luY2x1ZGUgPGxpbnV4L29mX3BsYXRmb3JtLmg+Cj4gKyNpbmNs dWRlIDxsaW51eC9wbS5oPgo+ICsjaW5jbHVkZSA8bGludXgvcmVib290Lmg+Cj4gKyNpbmNsdWRl IDxsaW51eC90eXBlcy5oPgo+ICsKPiArCj4gKyNkZWZpbmUgTlRYRUNfVkVSU0lPTgkJMHgwMAo+ ICsjZGVmaW5lIE5UWEVDX1BPV0VST0ZGCQkweDUwCj4gKyNkZWZpbmUgTlRYRUNfUE9XRVJLRUVQ CQkweDcwCj4gKyNkZWZpbmUgTlRYRUNfUkVTRVQJCTB4OTAKPiArCj4gKwo+ICsvKiBSZWdpc3Rl ciBhY2Nlc3MgKi8KPiArCj4gK2ludCBudHhlY19yZWFkMTYoc3RydWN0IG50eGVjICplYywgdTgg YWRkcikKPiArewo+ICsJdTggcmVxdWVzdFsxXSA9IHsgYWRkciB9Owo+ICsJdTggcmVzcG9uc2Vb Ml07Cj4gKwlpbnQgcmVzOwo+ICsKPiArCXN0cnVjdCBpMmNfbXNnIG1zZ3NbXSA9IHsKPiArCQl7 Cj4gKwkJCS5hZGRyID0gZWMtPmNsaWVudC0+YWRkciwKPiArCQkJLmZsYWdzID0gZWMtPmNsaWVu dC0+ZmxhZ3MsCj4gKwkJCS5sZW4gPSBzaXplb2YocmVxdWVzdCksCj4gKwkJCS5idWYgPSByZXF1 ZXN0Cj4gKwkJfSwgewo+ICsJCQkuYWRkciA9IGVjLT5jbGllbnQtPmFkZHIsCj4gKwkJCS5mbGFn cyA9IGVjLT5jbGllbnQtPmZsYWdzIHwgSTJDX01fUkQsCj4gKwkJCS5sZW4gPSBzaXplb2YocmVz cG9uc2UpLAo+ICsJCQkuYnVmID0gcmVzcG9uc2UKPiArCQl9Cj4gKwl9Owo+ICsKPiArCXJlcyA9 IGkyY190cmFuc2ZlcihlYy0+Y2xpZW50LT5hZGFwdGVyLCBtc2dzLCBBUlJBWV9TSVpFKG1zZ3Mp KTsKPiArCWlmIChyZXMgPCAwKQo+ICsJCXJldHVybiByZXM7Cj4gKwlpZiAocmVzICE9IEFSUkFZ X1NJWkUobXNncykpCj4gKwkJcmV0dXJuIC1FSU87Cj4gKwo+ICsJcmV0dXJuIGdldF91bmFsaWdu ZWRfYmUxNihyZXNwb25zZSk7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChudHhlY19yZWFkMTYpOwo+ ICsKPiAraW50IG50eGVjX3dyaXRlMTYoc3RydWN0IG50eGVjICplYywgdTggYWRkciwgdTE2IHZh bHVlKQo+ICt7Cj4gKwl1OCByZXF1ZXN0WzNdID0geyBhZGRyLCB9Owo+ICsJaW50IHJlczsKPiAr Cj4gKwlwdXRfdW5hbGlnbmVkX2JlMTYodmFsdWUsIHJlcXVlc3QgKyAxKTsKPiArCj4gKwlyZXMg PSBpMmNfdHJhbnNmZXJfYnVmZmVyX2ZsYWdzKGVjLT5jbGllbnQsIHJlcXVlc3QsIHNpemVvZihy ZXF1ZXN0KSwKPiArCQkJCQllYy0+Y2xpZW50LT5mbGFncyk7Cj4gKwlpZiAocmVzIDwgMCkKPiAr CQlyZXR1cm4gcmVzOwo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0wobnR4 ZWNfd3JpdGUxNik7Cj4gKwo+ICtpbnQgbnR4ZWNfcmVhZDgoc3RydWN0IG50eGVjICplYywgdTgg YWRkcikKPiArewo+ICsJaW50IHJlcyA9IG50eGVjX3JlYWQxNihlYywgYWRkcik7Cj4gKwo+ICsJ aWYgKHJlcyA8IDApCj4gKwkJcmV0dXJuIHJlczsKPiArCj4gKwlyZXR1cm4gKHJlcyA+PiA4KSAm IDB4ZmY7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChudHhlY19yZWFkOCk7Cj4gKwo+ICtpbnQgbnR4 ZWNfd3JpdGU4KHN0cnVjdCBudHhlYyAqZWMsIHU4IGFkZHIsIHU4IHZhbHVlKQo+ICt7Cj4gKwly ZXR1cm4gbnR4ZWNfd3JpdGUxNihlYywgYWRkciwgdmFsdWUgPDwgOCk7Cj4gK30KPiArRVhQT1JU X1NZTUJPTChudHhlY193cml0ZTgpOwo+ICsKCmRvIHdlIHJlYWxseSBuZWVkIGJvdGggMTZiaXQg YW5kIDhiaXQgYWNjZXNzb3JzPyBJZiBub3QsCnRoZW4gc2ltcGx5IHVzZSByZWdtYXBfaTJjX2lu aXQgYW5kIHNldCB2YWxfYml0cyBhY2NvcmRpbmdseS4KTWF5YmUganVzdCBkb2luZyB0aGUgPDwg OCBpbiB0aGUgY29uc3RhbnRzPwoKPiArCj4gKy8qIFJlYm9vdC9wb3dlcm9mZiBoYW5kbGluZyAq Lwo+ICsKPiArc3RhdGljIHN0cnVjdCBudHhlYyAqcG93ZXJvZmZfcmVzdGFydF9pbnN0YW5jZTsK PiArCj4gK3N0YXRpYyB2b2lkIG50eGVjX3Bvd2Vyb2ZmKHZvaWQpCj4gK3sKPiArCW50eGVjX3dy aXRlOChwb3dlcm9mZl9yZXN0YXJ0X2luc3RhbmNlLCBOVFhFQ19QT1dFUk9GRiwgMHgwMSk7Cj4g Kwltc2xlZXAoNTAwMCk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgbnR4ZWNfcmVzdGFydChzdHJ1 Y3Qgbm90aWZpZXJfYmxvY2sgKm5iLAo+ICsJCXVuc2lnbmVkIGxvbmcgYWN0aW9uLCB2b2lkICpk YXRhKQo+ICt7Cj4gKwkvKiBGSVhNRTogVGhlIEkyQyBkcml2ZXIgc2xlZXBzLCBidXQgcmVzdGFy dCBoYW5kbGVycyBtYXkgbm90IHNsZWVwICovCj4gKwludHhlY193cml0ZTgocG93ZXJvZmZfcmVz dGFydF9pbnN0YW5jZSwgTlRYRUNfUkVTRVQsIDB4ZmYpOwo+ICsJLyogVE9ETzogZGVsYXk/ICov Cj4gKwlyZXR1cm4gTk9USUZZX0RPTkU7Cj4gK30KPiArCj4gK3N0YXRpYyBzdHJ1Y3Qgbm90aWZp ZXJfYmxvY2sgbnR4ZWNfcmVzdGFydF9oYW5kbGVyID0gewo+ICsJLm5vdGlmaWVyX2NhbGwgPSBu dHhlY19yZXN0YXJ0LAo+ICsJLnByaW9yaXR5ID0gMTI4Cj4gK307Cj4gKwo+ICsKPiArLyogRHJp dmVyIHNldHVwICovCj4gKwo+ICtzdGF0aWMgaW50IG50eGVjX3Byb2JlKHN0cnVjdCBpMmNfY2xp ZW50ICpjbGllbnQsCj4gKwkJCSAgICBjb25zdCBzdHJ1Y3QgaTJjX2RldmljZV9pZCAqaWRzKQo+ ICt7Cj4gKwlzdHJ1Y3QgbnR4ZWMgKmVjOwo+ICsJaW50IHJlczsKPiArCj4gKwllYyA9IGRldm1f a21hbGxvYygmY2xpZW50LT5kZXYsIHNpemVvZigqZWMpLCBHRlBfS0VSTkVMKTsKPiArCWlmICgh ZWMpCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwo+ICsJZWMtPmRldiA9ICZjbGllbnQtPmRldjsK PiArCWVjLT5jbGllbnQgPSBjbGllbnQ7Cj4gKwo+ICsJLyogRGV0ZXJtaW5lIHRoZSBmaXJtd2Fy ZSB2ZXJzaW9uICovCj4gKwlyZXMgPSBudHhlY19yZWFkMTYoZWMsIE5UWEVDX1ZFUlNJT04pOwo+ ICsJaWYgKHJlcyA8IDApIHsKPiArCQlkZXZfZGJnKGVjLT5kZXYsICJGYWlsZWQgdG8gcmVhZCBm aXJtd2FyZSB2ZXJzaW9uIG51bWJlclxuIik7Cj4gKwkJcmV0dXJuIHJlczsKPiArCX0KPiArCWVj LT52ZXJzaW9uID0gcmVzOwo+ICsKPiArCWRldl9pbmZvKGVjLT5kZXYsCj4gKwkJICJOZXRyb25p eCBlbWJlZGRlZCBjb250cm9sbGVyIHZlcnNpb24gJTA0eCBkZXRlY3RlZC5cbiIsCj4gKwkJIGVj LT52ZXJzaW9uKTsKPiArCj4gKwkvKiBGb3Igbm93LCB3ZSBkb24ndCBzdXBwb3J0IHRoZSBuZXcg cmVnaXN0ZXIgbGF5b3V0LiAqLwo+ICsJaWYgKG50eGVjX2hhc19uZXdfbGF5b3V0KGVjKSkKPiAr CQlyZXR1cm4gLUVPUE5PVFNVUFA7Cj4gKwo+ICsJaWYgKG9mX2RldmljZV9pc19zeXN0ZW1fcG93 ZXJfY29udHJvbGxlcihlYy0+ZGV2LT5vZl9ub2RlKSkgewo+ICsJCS8qCj4gKwkJICogU2V0IHRo ZSAncG93ZXJrZWVwJyBiaXQuIFRoaXMgaXMgbmVjZXNzYXJ5IG9uIHNvbWUgYm9hcmRzCj4gKwkJ ICogaW4gb3JkZXIgdG8ga2VlcCB0aGUgc3lzdGVtIHJ1bm5pbmcuCj4gKwkJICovCj4gKwkJcmVz ID0gbnR4ZWNfd3JpdGU4KGVjLCBOVFhFQ19QT1dFUktFRVAsIDB4MDgpOwo+ICsJCWlmIChyZXMg PCAwKQo+ICsJCQlyZXR1cm4gcmVzOwo+ICsKPiArCQkvKiBJbnN0YWxsIHBvd2Vyb2ZmIGhhbmRs ZXIgKi8KPiArCQlXQVJOX09OKHBvd2Vyb2ZmX3Jlc3RhcnRfaW5zdGFuY2UpOwo+ICsJCXBvd2Vy b2ZmX3Jlc3RhcnRfaW5zdGFuY2UgPSBlYzsKPiArCQlpZiAocG1fcG93ZXJfb2ZmICE9IE5VTEwp Cj4gKwkJCS8qIFRPRE86IFJlZmFjdG9yIGFtb25nIGFsbCBwb3dlcm9mZiBkcml2ZXJzICovCj4g KwkJCWRldl9lcnIoZWMtPmRldiwgInBtX3Bvd2VyX29mZiBhbHJlYWR5IGFzc2lnbmVkXG4iKTsK PiArCQllbHNlCj4gKwkJCXBtX3Bvd2VyX29mZiA9IG50eGVjX3Bvd2Vyb2ZmOwo+ICsKY29tbW9u IHBhdHRlcm4sIGFjcm9zcyBkcml2ZXJzLCBzbyBJIHRoaW5rIGRvaW5nIHNvbWV0aGluZyBlbHNl IHdvdWxkCmJlIGEgc2VwYXJhdGUgY2xlYW51cCBpc3N1ZS4KClJlZ2FyZHMsCkFuZHJlYXMKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK