All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Straube <straube.linux@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8188eu: remove unnecessary comments in hal8188e_phy_cfg.h
Date: Sat, 27 Jun 2020 20:21:30 +0300	[thread overview]
Message-ID: <20200627172130.GK2549@kadam> (raw)
In-Reply-To: <20200627151544.11251-1-straube.linux@gmail.com>

On Sat, Jun 27, 2020 at 05:15:44PM +0200, Michael Straube wrote:
> @@ -145,21 +138,7 @@ struct bb_reg_def {
>  				 */
>  };
>  
> -/*------------------------------Define structure----------------------------*/
> -
> -
> -/*------------------------Export global variable----------------------------*/
> -/*------------------------Export global variable----------------------------*/
> -
> -
> -/*------------------------Export Marco Definition---------------------------*/
> -/*------------------------Export Marco Definition---------------------------*/
> -
> -
> -/*--------------------------Exported Function prototype---------------------*/
> -/*  */
>  /*  BB and RF register read/write */

You can probably delete this line as well.  ;)

> -/*  */
>  
>  /* Read initi reg value for tx power setting. */
>  void rtl8192c_PHY_GetHWRegOriginalValue(struct adapter *adapter);

regards,
dan carpenter


      reply	other threads:[~2020-06-27 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 15:15 [PATCH] staging: rtl8188eu: remove unnecessary comments in hal8188e_phy_cfg.h Michael Straube
2020-06-27 17:21 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200627172130.GK2549@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.