From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Date: Sat, 27 Jun 2020 23:43:38 +0300 Message-ID: <20200627204338.GL5966@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20200621222742.25695-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Thierry Reding , Sam Ravnborg , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Dmitry, Thank you for the patch. On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > This patch adds missing BUS fields to the display panel descriptions of > the panels which are found on NVIDIA Tegra devices: > > 1. AUO B101AW03 > 2. Chunghwa CLAA070WP03XG > 3. Chunghwa CLAA101WA01A > 4. Chunghwa CLAA101WB01 > 5. Innolux N156BGE L21 > 6. Samsung LTN101NT05 > > Suggested-by: Laurent Pinchart > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 87edd2bdf09a..986df9937650 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? The rest looks good, except the Samsung panel for which I haven't been able to locate a datasheet. Reviewed-by: Laurent Pinchart > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1352,6 +1354,8 @@ static const struct panel_desc chunghwa_claa070wp03xg = { > .width = 94, > .height = 150, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1375,6 +1379,8 @@ static const struct panel_desc chunghwa_claa101wa01a = { > .width = 220, > .height = 120, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1398,6 +1404,8 @@ static const struct panel_desc chunghwa_claa101wb01 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -2071,6 +2079,8 @@ static const struct panel_desc innolux_n156bge_l21 = { > .width = 344, > .height = 193, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -3018,6 +3028,8 @@ static const struct panel_desc samsung_ltn101nt05 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED05C433DF for ; Sat, 27 Jun 2020 20:43:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11955206A5 for ; Sat, 27 Jun 2020 20:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CuoXchm3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11955206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68B346E176; Sat, 27 Jun 2020 20:43:46 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48F8E6E176 for ; Sat, 27 Jun 2020 20:43:44 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E6C18576; Sat, 27 Jun 2020 22:43:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593290622; bh=jvH2aA/gigMXp4FM0R9jUn0zODDOAzaZorDcNJk2SfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CuoXchm35zDuLxDDzAVCIbwMKI+DOD1CMoMR92qVNJ8JAlCrgNLIic0K+jMjQ1B2O O40aySE55l3R2GgS8DaZBT+At+Jn6E8jCBZR65dmMOt6VttK1HpFTKzxLSeRhJM+MV DbPesDiv173/IwTr7IBAw/T+Zal6MkceHN/H6dPc= Date: Sat, 27 Jun 2020 23:43:38 +0300 From: Laurent Pinchart To: Dmitry Osipenko Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Message-ID: <20200627204338.GL5966@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200621222742.25695-3-digetx@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dmitry, Thank you for the patch. On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > This patch adds missing BUS fields to the display panel descriptions of > the panels which are found on NVIDIA Tegra devices: > > 1. AUO B101AW03 > 2. Chunghwa CLAA070WP03XG > 3. Chunghwa CLAA101WA01A > 4. Chunghwa CLAA101WB01 > 5. Innolux N156BGE L21 > 6. Samsung LTN101NT05 > > Suggested-by: Laurent Pinchart > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 87edd2bdf09a..986df9937650 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? The rest looks good, except the Samsung panel for which I haven't been able to locate a datasheet. Reviewed-by: Laurent Pinchart > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1352,6 +1354,8 @@ static const struct panel_desc chunghwa_claa070wp03xg = { > .width = 94, > .height = 150, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1375,6 +1379,8 @@ static const struct panel_desc chunghwa_claa101wa01a = { > .width = 220, > .height = 120, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1398,6 +1404,8 @@ static const struct panel_desc chunghwa_claa101wb01 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -2071,6 +2079,8 @@ static const struct panel_desc innolux_n156bge_l21 = { > .width = 344, > .height = 193, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -3018,6 +3028,8 @@ static const struct panel_desc samsung_ltn101nt05 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9398DC433E0 for ; Sat, 27 Jun 2020 20:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E51720663 for ; Sat, 27 Jun 2020 20:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CuoXchm3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726094AbgF0Unp (ORCPT ); Sat, 27 Jun 2020 16:43:45 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:37474 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725792AbgF0Uno (ORCPT ); Sat, 27 Jun 2020 16:43:44 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E6C18576; Sat, 27 Jun 2020 22:43:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593290622; bh=jvH2aA/gigMXp4FM0R9jUn0zODDOAzaZorDcNJk2SfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CuoXchm35zDuLxDDzAVCIbwMKI+DOD1CMoMR92qVNJ8JAlCrgNLIic0K+jMjQ1B2O O40aySE55l3R2GgS8DaZBT+At+Jn6E8jCBZR65dmMOt6VttK1HpFTKzxLSeRhJM+MV DbPesDiv173/IwTr7IBAw/T+Zal6MkceHN/H6dPc= Date: Sat, 27 Jun 2020 23:43:38 +0300 From: Laurent Pinchart To: Dmitry Osipenko Cc: Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Message-ID: <20200627204338.GL5966@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200621222742.25695-3-digetx@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, Thank you for the patch. On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > This patch adds missing BUS fields to the display panel descriptions of > the panels which are found on NVIDIA Tegra devices: > > 1. AUO B101AW03 > 2. Chunghwa CLAA070WP03XG > 3. Chunghwa CLAA101WA01A > 4. Chunghwa CLAA101WB01 > 5. Innolux N156BGE L21 > 6. Samsung LTN101NT05 > > Suggested-by: Laurent Pinchart > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 87edd2bdf09a..986df9937650 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? The rest looks good, except the Samsung panel for which I haven't been able to locate a datasheet. Reviewed-by: Laurent Pinchart > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1352,6 +1354,8 @@ static const struct panel_desc chunghwa_claa070wp03xg = { > .width = 94, > .height = 150, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1375,6 +1379,8 @@ static const struct panel_desc chunghwa_claa101wa01a = { > .width = 220, > .height = 120, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -1398,6 +1404,8 @@ static const struct panel_desc chunghwa_claa101wb01 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -2071,6 +2079,8 @@ static const struct panel_desc innolux_n156bge_l21 = { > .width = 344, > .height = 193, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > @@ -3018,6 +3028,8 @@ static const struct panel_desc samsung_ltn101nt05 = { > .width = 223, > .height = 125, > }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > -- Regards, Laurent Pinchart