Re: [PATCH net-next v1 2/5] net: sched: Introduce helpers for qevent blocks

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6111 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <79417f27b7c57da5c0eb54bb6d074d3a472d9ebf.1593209494.git.petrm@mellanox.com>
References: <79417f27b7c57da5c0eb54bb6d074d3a472d9ebf.1593209494.git.petrm(a)mellanox.com>
TO: Petr Machata <petrm@mellanox.com>

Hi Petr,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Petr-Machata/TC-Introduce-qevents/20200627-064838
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 18c955b730002afdb0f86be39c0d202450acbbfc
:::::: branch date: 22 hours ago
:::::: commit date: 22 hours ago
config: x86_64-randconfig-s021-20200628 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   net/sched/cls_api.c:270:22: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be16 [usertype] protocol @@     got unsigned int [usertype] protocol @@
   net/sched/cls_api.c:270:22: sparse:     expected restricted __be16 [usertype] protocol
   net/sched/cls_api.c:270:22: sparse:     got unsigned int [usertype] protocol
   net/sched/cls_api.c:1672:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1672:16: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1672:16: sparse:    struct tcf_proto [noderef] __rcu *
   net/sched/cls_api.c:1772:20: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1772:20: sparse:    struct tcf_proto [noderef] __rcu *
   net/sched/cls_api.c:1772:20: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1734:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1734:25: sparse:    struct tcf_proto [noderef] __rcu *
   net/sched/cls_api.c:1734:25: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1754:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1754:16: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1754:16: sparse:    struct tcf_proto [noderef] __rcu *
   net/sched/cls_api.c:1819:25: sparse: sparse: restricted __be16 degrades to integer
   net/sched/cls_api.c:2494:50: sparse: sparse: restricted __be16 degrades to integer
   net/sched/cls_api.c:3725:9: sparse: sparse: context imbalance in 'tc_setup_flow_action' - different lock contexts for basic block
>> net/sched/cls_api.c:3834:28: sparse: sparse: context imbalance in 'tcf_qevent_handle' - unexpected unlock

# https://github.com/0day-ci/linux/commit/7c5fa194990f3016307b41d64095ee09df104e1a
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 7c5fa194990f3016307b41d64095ee09df104e1a
vim +/tcf_qevent_handle +3834 net/sched/cls_api.c

7c5fa194990f30 Petr Machata 2020-06-27  3821  
7c5fa194990f30 Petr Machata 2020-06-27  3822  struct sk_buff *tcf_qevent_handle(struct tcf_qevent *qe, struct Qdisc *sch, struct sk_buff *skb,
7c5fa194990f30 Petr Machata 2020-06-27  3823  				  spinlock_t *root_lock, struct sk_buff **to_free, int *ret)
7c5fa194990f30 Petr Machata 2020-06-27  3824  {
7c5fa194990f30 Petr Machata 2020-06-27  3825  	struct tcf_result cl_res;
7c5fa194990f30 Petr Machata 2020-06-27  3826  	struct tcf_proto *fl;
7c5fa194990f30 Petr Machata 2020-06-27  3827  
7c5fa194990f30 Petr Machata 2020-06-27  3828  	if (!qe->info.block_index)
7c5fa194990f30 Petr Machata 2020-06-27  3829  		return skb;
7c5fa194990f30 Petr Machata 2020-06-27  3830  
7c5fa194990f30 Petr Machata 2020-06-27  3831  	fl = rcu_dereference_bh(qe->filter_chain);
7c5fa194990f30 Petr Machata 2020-06-27  3832  
7c5fa194990f30 Petr Machata 2020-06-27  3833  	if (root_lock)
7c5fa194990f30 Petr Machata 2020-06-27 @3834  		spin_unlock(root_lock);
7c5fa194990f30 Petr Machata 2020-06-27  3835  
7c5fa194990f30 Petr Machata 2020-06-27  3836  	switch (tcf_classify(skb, fl, &cl_res, false)) {
7c5fa194990f30 Petr Machata 2020-06-27  3837  	case TC_ACT_SHOT:
7c5fa194990f30 Petr Machata 2020-06-27  3838  		qdisc_qstats_drop(sch);
7c5fa194990f30 Petr Machata 2020-06-27  3839  		__qdisc_drop(skb, to_free);
7c5fa194990f30 Petr Machata 2020-06-27  3840  		*ret = __NET_XMIT_BYPASS;
7c5fa194990f30 Petr Machata 2020-06-27  3841  		return NULL;
7c5fa194990f30 Petr Machata 2020-06-27  3842  	case TC_ACT_STOLEN:
7c5fa194990f30 Petr Machata 2020-06-27  3843  	case TC_ACT_QUEUED:
7c5fa194990f30 Petr Machata 2020-06-27  3844  	case TC_ACT_TRAP:
7c5fa194990f30 Petr Machata 2020-06-27  3845  		__qdisc_drop(skb, to_free);
7c5fa194990f30 Petr Machata 2020-06-27  3846  		*ret = __NET_XMIT_STOLEN;
7c5fa194990f30 Petr Machata 2020-06-27  3847  		return NULL;
7c5fa194990f30 Petr Machata 2020-06-27  3848  	case TC_ACT_REDIRECT:
7c5fa194990f30 Petr Machata 2020-06-27  3849  		skb_do_redirect(skb);
7c5fa194990f30 Petr Machata 2020-06-27  3850  		*ret = __NET_XMIT_STOLEN;
7c5fa194990f30 Petr Machata 2020-06-27  3851  		return NULL;
7c5fa194990f30 Petr Machata 2020-06-27  3852  	}
7c5fa194990f30 Petr Machata 2020-06-27  3853  
7c5fa194990f30 Petr Machata 2020-06-27  3854  	if (root_lock)
7c5fa194990f30 Petr Machata 2020-06-27  3855  		spin_lock(root_lock);
7c5fa194990f30 Petr Machata 2020-06-27  3856  
7c5fa194990f30 Petr Machata 2020-06-27  3857  	return skb;
7c5fa194990f30 Petr Machata 2020-06-27  3858  }
7c5fa194990f30 Petr Machata 2020-06-27  3859  EXPORT_SYMBOL(tcf_qevent_handle);
7c5fa194990f30 Petr Machata 2020-06-27  3860  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35447 bytes --]