From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Date: Sun, 28 Jun 2020 10:07:45 +0300 Message-ID: <20200628070745.GC6954@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Thierry Reding , Sam Ravnborg , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Dmitry, On Sun, Jun 28, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote: > 27.06.2020 23:43, Laurent Pinchart пишет: > > On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > >> This patch adds missing BUS fields to the display panel descriptions of > >> the panels which are found on NVIDIA Tegra devices: > >> > >> 1. AUO B101AW03 > >> 2. Chunghwa CLAA070WP03XG > >> 3. Chunghwa CLAA101WA01A > >> 4. Chunghwa CLAA101WB01 > >> 5. Innolux N156BGE L21 > >> 6. Samsung LTN101NT05 > >> > >> Suggested-by: Laurent Pinchart > >> Signed-off-by: Dmitry Osipenko > >> --- > >> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > >> index 87edd2bdf09a..986df9937650 100644 > >> --- a/drivers/gpu/drm/panel/panel-simple.c > >> +++ b/drivers/gpu/drm/panel/panel-simple.c > >> @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > >> .width = 223, > >> .height = 125, > >> }, > >> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > > > > Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? > > To be honest I don't know whether it make sense or not for LVDS. I saw > that other LVDS panels in panel-simple.c use the PIXDATA flag and then > looked at what timing diagrams in the datasheets show. I think we should drop DRM_BUS_FLAG_PIXDATA_DRIVE_* for LVDS panels. I'll submit a patch. > > The rest looks good, except the Samsung panel for which I haven't been > > able to locate a datasheet. > > > > Reviewed-by: Laurent Pinchart > > Thanks to you and Sam! -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBB8C433E0 for ; Sun, 28 Jun 2020 07:07:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70C3E21531 for ; Sun, 28 Jun 2020 07:07:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mZWrQiCI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70C3E21531 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A2A36E0AC; Sun, 28 Jun 2020 07:07:52 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 837AA6E0AC for ; Sun, 28 Jun 2020 07:07:51 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F1BE4FB; Sun, 28 Jun 2020 09:07:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593328068; bh=ImFuBGjxJULNuw+yqvo5n5X0F7D3HfmoOWnUOSbRzm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mZWrQiCIL16vCYCEWGXxF5PFUeoYcRNgv6ZlEWX5oTEaRoSS/I30KYB7wW5Rm6RoK fYJznRM9kSQJlgZVYj0L5IQOB0OB+APHvUBdd6OS5lbbZM+bA6YdnbMMhH9jKhBhez ql+XjZI2kMN1PpOp+4cl1EiPcX4gCCbXnXUttJtM= Date: Sun, 28 Jun 2020 10:07:45 +0300 From: Laurent Pinchart To: Dmitry Osipenko Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Message-ID: <20200628070745.GC6954@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgRG1pdHJ5LAoKT24gU3VuLCBKdW4gMjgsIDIwMjAgYXQgMDI6NDQ6MTVBTSArMDMwMCwgRG1p dHJ5IE9zaXBlbmtvIHdyb3RlOgo+IDI3LjA2LjIwMjAgMjM6NDMsIExhdXJlbnQgUGluY2hhcnQg 0L/QuNGI0LXRgjoKPiA+IE9uIE1vbiwgSnVuIDIyLCAyMDIwIGF0IDAxOjI3OjQyQU0gKzAzMDAs IERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+PiBUaGlzIHBhdGNoIGFkZHMgbWlzc2luZyBCVVMg ZmllbGRzIHRvIHRoZSBkaXNwbGF5IHBhbmVsIGRlc2NyaXB0aW9ucyBvZgo+ID4+IHRoZSBwYW5l bHMgd2hpY2ggYXJlIGZvdW5kIG9uIE5WSURJQSBUZWdyYSBkZXZpY2VzOgo+ID4+Cj4gPj4gICAx LiBBVU8gQjEwMUFXMDMKPiA+PiAgIDIuIENodW5naHdhIENMQUEwNzBXUDAzWEcKPiA+PiAgIDMu IENodW5naHdhIENMQUExMDFXQTAxQQo+ID4+ICAgNC4gQ2h1bmdod2EgQ0xBQTEwMVdCMDEKPiA+ PiAgIDUuIElubm9sdXggTjE1NkJHRSBMMjEKPiA+PiAgIDYuIFNhbXN1bmcgTFROMTAxTlQwNQo+ ID4+Cj4gPj4gU3VnZ2VzdGVkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0 QGlkZWFzb25ib2FyZC5jb20+Cj4gPj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9zaXBlbmtvIDxk aWdldHhAZ21haWwuY29tPgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFu ZWwtc2ltcGxlLmMgfCAxMiArKysrKysrKysrKysKPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDEyIGlu c2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwv cGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiA+ PiBpbmRleCA4N2VkZDJiZGYwOWEuLjk4NmRmOTkzNzY1MCAxMDA2NDQKPiA+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiA+PiBAQCAtNjk4LDYgKzY5OCw4IEBAIHN0YXRpYyBj b25zdCBzdHJ1Y3QgcGFuZWxfZGVzYyBhdW9fYjEwMWF3MDMgPSB7Cj4gPj4gIAkJLndpZHRoID0g MjIzLAo+ID4+ICAJCS5oZWlnaHQgPSAxMjUsCj4gPj4gIAl9LAo+ID4+ICsJLmJ1c19mb3JtYXQg PSBNRURJQV9CVVNfRk1UX1JHQjY2Nl8xWDdYM19TUFdHLAo+ID4+ICsJLmJ1c19mbGFncyA9IERS TV9CVVNfRkxBR19ERV9ISUdIIHwgRFJNX0JVU19GTEFHX1BJWERBVEFfRFJJVkVfUE9TRURHRSwK PiA+IAo+ID4gRG9lcyBEUk1fQlVTX0ZMQUdfUElYREFUQV9EUklWRV8qIG1ha2Ugc2Vuc2UgZm9y IExWRFMgPwo+IAo+IFRvIGJlIGhvbmVzdCBJIGRvbid0IGtub3cgd2hldGhlciBpdCBtYWtlIHNl bnNlIG9yIG5vdCBmb3IgTFZEUy4gSSBzYXcKPiB0aGF0IG90aGVyIExWRFMgcGFuZWxzIGluIHBh bmVsLXNpbXBsZS5jIHVzZSB0aGUgUElYREFUQSBmbGFnIGFuZCB0aGVuCj4gbG9va2VkIGF0IHdo YXQgdGltaW5nIGRpYWdyYW1zIGluIHRoZSBkYXRhc2hlZXRzIHNob3cuCgpJIHRoaW5rIHdlIHNo b3VsZCBkcm9wIERSTV9CVVNfRkxBR19QSVhEQVRBX0RSSVZFXyogZm9yIExWRFMgcGFuZWxzLgpJ J2xsIHN1Ym1pdCBhIHBhdGNoLgoKPiA+IFRoZSByZXN0IGxvb2tzIGdvb2QsIGV4Y2VwdCB0aGUg U2Ftc3VuZyBwYW5lbCBmb3Igd2hpY2ggSSBoYXZlbid0IGJlZW4KPiA+IGFibGUgdG8gbG9jYXRl IGEgZGF0YXNoZWV0Lgo+ID4gCj4gPiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1 cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IAo+IFRoYW5rcyB0byB5b3UgYW5kIFNh bSEKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EADDC433DF for ; Sun, 28 Jun 2020 07:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD59520775 for ; Sun, 28 Jun 2020 07:07:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mZWrQiCI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726110AbgF1HHv (ORCPT ); Sun, 28 Jun 2020 03:07:51 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:41900 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbgF1HHv (ORCPT ); Sun, 28 Jun 2020 03:07:51 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F1BE4FB; Sun, 28 Jun 2020 09:07:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593328068; bh=ImFuBGjxJULNuw+yqvo5n5X0F7D3HfmoOWnUOSbRzm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mZWrQiCIL16vCYCEWGXxF5PFUeoYcRNgv6ZlEWX5oTEaRoSS/I30KYB7wW5Rm6RoK fYJznRM9kSQJlgZVYj0L5IQOB0OB+APHvUBdd6OS5lbbZM+bA6YdnbMMhH9jKhBhez ql+XjZI2kMN1PpOp+4cl1EiPcX4gCCbXnXUttJtM= Date: Sun, 28 Jun 2020 10:07:45 +0300 From: Laurent Pinchart To: Dmitry Osipenko Cc: Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Message-ID: <20200628070745.GC6954@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Sun, Jun 28, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote: > 27.06.2020 23:43, Laurent Pinchart пишет: > > On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > >> This patch adds missing BUS fields to the display panel descriptions of > >> the panels which are found on NVIDIA Tegra devices: > >> > >> 1. AUO B101AW03 > >> 2. Chunghwa CLAA070WP03XG > >> 3. Chunghwa CLAA101WA01A > >> 4. Chunghwa CLAA101WB01 > >> 5. Innolux N156BGE L21 > >> 6. Samsung LTN101NT05 > >> > >> Suggested-by: Laurent Pinchart > >> Signed-off-by: Dmitry Osipenko > >> --- > >> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > >> index 87edd2bdf09a..986df9937650 100644 > >> --- a/drivers/gpu/drm/panel/panel-simple.c > >> +++ b/drivers/gpu/drm/panel/panel-simple.c > >> @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > >> .width = 223, > >> .height = 125, > >> }, > >> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > > > > Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? > > To be honest I don't know whether it make sense or not for LVDS. I saw > that other LVDS panels in panel-simple.c use the PIXDATA flag and then > looked at what timing diagrams in the datasheets show. I think we should drop DRM_BUS_FLAG_PIXDATA_DRIVE_* for LVDS panels. I'll submit a patch. > > The rest looks good, except the Samsung panel for which I haven't been > > able to locate a datasheet. > > > > Reviewed-by: Laurent Pinchart > > Thanks to you and Sam! -- Regards, Laurent Pinchart