From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Date: Sun, 28 Jun 2020 09:52:45 +0200 Message-ID: <20200628075245.GA128039@ravnborg.org> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> <20200628070745.GC6954@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200628070745.GC6954-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurent Pinchart Cc: Dmitry Osipenko , Thierry Reding , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Laurent. On Sun, Jun 28, 2020 at 10:07:45AM +0300, Laurent Pinchart wrote: > Hi Dmitry, > > On Sun, Jun 28, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote: > > 27.06.2020 23:43, Laurent Pinchart пишет: > > > On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > > >> This patch adds missing BUS fields to the display panel descriptions of > > >> the panels which are found on NVIDIA Tegra devices: > > >> > > >> 1. AUO B101AW03 > > >> 2. Chunghwa CLAA070WP03XG > > >> 3. Chunghwa CLAA101WA01A > > >> 4. Chunghwa CLAA101WB01 > > >> 5. Innolux N156BGE L21 > > >> 6. Samsung LTN101NT05 > > >> > > >> Suggested-by: Laurent Pinchart > > >> Signed-off-by: Dmitry Osipenko > > >> --- > > >> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > > >> 1 file changed, 12 insertions(+) > > >> > > >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > >> index 87edd2bdf09a..986df9937650 100644 > > >> --- a/drivers/gpu/drm/panel/panel-simple.c > > >> +++ b/drivers/gpu/drm/panel/panel-simple.c > > >> @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > > >> .width = 223, > > >> .height = 125, > > >> }, > > >> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > > >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > > > > > > Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? > > > > To be honest I don't know whether it make sense or not for LVDS. I saw > > that other LVDS panels in panel-simple.c use the PIXDATA flag and then > > looked at what timing diagrams in the datasheets show. > > I think we should drop DRM_BUS_FLAG_PIXDATA_DRIVE_* for LVDS panels. > I'll submit a patch. We should also clean up all the DRM_BUS_FLAG_* one day. No need for the deprecated values, so a few files needs an update. And we could document what flags makes sense for LVDS etc. On the TODO list... Sam > > > > The rest looks good, except the Samsung panel for which I haven't been > > > able to locate a datasheet. > > > > > > Reviewed-by: Laurent Pinchart > > > > Thanks to you and Sam! > > -- > Regards, > > Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A52C433E0 for ; Sun, 28 Jun 2020 07:52:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4151620773 for ; Sun, 28 Jun 2020 07:52:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4151620773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C55B6E081; Sun, 28 Jun 2020 07:52:51 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id B1CB16E081 for ; Sun, 28 Jun 2020 07:52:50 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 0AEF22002B; Sun, 28 Jun 2020 09:52:46 +0200 (CEST) Date: Sun, 28 Jun 2020 09:52:45 +0200 From: Sam Ravnborg To: Laurent Pinchart Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Message-ID: <20200628075245.GA128039@ravnborg.org> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> <20200628070745.GC6954@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200628070745.GC6954@pendragon.ideasonboard.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=P1BnusSwAAAA:8 a=pGLkceISAAAA:8 a=gXmQgUmAU1xYsUhDFicA:9 a=QEXdDO2ut3YA:10 a=D0XLA9XvdZm18NrgonBM:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Dmitry Osipenko , Thierry Reding , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTGF1cmVudC4KCk9uIFN1biwgSnVuIDI4LCAyMDIwIGF0IDEwOjA3OjQ1QU0gKzAzMDAsIExh dXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gSGkgRG1pdHJ5LAo+IAo+IE9uIFN1biwgSnVuIDI4LCAy MDIwIGF0IDAyOjQ0OjE1QU0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+IDI3LjA2 LjIwMjAgMjM6NDMsIExhdXJlbnQgUGluY2hhcnQg0L/QuNGI0LXRgjoKPiA+ID4gT24gTW9uLCBK dW4gMjIsIDIwMjAgYXQgMDE6Mjc6NDJBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+ ID4gPj4gVGhpcyBwYXRjaCBhZGRzIG1pc3NpbmcgQlVTIGZpZWxkcyB0byB0aGUgZGlzcGxheSBw YW5lbCBkZXNjcmlwdGlvbnMgb2YKPiA+ID4+IHRoZSBwYW5lbHMgd2hpY2ggYXJlIGZvdW5kIG9u IE5WSURJQSBUZWdyYSBkZXZpY2VzOgo+ID4gPj4KPiA+ID4+ICAgMS4gQVVPIEIxMDFBVzAzCj4g PiA+PiAgIDIuIENodW5naHdhIENMQUEwNzBXUDAzWEcKPiA+ID4+ICAgMy4gQ2h1bmdod2EgQ0xB QTEwMVdBMDFBCj4gPiA+PiAgIDQuIENodW5naHdhIENMQUExMDFXQjAxCj4gPiA+PiAgIDUuIElu bm9sdXggTjE1NkJHRSBMMjEKPiA+ID4+ICAgNi4gU2Ftc3VuZyBMVE4xMDFOVDA1Cj4gPiA+Pgo+ ID4gPj4gU3VnZ2VzdGVkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlk ZWFzb25ib2FyZC5jb20+Cj4gPiA+PiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgT3NpcGVua28gPGRp Z2V0eEBnbWFpbC5jb20+Cj4gPiA+PiAtLS0KPiA+ID4+ICBkcml2ZXJzL2dwdS9kcm0vcGFuZWwv cGFuZWwtc2ltcGxlLmMgfCAxMiArKysrKysrKysrKysKPiA+ID4+ICAxIGZpbGUgY2hhbmdlZCwg MTIgaW5zZXJ0aW9ucygrKQo+ID4gPj4KPiA+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2lt cGxlLmMKPiA+ID4+IGluZGV4IDg3ZWRkMmJkZjA5YS4uOTg2ZGY5OTM3NjUwIDEwMDY0NAo+ID4g Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jCj4gPiA+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiA+ID4+IEBAIC02OTgsNiAr Njk4LDggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjIGF1b19iMTAxYXcwMyA9IHsK PiA+ID4+ICAJCS53aWR0aCA9IDIyMywKPiA+ID4+ICAJCS5oZWlnaHQgPSAxMjUsCj4gPiA+PiAg CX0sCj4gPiA+PiArCS5idXNfZm9ybWF0ID0gTUVESUFfQlVTX0ZNVF9SR0I2NjZfMVg3WDNfU1BX RywKPiA+ID4+ICsJLmJ1c19mbGFncyA9IERSTV9CVVNfRkxBR19ERV9ISUdIIHwgRFJNX0JVU19G TEFHX1BJWERBVEFfRFJJVkVfUE9TRURHRSwKPiA+ID4gCj4gPiA+IERvZXMgRFJNX0JVU19GTEFH X1BJWERBVEFfRFJJVkVfKiBtYWtlIHNlbnNlIGZvciBMVkRTID8KPiA+IAo+ID4gVG8gYmUgaG9u ZXN0IEkgZG9uJ3Qga25vdyB3aGV0aGVyIGl0IG1ha2Ugc2Vuc2Ugb3Igbm90IGZvciBMVkRTLiBJ IHNhdwo+ID4gdGhhdCBvdGhlciBMVkRTIHBhbmVscyBpbiBwYW5lbC1zaW1wbGUuYyB1c2UgdGhl IFBJWERBVEEgZmxhZyBhbmQgdGhlbgo+ID4gbG9va2VkIGF0IHdoYXQgdGltaW5nIGRpYWdyYW1z IGluIHRoZSBkYXRhc2hlZXRzIHNob3cuCj4gCj4gSSB0aGluayB3ZSBzaG91bGQgZHJvcCBEUk1f QlVTX0ZMQUdfUElYREFUQV9EUklWRV8qIGZvciBMVkRTIHBhbmVscy4KPiBJJ2xsIHN1Ym1pdCBh IHBhdGNoLgoKV2Ugc2hvdWxkIGFsc28gY2xlYW4gdXAgYWxsIHRoZSBEUk1fQlVTX0ZMQUdfKiBv bmUgZGF5LgpObyBuZWVkIGZvciB0aGUgZGVwcmVjYXRlZCB2YWx1ZXMsIHNvIGEgZmV3IGZpbGVz IG5lZWRzIGFuIHVwZGF0ZS4KQW5kIHdlIGNvdWxkIGRvY3VtZW50IHdoYXQgZmxhZ3MgbWFrZXMg c2Vuc2UgZm9yIExWRFMgZXRjLgoKT24gdGhlIFRPRE8gbGlzdC4uLgoKCVNhbQo+IAo+ID4gPiBU aGUgcmVzdCBsb29rcyBnb29kLCBleGNlcHQgdGhlIFNhbXN1bmcgcGFuZWwgZm9yIHdoaWNoIEkg aGF2ZW4ndCBiZWVuCj4gPiA+IGFibGUgdG8gbG9jYXRlIGEgZGF0YXNoZWV0Lgo+ID4gPiAKPiA+ ID4gUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNv bmJvYXJkLmNvbT4KPiA+IAo+ID4gVGhhbmtzIHRvIHlvdSBhbmQgU2FtIQo+IAo+IC0tIAo+IFJl Z2FyZHMsCj4gCj4gTGF1cmVudCBQaW5jaGFydApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D87C433E1 for ; Sun, 28 Jun 2020 07:52:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AFBE20773 for ; Sun, 28 Jun 2020 07:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbgF1Hww (ORCPT ); Sun, 28 Jun 2020 03:52:52 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:43150 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbgF1Hwv (ORCPT ); Sun, 28 Jun 2020 03:52:51 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 0AEF22002B; Sun, 28 Jun 2020 09:52:46 +0200 (CEST) Date: Sun, 28 Jun 2020 09:52:45 +0200 From: Sam Ravnborg To: Laurent Pinchart Cc: Dmitry Osipenko , Thierry Reding , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Message-ID: <20200628075245.GA128039@ravnborg.org> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> <20200628070745.GC6954@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200628070745.GC6954@pendragon.ideasonboard.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=P1BnusSwAAAA:8 a=pGLkceISAAAA:8 a=gXmQgUmAU1xYsUhDFicA:9 a=QEXdDO2ut3YA:10 a=D0XLA9XvdZm18NrgonBM:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent. On Sun, Jun 28, 2020 at 10:07:45AM +0300, Laurent Pinchart wrote: > Hi Dmitry, > > On Sun, Jun 28, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote: > > 27.06.2020 23:43, Laurent Pinchart пишет: > > > On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > > >> This patch adds missing BUS fields to the display panel descriptions of > > >> the panels which are found on NVIDIA Tegra devices: > > >> > > >> 1. AUO B101AW03 > > >> 2. Chunghwa CLAA070WP03XG > > >> 3. Chunghwa CLAA101WA01A > > >> 4. Chunghwa CLAA101WB01 > > >> 5. Innolux N156BGE L21 > > >> 6. Samsung LTN101NT05 > > >> > > >> Suggested-by: Laurent Pinchart > > >> Signed-off-by: Dmitry Osipenko > > >> --- > > >> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > > >> 1 file changed, 12 insertions(+) > > >> > > >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > >> index 87edd2bdf09a..986df9937650 100644 > > >> --- a/drivers/gpu/drm/panel/panel-simple.c > > >> +++ b/drivers/gpu/drm/panel/panel-simple.c > > >> @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > > >> .width = 223, > > >> .height = 125, > > >> }, > > >> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > > >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > > > > > > Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? > > > > To be honest I don't know whether it make sense or not for LVDS. I saw > > that other LVDS panels in panel-simple.c use the PIXDATA flag and then > > looked at what timing diagrams in the datasheets show. > > I think we should drop DRM_BUS_FLAG_PIXDATA_DRIVE_* for LVDS panels. > I'll submit a patch. We should also clean up all the DRM_BUS_FLAG_* one day. No need for the deprecated values, so a few files needs an update. And we could document what flags makes sense for LVDS etc. On the TODO list... Sam > > > > The rest looks good, except the Samsung panel for which I haven't been > > > able to locate a datasheet. > > > > > > Reviewed-by: Laurent Pinchart > > > > Thanks to you and Sam! > > -- > Regards, > > Laurent Pinchart