From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Date: Sun, 28 Jun 2020 11:02:53 +0300 Message-ID: <20200628080253.GD6954@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> <20200628070745.GC6954@pendragon.ideasonboard.com> <20200628075245.GA128039@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200628075245.GA128039-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sam Ravnborg Cc: Dmitry Osipenko , Thierry Reding , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Sam, On Sun, Jun 28, 2020 at 09:52:45AM +0200, Sam Ravnborg wrote: > On Sun, Jun 28, 2020 at 10:07:45AM +0300, Laurent Pinchart wrote: > > On Sun, Jun 28, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote: > >> 27.06.2020 23:43, Laurent Pinchart пишет: > >>> On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > >>>> This patch adds missing BUS fields to the display panel descriptions of > >>>> the panels which are found on NVIDIA Tegra devices: > >>>> > >>>> 1. AUO B101AW03 > >>>> 2. Chunghwa CLAA070WP03XG > >>>> 3. Chunghwa CLAA101WA01A > >>>> 4. Chunghwa CLAA101WB01 > >>>> 5. Innolux N156BGE L21 > >>>> 6. Samsung LTN101NT05 > >>>> > >>>> Suggested-by: Laurent Pinchart > >>>> Signed-off-by: Dmitry Osipenko > >>>> --- > >>>> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > >>>> 1 file changed, 12 insertions(+) > >>>> > >>>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > >>>> index 87edd2bdf09a..986df9937650 100644 > >>>> --- a/drivers/gpu/drm/panel/panel-simple.c > >>>> +++ b/drivers/gpu/drm/panel/panel-simple.c > >>>> @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > >>>> .width = 223, > >>>> .height = 125, > >>>> }, > >>>> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > >>>> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > >>> > >>> Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? > >> > >> To be honest I don't know whether it make sense or not for LVDS. I saw > >> that other LVDS panels in panel-simple.c use the PIXDATA flag and then > >> looked at what timing diagrams in the datasheets show. > > > > I think we should drop DRM_BUS_FLAG_PIXDATA_DRIVE_* for LVDS panels. > > I'll submit a patch. > > We should also clean up all the DRM_BUS_FLAG_* one day. > No need for the deprecated values, so a few files needs an update. > And we could document what flags makes sense for LVDS etc. Where would you add that documentation ? The hardest part is to find a place that will be noticed by developers :-) I've just submitted a patch that adds a WARN_ON to catch similar issues in the panel-simple driver. It's not ideal as we really shouldn't have such code in the kernel, this is something that should be caught as part of the integration process. > On the TODO list... > > >>> The rest looks good, except the Samsung panel for which I haven't been > >>> able to locate a datasheet. > >>> > >>> Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2FA7C433E0 for ; Sun, 28 Jun 2020 08:03:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F91F20773 for ; Sun, 28 Jun 2020 08:03:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SYdIbHiF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F91F20773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 64CCF6E1C0; Sun, 28 Jun 2020 08:02:59 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id E33746E1C0 for ; Sun, 28 Jun 2020 08:02:57 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BE854FB; Sun, 28 Jun 2020 10:02:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593331376; bh=nESMEEzOIRljPa7RAK8ux5xjY76qkCuwalXmm9dYPSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SYdIbHiF9Bq1TVmfEgpI03wV7vnpqn34KS8O128xqXeK3NzTFCd2WZESfCf1WuJqJ T3PTnIEPcI8mp4C/8tfyc827Z0tUoNECApMEfw9ijOV9GLywyXsiHq54f+ABU8MLKL JWgeoyPs2lEZlqlYkU1OIUWNqyX69wli98bOzhBU= Date: Sun, 28 Jun 2020 11:02:53 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Message-ID: <20200628080253.GD6954@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> <20200628070745.GC6954@pendragon.ideasonboard.com> <20200628075245.GA128039@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200628075245.GA128039@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Dmitry Osipenko , Thierry Reding , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgU2FtLAoKT24gU3VuLCBKdW4gMjgsIDIwMjAgYXQgMDk6NTI6NDVBTSArMDIwMCwgU2FtIFJh dm5ib3JnIHdyb3RlOgo+IE9uIFN1biwgSnVuIDI4LCAyMDIwIGF0IDEwOjA3OjQ1QU0gKzAzMDAs IExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBTdW4sIEp1biAyOCwgMjAyMCBhdCAwMjo0 NDoxNUFNICswMzAwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gPj4gMjcuMDYuMjAyMCAyMzo0 MywgTGF1cmVudCBQaW5jaGFydCDQv9C40YjQtdGCOgo+ID4+PiBPbiBNb24sIEp1biAyMiwgMjAy MCBhdCAwMToyNzo0MkFNICswMzAwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gPj4+PiBUaGlz IHBhdGNoIGFkZHMgbWlzc2luZyBCVVMgZmllbGRzIHRvIHRoZSBkaXNwbGF5IHBhbmVsIGRlc2Ny aXB0aW9ucyBvZgo+ID4+Pj4gdGhlIHBhbmVscyB3aGljaCBhcmUgZm91bmQgb24gTlZJRElBIFRl Z3JhIGRldmljZXM6Cj4gPj4+Pgo+ID4+Pj4gICAxLiBBVU8gQjEwMUFXMDMKPiA+Pj4+ICAgMi4g Q2h1bmdod2EgQ0xBQTA3MFdQMDNYRwo+ID4+Pj4gICAzLiBDaHVuZ2h3YSBDTEFBMTAxV0EwMUEK PiA+Pj4+ICAgNC4gQ2h1bmdod2EgQ0xBQTEwMVdCMDEKPiA+Pj4+ICAgNS4gSW5ub2x1eCBOMTU2 QkdFIEwyMQo+ID4+Pj4gICA2LiBTYW1zdW5nIExUTjEwMU5UMDUKPiA+Pj4+Cj4gPj4+PiBTdWdn ZXN0ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJk LmNvbT4KPiA+Pj4+IFNpZ25lZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWls LmNvbT4KPiA+Pj4+IC0tLQo+ID4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1w bGUuYyB8IDEyICsrKysrKysrKysrKwo+ID4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRp b25zKCspCj4gPj4+Pgo+ID4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9w YW5lbC1zaW1wbGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+ID4+ Pj4gaW5kZXggODdlZGQyYmRmMDlhLi45ODZkZjk5Mzc2NTAgMTAwNjQ0Cj4gPj4+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiA+Pj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+ID4+Pj4gQEAgLTY5OCw2ICs2OTgsOCBAQCBz dGF0aWMgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgYXVvX2IxMDFhdzAzID0gewo+ID4+Pj4gIAkJ LndpZHRoID0gMjIzLAo+ID4+Pj4gIAkJLmhlaWdodCA9IDEyNSwKPiA+Pj4+ICAJfSwKPiA+Pj4+ ICsJLmJ1c19mb3JtYXQgPSBNRURJQV9CVVNfRk1UX1JHQjY2Nl8xWDdYM19TUFdHLAo+ID4+Pj4g KwkuYnVzX2ZsYWdzID0gRFJNX0JVU19GTEFHX0RFX0hJR0ggfCBEUk1fQlVTX0ZMQUdfUElYREFU QV9EUklWRV9QT1NFREdFLAo+ID4+PiAKPiA+Pj4gRG9lcyBEUk1fQlVTX0ZMQUdfUElYREFUQV9E UklWRV8qIG1ha2Ugc2Vuc2UgZm9yIExWRFMgPwo+ID4+IAo+ID4+IFRvIGJlIGhvbmVzdCBJIGRv bid0IGtub3cgd2hldGhlciBpdCBtYWtlIHNlbnNlIG9yIG5vdCBmb3IgTFZEUy4gSSBzYXcKPiA+ PiB0aGF0IG90aGVyIExWRFMgcGFuZWxzIGluIHBhbmVsLXNpbXBsZS5jIHVzZSB0aGUgUElYREFU QSBmbGFnIGFuZCB0aGVuCj4gPj4gbG9va2VkIGF0IHdoYXQgdGltaW5nIGRpYWdyYW1zIGluIHRo ZSBkYXRhc2hlZXRzIHNob3cuCj4gPiAKPiA+IEkgdGhpbmsgd2Ugc2hvdWxkIGRyb3AgRFJNX0JV U19GTEFHX1BJWERBVEFfRFJJVkVfKiBmb3IgTFZEUyBwYW5lbHMuCj4gPiBJJ2xsIHN1Ym1pdCBh IHBhdGNoLgo+IAo+IFdlIHNob3VsZCBhbHNvIGNsZWFuIHVwIGFsbCB0aGUgRFJNX0JVU19GTEFH Xyogb25lIGRheS4KPiBObyBuZWVkIGZvciB0aGUgZGVwcmVjYXRlZCB2YWx1ZXMsIHNvIGEgZmV3 IGZpbGVzIG5lZWRzIGFuIHVwZGF0ZS4KPiBBbmQgd2UgY291bGQgZG9jdW1lbnQgd2hhdCBmbGFn cyBtYWtlcyBzZW5zZSBmb3IgTFZEUyBldGMuCgpXaGVyZSB3b3VsZCB5b3UgYWRkIHRoYXQgZG9j dW1lbnRhdGlvbiA/IFRoZSBoYXJkZXN0IHBhcnQgaXMgdG8gZmluZCBhCnBsYWNlIHRoYXQgd2ls bCBiZSBub3RpY2VkIGJ5IGRldmVsb3BlcnMgOi0pCgpJJ3ZlIGp1c3Qgc3VibWl0dGVkIGEgcGF0 Y2ggdGhhdCBhZGRzIGEgV0FSTl9PTiB0byBjYXRjaCBzaW1pbGFyIGlzc3VlcwppbiB0aGUgcGFu ZWwtc2ltcGxlIGRyaXZlci4gSXQncyBub3QgaWRlYWwgYXMgd2UgcmVhbGx5IHNob3VsZG4ndCBo YXZlCnN1Y2ggY29kZSBpbiB0aGUga2VybmVsLCB0aGlzIGlzIHNvbWV0aGluZyB0aGF0IHNob3Vs ZCBiZSBjYXVnaHQgYXMgcGFydApvZiB0aGUgaW50ZWdyYXRpb24gcHJvY2Vzcy4KCj4gT24gdGhl IFRPRE8gbGlzdC4uLgo+Cj4gPj4+IFRoZSByZXN0IGxvb2tzIGdvb2QsIGV4Y2VwdCB0aGUgU2Ft c3VuZyBwYW5lbCBmb3Igd2hpY2ggSSBoYXZlbid0IGJlZW4KPiA+Pj4gYWJsZSB0byBsb2NhdGUg YSBkYXRhc2hlZXQuCj4gPj4+IAo+ID4+PiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8 bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50 IFBpbmNoYXJ0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B610C433DF for ; Sun, 28 Jun 2020 08:03:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BEE720773 for ; Sun, 28 Jun 2020 08:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SYdIbHiF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726178AbgF1IC7 (ORCPT ); Sun, 28 Jun 2020 04:02:59 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:42932 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbgF1IC6 (ORCPT ); Sun, 28 Jun 2020 04:02:58 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BE854FB; Sun, 28 Jun 2020 10:02:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593331376; bh=nESMEEzOIRljPa7RAK8ux5xjY76qkCuwalXmm9dYPSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SYdIbHiF9Bq1TVmfEgpI03wV7vnpqn34KS8O128xqXeK3NzTFCd2WZESfCf1WuJqJ T3PTnIEPcI8mp4C/8tfyc827Z0tUoNECApMEfw9ijOV9GLywyXsiHq54f+ABU8MLKL JWgeoyPs2lEZlqlYkU1OIUWNqyX69wli98bOzhBU= Date: Sun, 28 Jun 2020 11:02:53 +0300 From: Laurent Pinchart To: Sam Ravnborg Cc: Dmitry Osipenko , Thierry Reding , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Message-ID: <20200628080253.GD6954@pendragon.ideasonboard.com> References: <20200621222742.25695-1-digetx@gmail.com> <20200621222742.25695-3-digetx@gmail.com> <20200627204338.GL5966@pendragon.ideasonboard.com> <20200628070745.GC6954@pendragon.ideasonboard.com> <20200628075245.GA128039@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200628075245.GA128039@ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, On Sun, Jun 28, 2020 at 09:52:45AM +0200, Sam Ravnborg wrote: > On Sun, Jun 28, 2020 at 10:07:45AM +0300, Laurent Pinchart wrote: > > On Sun, Jun 28, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote: > >> 27.06.2020 23:43, Laurent Pinchart пишет: > >>> On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote: > >>>> This patch adds missing BUS fields to the display panel descriptions of > >>>> the panels which are found on NVIDIA Tegra devices: > >>>> > >>>> 1. AUO B101AW03 > >>>> 2. Chunghwa CLAA070WP03XG > >>>> 3. Chunghwa CLAA101WA01A > >>>> 4. Chunghwa CLAA101WB01 > >>>> 5. Innolux N156BGE L21 > >>>> 6. Samsung LTN101NT05 > >>>> > >>>> Suggested-by: Laurent Pinchart > >>>> Signed-off-by: Dmitry Osipenko > >>>> --- > >>>> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ > >>>> 1 file changed, 12 insertions(+) > >>>> > >>>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > >>>> index 87edd2bdf09a..986df9937650 100644 > >>>> --- a/drivers/gpu/drm/panel/panel-simple.c > >>>> +++ b/drivers/gpu/drm/panel/panel-simple.c > >>>> @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { > >>>> .width = 223, > >>>> .height = 125, > >>>> }, > >>>> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > >>>> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > >>> > >>> Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ? > >> > >> To be honest I don't know whether it make sense or not for LVDS. I saw > >> that other LVDS panels in panel-simple.c use the PIXDATA flag and then > >> looked at what timing diagrams in the datasheets show. > > > > I think we should drop DRM_BUS_FLAG_PIXDATA_DRIVE_* for LVDS panels. > > I'll submit a patch. > > We should also clean up all the DRM_BUS_FLAG_* one day. > No need for the deprecated values, so a few files needs an update. > And we could document what flags makes sense for LVDS etc. Where would you add that documentation ? The hardest part is to find a place that will be noticed by developers :-) I've just submitted a patch that adds a WARN_ON to catch similar issues in the panel-simple driver. It's not ideal as we really shouldn't have such code in the kernel, this is something that should be caught as part of the integration process. > On the TODO list... > > >>> The rest looks good, except the Samsung panel for which I haven't been > >>> able to locate a datasheet. > >>> > >>> Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart