From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68EE2C433E0 for ; Mon, 29 Jun 2020 07:45:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 331AD23159 for ; Mon, 29 Jun 2020 07:45:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m6R4jWi1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pAz/ZPYE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 331AD23159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lm8Fb8j8vHXmjCiAZoar8BQqicYkl8gbr0YFzn4Tnsw=; b=m6R4jWi1Nr4u6DuqWjhx5/1JO oOx8hUwBd1XwgzXblsbI1KhTFah06uIGoLldZojOAPqkkNhQvmKjTmhCrhYF/8j7FL0HIGcpj286z 3Jc+BZxApK6zVHUEHdEsW0luDn4rmRInuaRWDtOxE+6hKIlboyn8K2iaDVSAv4+puqTDKZ6l/gX71 khD7g4oCwFEIFSaw5bVq25hxzapKo6XAzDwVHbw+QVbkY7D5tJspvSrqOCqJ0zsoxEVqnxfGIe8sg 1uCL5DFoLwJ9TIk3VpMKX7m+EyD/lcNKlN9L36rJxjaPjnOozlNZe6gZEXtRX5j980dCIlV+KBKd9 O9o9Gh25w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpoRv-0004gb-F2; Mon, 29 Jun 2020 07:43:31 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpoRs-0004gJ-KS for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 07:43:29 +0000 Received: by mail-wr1-x441.google.com with SMTP id a6so15482208wrm.4 for ; Mon, 29 Jun 2020 00:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=1sq32oAMuFrxXberw1BKNrHbzi1OK3+z0FC4sQL74aY=; b=pAz/ZPYE7uXU4YYEjEHHPu8m/bh3dmQNZLzGPuccgUDjj4KIDswfVpH6KdQRVRmtIh rgScM7rfEUIRN5CyiCl5Ik6iSsDjS74UmWGOy6YMdjX/BLff3hjIdwIg550RHSHxfZ9a RIr+5sqalGa4Y5RYRI7pd1CUlokFz+XNrXtVohPbEY61IY9CbJqofNEloFXBDbnrMOwH LtPo8jIn/C9zptLX7jIAC/6bH+gL3H3WzRRwt+w2XGQGeBrCwOq38SxPG53d5HykmApN ROMPQvsKttzoEZI84zGb4Jwc/r+WYDcflbLJGSqT1lD0eRoCGU/lY5aP50NcUOWqTxNk AOTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1sq32oAMuFrxXberw1BKNrHbzi1OK3+z0FC4sQL74aY=; b=DysEv1I2QieTlkrq6gEVuAjD3r6FDO3zpZKMgbTnFp/toKsOI1CVFHVQZZiuGKneWg VfeegRL2KEu6FOUtnb/Xp2/HBsVAaGBoNJ91KI7mq3UE1JF+eew6VSXXyTlCiLCawJv+ 1XJuSqloxzxfLTnmdmAeblwdibf3/8V+c4M0glnWB3E6PyANY3/3+c4/IvPhO2JhRl3N Idjiqklf/Vu/Z3Yep8L4fLm72YKZ5f5FtC/gb8fsyNspBU+hf93khTHDE4kYY+vKcDZs o59Hs3aNEedd3X8HiTcNzBZy6abUfb4Nh/rX3a9xySSowgKz6u8Nm8zpxmDlBCKKKOBz UrCw== X-Gm-Message-State: AOAM531ddEs7yGKMRSzB6aeiAcmiTUE6nSHzUrcTcyog/bOZhpfTjFnZ yN6oWz7mZF33llBUKn/MM62zGg== X-Google-Smtp-Source: ABdhPJxT1sVMN+aZdzQqvMgPc3XF+a9fbNx7SqgAirl+kJm8AuQtiP9+nKblPZrqHh8+YtSwV/Lo7Q== X-Received: by 2002:adf:f082:: with SMTP id n2mr16571247wro.326.1593416607481; Mon, 29 Jun 2020 00:43:27 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id y6sm28755120wmy.0.2020.06.29.00.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 00:43:26 -0700 (PDT) Date: Mon, 29 Jun 2020 08:43:24 +0100 From: Lee Jones To: Masahiro Yamada Subject: Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Message-ID: <20200629074324.GG177734@dell> References: <20200623114614.792648-1-yamada.masahiro@socionext.com> <20200623114614.792648-4-yamada.masahiro@socionext.com> <20200623122413.GA954398@dell> <20200624181605.GJ954398@dell> <20200625145726.GT954398@dell> <20200629073617.GF177734@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200629073617.GF177734@dell> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Rob Herring , Linux Kernel Mailing List , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyOSBKdW4gMjAyMCwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBNb24sIDI5IEp1biAy MDIwLCBNYXNhaGlybyBZYW1hZGEgd3JvdGU6Cj4gCj4gPiBPbiBUaHUsIEp1biAyNSwgMjAyMCBh dCAxMTo1NyBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPiB3cm90ZToKPiA+ID4K PiA+ID4gT24gVGh1LCAyNSBKdW4gMjAyMCwgTWFzYWhpcm8gWWFtYWRhIHdyb3RlOgo+ID4gPgo+ ID4gPiA+IE9uIFRodSwgSnVuIDI1LCAyMDIwIGF0IDM6MTYgQU0gTGVlIEpvbmVzIDxsZWUuam9u ZXNAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4gT24gVGh1LCAyNSBKdW4g MjAyMCwgTWFzYWhpcm8gWWFtYWRhIHdyb3RlOgo+ID4gPiA+ID4KPiA+ID4gPiA+ID4gT24gVHVl LCBKdW4gMjMsIDIwMjAgYXQgOToyNCBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3Jn PiB3cm90ZToKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IE9uIFR1ZSwgMjMgSnVuIDIwMjAs IE1hc2FoaXJvIFlhbWFkYSB3cm90ZToKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gJ21h a2UgQVJDSD1hcm0gZHRic19jaGVjaycgZW1pdHMgdGhlIGZvbGxvd2luZyB3YXJuaW5nOgo+ID4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ICAgc3VwcG9ydC1jYXJkQDEsMWYwMDAwMDogJG5v ZGVuYW1lOjA6ICdzdXBwb3J0LWNhcmRAMSwxZjAwMDAwJyBkb2VzIG5vdCBtYXRjaCAnXihidXN8 c29jfGF4aXxhaGJ8YXBiKShAWzAtOWEtZl0rKT8kJwo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ ID4gPiA+IE1heWJlLCBzaW1wbGUtbWZkIGNvdWxkIGJlIGEgYmV0dGVyIGZpdCBmb3IgdGhpcyBk ZXZpY2UuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBUaGUgdHdvIHNob3VsZCBiZSBlcXVp dmFsZW50Lgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBZZXMsIEkga25vdy4KPiA+ID4gPiA+ID4g VGhhdCdzIHdoeSBJIGNhbiBjaGFuZ2UgInNpbXBsZS1idXMiIHRvICJzaW1wbGUtbWZkIgo+ID4g PiA+ID4gPiB3aXRoIG5vIHJpc2suCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFRoZSBkaWZmZXJl bmNlIGlzIHNjaGVtYS1jaGVjay4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gVGhlIG5vZGUgbmFt ZSBmb3IgInNpbXBsZS1idXMiIGlzIGNoZWNrZWQgYnkgJ21ha2UgZHRic19jaGVjaycuCj4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+IFNlZSB0aGlzIGNvZGU6Cj4gPiA+ID4gPiA+IGh0dHBzOi8vZ2l0 aHViLmNvbS9yb2JoZXJyaW5nL2R0LXNjaGVtYS9ibG9iL3YyMDIwLjA1L3NjaGVtYXMvc2ltcGxl LWJ1cy55YW1sI0wxNwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBFdmVuIGlmIEkgcmVuYW1lIHRo ZSBub2RlLCBpdCBkb2VzIG5vdCBhY2NlcHQgdGhlCj4gPiA+ID4gPiA+IHVuaXQgbmFtZSAnMSwx ZjAwMDAwJwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IFdoYXQgZG8geW91IG1lYW4gYnkgIm1h eWJlIj8gIERvZXMgdGhpcyBzcXVhc2ggdGhlIHdhcm5pbmc/Cj4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+ICJtYXliZSIgbWVhbnMgSSBhbSBub3QgcXVpdGUgc3VyZQo+ID4gPiA+ID4gPiB3aGljaCBj b21wYXRpYmxlIGlzIGEgYmV0dGVyIGZpdAo+ID4gPiA+ID4gPiB0byBkZXNjcmliZSB0aGlzIGRl dmljZS4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gQXMgbWVudGlvbmVkIGFib3ZlLCBzaW1wbGUt YnVzIGFuZCBzaW1wbGUtbWZkCj4gPiA+ID4gPiA+IGFyZSBpbnRlcmNoYW5nZWFibGUgZnJvbSBh IGRyaXZlciBwb2ludCBvZiB2aWV3Lgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBUaGlzIGFkZC1v biBib2FyZCBpcyBpbnRlZ3JhdGVkIHdpdGggdmFyaW91cyBwZXJpcGhlcmFscwo+ID4gPiA+ID4g PiBzdWNoIGFzIDE2NTUwYSBzZXJpYWwsIHNtc2M5MTE1IGV0aGVyIGV0Yy4KPiA+ID4gPiA+ID4g VGhlIGFkZHJlc3MtZGVjb2RlIGlzIGltcGxlbWVudGVkIGluIGEgQ1BMRCBkZXZpY2UuCj4gPiA+ ID4gPiA+IEl0IGhhcyBjaGlwIHNlbGVjdHMgYW5kIGxvY2FsIGFkZHJlc3Nlcywgd2hpY2ggYXJl IG1hcHBlZCB0bwo+ID4gPiA+ID4gPiB0aGUgcGFyZW50Lgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiBJdCBjYW4gYmUgZWl0aGVyIHNpbXBsZS1idXMgb3Igc2ltcGxlLW1mZCwgSSB0aGluay4KPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gZHQtc2NoZW1hIGNoZWNrcyB0aGUgbm9k ZSBuYW1lIG9mIHNpbXBsZS1idXMuCj4gPiA+ID4gPiA+IEN1cnJlbnRseSwgdGhlcmUgaXMgbm8g Y2hlY2sgZm9yIHNpbXBsZS1tZmQuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFNvLCBJIHRoaW5r IHRoaXMgcGF0Y2ggaXMgYW4gZWFzeSBzb2x1dGlvbgo+ID4gPiA+ID4gPiB0byBmaXggdGhlIHdh cm5pbmcuCj4gPiA+ID4gPgo+ID4gPiA+ID4gWWVzLCBsb29raW5nIGF0IHRoZSBkb2N1bWVudGF0 aW9uIGl0IHNlZW1zIGFzIHRob3VnaCAnc2ltcGxlLW1mZCcKPiA+ID4gPiA+IHdvdWxkIGJlIGEg YmV0dGVyIGZpdC4gIElzIHRoZSBkZXZpY2UgYSBzaW5nbGUgSVAgd2l0aCB2YXJpb3VzCj4gPiA+ ID4gPiBkaWZmZXJlbnQgZnVuY3Rpb25zPwo+ID4gPiA+Cj4gPiA+ID4gTm90IGFuIElQLgo+ID4g PiA+Cj4gPiA+ID4gVGhpcyBpcyBhIHNtYWxsIGJvYXJkIHRoYXQgY29uc2lzdHMgb2YKPiA+ID4g PiBhIENQTEQgKyBldGhlcm5ldCBjb250cm9sbGVyICsgc2VyaWFsIGNvbnRyb2xsZXIgKyBMRUQs IGV0Yy4KPiA+ID4KPiA+ID4gVGhlbiBzaW1wbGUgTUZEIGRvZXMgbm90IHNlZW0gbGlrZSBhIGdv b2QgZml0Lgo+ID4gPgo+ID4gPiBOZWl0aGVyIGRvZXMgJ3NpbXBsZS1idXMnLgo+ID4gCj4gPiBU aGVuLCBJIGRvIG5vdCBrbm93IHdoYXQgdG8gZG8uCj4gPiAKPiA+IAo+ID4gVGhpcyBib2FyZCBj b25uZWN0aW9uIGlzIHNvIHNpbXBsZQo+ID4gdGhhdCBubyBoYXJkd2FyZSBpbml0aWFsaXphdGlv biBuZWVkZWQgdG8gZ2V0IGFjY2Vzcwo+ID4gdG8gcGVyaXBoZXJhbHMuCj4gPiAKPiA+IFNvLCAn c2ltcGxlLWJ1cycgb3IgJ3NpbXBsZS1tZmQnIGlzIHByZWZlcnJlZC4KPiA+IAo+ID4gSWYgdGhp cyBpcyBub3QgZWl0aGVyIHNpbXBsZS1idXMgb3Igc2ltcGxlLW1mZCwKPiA+IEkgbmVlZCBhIHNw ZWNpYWwgZHJpdmVyIHRvIHByb2JlIHRoZQo+ID4gY2hpbGQgZGV2aWNlcyBzdWNoIGFzIGV0aGVy bmV0LCBzZXJpYWwgZXRjLgo+ID4gCj4gPiAKPiA+IAo+ID4gPiBXaGF0IGlzIGl0IHlvdSdyZSB0 cnlpbmcgdG8gZGVzY3JpYmUgaW4gdGhlIGRldmljZSBoaWVyYXJjaHk/Cj4gPiAKPiA+IAo+ID4g VGhlIGNvbm5lY3Rpb24gaXMgYXMgZm9sbG93czoKPiA+IAo+ID4gCj4gPiB8LU1haW4gYm9hcmQg LXwgICAgICB8LS0tLS0gYWRkLW9uIGJvYXJkIC0tLS18Cj4gPiB8ICAgICAgICAgICAgIHwgICAg ICB8ICAgICAodGhpcyBib2FyZCkgICAgICB8Cj4gPiB8ICAgICAgICAgICAgIHwgICAgICB8ICAg ICAgICAgICAgICAgICAgICAgICB8Cj4gPiB8ICAgIChTb0MpIC0tLXwtLS0tLS18LS0tIENQTEQg LS0tIGV0aGVybmV0ICB8Cj4gPiB8ICAgICAgICAgICAgIHwgICAgICB8ICAgICAgICAgIHwtIHNl cmlhbCAgICB8Cj4gPiB8LS0tLS0tLS0tLS0tLXwgICAgICB8ICAgICAgICAgIHwtIExFRCAgICAg ICB8Cj4gPiAgICAgICAgICAgICAgICAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICB8Cj4g PiAgICAgICAgICAgICAgICAgICAgICB8LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS18Cj4gPiAKPiA+ IAo+ID4gCj4gPiB1bmlwaGllci1zdXBwb3J0LWNhcmQuZHRzaSBkZXNjcmliZXMgdGhlCj4gPiAi YWRkLW9uIGJvYXJkIiBwYXJ0Lgo+ID4gQWRkcmVzcy1kZWNvZGUgaXMgaW1wbGVtZW50ZWQgaW4g Q1BMRC4KPiA+IAo+ID4gCj4gPiBTbywgdGhlIGNyaXRlcmlhIHRvIGJlY29tZSBNRkQgaXMKPiA+ IHdoZXRoZXIgaXQgaXMgYW4gSVAgaW50ZWdyYXRlZCBpbnRvIFNvQy4KPiA+IAo+ID4gCj4gPiAt IGltcGxlbWVudGVkIGluIGFuIFNvQyAgLS0+IE1GRAo+IAo+IElmCj4gCj4gIHMvaW4gYW4gU29D L2luIGEgc2luZ2xlIHBpZWNlIG9mIHNpbGljb24vCj4gCj4gLi4uIHRoZW4geWVzLgo+IAo+ID4g LSBpbXBsZW1lbnRlZCBpbiBhIGJvYXJkICsgQ1BMRCAgLS0+IG5vdCBNRkQKPiA+IAo+ID4gUmln aHQ/Cj4gCj4gUmlnaHQuICBVbmxlc3MgYWxsIEgvVyBpcyByZXByZXNlbnRlZCBpbnNpZGUgdGhl IENQTEQsIGluIHdoaWNoIGNhc2UKPiB0aGUgQ1BMRCBpcywgaW4gdGhlb3J5LCB0aGUgTUZELiAg QWx0aG91Z2gsIGR1ZSB0byB0aGUgbmF0dXJlIG9mCj4gQ1BMRHMsIHRoaXMgaXMgYSBzbGlwcGVy eSBzbG9wZS4KPiAKPiBZb3UgbWF5IHdhbnQgc29tZXRoaW5nIGxpa2U6Cj4gCj4gICBhcmNoL2Fy bTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1yb2MtcGMtbWV6emFuaW5lLmR0cwo+IAo+IC4u LiB3aGVyZSB0aGUgYWRkLW9uIGJvYXJkIGlzIHJlcHJlc2VudGVkIHNlcGFyYXRlbHkgKG5vdCBp biB0aGUKPiBzYW1lIGhpZXJhcmNoaWNhbCBzdHJ1Y3R1cmUgYXMgdGhlIG1haW4gYm9hcmQuICBU aGUgbWFpbiBib2FyZCBpcyB0aGVuCj4gaW5jbHVkZWQgYXMgYSBEVFNJIGZyb20gdGhlIGFkZC1v biBib2FyZC4KPiAKPiBJdCBtaWdodCBhbHNvIGJlIHdvcnRoIGxvb2tpbmcgYXQgaG93IGNvbnN1 bWVyIGJvYXJkcyBzdWNoIGFzIHRoZQo+IFJhc3BiZXJyeVBpLCBCZWFnbGVCb2FyZCBhbmQgdGhl IGxpa2UgaGFuZGxlIHRoZWlyIGFkZC1vbiBib2FyZHMsCj4gbWV6emFuaW5lcywgY2FwZXMsIGhh dHMsIGV0Yy4KCkFub3RoZXIgb3B0aW9uOyBpZiB0aGUgYWRkLW9uIGJvYXJkIFBDQiByZWFsbHkg ZG9lc24ndCBkbyBhbnl0aGluZwpleGNlcHQgcHJvdmlkZSBzb21lIGNvcHBlciBsaW5lcyB0byB0 aGUgb24tYm9hcmQgY29tcG9uZW50cywgdGhlbiBkb2VzCml0IG5lZWQgcmVwcmVzZW50aW5nIGlu IERldmljZSBUcmVlIGF0IGFsbD8gIEkgc3VnZ2VzdCBub3QuCgpZb3VyIGlzc3VlIHdpbGwgY29t ZSB3aGVuIHlvdSB3YW50IHRvIHN3YXAgb3V0IHRoYXQgYm9hcmQgYW5kIGluc2VydAphbm90aGVy LCB3aGljaCBjb250YWlucyBkaWZmZXJlbnQgZnVuY3Rpb25hbGl0eS4gIFRoaXMgaXMgd2h5IGl0 IHdvdWxkCmJlIGJldHRlciB0byByZXByZXNlbnQgdGhlIHdob2xlIGJvYXJkIGFzIGFuIG9ydGhv Z29uYWwgKi5kdHMgZmlsZS4KV2hldGhlciB5b3UgZGVjaWRlIHRvIGxheSBpdCBvdXQgYXMgaXQn cyBvd24gYm9hcmQgKGFzIGFib3ZlKSBvciBhcwpjaGlsZHJlbiB0byB0aGUgc3lzdGVtLWJ1cyB3 aWxsIGJlIHVwIHRvIHlvdS4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2hu aWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNl IHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIg fCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C77C433DF for ; Mon, 29 Jun 2020 20:55:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E58392071A for ; Mon, 29 Jun 2020 20:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pAz/ZPYE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731037AbgF2Uz3 (ORCPT ); Mon, 29 Jun 2020 16:55:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731294AbgF2TNM (ORCPT ); Mon, 29 Jun 2020 15:13:12 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFD16C0A893E for ; Mon, 29 Jun 2020 00:43:28 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id k6so15487269wrn.3 for ; Mon, 29 Jun 2020 00:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=1sq32oAMuFrxXberw1BKNrHbzi1OK3+z0FC4sQL74aY=; b=pAz/ZPYE7uXU4YYEjEHHPu8m/bh3dmQNZLzGPuccgUDjj4KIDswfVpH6KdQRVRmtIh rgScM7rfEUIRN5CyiCl5Ik6iSsDjS74UmWGOy6YMdjX/BLff3hjIdwIg550RHSHxfZ9a RIr+5sqalGa4Y5RYRI7pd1CUlokFz+XNrXtVohPbEY61IY9CbJqofNEloFXBDbnrMOwH LtPo8jIn/C9zptLX7jIAC/6bH+gL3H3WzRRwt+w2XGQGeBrCwOq38SxPG53d5HykmApN ROMPQvsKttzoEZI84zGb4Jwc/r+WYDcflbLJGSqT1lD0eRoCGU/lY5aP50NcUOWqTxNk AOTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1sq32oAMuFrxXberw1BKNrHbzi1OK3+z0FC4sQL74aY=; b=nNTVgTm9nKpz2PvcMHV+BPcxrkZid7Nxxbak446fO1Nj1ohq2d8CRj/F07zKKFAh8f ogT62NRdEejN+Yl3Y7L5DBdtiaIbBytUnYZRWvS3zF8JkwgQMxQ6DBDB/OLT6+ECIOaO UONSS38WimYO1U0rL2QkBjL8422hNeQny3MyG9r2G25Ooi0HiDZx59drmmwzlqdarIn5 +rvn8vSHy5148m/Pl/+CxkugmkhUWSnCZlwddrF9dhEsWlqcK/HhT5ZtKsJf4Y7vbymt 0juFh9SWG95IRNp4F9Cd8wB47qzn1XisFK7ENZDwjPIJPKWWsptHfSEpECInHqynRIRP 2kRg== X-Gm-Message-State: AOAM531osHfmO7PRYQ3IKRwR9n5tNXa++q//+WK5wRXSip7rzKwYerJx DKUGtRN5Oz7co8uV3itlCLGXSQ== X-Google-Smtp-Source: ABdhPJxT1sVMN+aZdzQqvMgPc3XF+a9fbNx7SqgAirl+kJm8AuQtiP9+nKblPZrqHh8+YtSwV/Lo7Q== X-Received: by 2002:adf:f082:: with SMTP id n2mr16571247wro.326.1593416607481; Mon, 29 Jun 2020 00:43:27 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id y6sm28755120wmy.0.2020.06.29.00.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 00:43:26 -0700 (PDT) Date: Mon, 29 Jun 2020 08:43:24 +0100 From: Lee Jones To: Masahiro Yamada Cc: linux-arm-kernel , Rob Herring , DTML , Linux Kernel Mailing List Subject: Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Message-ID: <20200629074324.GG177734@dell> References: <20200623114614.792648-1-yamada.masahiro@socionext.com> <20200623114614.792648-4-yamada.masahiro@socionext.com> <20200623122413.GA954398@dell> <20200624181605.GJ954398@dell> <20200625145726.GT954398@dell> <20200629073617.GF177734@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200629073617.GF177734@dell> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 29 Jun 2020, Lee Jones wrote: > On Mon, 29 Jun 2020, Masahiro Yamada wrote: > > > On Thu, Jun 25, 2020 at 11:57 PM Lee Jones wrote: > > > > > > On Thu, 25 Jun 2020, Masahiro Yamada wrote: > > > > > > > On Thu, Jun 25, 2020 at 3:16 AM Lee Jones wrote: > > > > > > > > > > On Thu, 25 Jun 2020, Masahiro Yamada wrote: > > > > > > > > > > > On Tue, Jun 23, 2020 at 9:24 PM Lee Jones wrote: > > > > > > > > > > > > > > On Tue, 23 Jun 2020, Masahiro Yamada wrote: > > > > > > > > > > > > > > > 'make ARCH=arm dtbs_check' emits the following warning: > > > > > > > > > > > > > > > > support-card@1,1f00000: $nodename:0: 'support-card@1,1f00000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > > > > > > > > > > > > > > > Maybe, simple-mfd could be a better fit for this device. > > > > > > > > > > > > > > The two should be equivalent. > > > > > > > > > > > > Yes, I know. > > > > > > That's why I can change "simple-bus" to "simple-mfd" > > > > > > with no risk. > > > > > > > > > > > > The difference is schema-check. > > > > > > > > > > > > The node name for "simple-bus" is checked by 'make dtbs_check'. > > > > > > > > > > > > See this code: > > > > > > https://github.com/robherring/dt-schema/blob/v2020.05/schemas/simple-bus.yaml#L17 > > > > > > > > > > > > Even if I rename the node, it does not accept the > > > > > > unit name '1,1f00000' > > > > > > > > > > > > > What do you mean by "maybe"? Does this squash the warning? > > > > > > > > > > > > "maybe" means I am not quite sure > > > > > > which compatible is a better fit > > > > > > to describe this device. > > > > > > > > > > > > As mentioned above, simple-bus and simple-mfd > > > > > > are interchangeable from a driver point of view. > > > > > > > > > > > > This add-on board is integrated with various peripherals > > > > > > such as 16550a serial, smsc9115 ether etc. > > > > > > The address-decode is implemented in a CPLD device. > > > > > > It has chip selects and local addresses, which are mapped to > > > > > > the parent. > > > > > > > > > > > > It can be either simple-bus or simple-mfd, I think. > > > > > > > > > > > > > > > > > > dt-schema checks the node name of simple-bus. > > > > > > Currently, there is no check for simple-mfd. > > > > > > > > > > > > So, I think this patch is an easy solution > > > > > > to fix the warning. > > > > > > > > > > Yes, looking at the documentation it seems as though 'simple-mfd' > > > > > would be a better fit. Is the device a single IP with various > > > > > different functions? > > > > > > > > Not an IP. > > > > > > > > This is a small board that consists of > > > > a CPLD + ethernet controller + serial controller + LED, etc. > > > > > > Then simple MFD does not seem like a good fit. > > > > > > Neither does 'simple-bus'. > > > > Then, I do not know what to do. > > > > > > This board connection is so simple > > that no hardware initialization needed to get access > > to peripherals. > > > > So, 'simple-bus' or 'simple-mfd' is preferred. > > > > If this is not either simple-bus or simple-mfd, > > I need a special driver to probe the > > child devices such as ethernet, serial etc. > > > > > > > > > What is it you're trying to describe in the device hierarchy? > > > > > > The connection is as follows: > > > > > > |-Main board -| |----- add-on board ----| > > | | | (this board) | > > | | | | > > | (SoC) ---|------|--- CPLD --- ethernet | > > | | | |- serial | > > |-------------| | |- LED | > > | | > > |-----------------------| > > > > > > > > uniphier-support-card.dtsi describes the > > "add-on board" part. > > Address-decode is implemented in CPLD. > > > > > > So, the criteria to become MFD is > > whether it is an IP integrated into SoC. > > > > > > - implemented in an SoC --> MFD > > If > > s/in an SoC/in a single piece of silicon/ > > ... then yes. > > > - implemented in a board + CPLD --> not MFD > > > > Right? > > Right. Unless all H/W is represented inside the CPLD, in which case > the CPLD is, in theory, the MFD. Although, due to the nature of > CPLDs, this is a slippery slope. > > You may want something like: > > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts > > ... where the add-on board is represented separately (not in the > same hierarchical structure as the main board. The main board is then > included as a DTSI from the add-on board. > > It might also be worth looking at how consumer boards such as the > RaspberryPi, BeagleBoard and the like handle their add-on boards, > mezzanines, capes, hats, etc. Another option; if the add-on board PCB really doesn't do anything except provide some copper lines to the on-board components, then does it need representing in Device Tree at all? I suggest not. Your issue will come when you want to swap out that board and insert another, which contains different functionality. This is why it would be better to represent the whole board as an orthogonal *.dts file. Whether you decide to lay it out as it's own board (as above) or as children to the system-bus will be up to you. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog