Re: [PATCH] drm: panel: simple: Drop drive/sample bus flags for LVDS panels

From: Dmitry Osipenko <digetx@gmail.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Liu Ying <victor.liu@nxp.com>,
	dri-devel@lists.freedesktop.org,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Pascal Roeleven <dev@pascalroeleven.nl>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] drm: panel: simple: Drop drive/sample bus flags for LVDS panels
Date: Mon, 29 Jun 2020 07:43:40 +0300	[thread overview]
Message-ID: <20200629074340.11b427cc@dimatab> (raw)
In-Reply-To: <20200628075401.10975-1-laurent.pinchart+renesas@ideasonboard.com>

В Sun, 28 Jun 2020 10:54:01 +0300
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> пишет:

> The DRM bus flags reporting on which clock edge the pixel data and
> sync signals are sampled or driven don't make sense for LVDS panels,
> as the bus then uses sub-clock timings to send data. Drop those flags
> and add a warning in the probe function to make sure the mistake
> won't be repeated.
> 
> Signed-off-by: Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> ---
>  drivers/gpu/drm/panel/panel-simple.c | 30
> +++++++++++++++++----------- 1 file changed, 18 insertions(+), 12
> deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index
> bff1cab529d2..537d75ef7fc2 100644 ---
> a/drivers/gpu/drm/panel/panel-simple.c +++
> b/drivers/gpu/drm/panel/panel-simple.c @@ -549,6 +549,14 @@ static
> int panel_simple_probe(struct device *dev, const struct panel_desc
> *desc) panel_simple_parse_panel_timing_node(dev, panel, &dt); }
>  
> +	if (desc->connector_type == DRM_MODE_CONNECTOR_LVDS)
> +		/* Catch common mistakes for LVDS panels. */
> +		WARN_ON(desc->bus_flags &
> +			(DRM_BUS_FLAG_PIXDATA_POSEDGE |
> +			 DRM_BUS_FLAG_PIXDATA_NEGEDGE |
> +			 DRM_BUS_FLAG_SYNC_POSEDGE |
> +			 DRM_BUS_FLAG_SYNC_NEGEDGE));

Very nice! Thank you!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel