From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EADC433DF for ; Mon, 29 Jun 2020 08:16:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64AB923357 for ; Mon, 29 Jun 2020 08:16:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="weXUUnk2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wArtOsXx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64AB923357 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eTkWRlSR3IAsoTIV6STSlEN7lBblemXT9IzDs+qyoKA=; b=weXUUnk2c4nAfoug+nVrqoNRr tI9yaoiiMeMjtdDRGxP8MKGzDvFQfGem7N22LywJY+MU3pVA9kuZ+SXV2nni+J/+sfbdAqRQFRYvb 5KtducA+oQkFVxcGS7sGjaLxkfVke/elGtnLGpbjHnTi5nbR95TaJJTGYe96rKe5jqziBtEpB8GgH QBrg3sflmIOUbDnk4+f8l/fmC3GKjn0qDhrxREjv0C63+nhUbCjd49PslM6nBS6gvgkJZyIZUEJM9 8iavBgv9Pt6eXrGH5Zio8ojIXaNfXOsfZMzx2wpzxHNFcRZ8JeyiTzE47SLON1tIvw2v7rNLQToQ0 Gjeb14VrA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpow7-0001Zy-DG; Mon, 29 Jun 2020 08:14:43 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpow4-0001ZL-FX for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 08:14:41 +0000 Received: by mail-wm1-x343.google.com with SMTP id f139so15174879wmf.5 for ; Mon, 29 Jun 2020 01:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Eu8OtrlLnu2y39+RYRYUmyijmTp/DaN6tPPo1iZ5gVo=; b=wArtOsXxZjgrh5I1yKTeEpd/qgfBAs/GpVy7kBtRJjUPuu9WXbEtQnJs8nURZSV9o/ 76XbYrZGmTHpxyW9hEIi32LRersdf4EgYNqwt8/8AHZ/50VmfVs1IteEKmwvbYW1q3Rc dRPFVL0FH9Zg1kyLRIEVrnuaFtGPN5wZuxKs7ZAKd0Zh85UD4WFZtN+TrE7e3UkhgpP8 fJ1+JUsP7VcBo+TmeNi7wCdmsslAhUfRAmSf158OeIdWPP0NPxlnyb2yU9jPRb68tWjv MXdS88FKuoqTp6cJrvZgBzCyUnUxobcRslifswcwmk3HWJ1twxG8IpdUZHQeyk2Esopk mUqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Eu8OtrlLnu2y39+RYRYUmyijmTp/DaN6tPPo1iZ5gVo=; b=GJvQhS7ZSX9eb9HOkAHfpBwKyd9nLKVsr1pNZZSr1VwPV0CH0T71BWeJgHIpupDFBw 3svqxihNH0haCQ1o/HCHhXFSDZOYVkG52kkWNVmMR/ztkDsBvAmlbZM5WyRsjOs1BN/Q 8bmmawYmwWtDt9AOhGXnLC0RIU1TMvJQXSP1kGv8+o1DaTTU7CcHJvewaOA0+4f9TV/r 2oI1Q2BN+hNCS2uC7t5EVd6eg0N7vYWUf5kivtmqPLQOkLDTSCuxGKHhRcMQ8f9gX9dp 2Wklm1xzfPXRU/uXxb8YjqTw1EzGTlmashGbnSWb0msdxf76UmqkIczgs5fluT0u0Fia BdEw== X-Gm-Message-State: AOAM532Amp+/uCgRW+WgLT6dPbcjoIKQkd7LJN74EpDLJT/c9y1N4bIo Ioo47JQY8nd80+Qmn/MvERlyPpR6r1Q= X-Google-Smtp-Source: ABdhPJx3bP6Cpaq/EZ+1Uho3iFBaMLJrhrRGmtfXOZl+wrkBz1dt2CXCgSbGUBhftwy3njQHvPCCTw== X-Received: by 2002:a1c:b182:: with SMTP id a124mr14791259wmf.114.1593418479525; Mon, 29 Jun 2020 01:14:39 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id 22sm11577124wmb.11.2020.06.29.01.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 01:14:38 -0700 (PDT) Date: Mon, 29 Jun 2020 09:14:36 +0100 From: Lee Jones To: Wolfram Sang Subject: Re: [PATCH 06/10] misc: eeprom: eeprom_93cx6: Repair function arg descriptions Message-ID: <20200629081436.GH177734@dell> References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-7-lee.jones@linaro.org> <20200627203357.GA954@ninjato> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200627203357.GA954@ninjato> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCAyNyBKdW4gMjAyMCwgV29sZnJhbSBTYW5nIHdyb3RlOgoKPiA+IEBAIC0yNzAsNyAr MjcwLDcgQEAgRVhQT1JUX1NZTUJPTF9HUEwoZWVwcm9tXzkzY3g2X3JlYWRiKTsKPiA+ICAgKiBA ZWVwcm9tOiBQb2ludGVyIHRvIGVlcHJvbSBzdHJ1Y3R1cmUKPiA+ICAgKiBAYnl0ZTogSW5kZXgg ZnJvbSB3aGVyZSB3ZSBzaG91bGQgc3RhcnQgcmVhZGluZwo+ID4gICAqIEBkYXRhOiB0YXJnZXQg cG9pbnRlciB3aGVyZSB0aGUgaW5mb3JtYXRpb24gd2lsbCBoYXZlIHRvIGJlIHN0b3JlZAo+ID4g LSAqIEB3b3JkczogTnVtYmVyIG9mIGJ5dGVzIHRoYXQgc2hvdWxkIGJlIHJlYWQuCj4gPiArICog QGJ5dGVzOiBOdW1iZXIgb2YgYnl0ZXMgdGhhdCBzaG91bGQgYmUgcmVhZC4KPiAKPiBOb3cgd2Ug aGF2ZSAnYnl0ZScgYW5kICdieXRlcycgaGVyZSBhcyBhcmd1bWVudHMgd2hpY2ggaXMgY29uZnVz aW5nLiBJCj4gdGhpbmsgcmVuYW1pbmcgJ3dvcmRzJyBpbnRvICdudW1fYnl0ZXMnIHdvdWxkIGJl IGV2ZW4gYmV0dGVyLgoKSSBhd2FpdCB5b3VyIHBhdGNoIHdpdGggYmF0ZWQgYnJlYXRoLiA6KQoK LS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9w ZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBT b0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F9FC433DF for ; Mon, 29 Jun 2020 19:13:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 289FF206E2 for ; Mon, 29 Jun 2020 19:13:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wArtOsXx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731302AbgF2TNO (ORCPT ); Mon, 29 Jun 2020 15:13:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731105AbgF2TMo (ORCPT ); Mon, 29 Jun 2020 15:12:44 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6CC3C014A49 for ; Mon, 29 Jun 2020 01:14:40 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id f18so15194506wml.3 for ; Mon, 29 Jun 2020 01:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Eu8OtrlLnu2y39+RYRYUmyijmTp/DaN6tPPo1iZ5gVo=; b=wArtOsXxZjgrh5I1yKTeEpd/qgfBAs/GpVy7kBtRJjUPuu9WXbEtQnJs8nURZSV9o/ 76XbYrZGmTHpxyW9hEIi32LRersdf4EgYNqwt8/8AHZ/50VmfVs1IteEKmwvbYW1q3Rc dRPFVL0FH9Zg1kyLRIEVrnuaFtGPN5wZuxKs7ZAKd0Zh85UD4WFZtN+TrE7e3UkhgpP8 fJ1+JUsP7VcBo+TmeNi7wCdmsslAhUfRAmSf158OeIdWPP0NPxlnyb2yU9jPRb68tWjv MXdS88FKuoqTp6cJrvZgBzCyUnUxobcRslifswcwmk3HWJ1twxG8IpdUZHQeyk2Esopk mUqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Eu8OtrlLnu2y39+RYRYUmyijmTp/DaN6tPPo1iZ5gVo=; b=NINxGnrPhpcwUFxXZogvtcvUELgg3USRki2aGiAFegePskf5/nuXrrEp2Z2zfpocfb UmhLfiMchgLrhXU8bYQ57/d72fzfG59QIJAA5Er24ApEo3G+XZ3tHzsTPjItu4mnfbE3 rYZiTOZdRLdivqGJIYMw3rJ6lGEuylr2TfQgvhosP78vMvlqwn7JlJPpYzq0ImTVXSgF fPNefNUvYfOCjtp3Z2TlX/2VIxSYQ+A3CP+WOgrfH2vfhKl0x3N5Lfl0z0d8tVuFV3d6 apz/U82owPxubqyzicZKQ58mttYavLWcLWgWVKCjgPEewFJ0Y+7r5h/tc0X4O7NJV+mU I+QA== X-Gm-Message-State: AOAM530clobfdF2+aJjMGCQ+M6IFSA8DkltXWbqyPPo1nF42wWWfvMk1 DCihNTZIUQG+U02IXqJUQxbmtg== X-Google-Smtp-Source: ABdhPJx3bP6Cpaq/EZ+1Uho3iFBaMLJrhrRGmtfXOZl+wrkBz1dt2CXCgSbGUBhftwy3njQHvPCCTw== X-Received: by 2002:a1c:b182:: with SMTP id a124mr14791259wmf.114.1593418479525; Mon, 29 Jun 2020 01:14:39 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id 22sm11577124wmb.11.2020.06.29.01.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 01:14:38 -0700 (PDT) Date: Mon, 29 Jun 2020 09:14:36 +0100 From: Lee Jones To: Wolfram Sang Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] misc: eeprom: eeprom_93cx6: Repair function arg descriptions Message-ID: <20200629081436.GH177734@dell> References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-7-lee.jones@linaro.org> <20200627203357.GA954@ninjato> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200627203357.GA954@ninjato> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Jun 2020, Wolfram Sang wrote: > > @@ -270,7 +270,7 @@ EXPORT_SYMBOL_GPL(eeprom_93cx6_readb); > > * @eeprom: Pointer to eeprom structure > > * @byte: Index from where we should start reading > > * @data: target pointer where the information will have to be stored > > - * @words: Number of bytes that should be read. > > + * @bytes: Number of bytes that should be read. > > Now we have 'byte' and 'bytes' here as arguments which is confusing. I > think renaming 'words' into 'num_bytes' would be even better. I await your patch with bated breath. :) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog