From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5319392047677770396==" MIME-Version: 1.0 From: Steven Rostedt To: kbuild-all@lists.01.org Subject: Re: [trace:ftrace/ring-buffer-irq-timestamp 1/7] kernel/trace/trace.c:3356 trace_array_printk() warn: variable dereferenced before check 'tr' (see line 3353) Date: Mon, 29 Jun 2020 09:05:12 -0400 Message-ID: <20200629090512.53d19ec2@oasis.local.home> In-Reply-To: <20200629105710.GN2549@kadam> List-Id: --===============5319392047677770396== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, 29 Jun 2020 13:57:10 +0300 Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-tra= ce.git ftrace/ring-buffer-irq-timestamp > head: 63afaf390ebc12f578d6bb4ced9ed4a35eab1c92 > commit: 0b10b8f570623d0a82ce29089b9be3b3f53e5bf2 [1/7] tracing: Only allo= w trace_array_printk() to be used by instances > config: x86_64-randconfig-m001-20200629 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > = > smatch warnings: > kernel/trace/trace.c:3356 trace_array_printk() warn: variable dereference= d before check 'tr' (see line 3353) Thanks for the report. As this is not in a upstream tree yet (it's only in my development branch) and I'm going to fold the fix into the original commit. It doesn't make sense to add a "Reported-by" because the issue that was reported got fixed and folded, Reported-by is for issues that the patch fixes not issues for the patch itself. Should I just put in a "Reviewed-by: kernel test robot " a= nd "Reviewed-by: Dan Carpenter " ? -- Steve > = > # https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git= /commit/?id=3D0b10b8f570623d0a82ce29089b9be3b3f53e5bf2 > git remote add trace https://git.kernel.org/pub/scm/linux/kernel/git/rost= edt/linux-trace.git > git remote update trace > git checkout 0b10b8f570623d0a82ce29089b9be3b3f53e5bf2 > vim +/tr +3356 kernel/trace/trace.c >=20 --===============5319392047677770396==--