From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E8EC433E1 for ; Mon, 29 Jun 2020 19:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E114D208D5 for ; Mon, 29 Jun 2020 19:45:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387837AbgF2Tou convert rfc822-to-8bit (ORCPT ); Mon, 29 Jun 2020 15:44:50 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:39312 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732079AbgF2Tot (ORCPT ); Mon, 29 Jun 2020 15:44:49 -0400 X-Greylist: delayed 2416 seconds by postgrey-1.27 at vger.kernel.org; Mon, 29 Jun 2020 15:44:48 EDT Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 6BDD73A6287; Mon, 29 Jun 2020 08:15:29 +0000 (UTC) X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id EB831C000E; Mon, 29 Jun 2020 08:15:04 +0000 (UTC) Date: Mon, 29 Jun 2020 10:15:03 +0200 From: Miquel Raynal To: Laurent Pinchart Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maxime Chevallier , Paul Kocialkowski , Rob Herring , Thomas Petazzoni Subject: Re: [PATCH v5 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Message-ID: <20200629101503.5bae21d6@xps13> In-Reply-To: <20200628072444.GA8391@pendragon.ideasonboard.com> References: <20200109184037.9091-1-miquel.raynal@bootlin.com> <20200109184037.9091-2-miquel.raynal@bootlin.com> <20200628072444.GA8391@pendragon.ideasonboard.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, [...] > > > > +static const struct display_timing satoz_sat050at40h12r2_timing = { > > + .pixelclock = {33300000, 33300000, 50000000}, > > + .hactive = {800, 800, 800}, > > + .hfront_porch = {16, 210, 354}, > > + .hback_porch = {46, 46, 46}, > > + .hsync_len = {1, 1, 40}, > > + .vactive = {480, 480, 480}, > > + .vfront_porch = {7, 22, 147}, > > + .vback_porch = {23, 23, 23}, > > + .vsync_len = {1, 1, 20}, > > +}; > > + > > +static const struct panel_desc satoz_sat050at40h12r2 = { > > + .timings = &satoz_sat050at40h12r2_timing, > > + .num_timings = 1, > > + .bpc = 8, > > + .size = { > > + .width = 108, > > + .height = 65, > > + }, > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > I'm trying to fix inconsistencies in the panel-simple driver, and this > caught my eyes. MEDIA_BUS_FMT_RGB888_1X24 isn't a correct format for > LVDS panels. MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > MEDIA_BUS_FMT_RGB888_1X7X4_SPWG or MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA > should be used instead. As I couldn't find documentation for the panel, > I can't tell which format is correct. Could you please help ? Indeed, I got this datasheet under NDA. We checked with Paul, we think the right format is: MEDIA_BUS_FMT_RGB888_1X7X4_SPWG. Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED6DDC433DF for ; Tue, 30 Jun 2020 07:35:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA580206CB for ; Tue, 30 Jun 2020 07:35:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA580206CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC64789D8E; Tue, 30 Jun 2020 07:35:00 +0000 (UTC) Received: from mslow2.mail.gandi.net (mslow2.mail.gandi.net [217.70.178.242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 473AD89FC9 for ; Mon, 29 Jun 2020 08:19:05 +0000 (UTC) Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 9C5633AA9B4 for ; Mon, 29 Jun 2020 08:15:31 +0000 (UTC) X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id EB831C000E; Mon, 29 Jun 2020 08:15:04 +0000 (UTC) Date: Mon, 29 Jun 2020 10:15:03 +0200 From: Miquel Raynal To: Laurent Pinchart Subject: Re: [PATCH v5 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Message-ID: <20200629101503.5bae21d6@xps13> In-Reply-To: <20200628072444.GA8391@pendragon.ideasonboard.com> References: <20200109184037.9091-1-miquel.raynal@bootlin.com> <20200109184037.9091-2-miquel.raynal@bootlin.com> <20200628072444.GA8391@pendragon.ideasonboard.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 30 Jun 2020 07:34:53 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Thomas Petazzoni , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maxime Chevallier , Paul Kocialkowski , Rob Herring , Thierry Reding , Sam Ravnborg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTGF1cmVudCwKClsuLi5dCgo+ID4gIAo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZGlzcGxh eV90aW1pbmcgc2F0b3pfc2F0MDUwYXQ0MGgxMnIyX3RpbWluZyA9IHsKPiA+ICsJLnBpeGVsY2xv Y2sgPSB7MzMzMDAwMDAsIDMzMzAwMDAwLCA1MDAwMDAwMH0sCj4gPiArCS5oYWN0aXZlID0gezgw MCwgODAwLCA4MDB9LAo+ID4gKwkuaGZyb250X3BvcmNoID0gezE2LCAyMTAsIDM1NH0sCj4gPiAr CS5oYmFja19wb3JjaCA9IHs0NiwgNDYsIDQ2fSwKPiA+ICsJLmhzeW5jX2xlbiA9IHsxLCAxLCA0 MH0sCj4gPiArCS52YWN0aXZlID0gezQ4MCwgNDgwLCA0ODB9LAo+ID4gKwkudmZyb250X3BvcmNo ID0gezcsIDIyLCAxNDd9LAo+ID4gKwkudmJhY2tfcG9yY2ggPSB7MjMsIDIzLCAyM30sCj4gPiAr CS52c3luY19sZW4gPSB7MSwgMSwgMjB9LAo+ID4gK307Cj4gPiArCj4gPiArc3RhdGljIGNvbnN0 IHN0cnVjdCBwYW5lbF9kZXNjIHNhdG96X3NhdDA1MGF0NDBoMTJyMiA9IHsKPiA+ICsJLnRpbWlu Z3MgPSAmc2F0b3pfc2F0MDUwYXQ0MGgxMnIyX3RpbWluZywKPiA+ICsJLm51bV90aW1pbmdzID0g MSwKPiA+ICsJLmJwYyA9IDgsCj4gPiArCS5zaXplID0gewo+ID4gKwkJLndpZHRoID0gMTA4LAo+ ID4gKwkJLmhlaWdodCA9IDY1LAo+ID4gKwl9LAo+ID4gKwkuYnVzX2Zvcm1hdCA9IE1FRElBX0JV U19GTVRfUkdCODg4XzFYMjQsCj4gPiArCS5jb25uZWN0b3JfdHlwZSA9IERSTV9NT0RFX0NPTk5F Q1RPUl9MVkRTLCAgCj4gCj4gSSdtIHRyeWluZyB0byBmaXggaW5jb25zaXN0ZW5jaWVzIGluIHRo ZSBwYW5lbC1zaW1wbGUgZHJpdmVyLCBhbmQgdGhpcwo+IGNhdWdodCBteSBleWVzLiBNRURJQV9C VVNfRk1UX1JHQjg4OF8xWDI0IGlzbid0IGEgY29ycmVjdCBmb3JtYXQgZm9yCj4gTFZEUyBwYW5l bHMuIE1FRElBX0JVU19GTVRfUkdCNjY2XzFYN1gzX1NQV0csCj4gTUVESUFfQlVTX0ZNVF9SR0I4 ODhfMVg3WDRfU1BXRyBvciBNRURJQV9CVVNfRk1UX1JHQjg4OF8xWDdYNF9KRUlEQQo+IHNob3Vs ZCBiZSB1c2VkIGluc3RlYWQuIEFzIEkgY291bGRuJ3QgZmluZCBkb2N1bWVudGF0aW9uIGZvciB0 aGUgcGFuZWwsCj4gSSBjYW4ndCB0ZWxsIHdoaWNoIGZvcm1hdCBpcyBjb3JyZWN0LiBDb3VsZCB5 b3UgcGxlYXNlIGhlbHAgPwoKSW5kZWVkLCBJIGdvdCB0aGlzIGRhdGFzaGVldCB1bmRlciBOREEu CgpXZSBjaGVja2VkIHdpdGggUGF1bCwgd2UgdGhpbmsgdGhlIHJpZ2h0IGZvcm1hdCBpczoKTUVE SUFfQlVTX0ZNVF9SR0I4ODhfMVg3WDRfU1BXRy4KClRoYW5rcywKTWlxdcOobApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK