From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] i2c: add Kconfig help text for slave mode
Date: Mon, 29 Jun 2020 13:21:19 +0200 [thread overview]
Message-ID: <20200629112119.GA1932@ninjato> (raw)
In-Reply-To: <CAMuHMdXFgR__hnUO-o+2ukxOYc_6U63wjP1PJyip3KGg277gDA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
> > config I2C_SLAVE
> > bool "I2C slave support"
> >
>
> Why the blank line here ^^^?
Sure, I can fix before applying.
>
> > + help
> > + This enables Linux to act as an I2C slave device. Note that your I2C
> > + bus master driver also needs to support this functionality. Please
> > + read Documentation/i2c/slave-interface.rst for further details.
> > +
> > if I2C_SLAVE
> >
> > config I2C_SLAVE_EEPROM
>
> The rest looks fine to me.
Thanks, Geert!
> As you don't like conditional R-b's, I'll add mine on v2 ;-)
I don't? I can't recall that :) Maybe there was a corner case once...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-06-29 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 18:55 [PATCH] i2c: add Kconfig help text for slave mode Wolfram Sang
2020-06-28 22:13 ` Niklas Söderlund
2020-06-29 7:51 ` Geert Uytterhoeven
2020-06-29 11:21 ` Wolfram Sang [this message]
2020-06-29 11:28 ` Geert Uytterhoeven
2020-06-29 11:37 ` Wolfram Sang
2020-07-04 6:17 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629112119.GA1932@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.