From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A967C433DF for ; Mon, 29 Jun 2020 13:27:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD38F23D97 for ; Mon, 29 Jun 2020 13:27:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zhfaO0Ej"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I7PLcuk/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD38F23D97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dt3t6uBzvSDZiZJa4wvdZ3MfkHeaB+e2kwnQrRqwjz0=; b=zhfaO0EjuH2RVMksCH6J+Hnl5 sbYCnQKjyDgC2PX6R9Z0oXi95haa+Hr9H00JHMSv1SHd0LmJ0n1jRi55zV4QJAluISZlwgQHZewSH hQ4YsKEuLtXMDfl+8/JynfWbUJ6Y1dwjSU2Pqa7fB5xHOzPeMBZQKb30h2cgmlDkMWsfDHZH+CTJ2 HKJUEldM0AUx6rd0QmjWx8nHn3RnMmLF2Xy8rApyGFD+CvViAfKItlBgMdwa3m58jnukXMJkS/+yP 5OHF7XlBlNID3N8te8HZYx62y6gh1eePQ6Ndmn3IJ0hl1WDLzuS0zVeeDJKrpq3YB9ynrERP0ITQV baTFJppww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jptmb-0008BL-57; Mon, 29 Jun 2020 13:25:13 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jptmY-0008Am-JT for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 13:25:11 +0000 Received: by mail-wm1-x342.google.com with SMTP id o2so16127959wmh.2 for ; Mon, 29 Jun 2020 06:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zUEJkh5HHxVcYkydyDedgROg8kiF7ZTbhK+enqqtuzI=; b=I7PLcuk/NyfRTBDPzUHE5RTErXEBuYX5DVcAzkSE7wPRYhjM8vuGJxxS9ej05E/Bm5 pfOPk2nwxVNerwaCGroT6e/7x7DyAtr5AS9p30EFl0FjeW/axT06t4M4I1NQVZOLfss5 kHJpu/dOS6vz2BrQOnXcFzp2PflpVG7raeIMOVpA4m/x8bpPxoxip+4iNYKBnz07ERhb DEi56ZS9zJicNlF4bC1pXDaKuG8SwbU48R6jsYUJAivX7YGO/596ld84p2fwxMLcW7qg RH9X5bWbU6gLSCid1vmkx9/nrp1DvZnJWoT2tx/OTJlcjVRIpmaLefhbq/+HczJZZoQj z5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zUEJkh5HHxVcYkydyDedgROg8kiF7ZTbhK+enqqtuzI=; b=QCjHTHicJQSm61YUOlGTuy/J0hsvqBupATSourxcvs8cvGSwi+3JyQpuXBnHW55iii Vr7kfCaUzIdrijOEeiRADWnn5gO0KrcptryXqGhVevVXMKPtLgqaNNt3VPTQPBC5EVEf 7oc2XX164trx6KW+/8+BRNlG9SLqgmLs3BgXhXYProb3pOnYiFuvzxHRirir/PzRLSOH P13oQzlA5P+A/75tGuVDi7nyBKpB1a6x2QjISOXb6f36ByJhWn2psoFDydRI1k88Juxn 9vdNLspSZuiHFm9H28Vx5yFBKVI92udl2u+MdzpzhQSoqlqzJFUy95CiLtCj1fk+bQeR gO6w== X-Gm-Message-State: AOAM532RvrtDUs6ivQWlzj1FbeytdOM1ZwUpO5U614sFzgZD0QVSPd9h wz9H8LkeDAkR4O/lq7lxqttd4SdS0DQ= X-Google-Smtp-Source: ABdhPJw2RBOaOy5Q3WIZr7vVnxJYhhctpyTg/SYgmN3r9pNAxEnEbAtMxeOwkfhFlEEdm1Pl23RCPQ== X-Received: by 2002:a1c:9802:: with SMTP id a2mr15856350wme.64.1593437109494; Mon, 29 Jun 2020 06:25:09 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x14sm48402443wrt.60.2020.06.29.06.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 06:25:08 -0700 (PDT) Date: Mon, 29 Jun 2020 14:25:06 +0100 From: Lee Jones To: Johan Hovold Subject: Re: [PATCH 2/5] mfd: lm3533-ctrlbank: Cap BRIGHTNESS_MAX to 127 since API uses u8 as carrier Message-ID: <20200629132506.GJ177734@dell> References: <20200629123215.1014747-1-lee.jones@linaro.org> <20200629123215.1014747-3-lee.jones@linaro.org> <20200629125102.GT3334@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200629125102.GT3334@localhost> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Johan Hovold , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyOSBKdW4gMjAyMCwgSm9oYW4gSG92b2xkIHdyb3RlOgoKPiBPbiBNb24sIEp1biAy OSwgMjAyMCBhdCAwMTozMjoxMlBNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBTaW5jZSBp dHMgY29uY2VwdGlvbiBpbiAyMDEyIGJyaWdodG5lc3MgaGFzIGJlZW4gYXJ0aWZpY2lhbGx5IGNh cHBlZAo+ID4gYXQgMTI3IHNpbmNlIHRoZSB2YXJpYWJsZSBjYXJyeWluZyB0aGUgdmFsdWUgaXMg dTguICBXZSBjb3VsZCBnbyB0bwo+ID4gdGhlIHRyb3VibGUgb2YgY2hhbmdpbmcgdGhlIHdob2xl IEFQSSAoY3Jvc3NpbmcgMyBkaWZmZXJlbnQgc3Vic3lzdGVtcyksCj4gPiBidXQgY2xlYXJseSB0 aGlzIGhhc24ndCBib3RoZXJlZCBhbnlvbmUgaW4gdGhlIGJlc3QgcGFydCBvZiBhIGRlY2FkZS4K PiA+IAo+ID4gU2ltcGx5LCBjYXAgQlJJR0hUTkVTU19NQVggdG8gMTI3IGluc3RlYWQgKGZvciBu b3cgYXQgbGVhc3QpLgo+IAo+IEhtbS4gVGhpcyBwYXRjaCBpcyBjbGVhcmx5IGJyb2tlbiBhbmQg d291bGQgY29udHJhcnkgdG8gdGhlIGNsYWltIGJlCj4gaW50cm9kdWNpbmcgYW4gYXJ0aWZpY2lh bCBjYXAgYXQgaGFsZiBicmlnaHRuZXNzLiB1OCBjYW4gaG9sZCB0aGUgbWF4Cj4gYnJpZ2h0bmVz cyB2YWx1ZSAyNTUganVzdCBmaW5lLgoKWWVzLCBvZiBjb3Vyc2UgaXQgY2FuLiAgU2VuaW9yIG1v bWVudCBvbiBteSBhY2NvdW50LgoKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIHdhcm5pbmco cyk6Cj4gPiAKPiA+ICBkcml2ZXJzL21mZC9sbTM1MzMtY3RybGJhbmsuYzogSW4gZnVuY3Rpb24g 4oCYbG0zNTMzX2N0cmxiYW5rX3NldF9icmlnaHRuZXNz4oCZOgo+ID4gIGRyaXZlcnMvbWZkL2xt MzUzMy1jdHJsYmFuay5jOjk4OjEwOiB3YXJuaW5nOiBjb21wYXJpc29uIGlzIGFsd2F5cyBmYWxz ZSBkdWUgdG8gbGltaXRlZCByYW5nZSBvZiBkYXRhIHR5cGUgWy1XdHlwZS1saW1pdHNdCj4gPiAg OTggfCBpZiAodmFsID4gTE0zNTMzXyMjX05BTUUjI19NQVgpIHwgXgo+ID4gIGRyaXZlcnMvbWZk L2xtMzUzMy1jdHJsYmFuay5jOjEyNToxOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCY bG0zNTMzX2N0cmxiYW5rX3NldOKAmQo+ID4gIDEyNSB8IGxtMzUzM19jdHJsYmFua19zZXQoYnJp Z2h0bmVzcywgQlJJR0hUTkVTUyk7Cj4gPiAgfCBefn5+fn5+fn5+fn5+fn5+fn5+Cj4gCj4gVGhp cyB3YXJuaW5nIGlzIGJlbmlnbi4gVGhlIHNhbWUgbWFjcm8gaXMgdXNlZCB0byBkZWZpbmVkIHR3 byBmdW5jdGlvbgo+IHdoZXJlIGluIG9uZSBjYXNlIHRoZSBtYXggdmFsdWUgY29pbmNpZGVzIHdp dGggVThfTUFYIHNvIHRoYXQgdGhlIHNhbml0eQo+IGNoZWNrIGJlY29tZXMgcmVkdW5kYW50LgoK QSBiZW5pZ24gd2FybmluZywgYXMgbW9zdCBXPTEgd2FybmluZ3MgYXJlLCBpcyBzdGlsbCBhIHdh cm5pbmcuCgpTbyBob3cgZG8geW91IHByb3Bvc2Ugd2UgZml4IGl0PwoKSXMgMjU1IGEgdmFsaWQg YW5kIHVzZWQgYnJpZ2h0bmVzcyBsZXZlbD8KCklmIHNvLCBob3cgZG8geW91IGZlZWwgYWJvdXQ6 CgogIC8qIEF2b2lkICdhbHdheXMgZmFsc2UnIGNoZWNrICcodTgpID4gMjU1JyAqLwogIGlmIChM TTM1MzNfIyNfTkFNRSMjX01BWCAhPSAweGZmICYmIHZhbCA+IExNMzUzM18jI19OQU1FIyNfTUFY KQogICAgICAgICAgcmV0dXJuIC1FSU5WQUw7ICAgICAgICAKCj4gPiBDYzogSm9oYW4gSG92b2xk IDxqaG92b2xkQGdtYWlsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpv bmVzQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL21mZC9sbTM1MzMtY3RybGJhbmsu YyB8IDIgKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24o LSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL2xtMzUzMy1jdHJsYmFuay5jIGIv ZHJpdmVycy9tZmQvbG0zNTMzLWN0cmxiYW5rLmMKPiA+IGluZGV4IDM0ZmJhMDZlYzcwNTcuLjM0 OGNlNjc0NTMwOTIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL21mZC9sbTM1MzMtY3RybGJhbmsu Ywo+ID4gKysrIGIvZHJpdmVycy9tZmQvbG0zNTMzLWN0cmxiYW5rLmMKPiA+IEBAIC0xNyw3ICsx Nyw3IEBACj4gPiAgI2RlZmluZSBMTTM1MzNfTUFYX0NVUlJFTlRfTUFYCQkyOTgwMAo+ID4gICNk ZWZpbmUgTE0zNTMzX01BWF9DVVJSRU5UX1NURVAJCTgwMAo+ID4gIAo+ID4gLSNkZWZpbmUgTE0z NTMzX0JSSUdIVE5FU1NfTUFYCQkyNTUKPiA+ICsjZGVmaW5lIExNMzUzM19CUklHSFRORVNTX01B WAkJMTI3ICAvKiBDYXBwZWQgYnkgQVBJIC0gY291bGQgYmUgdXAgdG8gMjU1ICovCj4gPiAgI2Rl ZmluZSBMTTM1MzNfUFdNX01BWAkJCTB4M2YKPiA+ICAKPiA+ICAjZGVmaW5lIExNMzUzM19SRUdf UFdNX0JBU0UJCTB4MTQKPiAKPiBKb2hhbgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5p b3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3Bl biBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwg VHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E74C433E0 for ; Mon, 29 Jun 2020 19:24:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0609C206F1 for ; Mon, 29 Jun 2020 19:24:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I7PLcuk/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732336AbgF2TX4 (ORCPT ); Mon, 29 Jun 2020 15:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732234AbgF2TWm (ORCPT ); Mon, 29 Jun 2020 15:22:42 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C22C1C02A569 for ; Mon, 29 Jun 2020 06:25:10 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l17so15392522wmj.0 for ; Mon, 29 Jun 2020 06:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zUEJkh5HHxVcYkydyDedgROg8kiF7ZTbhK+enqqtuzI=; b=I7PLcuk/NyfRTBDPzUHE5RTErXEBuYX5DVcAzkSE7wPRYhjM8vuGJxxS9ej05E/Bm5 pfOPk2nwxVNerwaCGroT6e/7x7DyAtr5AS9p30EFl0FjeW/axT06t4M4I1NQVZOLfss5 kHJpu/dOS6vz2BrQOnXcFzp2PflpVG7raeIMOVpA4m/x8bpPxoxip+4iNYKBnz07ERhb DEi56ZS9zJicNlF4bC1pXDaKuG8SwbU48R6jsYUJAivX7YGO/596ld84p2fwxMLcW7qg RH9X5bWbU6gLSCid1vmkx9/nrp1DvZnJWoT2tx/OTJlcjVRIpmaLefhbq/+HczJZZoQj z5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zUEJkh5HHxVcYkydyDedgROg8kiF7ZTbhK+enqqtuzI=; b=jxOTNi/X3tDirD/2Px7dXD+F/T+xSYwq/Nxo/1+ndYni68GXzHcQMHTmcUrIeWEBdQ 3SEp3O+Fd75EsR3kJB99wwJqEMQF1E1etXAfI3aGED7V6bVn9Bh3StRdT3s1UoKQTZoP IgUOgWdHdI2vgWKSE3/hqsMBZGSe2b2wUsDo42JCG6dNLGkCjp1g21tQQC8FlhEuDQXh kEdvZfyT5ZPe8vUx9J4/D6/4sBMhBlkPJRITb+fVPx2fzWhy+g9W98yyb0MFqb2YFbHi aCOY9+ePUvJEqauYK8aiEm+8dtL0gP/0K+3XW+U2HcRNEs+Qv4FKnsyqZPiKOVQctkSS Tw0Q== X-Gm-Message-State: AOAM533MGMf6C6rcb96iYBcnOXKyD6iU2afAsDLDQqr90i9O4p+0BmVc pbB5YYSirlGpbjUT9WnHsTDtUg== X-Google-Smtp-Source: ABdhPJw2RBOaOy5Q3WIZr7vVnxJYhhctpyTg/SYgmN3r9pNAxEnEbAtMxeOwkfhFlEEdm1Pl23RCPQ== X-Received: by 2002:a1c:9802:: with SMTP id a2mr15856350wme.64.1593437109494; Mon, 29 Jun 2020 06:25:09 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x14sm48402443wrt.60.2020.06.29.06.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 06:25:08 -0700 (PDT) Date: Mon, 29 Jun 2020 14:25:06 +0100 From: Lee Jones To: Johan Hovold Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH 2/5] mfd: lm3533-ctrlbank: Cap BRIGHTNESS_MAX to 127 since API uses u8 as carrier Message-ID: <20200629132506.GJ177734@dell> References: <20200629123215.1014747-1-lee.jones@linaro.org> <20200629123215.1014747-3-lee.jones@linaro.org> <20200629125102.GT3334@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200629125102.GT3334@localhost> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Jun 2020, Johan Hovold wrote: > On Mon, Jun 29, 2020 at 01:32:12PM +0100, Lee Jones wrote: > > Since its conception in 2012 brightness has been artificially capped > > at 127 since the variable carrying the value is u8. We could go to > > the trouble of changing the whole API (crossing 3 different subsystems), > > but clearly this hasn't bothered anyone in the best part of a decade. > > > > Simply, cap BRIGHTNESS_MAX to 127 instead (for now at least). > > Hmm. This patch is clearly broken and would contrary to the claim be > introducing an artificial cap at half brightness. u8 can hold the max > brightness value 255 just fine. Yes, of course it can. Senior moment on my account. > > Fixes the following W=1 warning(s): > > > > drivers/mfd/lm3533-ctrlbank.c: In function ‘lm3533_ctrlbank_set_brightness’: > > drivers/mfd/lm3533-ctrlbank.c:98:10: warning: comparison is always false due to limited range of data type [-Wtype-limits] > > 98 | if (val > LM3533_##_NAME##_MAX) | ^ > > drivers/mfd/lm3533-ctrlbank.c:125:1: note: in expansion of macro ‘lm3533_ctrlbank_set’ > > 125 | lm3533_ctrlbank_set(brightness, BRIGHTNESS); > > | ^~~~~~~~~~~~~~~~~~~ > > This warning is benign. The same macro is used to defined two function > where in one case the max value coincides with U8_MAX so that the sanity > check becomes redundant. A benign warning, as most W=1 warnings are, is still a warning. So how do you propose we fix it? Is 255 a valid and used brightness level? If so, how do you feel about: /* Avoid 'always false' check '(u8) > 255' */ if (LM3533_##_NAME##_MAX != 0xff && val > LM3533_##_NAME##_MAX) return -EINVAL; > > Cc: Johan Hovold > > Signed-off-by: Lee Jones > > --- > > drivers/mfd/lm3533-ctrlbank.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/lm3533-ctrlbank.c b/drivers/mfd/lm3533-ctrlbank.c > > index 34fba06ec7057..348ce67453092 100644 > > --- a/drivers/mfd/lm3533-ctrlbank.c > > +++ b/drivers/mfd/lm3533-ctrlbank.c > > @@ -17,7 +17,7 @@ > > #define LM3533_MAX_CURRENT_MAX 29800 > > #define LM3533_MAX_CURRENT_STEP 800 > > > > -#define LM3533_BRIGHTNESS_MAX 255 > > +#define LM3533_BRIGHTNESS_MAX 127 /* Capped by API - could be up to 255 */ > > #define LM3533_PWM_MAX 0x3f > > > > #define LM3533_REG_PWM_BASE 0x14 > > Johan -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog