From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] blk-mq: put driver tag when this request is completed
Date: Mon, 29 Jun 2020 17:04:37 +0200 [thread overview]
Message-ID: <20200629150437.GA25144@lst.de> (raw)
In-Reply-To: <20200629094759.2002708-1-ming.lei@redhat.com>
On Mon, Jun 29, 2020 at 05:47:59PM +0800, Ming Lei wrote:
> It is natural to release driver tag when this request is completed by
> LLD or device since its purpose is for LLD use.
>
> One big benefit is that the released tag can be re-used quicker since
> bio_endio() may take too long.
>
> Meantime we don't need to release driver tag for flush request.
Reviewed-by: Christoph Hellwig <hch@lst.de>
A bunch of comments on the surrounding code from reviewing it, though:
- blk_mq_put_driver_tag and __blk_mq_put_driver_tag can and should be
moved to blk-mq.c and marked static in a follow on patch (and possibly
merged as well)
- The rq->internal_tag == BLK_MQ_NO_TAG check in shold probably be
replaced with a !data->q->elevator check to make it more obvious
that we are only putting the driver tag for the iosched case
next prev parent reply other threads:[~2020-06-29 18:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200701130104eucas1p1f8dcce58bf704b726aee1e89980fe19e@eucas1p1.samsung.com>
2020-06-29 9:47 ` [PATCH] blk-mq: put driver tag when this request is completed Ming Lei
2020-06-29 15:04 ` Christoph Hellwig [this message]
2020-06-29 15:56 ` Jens Axboe
2020-07-01 13:01 ` Marek Szyprowski
2020-07-01 13:45 ` Ming Lei
2020-07-01 14:16 ` Marek Szyprowski
2020-07-01 14:58 ` Marek Szyprowski
2020-07-02 1:22 ` Ming Lei
2020-07-02 5:03 ` Jens Axboe
2020-07-02 8:04 ` Marek Szyprowski
2020-07-02 9:23 ` Ming Lei
2020-07-02 10:19 ` Marek Szyprowski
2020-07-02 11:48 ` Ming Lei
2020-07-02 12:12 ` Marek Szyprowski
2020-07-06 14:40 Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629150437.GA25144@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.