From: Prashant Malani <pmalani@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
groeck@chromium.org, bleung@chromium.org, dtor@chromium.org,
gwendal@chromium.org, kernel test robot <lkp@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Add a dependency on USB_ROLE_SWITCH
Date: Mon, 29 Jun 2020 09:55:09 -0700 [thread overview]
Message-ID: <20200629165509.GB235106@google.com> (raw)
In-Reply-To: <20200629103223.1284442-1-enric.balletbo@collabora.com>
Hi Enric,
Thanks for the patch.
On Mon, Jun 29, 2020 at 12:32:23PM +0200, Enric Balletbo i Serra wrote:
> As reported by the kernel test robot the cros_ec_typec driver fails to
> build if the USB_ROLE_SWITCH is not selected, to fix that, add a
> dependency on that symbol. This fixes the following build error:
>
> drivers/platform/chrome/cros_ec_typec.c:133: undefined reference to `usb_role_switch_put'
> ld: drivers/platform/chrome/cros_ec_typec.o: in function `cros_typec_get_switch_handles':
> drivers/platform/chrome/cros_ec_typec.c:108: undefined reference to `fwnode_usb_role_switch_get'
> ld: drivers/platform/chrome/cros_ec_typec.c:117: undefined reference to `usb_role_switch_put'
>
> Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Prashant Malani <pmalani@chromium.org>
> ---
>
> drivers/platform/chrome/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index cf072153bdc5..a056031dee81 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -218,6 +218,7 @@ config CROS_EC_TYPEC
> tristate "ChromeOS EC Type-C Connector Control"
> depends on MFD_CROS_EC_DEV && TYPEC
> depends on CROS_USBPD_NOTIFY
> + depends on USB_ROLE_SWITCH
> default MFD_CROS_EC_DEV
> help
> If you say Y here, you get support for accessing Type C connector
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-06-29 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 10:32 [PATCH] platform/chrome: cros_ec_typec: Add a dependency on USB_ROLE_SWITCH Enric Balletbo i Serra
2020-06-29 16:55 ` Prashant Malani [this message]
2020-07-01 9:10 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629165509.GB235106@google.com \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=dtor@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.