From: Tony Lindgren <tony@atomide.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jason Kridner" <jkridner@beagleboard.org>,
"Robert Nelson" <robertcnelson@gmail.com>,
"Mark A. Yoder" <mark.a.yoder@gmail.com>
Subject: Re: [PATCH V2] ARM: dts: am33xx-l4: add gpio-ranges
Date: Mon, 29 Jun 2020 10:12:57 -0700 [thread overview]
Message-ID: <20200629171257.GU37466@atomide.com> (raw)
In-Reply-To: <20200610110258.GA3024740@x1>
* Drew Fustini <drew@beagleboard.org> [200610 04:03]:
> Add gpio-ranges properties to the gpio controller nodes.
>
> These gpio-ranges were created based on "Table 9-10. CONTROL_MODULE
> REGISTERS" in the "AM335x Technical Reference Manual" [0] and "Table
> 4-2. Pin Attributes" in the "AM335x Sitara Processor datasheet" [1].
> A csv file with this data is available for reference [2].
>
> These mappings are valid for all SoC's that are using am33xx-l4.dtsi.
> In addition, the only TI AM33xx parts that actually exist are [0]:
> AM3351, AM3352, AM3354, AM3356, AM3357, AM3358, AM3359
>
> These gpio-ranges properties should be added as they describe the
> relationship between a gpio line and pin control register that exists
> in the hardware. For example, GPMC_A0 pin has mode 7 which is labeled
> gpio1_16. conf_gpmc_a0 register is at offset 840h which makes it pin 16.
>
> [0] https://www.ti.com/lit/ug/spruh73q/spruh73q.pdf
> [1] http://www.ti.com/lit/ds/symlink/am3358.pdf
> [2] https://gist.github.com/pdp7/6ffaddc8867973c1c3e8612cfaf72020
> [3] http://www.ti.com/processors/sitara-arm/am335x-cortex-a8/overview.html
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> V2 changes:
> - clarify that these gpio-ranges are valid for all SoCs including that
> am33xx-l4.dtsi
> - describe why these gpio-ranges should be added
Thanks applying into omap-for-v5.9/dt.
Regards,
Tony
prev parent reply other threads:[~2020-06-29 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 11:02 [PATCH V2] ARM: dts: am33xx-l4: add gpio-ranges Drew Fustini
2020-06-29 17:12 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629171257.GU37466@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.a.yoder@gmail.com \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.