From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 632F3C433E1 for ; Mon, 29 Jun 2020 21:42:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 288B120768 for ; Mon, 29 Jun 2020 21:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593466961; bh=Z+F/qR/QS1LYwSaqxET4TPmnUaYOUwWvnPRwP3RDrtM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xV0lvgXosXqLBhQEwrKzq0Vq0hOmbm34Genev2oK10DIS16bWRQj9zd3tbMWkBHy4 p679wbqXiiOTLDSHJmtPT+xz3v6Xldluq5qhn1KlgtQvh17wYWcsvoyOwLm1H5ZJAk Ikmg+fPO3aKE8HktLOS7mUeQJL1v9RoYRLiPnmK4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403943AbgF2Vm3 (ORCPT ); Mon, 29 Jun 2020 17:42:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727906AbgF2Sh4 (ORCPT ); Mon, 29 Jun 2020 14:37:56 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76484C033C34; Mon, 29 Jun 2020 11:28:55 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id b15so13734657edy.7; Mon, 29 Jun 2020 11:28:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v4RywOSBW8Kuw1+zf6DDYYL42xVE9deqCEslZIfGs/U=; b=C6ibjhrwQKECnH+TWlZ+vHl6UQ0YlQVFQgDkTF5WAigqjwQuOHweYLobU7pgwv3ByH Um/eGwTACbKXMsqK5u17DTWcn1e0WWtycNFg++9NrPlgArnLyFkAssMylAF0yqzpD6RI yxa9hNZBnXHjYebm+i8Zi9uPkeHFNJak2SD3SLGg5LZE4Rfp1Fo5o3Qux1XiDnUthe76 wvmrd0tgylNpU6wSbCsOqy1sKIWnNfCLm+jknb+b4GLyQaiLwEcrmDeuF0Q0mxMgOVKL Z5AK+5Gr1SpkGqeM+UXhHwqSk9HOLZvfDuO3RdHVY9Y54BbFotVi7nqDoWeZm6uiS5HB /1wg== X-Gm-Message-State: AOAM5308usOISsLKdAaLGv3AyXNvPZ/SD5BRyNNQ4uDauEPzXLZwiAu6 hDOfdd5/CBUcmS+URv4BGFs= X-Google-Smtp-Source: ABdhPJyzSgCljqhMYA8qL9G+ulHz7u8sTpeqpwRRupJqxrfMHwsH2mmBxQkKBgGt9N38HlNRmuf3sQ== X-Received: by 2002:a05:6402:1c07:: with SMTP id ck7mr7331907edb.297.1593455333941; Mon, 29 Jun 2020 11:28:53 -0700 (PDT) Received: from kozik-lap ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id d13sm257118ejj.95.2020.06.29.11.28.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jun 2020 11:28:53 -0700 (PDT) Date: Mon, 29 Jun 2020 20:28:51 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Lorenzo Pieralisi , Daniel Lezcano , Lukasz Luba , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 1/4] ARM: exynos: MCPM: Restore big.LITTLE cpuidle support Message-ID: <20200629182851.GA3848@kozik-lap> References: <20200629091343.GA16015@kozik-lap> <20200629100218.6267-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200629100218.6267-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jun 29, 2020 at 12:02:18PM +0200, Marek Szyprowski wrote: > Call exynos_cpu_power_up(cpunr) unconditionally. This is needed by the > big.LITTLE cpuidle driver and has no side-effects on other code paths. > > The additional soft-reset call during little core power up has been added > to properly boot all cores on the Exynos5422-based boards with secure > firmware (like Odroid XU3/XU4 family). This however broke big.LITTLE > CPUidle driver, which worked only on boards without secure firmware (like > Peach-Pit/Pi Chromebooks). Apply the workaround only when board is > running under secure firmware. > > Fixes: 833b5794e330 ("ARM: EXYNOS: reset Little cores when cpu is up") > Signed-off-by: Marek Szyprowski > --- > v2: > - adjusted patch subject to better describe the change > - added a comment about exynos_cpu_power_up(cpunr) call > --- > arch/arm/mach-exynos/mcpm-exynos.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Thanks, applied (but somehow your patch did not make it to the linux-samsung-soc list). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C52C433DF for ; Mon, 29 Jun 2020 18:30:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68C95255D7 for ; Mon, 29 Jun 2020 18:30:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="coRdCDkc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68C95255D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dZhyahvjHV5iK1/KzG4iMmnVAoCAeQxGq0+6tAxuyj0=; b=coRdCDkcsz80vxbTCLKRBiK55 vUjQK/vB20TP0/MsMCXuV4ItrImJJbDUO8xSfzIw9T3u0xSD9oqUpyrCoB4B6Emeue3LK9DxA8chX qWeHx7e3fT/3S2sOgTwGbOhP81oq+USdtZnLON2JHIrGvrC3yJ1COVjPanM6zQqZJjARlrzcUHM7x 5m2Lb0L1pYPhqDx7+i3ucODZ5TJtHg9K3DYlcsB2QecK80DRCwvWhWpwwJPk0mQE8so2bs0PV5lvi J/XquCfFzBne1juaHXX9POUVlrHsU8M3Ai8IhJJvAlaiclW4lvQ7H1HlKcQo/8RD9k+2/2yuBq0/D g9FmKq0Tw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpyWX-0001FW-HG; Mon, 29 Jun 2020 18:28:57 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpyWV-0001FK-Dt for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 18:28:56 +0000 Received: by mail-ed1-f65.google.com with SMTP id dg28so13736792edb.3 for ; Mon, 29 Jun 2020 11:28:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v4RywOSBW8Kuw1+zf6DDYYL42xVE9deqCEslZIfGs/U=; b=nYtdyTtlG27uCO32C0I4zxhP2humlZIRrPzzBISMF+TdpGa2DvOplFXAHbB4zLZT09 LIleYQBI6HUE3zSAk4DjlQtvdjUcv16TylNg8AVCMy2+kjcPRqYn8eP0l6CWdvsbDdTz oQmB2YNJwtXk7/fVohWRdh40kuc5A/HYF39gPfmWp04MvTNxy7WTva+GEhq9xEp6XLVx ffuUkGSQOtNrmn1C1/EUB49VBsjUICPf6O2HDe71YhkY4aTRFcL71c781lQYbTb5u5d9 1M+MKWkavEOgvUWkWjBWNHhhicFcsK8ZeDlnC+NrBIjDKehT6Bg8yWmtu3QUWGhr4LMC RS8Q== X-Gm-Message-State: AOAM533zSpcB7VfS0Hd9K8lp7FQ8k+eUKr+VrMskaBLTKGVv8bdtMgVI xi6DVXrpcqtyAUqY4JquHe/Fwp9h X-Google-Smtp-Source: ABdhPJyzSgCljqhMYA8qL9G+ulHz7u8sTpeqpwRRupJqxrfMHwsH2mmBxQkKBgGt9N38HlNRmuf3sQ== X-Received: by 2002:a05:6402:1c07:: with SMTP id ck7mr7331907edb.297.1593455333941; Mon, 29 Jun 2020 11:28:53 -0700 (PDT) Received: from kozik-lap ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id d13sm257118ejj.95.2020.06.29.11.28.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jun 2020 11:28:53 -0700 (PDT) Date: Mon, 29 Jun 2020 20:28:51 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Subject: Re: [PATCH v2 1/4] ARM: exynos: MCPM: Restore big.LITTLE cpuidle support Message-ID: <20200629182851.GA3848@kozik-lap> References: <20200629091343.GA16015@kozik-lap> <20200629100218.6267-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200629100218.6267-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , linux-pm@vger.kernel.org, Daniel Lezcano , Bartlomiej Zolnierkiewicz , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 12:02:18PM +0200, Marek Szyprowski wrote: > Call exynos_cpu_power_up(cpunr) unconditionally. This is needed by the > big.LITTLE cpuidle driver and has no side-effects on other code paths. > > The additional soft-reset call during little core power up has been added > to properly boot all cores on the Exynos5422-based boards with secure > firmware (like Odroid XU3/XU4 family). This however broke big.LITTLE > CPUidle driver, which worked only on boards without secure firmware (like > Peach-Pit/Pi Chromebooks). Apply the workaround only when board is > running under secure firmware. > > Fixes: 833b5794e330 ("ARM: EXYNOS: reset Little cores when cpu is up") > Signed-off-by: Marek Szyprowski > --- > v2: > - adjusted patch subject to better describe the change > - added a comment about exynos_cpu_power_up(cpunr) call > --- > arch/arm/mach-exynos/mcpm-exynos.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Thanks, applied (but somehow your patch did not make it to the linux-samsung-soc list). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel