From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/3] blk-mq: move blk_mq_get_driver_tag into blk-mq.c
Date: Tue, 30 Jun 2020 05:57:55 +0100 [thread overview]
Message-ID: <20200630045755.GC17653@infradead.org> (raw)
In-Reply-To: <20200630022356.2149607-2-ming.lei@redhat.com>
On Tue, Jun 30, 2020 at 10:23:54AM +0800, Ming Lei wrote:
> blk_mq_get_driver_tag() is only used by blk-mq.c and is supposed to
> stay in blk-mq.c, so move it and preparing for cleanup code of
> get/put driver tag.
>
> Meantime hctx_may_queue() is moved to header file and it is fine
> since it is defined as inline always.
hctx_may_queue looks pretty big for an inline function to start with.
But except for that this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-06-30 4:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 2:23 [PATCH 0/3] blk-mq: driver tag related cleanup Ming Lei
2020-06-30 2:23 ` [PATCH 1/3] blk-mq: move blk_mq_get_driver_tag into blk-mq.c Ming Lei
2020-06-30 4:57 ` Christoph Hellwig [this message]
2020-06-30 6:10 ` Hannes Reinecke
2020-06-30 2:23 ` [PATCH 2/3] blk-mq: move blk_mq_put_driver_tag() " Ming Lei
2020-06-30 4:58 ` Christoph Hellwig
2020-06-30 6:10 ` Hannes Reinecke
2020-06-30 2:23 ` [PATCH 3/3] blk-mq: centralise related handling into blk_mq_get_driver_tag Ming Lei
2020-06-30 5:05 ` Christoph Hellwig
2020-06-30 6:13 ` Ming Lei
2020-06-30 6:26 ` Hannes Reinecke
2020-06-30 6:43 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630045755.GC17653@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.