From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC32C433DF for ; Tue, 30 Jun 2020 08:15:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0753D20759 for ; Tue, 30 Jun 2020 08:15:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EFcGxARv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DO5aHBa3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0753D20759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8a46SlMZW5nM/eEF9JmRit43rDyniVsOfKIvpJfvtjo=; b=EFcGxARv4uQn1jaak9nE72b/g deF8ZGOnmIcsF1fBIg3qvV6qugq/U9m5nnrtKOBkrbaqazW5G/Kg+2/hHHjZdiwkrnbCyBImiWU2E 3b28eMRY/ujMxUVP5/cDWtil1pVbxmqU4YjWSkRKuVX0UX6z1XqdekwKK3FJ4ENy3Xikn73B7j/pA ZDtfKBNa16VYGbjmlQlLLcSE2VHcuJmHyx8rXgop5Ux99rKSG7FXxe3J71hf5G06seXsuCQJey0UA yKkc7O1VzWOJfwf2FTBwambozR+XsnRxqjOimpaD9UWUGK/xUqcr6W+PamZ308ZNB9YVHfrikWkRt gcTsZ7TxA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqBNu-00046I-Tq; Tue, 30 Jun 2020 08:12:54 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqBNs-000463-1j for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 08:12:53 +0000 Received: by mail-wr1-x444.google.com with SMTP id h5so19137442wrc.7 for ; Tue, 30 Jun 2020 01:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=rLJNg6SZ5HWWuZJdX48spsQBewv6zMsf37jjJ1GBFiQ=; b=DO5aHBa3pNUaSGETSWQbzofDqahUYhogpdVMSaV5TJlJRqs3OGdlyZtLoInmnpn22p em373dlDejE5fuud8z1S1bUSgxOzS7iLzlW83StXkc7Ga5xL3v4jBHwQelDaajWtC2dp ullhzxtosXK96KE1TcOpDCTk1l+zG0s1TfKx+8ZCadweQAoTXlb0KaAXVfdhQebo3kMd dsSqaxyReuGgZWoekjOGguN93HVjM9tlZKISxbRSYMPfdkRtMndednWm7oqxlyGNhYH1 au1+FTOV3GzZJaAVjcz62PjOPBPQ8jxsU5cRAYNPI0GL45FdNc3Gg9jE9PbiKgLUvvoH jmUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rLJNg6SZ5HWWuZJdX48spsQBewv6zMsf37jjJ1GBFiQ=; b=gXpZWj1Alwh50ROW53Gkpmx+Y2La2xJeeMealC+DnoXmf9tRMdeOKKf11cfwlSuWsF BB6xFmEioY9le9bQJpzmvBXgzYTwiGlIKPKOR5riM5LaLbmaljSx4W/zgPtT8bGSRH/v cvQyhEMHDYMDFHDglW5icGLzZFsxjkcCUznexQXQQGA/5/rMa9AwCtdp11bYxybVhw6P zh5Z8Ue8KXA04aNiHbRr4r3wGCeppsu835HytV4aZ7OCMqfXkVCVQlYfVQ/yjHHlnJtf S54+4rPDV5dlCCj1PKRY0GjW8ylcGxD+KanXT7BeaoxMKc0mnSLkb1gRKDYEbZKgo/Hc be1Q== X-Gm-Message-State: AOAM53347S0RRCfo5P+/HUtQIv5jHgS7fNJJMzAC4/FrZwKc6vTILp2j tNSqE7mGr19p9YVN0c9RPVlmDg== X-Google-Smtp-Source: ABdhPJwzVH84vx569ch3pQWZoaa/tB1s2+xBvZx8nv2vs4jTY0G7z5RQJESw82aZLv7bw+tzTqJuoA== X-Received: by 2002:a05:6000:1283:: with SMTP id f3mr20939240wrx.106.1593504770162; Tue, 30 Jun 2020 01:12:50 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id i17sm2767303wrc.34.2020.06.30.01.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 01:12:49 -0700 (PDT) Date: Tue, 30 Jun 2020 09:12:47 +0100 From: Lee Jones To: haver Subject: Re: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc' Message-ID: <20200630081247.GI1179328@dell> References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-17-lee.jones@linaro.org> <20200630074224.GH1179328@dell> <770e66e5f2d7efcea61fc9d57e1053f0@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <770e66e5f2d7efcea61fc9d57e1053f0@linux.vnet.ibm.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , arnd@arndb.de, gregkh@linuxfoundation.org, Frank Haverkamp , Michael Jung , linux-kernel@vger.kernel.org, Michael Ruettger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAzMCBKdW4gMjAyMCwgaGF2ZXIgd3JvdGU6Cgo+IE9uIDIwMjAtMDYtMzAgMDk6NDIs IExlZSBKb25lcyB3cm90ZToKPiA+IE9uIFR1ZSwgMzAgSnVuIDIwMjAsIGhhdmVyIHdyb3RlOgo+ ID4gCj4gPiA+IE9uIDIwMjAtMDYtMjkgMTY6MDQsIExlZSBKb25lcyB3cm90ZToKPiA+ID4gPiBW YXJpYWJsZSAncmMnIGhhc24ndCBiZWVuIGNoZWNrZWQgc2luY2UgdGhlIGRyaXZlcidzIGluY2Vw dGlvbgo+ID4gPiA+IGluIDIwMTMuICBJZiBpdCBoYXNuJ3QgY2F1c2VkIGFueSBpc3N1ZXMgc2lu Y2UgdGhlbiwgaXQncyB1bmxpa2VseQo+ID4gPiA+IHRvIGluIHRoZSBmdXR1cmUuICBMZXQncyB0 YWtlIGl0IG91dCBmb3Igbm93Lgo+ID4gPiA+Cj4gPiA+ID4gRml4ZXMgdGhlIGZvbGxvd2luZyBX PTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4gPiA+ID4KPiA+ID4gPiAgZHJpdmVycy9taXNj L2dlbndxZS9jYXJkX2Jhc2UuYzogSW4gZnVuY3Rpb24KPiA+ID4gPiDigJhnZW53cWVfaGVhbHRo X2NoZWNrX3N0b3DigJk6Cj4gPiA+ID4KPiA+ID4gPiAvaG9tZS9sZWUvcHJvamVjdHMvbGludXgv a2VybmVsL2RyaXZlcnMvbWlzYy9nZW53cWUvY2FyZF9iYXNlLmM6MTA0Njo2Ogo+ID4gPiA+IHdh cm5pbmc6IHZhcmlhYmxlIOKAmHJj4oCZIHNldCBidXQgbm90IHVzZWQKPiA+ID4gPiBbLVd1bnVz ZWQtYnV0LXNldC12YXJpYWJsZV0KPiA+ID4gPiAgMTA0NiB8IGludCByYzsKPiA+ID4gPiAgfCBe fgo+ID4gPiA+Cj4gPiA+ID4gQ2M6IE1pY2hhZWwgSnVuZyA8bWlqdW5nQGdteC5uZXQ+Cj4gPiA+ ID4gQ2M6IE1pY2hhZWwgUnVldHRnZXIgPG1pY2hhZWxAaWJtcmEuZGU+Cj4gPiA+ID4gQ2M6IEZy YW5rIEhhdmVya2FtcCA8aGF2ZXJAbGludXguaWJtLmNvbT4KPiA+ID4gPiBDYzogSm9lcmctU3Rl cGhhbiBWb2d0IDxqc3ZvZ3RAZGUuaWJtLmNvbT4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUg Sm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gPiA+IC0tLQo+ID4gPiA+ICBkcml2ZXJz L21pc2MvZ2Vud3FlL2NhcmRfYmFzZS5jIHwgNCArLS0tCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMyBkZWxldGlvbnMoLSkKPiA+ID4gPgo+ID4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL21pc2MvZ2Vud3FlL2NhcmRfYmFzZS5jCj4gPiA+ID4gYi9kcml2ZXJzL21p c2MvZ2Vud3FlL2NhcmRfYmFzZS5jCj4gPiA+ID4gaW5kZXggMWRjNmM3YzVjYmNlOS4uYmNlZWJm NDlkZTJkNSAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL21pc2MvZ2Vud3FlL2NhcmRfYmFz ZS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9taXNjL2dlbndxZS9jYXJkX2Jhc2UuYwo+ID4gPiA+ IEBAIC0xMDQzLDEyICsxMDQzLDEwIEBAIHN0YXRpYyBpbnQgZ2Vud3FlX2hlYWx0aF90aHJlYWRf cnVubmluZyhzdHJ1Y3QKPiA+ID4gPiBnZW53cWVfZGV2ICpjZCkKPiA+ID4gPgo+ID4gPiA+ICBz dGF0aWMgaW50IGdlbndxZV9oZWFsdGhfY2hlY2tfc3RvcChzdHJ1Y3QgZ2Vud3FlX2RldiAqY2Qp Cj4gPiA+ID4gIHsKPiA+ID4gPiAtCWludCByYzsKPiA+ID4gPiAtCj4gPiA+ID4gIAlpZiAoIWdl bndxZV9oZWFsdGhfdGhyZWFkX3J1bm5pbmcoY2QpKQo+ID4gPiA+ICAJCXJldHVybiAtRUlPOwo+ ID4gPiA+Cj4gPiA+ID4gLQlyYyA9IGt0aHJlYWRfc3RvcChjZC0+aGVhbHRoX3RocmVhZCk7Cj4g PiA+ID4gKwlrdGhyZWFkX3N0b3AoY2QtPmhlYWx0aF90aHJlYWQpOwo+ID4gPiA+ICAJY2QtPmhl YWx0aF90aHJlYWQgPSBOVUxMOwo+ID4gPiA+ICAJcmV0dXJuIDA7Cj4gPiA+ID4gIH0KPiA+ID4g Cj4gPiA+IEdvb2QgaWRlYS4gTGV0J3MgcmVtb3ZlIGl0IFRoYW5rcyBmb3IgdGhlIGNvbnRyaWJ1 dGlvbi4KPiA+IAo+ID4gTm8gcHJvYmxlbSwgYW5kIHlvdSBhcmUgd2VsY29tZS4KPiA+IAo+ID4g PiBTaWduZWQtb2ZmLWJ5OiBGcmFuayBIYXZlcmthbXAgPGhhdmVyQGxpbnV4LmlibS5jb20+Cj4g PiAKPiA+IEp1c3QgYXMgYW4gYXNpZGUsIHRoaXMgc2hvdWxkIGJlIEFja2VkLWJ5LCB1bmxlc3Mg eW91IGVpdGhlcgo+ID4gY29udHJpYnV0ZWQgdG8gdGhlIHBhdGNoIGRpcmVjdGx5IG9yIGFyZSBp biB0aGUgZGVsaXZlcnkgcGF0aCBpLmUuIHlvdQo+ID4gcGxhbiB0byBwaWNrIHRoZSBwYXRjaCBh bmQgc2VuZCBpdCB0bywgc2F5IExpbnVzLCB2aWEgYSBwdWxsLXJlcXVlc3QuCj4gCj4gUmlnaHQu IFRoYW5rcyBmb3IgcmVtaW5kaW5nIG1lLiBGZWVsIGZyZWUgdG8gc2VuZCBpdCB5b3Vyc2VsZi4K PiBXaGVuIHdhcyB0aGUgZG9jdW1lbnRhdGlvbiBjaGVja2luZyBpbnRyb2R1Y2VkPyBBdCB0aGUg dGltZSB3ZQo+IGNvbnRyaWJ1dGVkIHRoZSBjb2RlIHRoZXJlIHdhcyBubyBzdWNoIGNoZWNraW5n LgoKVGhlIGNoZWNraW5nIHNjcmlwdHMgaGF2ZSBiZWVuIGluIHBsYWNlIGZvciBtYW55IHllYXJz LCBidXQgaXQgbG9va3MKbGlrZSBkb2MgY2hlY2tpbmcgYmVjYW1lIHBhcnQgb2YgRVhUUkFfR0ND X0NIRUNLUyBidWlsZHMgaW4gMjAxNzoKCj4gY29tbWl0IDNhMDI1ZTFkMWMyZWE0MmZhNDk3Yzlj NmIyMWMyODRlMGY2OWUyOGIKQXV0aG9yOiBNYXR0aGV3IFdpbGNveCA8d2lsbHlAaW5mcmFkZWFk Lm9yZz4KRGF0ZTogICBNb24gTm92IDIwIDEwOjQwOjQwIDIwMTcgLTA4MDAKCiAgICBBZGQgb3B0 aW9uYWwgY2hlY2sgZm9yIGJhZCBrZXJuZWwtZG9jIGNvbW1lbnRzCiAgICAKICAgIEltcGxlbWVu dCBhICctbm9uZScgb3V0cHV0IG1vZGUgZm9yIGtlcm5lbC1kb2Mgd2hpY2ggd2lsbCBvbmx5IG91 dHB1dAogICAgd2FybmluZyBtZXNzYWdlcywgYW5kIHN1cHByZXNzZXMgdGhlIHdhcm5pbmcgbWVz c2FnZSBhYm91dCB0aGVyZSBiZWluZwogICAgbm8ga2VybmVsLWRvYyBpbiB0aGUgZmlsZS4KICAg IAogICAgSWYgdGhlIGJ1aWxkIGhhcyByZXF1ZXN0ZWQgYWRkaXRpb25hbCB3YXJuaW5ncywgYXV0 b21hdGljYWxseSBjaGVjayBhbGwKICAgIC5jIGZpbGVzLiAgVGhpcyBwYXRjaCBkb2VzIG5vdCBj aGVjayAuaCBmaWxlcy4gIEVuYWJsaW5nIHRoZSB3YXJuaW5nCiAgICBieSBkZWZhdWx0IHdvdWxk IGFkZCBhYm91dCAxMzAwIHdhcm5pbmdzLCBzbyBpdCdzIGRlZmF1bHQgb2ZmIGZvciBub3cuCiAg ICBQZW9wbGUgd2hvIGNhcmUgY2FuIHVzZSB0aGlzIHRvIGNoZWNrIHRoZXkgZGlkbid0IGJyZWFr IHRoZSBkb2NzIGFuZAogICAgbWF5YmUgd2UnbGwgZ2V0IGFsbCB0aGUgd2FybmluZ3MgZml4ZWQg YW5kIGJlIGFibGUgdG8gZW5hYmxlIHRoaXMgY2hlY2sKICAgIGJ5IGRlZmF1bHQgaW4gdGhlIGZ1 dHVyZS4KICAgIAogICAgU2lnbmVkLW9mZi1ieTogTWF0dGhldyBXaWxjb3ggPG1hd2lsY294QG1p Y3Jvc29mdC5jb20+CiAgICBTaWduZWQtb2ZmLWJ5OiBKb25hdGhhbiBDb3JiZXQgPGNvcmJldEBs d24ubmV0PgoKZGlmZiAtLWdpdCBhL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQgYi9zY3JpcHRzL01h a2VmaWxlLmJ1aWxkCmluZGV4IDJlM2ExMGU3OWNhOWUuLmFjZWFjMGJhMDc0NTEgMTAwNjQ0Ci0t LSBhL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQKKysrIGIvc2NyaXB0cy9NYWtlZmlsZS5idWlsZApA QCAtMTA4LDYgKzEwOCwxMCBAQCBpZm5lcSAoJChLQlVJTERfQ0hFQ0tTUkMpLDApCiAgIGVuZGlm CiBlbmRpZgogCitpZm5lcSAoJChLQlVJTERfRU5BQkxFX0VYVFJBX0dDQ19DSEVDS1MpLCkKKyAg Y21kX2NoZWNrZG9jID0gJChzcmN0cmVlKS9zY3JpcHRzL2tlcm5lbC1kb2MgLW5vbmUgJDwgOwor ZW5kaWYKKwogIyBEbyBzZWN0aW9uIG1pc21hdGNoIGFuYWx5c2lzIGZvciBlYWNoIG1vZHVsZS9i dWlsdC1pbi5vCiBpZmRlZiBDT05GSUdfREVCVUdfU0VDVElPTl9NSVNNQVRDSAogICBjbWRfc2Vj YW5hbHlzaXMgPSA7IHNjcmlwdHMvbW9kL21vZHBvc3QgJEAKQEAgLTI4OSw2ICsyOTMsNyBAQCBk ZWZpbmUgcnVsZV9jY19vX2MKICAgICAgICAkKGNhbGwgZWNoby1jbWQsY2hlY2tzcmMpICQoY21k X2NoZWNrc3JjKSAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgJChjYWxsIGNtZF9h bmRfZml4ZGVwLGNjX29fYykgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAog ICAgICAgICQoY21kX21vZHZlcnNpb25zX2MpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFwKKyAgICAgICAkKGNtZF9jaGVja2RvYykgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgJChjYWxsIGVjaG8t Y21kLG9ianRvb2wpICQoY21kX29ianRvb2wpICAgICAgICAgICAgICAgICAgICAgICAgICAgXAog ICAgICAgICQoY2FsbCBlY2hvLWNtZCxyZWNvcmRfbWNvdW50KSAkKGNtZF9yZWNvcmRfbWNvdW50 KQogZW5kZWYKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFk IC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJl IGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E32EC433DF for ; Tue, 30 Jun 2020 08:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F0BF20759 for ; Tue, 30 Jun 2020 08:12:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DO5aHBa3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730755AbgF3IMx (ORCPT ); Tue, 30 Jun 2020 04:12:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728073AbgF3IMv (ORCPT ); Tue, 30 Jun 2020 04:12:51 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DE4CC061755 for ; Tue, 30 Jun 2020 01:12:51 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z15so7877998wrl.8 for ; Tue, 30 Jun 2020 01:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=rLJNg6SZ5HWWuZJdX48spsQBewv6zMsf37jjJ1GBFiQ=; b=DO5aHBa3pNUaSGETSWQbzofDqahUYhogpdVMSaV5TJlJRqs3OGdlyZtLoInmnpn22p em373dlDejE5fuud8z1S1bUSgxOzS7iLzlW83StXkc7Ga5xL3v4jBHwQelDaajWtC2dp ullhzxtosXK96KE1TcOpDCTk1l+zG0s1TfKx+8ZCadweQAoTXlb0KaAXVfdhQebo3kMd dsSqaxyReuGgZWoekjOGguN93HVjM9tlZKISxbRSYMPfdkRtMndednWm7oqxlyGNhYH1 au1+FTOV3GzZJaAVjcz62PjOPBPQ8jxsU5cRAYNPI0GL45FdNc3Gg9jE9PbiKgLUvvoH jmUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rLJNg6SZ5HWWuZJdX48spsQBewv6zMsf37jjJ1GBFiQ=; b=rCijSUNvG6DqDp/740kATmqyzBy72HAiCEApYLOjFVqukSPxOKnUjfwuVYG63fvVYX i/UzA+S1EfWmPmaZ2qPO46ovOmu68Ts9NF9jruW4W5VCpxJY67lMVE1mec+MXnvlufvI sOa+ZBDZGFUO0Myf+Ieu9EgR6AFKmumEeJmuJGBsUBbIqE4Rznq7hKz9vfbRf2T91Col AVogC2f/acIXvIXF35imlXqVXYsegEXWiFACDuHnj89Yyiak1aQrFo4KYTLisHKBmkYi 8npKdGwlaqS/HVkdOarC93M5dbG5eBoB00o50IlASKy/2LUDhIRcHfkU7uSNMSqo48wR r8Xg== X-Gm-Message-State: AOAM531VADdhQlmgxj3CqqJ3+8XliwW7j4qSeu8EXHJXRQDrZKmBp+pF RZ7srrWXrlFAxQLnf7tyW9DjYQ== X-Google-Smtp-Source: ABdhPJwzVH84vx569ch3pQWZoaa/tB1s2+xBvZx8nv2vs4jTY0G7z5RQJESw82aZLv7bw+tzTqJuoA== X-Received: by 2002:a05:6000:1283:: with SMTP id f3mr20939240wrx.106.1593504770162; Tue, 30 Jun 2020 01:12:50 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id i17sm2767303wrc.34.2020.06.30.01.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 01:12:49 -0700 (PDT) Date: Tue, 30 Jun 2020 09:12:47 +0100 From: Lee Jones To: haver Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Jung , Michael Ruettger , Frank Haverkamp , Joerg-Stephan Vogt Subject: Re: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc' Message-ID: <20200630081247.GI1179328@dell> References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-17-lee.jones@linaro.org> <20200630074224.GH1179328@dell> <770e66e5f2d7efcea61fc9d57e1053f0@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <770e66e5f2d7efcea61fc9d57e1053f0@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Jun 2020, haver wrote: > On 2020-06-30 09:42, Lee Jones wrote: > > On Tue, 30 Jun 2020, haver wrote: > > > > > On 2020-06-29 16:04, Lee Jones wrote: > > > > Variable 'rc' hasn't been checked since the driver's inception > > > > in 2013. If it hasn't caused any issues since then, it's unlikely > > > > to in the future. Let's take it out for now. > > > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > drivers/misc/genwqe/card_base.c: In function > > > > ‘genwqe_health_check_stop’: > > > > > > > > /home/lee/projects/linux/kernel/drivers/misc/genwqe/card_base.c:1046:6: > > > > warning: variable ‘rc’ set but not used > > > > [-Wunused-but-set-variable] > > > > 1046 | int rc; > > > > | ^~ > > > > > > > > Cc: Michael Jung > > > > Cc: Michael Ruettger > > > > Cc: Frank Haverkamp > > > > Cc: Joerg-Stephan Vogt > > > > Signed-off-by: Lee Jones > > > > --- > > > > drivers/misc/genwqe/card_base.c | 4 +--- > > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/misc/genwqe/card_base.c > > > > b/drivers/misc/genwqe/card_base.c > > > > index 1dc6c7c5cbce9..bceebf49de2d5 100644 > > > > --- a/drivers/misc/genwqe/card_base.c > > > > +++ b/drivers/misc/genwqe/card_base.c > > > > @@ -1043,12 +1043,10 @@ static int genwqe_health_thread_running(struct > > > > genwqe_dev *cd) > > > > > > > > static int genwqe_health_check_stop(struct genwqe_dev *cd) > > > > { > > > > - int rc; > > > > - > > > > if (!genwqe_health_thread_running(cd)) > > > > return -EIO; > > > > > > > > - rc = kthread_stop(cd->health_thread); > > > > + kthread_stop(cd->health_thread); > > > > cd->health_thread = NULL; > > > > return 0; > > > > } > > > > > > Good idea. Let's remove it Thanks for the contribution. > > > > No problem, and you are welcome. > > > > > Signed-off-by: Frank Haverkamp > > > > Just as an aside, this should be Acked-by, unless you either > > contributed to the patch directly or are in the delivery path i.e. you > > plan to pick the patch and send it to, say Linus, via a pull-request. > > Right. Thanks for reminding me. Feel free to send it yourself. > When was the documentation checking introduced? At the time we > contributed the code there was no such checking. The checking scripts have been in place for many years, but it looks like doc checking became part of EXTRA_GCC_CHECKS builds in 2017: > commit 3a025e1d1c2ea42fa497c9c6b21c284e0f69e28b Author: Matthew Wilcox Date: Mon Nov 20 10:40:40 2017 -0800 Add optional check for bad kernel-doc comments Implement a '-none' output mode for kernel-doc which will only output warning messages, and suppresses the warning message about there being no kernel-doc in the file. If the build has requested additional warnings, automatically check all .c files. This patch does not check .h files. Enabling the warning by default would add about 1300 warnings, so it's default off for now. People who care can use this to check they didn't break the docs and maybe we'll get all the warnings fixed and be able to enable this check by default in the future. Signed-off-by: Matthew Wilcox Signed-off-by: Jonathan Corbet diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 2e3a10e79ca9e..aceac0ba07451 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -108,6 +108,10 @@ ifneq ($(KBUILD_CHECKSRC),0) endif endif +ifneq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),) + cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $< ; +endif + # Do section mismatch analysis for each module/built-in.o ifdef CONFIG_DEBUG_SECTION_MISMATCH cmd_secanalysis = ; scripts/mod/modpost $@ @@ -289,6 +293,7 @@ define rule_cc_o_c $(call echo-cmd,checksrc) $(cmd_checksrc) \ $(call cmd_and_fixdep,cc_o_c) \ $(cmd_modversions_c) \ + $(cmd_checkdoc) \ $(call echo-cmd,objtool) $(cmd_objtool) \ $(call echo-cmd,record_mcount) $(cmd_record_mcount) endef -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog