From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC] Host1x/TegraDRM UAPI Date: Tue, 30 Jun 2020 11:09:10 +0200 Message-ID: <20200630090910.GS3278063@phenom.ffwll.local> References: <9b06b7ec-f952-2561-7afb-5653514cd5d3@kapsi.fi> <20200626114040.GA3143884@ulmo> <20200626133837.GE3278063@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Daniel Vetter , Thierry Reding , Karol Herbst , Mikko Perttunen , Jon Hunter , David Airlie , sumit.semwal-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org, "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, bhuntsman-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dri-devel List-Id: linux-tegra@vger.kernel.org On Fri, Jun 26, 2020 at 04:59:45PM +0300, Dmitry Osipenko wrote: > 26.06.2020 16:38, Daniel Vetter пишет: > > On Fri, Jun 26, 2020 at 01:40:40PM +0200, Thierry Reding wrote: > >> On Fri, Jun 26, 2020 at 01:06:58PM +0200, Karol Herbst wrote: > >>> On Tue, Jun 23, 2020 at 3:03 PM Mikko Perttunen wrote: > >>>> > >>>> # Host1x/TegraDRM UAPI proposal > >>>> > >>>> This is a proposal for a stable UAPI for Host1x and TegraDRM, to replace > >>>> the current TegraDRM UAPI that is behind `STAGING` and quite obsolete in > >>>> many ways. > >>>> > >>>> I haven't written any implementation yet -- I'll do that once there is > >>>> some agreement on the high-level design. > >>>> > >>>> Current open items: > >>>> > >>>> * The syncpoint UAPI allows userspace to create sync_file FDs with > >>>> arbitrary syncpoint fences. dma_fence code currently seems to assume all > >>>> fences will be signaled, which would not necessarily be the case with > >>>> this interface. > >>>> * Previously present GEM IOCTLs (GEM_CREATE, GEM_MMAP) are not present. > >>>> Not sure if they are still needed. > >>>> > >>> > >>> Hi, as this wasn't addressed here (and sorry if I missed it): is there > >>> an open source userspace making use of this UAPI? Because this is > >>> something which needs to be seen before it can be included at all. > >> > >> There's a set of commits that implement an earlier draft here: > >> > >> https://github.com/thierryreding/linux/tree/for-5.6/drm-tegra-destage-abi > >> > >> and corresponding changes to libdrm to make use of that and implement > >> tests using the various generations of VIC here: > >> > >> https://cgit.freedesktop.org/~tagr/drm/log/ > >> > >> Before actually jumping to an implementation we wanted to go over the > >> design a bit more to avoid wasting a lot of work, like we've done in > >> the past. Turns out it isn't easy to get everyone to agree on a good > >> ABI. Who would've thought? =) > >> > >> I expect that once the discussion around the ABI settles Mikko will > >> start on implementing this ABI in the kernel and we'll update the > >> libdrm patches to make use of the new ABI as well. > > > > Do we have more than libdrm and tests for this, like something somewhat > > functional? Since tegradrm landed years ago we've refined the criteria a > > bit in this regard, latest version is explicit in that it needs to be > > something that's functional (for end-users in some form), not just > > infrastructure and tests. > > We have Opentegra [1] and VDPAU [2] userspace drivers for older Tegra > SoCs that have been using the staging UAPI for years now. > > [1] https://github.com/grate-driver/xf86-video-opentegra > [2] https://github.com/grate-driver/libvdpau-tegra > > The UAPI and the kernel driver updates are very needed for these drivers > because of the missing UAPI synchronization features and performance > problems of the kernel driver. > > So we already have some real-world userspace for the testing! Awesome! Maybe for future rounds include the links for the vdpau driver. I didn't know about that one at all. -opentegra is probably not so relevant anymore (and I flat out forgot it exists) ... Including the userspace side links is good so that forgetful people like me don't nag :-) -Daniel > It's not the first and not the second time we're discussing the Tegra > DRM UAPI changes, but this time it feels like there is a good chance > that it will finally materialize and I'm very happy about it :) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00AD0C433DF for ; Tue, 30 Jun 2020 09:09:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C475F206A1 for ; Tue, 30 Jun 2020 09:09:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="W4Z47Fua" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C475F206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 328D289DC2; Tue, 30 Jun 2020 09:09:15 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71EE189DC2 for ; Tue, 30 Jun 2020 09:09:14 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id o2so18842143wmh.2 for ; Tue, 30 Jun 2020 02:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=v1q4QGXjMWZSBDrrcU4H5+qS7hC0O+sT9hyxnsYCcqE=; b=W4Z47FuaGv4onoJ956YWoCbld2K8uLJoAdXFtJUqNigpqzWR5e31o4wolvqY33vTyr dlLTVPKJo0VQP26UYJHw/Zwu2XMKywG5HTnXih9WQjpyzBff0POBSrbOTGsSr+zK+mzR uB72DqCvjrPkVp/j8yRs/8+hpbhc7bzH/JMKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=v1q4QGXjMWZSBDrrcU4H5+qS7hC0O+sT9hyxnsYCcqE=; b=Nw3XiXUkbyTsxWkn8Wy/EuwSxGnSd/11GJ6NDMnaw8fLtv9o9F75B+Be0uRiOcdpGa X1Cou9G18TDMDhRk4S5ZjEmlwhd51f9BZrNJ5yRbYHSuLUUlVVLmYALbAl4FrRv6l9JL xQPZ0Xnb2E1kyK1zMTBvY6qnnxMW0ZfMYdGWB9c2gcOA6qmQwaPtNfmQfhuMBc8Q23zr 3X8UOZy6WcCooQn2Oc7No1JOaG8eRF6dxPslleeWuqzsEc9wVyIBM7FnRH3uEQbP9Cnh QNJE2dUgbxrMslbMAsFO1dsI2PkVFtXHleQGxXPRTqcvzHAMrRGc1N0/xp76egCwjRkD Vyng== X-Gm-Message-State: AOAM532oFjxlvl9/S45gZ36iwm78SY+t28PKtZeQvUXKnkMqmDB2WYph yHZAf/To3+6GsCS4GR24/fZJWA== X-Google-Smtp-Source: ABdhPJz01ctYAQj52pCdpr7xZk/xPr+GlIMvpe/7+P5dm7xJPg++jrM25CX+IV6hRjPxU/B7ZotATw== X-Received: by 2002:a1c:7f87:: with SMTP id a129mr21439003wmd.10.1593508152984; Tue, 30 Jun 2020 02:09:12 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id f14sm3298455wro.90.2020.06.30.02.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 02:09:12 -0700 (PDT) Date: Tue, 30 Jun 2020 11:09:10 +0200 From: Daniel Vetter To: Dmitry Osipenko Subject: Re: [RFC] Host1x/TegraDRM UAPI Message-ID: <20200630090910.GS3278063@phenom.ffwll.local> References: <9b06b7ec-f952-2561-7afb-5653514cd5d3@kapsi.fi> <20200626114040.GA3143884@ulmo> <20200626133837.GE3278063@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.6.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mikko Perttunen , Karol Herbst , David Airlie , gustavo@padovan.org, dri-devel , Jon Hunter , talho@nvidia.com, bhuntsman@nvidia.com, Thierry Reding , "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBKdW4gMjYsIDIwMjAgYXQgMDQ6NTk6NDVQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI2LjA2LjIwMjAgMTY6MzgsIERhbmllbCBWZXR0ZXIg0L/QuNGI0LXRgjoKPiA+ IE9uIEZyaSwgSnVuIDI2LCAyMDIwIGF0IDAxOjQwOjQwUE0gKzAyMDAsIFRoaWVycnkgUmVkaW5n IHdyb3RlOgo+ID4+IE9uIEZyaSwgSnVuIDI2LCAyMDIwIGF0IDAxOjA2OjU4UE0gKzAyMDAsIEth cm9sIEhlcmJzdCB3cm90ZToKPiA+Pj4gT24gVHVlLCBKdW4gMjMsIDIwMjAgYXQgMzowMyBQTSBN aWtrbyBQZXJ0dHVuZW4gPGN5bmRpc0BrYXBzaS5maT4gd3JvdGU6Cj4gPj4+Pgo+ID4+Pj4gIyBI b3N0MXgvVGVncmFEUk0gVUFQSSBwcm9wb3NhbAo+ID4+Pj4KPiA+Pj4+IFRoaXMgaXMgYSBwcm9w b3NhbCBmb3IgYSBzdGFibGUgVUFQSSBmb3IgSG9zdDF4IGFuZCBUZWdyYURSTSwgdG8gcmVwbGFj ZQo+ID4+Pj4gdGhlIGN1cnJlbnQgVGVncmFEUk0gVUFQSSB0aGF0IGlzIGJlaGluZCBgU1RBR0lO R2AgYW5kIHF1aXRlIG9ic29sZXRlIGluCj4gPj4+PiBtYW55IHdheXMuCj4gPj4+Pgo+ID4+Pj4g SSBoYXZlbid0IHdyaXR0ZW4gYW55IGltcGxlbWVudGF0aW9uIHlldCAtLSBJJ2xsIGRvIHRoYXQg b25jZSB0aGVyZSBpcwo+ID4+Pj4gc29tZSBhZ3JlZW1lbnQgb24gdGhlIGhpZ2gtbGV2ZWwgZGVz aWduLgo+ID4+Pj4KPiA+Pj4+IEN1cnJlbnQgb3BlbiBpdGVtczoKPiA+Pj4+Cj4gPj4+PiAqIFRo ZSBzeW5jcG9pbnQgVUFQSSBhbGxvd3MgdXNlcnNwYWNlIHRvIGNyZWF0ZSBzeW5jX2ZpbGUgRkRz IHdpdGgKPiA+Pj4+IGFyYml0cmFyeSBzeW5jcG9pbnQgZmVuY2VzLiBkbWFfZmVuY2UgY29kZSBj dXJyZW50bHkgc2VlbXMgdG8gYXNzdW1lIGFsbAo+ID4+Pj4gZmVuY2VzIHdpbGwgYmUgc2lnbmFs ZWQsIHdoaWNoIHdvdWxkIG5vdCBuZWNlc3NhcmlseSBiZSB0aGUgY2FzZSB3aXRoCj4gPj4+PiB0 aGlzIGludGVyZmFjZS4KPiA+Pj4+ICogUHJldmlvdXNseSBwcmVzZW50IEdFTSBJT0NUTHMgKEdF TV9DUkVBVEUsIEdFTV9NTUFQKSBhcmUgbm90IHByZXNlbnQuCj4gPj4+PiBOb3Qgc3VyZSBpZiB0 aGV5IGFyZSBzdGlsbCBuZWVkZWQuCj4gPj4+Pgo+ID4+Pgo+ID4+PiBIaSwgYXMgdGhpcyB3YXNu J3QgYWRkcmVzc2VkIGhlcmUgKGFuZCBzb3JyeSBpZiBJIG1pc3NlZCBpdCk6IGlzIHRoZXJlCj4g Pj4+IGFuIG9wZW4gc291cmNlIHVzZXJzcGFjZSBtYWtpbmcgdXNlIG9mIHRoaXMgVUFQST8gQmVj YXVzZSB0aGlzIGlzCj4gPj4+IHNvbWV0aGluZyB3aGljaCBuZWVkcyB0byBiZSBzZWVuIGJlZm9y ZSBpdCBjYW4gYmUgaW5jbHVkZWQgYXQgYWxsLgo+ID4+Cj4gPj4gVGhlcmUncyBhIHNldCBvZiBj b21taXRzIHRoYXQgaW1wbGVtZW50IGFuIGVhcmxpZXIgZHJhZnQgaGVyZToKPiA+Pgo+ID4+ICAg ICBodHRwczovL2dpdGh1Yi5jb20vdGhpZXJyeXJlZGluZy9saW51eC90cmVlL2Zvci01LjYvZHJt LXRlZ3JhLWRlc3RhZ2UtYWJpCj4gPj4KPiA+PiBhbmQgY29ycmVzcG9uZGluZyBjaGFuZ2VzIHRv IGxpYmRybSB0byBtYWtlIHVzZSBvZiB0aGF0IGFuZCBpbXBsZW1lbnQKPiA+PiB0ZXN0cyB1c2lu ZyB0aGUgdmFyaW91cyBnZW5lcmF0aW9ucyBvZiBWSUMgaGVyZToKPiA+Pgo+ID4+ICAgICBodHRw czovL2NnaXQuZnJlZWRlc2t0b3Aub3JnL350YWdyL2RybS9sb2cvCj4gPj4KPiA+PiBCZWZvcmUg YWN0dWFsbHkganVtcGluZyB0byBhbiBpbXBsZW1lbnRhdGlvbiB3ZSB3YW50ZWQgdG8gZ28gb3Zl ciB0aGUKPiA+PiBkZXNpZ24gYSBiaXQgbW9yZSB0byBhdm9pZCB3YXN0aW5nIGEgbG90IG9mIHdv cmssIGxpa2Ugd2UndmUgZG9uZSBpbgo+ID4+IHRoZSBwYXN0LiBUdXJucyBvdXQgaXQgaXNuJ3Qg ZWFzeSB0byBnZXQgZXZlcnlvbmUgdG8gYWdyZWUgb24gYSBnb29kCj4gPj4gQUJJLiBXaG8gd291 bGQndmUgdGhvdWdodD8gPSkKPiA+Pgo+ID4+IEkgZXhwZWN0IHRoYXQgb25jZSB0aGUgZGlzY3Vz c2lvbiBhcm91bmQgdGhlIEFCSSBzZXR0bGVzIE1pa2tvIHdpbGwKPiA+PiBzdGFydCBvbiBpbXBs ZW1lbnRpbmcgdGhpcyBBQkkgaW4gdGhlIGtlcm5lbCBhbmQgd2UnbGwgdXBkYXRlIHRoZQo+ID4+ IGxpYmRybSBwYXRjaGVzIHRvIG1ha2UgdXNlIG9mIHRoZSBuZXcgQUJJIGFzIHdlbGwuCj4gPiAK PiA+IERvIHdlIGhhdmUgbW9yZSB0aGFuIGxpYmRybSBhbmQgdGVzdHMgZm9yIHRoaXMsIGxpa2Ug c29tZXRoaW5nIHNvbWV3aGF0Cj4gPiBmdW5jdGlvbmFsPyBTaW5jZSB0ZWdyYWRybSBsYW5kZWQg eWVhcnMgYWdvIHdlJ3ZlIHJlZmluZWQgdGhlIGNyaXRlcmlhIGEKPiA+IGJpdCBpbiB0aGlzIHJl Z2FyZCwgbGF0ZXN0IHZlcnNpb24gaXMgZXhwbGljaXQgaW4gdGhhdCBpdCBuZWVkcyB0byBiZQo+ ID4gc29tZXRoaW5nIHRoYXQncyBmdW5jdGlvbmFsIChmb3IgZW5kLXVzZXJzIGluIHNvbWUgZm9y bSksIG5vdCBqdXN0Cj4gPiBpbmZyYXN0cnVjdHVyZSBhbmQgdGVzdHMuCj4gCj4gV2UgaGF2ZSBP cGVudGVncmEgWzFdIGFuZCBWRFBBVSBbMl0gdXNlcnNwYWNlIGRyaXZlcnMgZm9yIG9sZGVyIFRl Z3JhCj4gU29DcyB0aGF0IGhhdmUgYmVlbiB1c2luZyB0aGUgc3RhZ2luZyBVQVBJIGZvciB5ZWFy cyBub3cuCj4gCj4gWzFdIGh0dHBzOi8vZ2l0aHViLmNvbS9ncmF0ZS1kcml2ZXIveGY4Ni12aWRl by1vcGVudGVncmEKPiBbMl0gaHR0cHM6Ly9naXRodWIuY29tL2dyYXRlLWRyaXZlci9saWJ2ZHBh dS10ZWdyYQo+IAo+IFRoZSBVQVBJIGFuZCB0aGUga2VybmVsIGRyaXZlciB1cGRhdGVzIGFyZSB2 ZXJ5IG5lZWRlZCBmb3IgdGhlc2UgZHJpdmVycwo+IGJlY2F1c2Ugb2YgdGhlIG1pc3NpbmcgVUFQ SSBzeW5jaHJvbml6YXRpb24gZmVhdHVyZXMgYW5kIHBlcmZvcm1hbmNlCj4gcHJvYmxlbXMgb2Yg dGhlIGtlcm5lbCBkcml2ZXIuCj4gCj4gU28gd2UgYWxyZWFkeSBoYXZlIHNvbWUgcmVhbC13b3Js ZCB1c2Vyc3BhY2UgZm9yIHRoZSB0ZXN0aW5nIQoKQXdlc29tZSEgTWF5YmUgZm9yIGZ1dHVyZSBy b3VuZHMgaW5jbHVkZSB0aGUgbGlua3MgZm9yIHRoZSB2ZHBhdSBkcml2ZXIuIEkKZGlkbid0IGtu b3cgYWJvdXQgdGhhdCBvbmUgYXQgYWxsLiAtb3BlbnRlZ3JhIGlzIHByb2JhYmx5IG5vdCBzbyBy ZWxldmFudAphbnltb3JlIChhbmQgSSBmbGF0IG91dCBmb3Jnb3QgaXQgZXhpc3RzKSAuLi4gSW5j bHVkaW5nIHRoZSB1c2Vyc3BhY2Ugc2lkZQpsaW5rcyBpcyBnb29kIHNvIHRoYXQgZm9yZ2V0ZnVs IHBlb3BsZSBsaWtlIG1lIGRvbid0IG5hZyA6LSkKLURhbmllbAoKCj4gSXQncyBub3QgdGhlIGZp cnN0IGFuZCBub3QgdGhlIHNlY29uZCB0aW1lIHdlJ3JlIGRpc2N1c3NpbmcgdGhlIFRlZ3JhCj4g RFJNIFVBUEkgY2hhbmdlcywgYnV0IHRoaXMgdGltZSBpdCBmZWVscyBsaWtlIHRoZXJlIGlzIGEg Z29vZCBjaGFuY2UKPiB0aGF0IGl0IHdpbGwgZmluYWxseSBtYXRlcmlhbGl6ZSBhbmQgSSdtIHZl cnkgaGFwcHkgYWJvdXQgaXQgOikKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK