From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: David Gow <davidgow@google.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
Brendan Higgins <brendanhiggins@google.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: Specify IOMEM dependency for adi-axi-adc driver
Date: Tue, 30 Jun 2020 11:06:54 +0100 [thread overview]
Message-ID: <20200630110654.00001d40@Huawei.com> (raw)
In-Reply-To: <20200630070552.1110864-1-davidgow@google.com>
On Tue, 30 Jun 2020 00:05:52 -0700
David Gow <davidgow@google.com> wrote:
> The Analog Devices AXI ADC driver uses the devm_ioremap_resource
> function, but does not specify a dependency on IOMEM in Kconfig. This
> causes a build failure on architectures without IOMEM, for example, UML
> (notably with make allyesconfig).
>
> Fix this by making CONFIG_ADI_AXI_ADC depend on CONFIG_IOMEM.
>
> Signed-off-by: David Gow <davidgow@google.com>
Hi David,
Could you confirm what the build error is? I thought the stubs added in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1bcbfbfdeb
were meant to allow us to avoid having lots of depends on IOMEM lines for the
few architectures who don't support it.
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index ff3569635ce0..f5009b61b80c 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -263,6 +263,7 @@ config AD9467
>
> config ADI_AXI_ADC
> tristate "Analog Devices Generic AXI ADC IP core driver"
> + depends on IOMEM
> select IIO_BUFFER
> select IIO_BUFFER_HW_CONSUMER
> select IIO_BUFFER_DMAENGINE
next prev parent reply other threads:[~2020-06-30 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 7:05 [PATCH] iio: adc: Specify IOMEM dependency for adi-axi-adc driver David Gow
2020-06-30 10:06 ` Jonathan Cameron [this message]
2020-07-01 3:04 ` David Gow
2020-07-01 9:54 ` Jonathan Cameron
2020-06-30 20:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630110654.00001d40@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alexandru.ardelean@analog.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.