From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/4] package/freescale-imx/firmware-imx: Clean up the image/target semantic
Date: Tue, 30 Jun 2020 14:09:34 +0200 [thread overview]
Message-ID: <20200630140934.7b56150f@windsurf> (raw)
In-Reply-To: <20200630115910.GB791671@p1g2>
On Tue, 30 Jun 2020 13:59:10 +0200
Gary Bisson <gary.bisson@boundarydevices.com> wrote:
> > +ifeq ($(BR2_PACKAGE_FIRMWARE_IMX_VPU_MALONE),y)
> > +FIRMWARE_IMX_INSTALL_TARGET = YES
>
> Instead of setting FIRMWARE_IMX_INSTALL_TARGET at multiple places,
> wouldn't it be ok to have it set to YES at the beginning, and worst case
> scenario none of the macros are defined and it does nothing?
>
> Just trying to simplify the package even more. Same goes for
> FIRMWARE_IMX_INSTALL_IMAGES_CMDS.
Yes, I did notice the same thing when reviewing an earlier version of
the patch. But since I didn't had a very strong preference, I didn't
comment on this. I agree setting INSTALL_TARGET = YES and
INSTALL_IMAGES = YES makes things a bit simpler.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-30 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 8:25 [Buildroot] [PATCH v2 0/4] package/freescale-imx: clean-up proposal Stephane Viau
2020-06-29 8:25 ` [Buildroot] [PATCH v2 1/4] package/freescale-imx: Move DDR FW choice down to firmware-imx package Stephane Viau
2020-06-29 8:25 ` [Buildroot] [PATCH v2 2/4] package/freescale-imx/firmware-imx: Add option for all i.MX FW needs Stephane Viau
2020-06-30 11:53 ` Gary Bisson
2020-06-30 12:08 ` Thomas Petazzoni
2020-06-30 12:18 ` Gary Bisson
2020-06-30 12:26 ` Thomas Petazzoni
2020-06-30 12:54 ` Gary Bisson
2020-06-29 8:25 ` [Buildroot] [PATCH v2 3/4] package/freescale-imx/firmware-imx: Clean up the image/target semantic Stephane Viau
2020-06-30 11:59 ` Gary Bisson
2020-06-30 12:09 ` Thomas Petazzoni [this message]
2020-06-29 8:25 ` [Buildroot] [PATCH v2 4/4] package/freescale-imx/firmware-imx: Fix sdma/vpu firmware install path Stephane Viau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630140934.7b56150f@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.