From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf-next] nft_set_pipapo: Drop useless assignment of scratch map index on insert
Date: Tue, 30 Jun 2020 18:44:34 +0200 [thread overview]
Message-ID: <20200630164434.GA25926@salvia> (raw)
In-Reply-To: <033bc756cdecd4e8cbe01be3bcd50e59a844665c.1592167414.git.sbrivio@redhat.com>
On Sun, Jun 14, 2020 at 11:42:07PM +0200, Stefano Brivio wrote:
> In nft_pipapo_insert(), we need to reallocate scratch maps that will
> be used for matching by lookup functions, if they have never been
> allocated or if the bucket size changes as a result of the insertion.
>
> As pipapo_realloc_scratch() provides a pair of fresh, zeroed out
> maps, there's no need to select a particular one after reallocation.
>
> Other than being useless, the existing assignment was also troubled
> by the fact that the index was set only on the CPU performing the
> actual insertion, as spotted by Florian.
>
> Simply drop the assignment.
Applied to nf-next, thanks.
prev parent reply other threads:[~2020-06-30 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 21:42 [PATCH nf-next] nft_set_pipapo: Drop useless assignment of scratch map index on insert Stefano Brivio
2020-06-17 20:00 ` Pablo Neira Ayuso
2020-06-17 20:07 ` Pablo Neira Ayuso
2020-06-17 20:17 ` Stefano Brivio
2020-06-30 16:44 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630164434.GA25926@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.