From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ABC5C433E0 for ; Tue, 30 Jun 2020 20:24:12 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D21E206B6; Tue, 30 Jun 2020 20:24:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="ZBaqFs8p"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="j9JWSuwA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="peu3T7Lc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D21E206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jqMna-0002gn-I0; Tue, 30 Jun 2020 20:24:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqMnZ-0002gf-FV for linux-f2fs-devel@lists.sourceforge.net; Tue, 30 Jun 2020 20:24:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6N+wYIGxnlFz1o+rGrGva/roykQ3/x8/8AfK/NJn09E=; b=ZBaqFs8pjEmE5usz6qn0svLe+3 SZzeP+mFL0W8vOqJwULczXvFv9KpZWX/iCMaJqSSRiZygS4Lq8tnTb5rN4P2AZ9DncWpKEdRF0uPP xOSj2qObpF7z3NWOOqgl8rkYzNG7tsCmKxvwHCwxkNPYNFdBprau+hAiZ6446+J57YQ8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6N+wYIGxnlFz1o+rGrGva/roykQ3/x8/8AfK/NJn09E=; b=j9JWSuwAC/pxwjLElYlkT6FqZL NqykCSnLtPmZNSargmz1bdmP2IJm5jZmqQ8xVtyRK2dlMrEFe98yPFH7oJAonpt4mUPLU2y1lk8xp nKXpLXNcdpFw2CU+pqWf7O/7AwU79plBBqo2GGY6UYuvmX4q381Yrfh7Ns8C743C1bnE=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jqMnT-006Rm0-5I for linux-f2fs-devel@lists.sourceforge.net; Tue, 30 Jun 2020 20:24:09 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9B38206B6; Tue, 30 Jun 2020 20:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593548637; bh=l9RYQ1V9rC0eV/2Cav74VbY6gmCMxIgckvz1UR0Gs5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=peu3T7LcDbJmZ6m1V77CJRMfLPcFdijYiYlvAS7BjXdj96eVSaImqnQof9UnF1h8k deyTLMmDjr0j1U7+Bs5iV/SpK7ZX71d6YqY2/bnENix7jEKj91AP+Akr91Zd6EUe6w SG6OXmtF+/q8CZFJFx0PBnSPMVqVki8VJf61/nZw= Date: Tue, 30 Jun 2020 13:23:57 -0700 From: Jaegeuk Kim To: Randy Dunlap Message-ID: <20200630202357.GA1396584@google.com> References: <020937f3-2947-ca41-c18a-026782216711@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <020937f3-2947-ca41-c18a-026782216711@infradead.org> X-Headers-End: 1jqMnT-006Rm0-5I Subject: Re: [f2fs-dev] [PATCH] f2fs: always expose label 'next_page' X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux FS Devel , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDYvMzAsIFJhbmR5IER1bmxhcCB3cm90ZToKPiBGcm9tOiBSYW5keSBEdW5sYXAgPHJkdW5s YXBAaW5mcmFkZWFkLm9yZz4KPiAKPiBGaXggYnVpbGQgZXJyb3Igd2hlbiBGMkZTX0ZTX0NPTVBS RVNTSU9OIGlzIG5vdCBzZXQvZW5hYmxlZC4KPiBUaGlzIGxhYmVsIGlzIG5lZWRlZCBpbiBlaXRo ZXIgY2FzZS4KPiAKPiAuLi9mcy9mMmZzL2RhdGEuYzogSW4gZnVuY3Rpb24g4oCYZjJmc19tcGFn ZV9yZWFkcGFnZXPigJk6Cj4gLi4vZnMvZjJmcy9kYXRhLmM6MjMyNzo1OiBlcnJvcjogbGFiZWwg 4oCYbmV4dF9wYWdl4oCZIHVzZWQgYnV0IG5vdCBkZWZpbmVkCj4gICAgICBnb3RvIG5leHRfcGFn ZTsKClRoYW5rIHlvdSBmb3IgdGhlIGZpeC4gVGhpcyB3YXMgYWN0dWFsbHkgaW50cm9kdWNlZCBi eSB0aGUgcmVjZW50IHRlc3RpbmcgcGF0Y2guCgpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9z Y20vbGludXgva2VybmVsL2dpdC9qYWVnZXVrL2YyZnMuZ2l0L2NvbW1pdC8/aD1kZXYmaWQ9ZmY5 NjNhZDJiZjU0NDYwNDMxZjUxN2I1Y2FlNDczOTk3YTI5YmYyYQoKSWYgeW91IGRvbid0IG1pbmQs IHBsZWFzZSBsZXQgbWUgaW50ZWdyYXRlIHRoaXMgaW50byB0aGUgb3JpZ2luYWwgcGF0Y2guCkxl dCBtZSBrbm93LgoKVGhhbmtzLAoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBSYW5keSBEdW5sYXAgPHJk dW5sYXBAaW5mcmFkZWFkLm9yZz4KPiBDYzogSmFlZ2V1ayBLaW0gPGphZWdldWtAa2VybmVsLm9y Zz4KPiBDYzogQ2hhbyBZdSA8eXVjaGFvMEBodWF3ZWkuY29tPgo+IENjOiBsaW51eC1mMmZzLWRl dmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldAo+IC0tLQo+ICBmcy9mMmZzL2RhdGEuYyB8ICAgIDIg LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gCj4gLS0tIGxpbnV4LW5leHQt MjAyMDA2MzAub3JpZy9mcy9mMmZzL2RhdGEuYwo+ICsrKyBsaW51eC1uZXh0LTIwMjAwNjMwL2Zz L2YyZnMvZGF0YS5jCj4gQEAgLTIzNjYsOSArMjM2Niw3IEBAIHNldF9lcnJvcl9wYWdlOgo+ICAJ CQl6ZXJvX3VzZXJfc2VnbWVudChwYWdlLCAwLCBQQUdFX1NJWkUpOwo+ICAJCQl1bmxvY2tfcGFn ZShwYWdlKTsKPiAgCQl9Cj4gLSNpZmRlZiBDT05GSUdfRjJGU19GU19DT01QUkVTU0lPTgo+ICBu ZXh0X3BhZ2U6Cj4gLSNlbmRpZgo+ICAJCWlmIChyYWMpCj4gIAkJCXB1dF9wYWdlKHBhZ2UpOwo+ ICAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1mMmZzLWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZv cmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51 eC1mMmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09EEEC433E0 for ; Tue, 30 Jun 2020 20:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8ECC20768 for ; Tue, 30 Jun 2020 20:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593548638; bh=l9RYQ1V9rC0eV/2Cav74VbY6gmCMxIgckvz1UR0Gs5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=H4Y5gR6q9D+1NEFV7wkMQ2QhiaMYyF1zGiua1jZKptaiJKRmTRvJaLXfnCTJG+MrK HllZx96wdMTSO8WHIV0wZppENVn9wQIVPbZdYV9nV6pupbPGViaLCYKKffjPwmykKs KPrCqAdfTWl53580p7tE/nOPP/mr+5/Ug/Mt8tkA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728862AbgF3UX6 (ORCPT ); Tue, 30 Jun 2020 16:23:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:52772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbgF3UX6 (ORCPT ); Tue, 30 Jun 2020 16:23:58 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9B38206B6; Tue, 30 Jun 2020 20:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593548637; bh=l9RYQ1V9rC0eV/2Cav74VbY6gmCMxIgckvz1UR0Gs5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=peu3T7LcDbJmZ6m1V77CJRMfLPcFdijYiYlvAS7BjXdj96eVSaImqnQof9UnF1h8k deyTLMmDjr0j1U7+Bs5iV/SpK7ZX71d6YqY2/bnENix7jEKj91AP+Akr91Zd6EUe6w SG6OXmtF+/q8CZFJFx0PBnSPMVqVki8VJf61/nZw= Date: Tue, 30 Jun 2020 13:23:57 -0700 From: Jaegeuk Kim To: Randy Dunlap Cc: Linux FS Devel , Chao Yu , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH] f2fs: always expose label 'next_page' Message-ID: <20200630202357.GA1396584@google.com> References: <020937f3-2947-ca41-c18a-026782216711@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <020937f3-2947-ca41-c18a-026782216711@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 06/30, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build error when F2FS_FS_COMPRESSION is not set/enabled. > This label is needed in either case. > > ../fs/f2fs/data.c: In function ‘f2fs_mpage_readpages’: > ../fs/f2fs/data.c:2327:5: error: label ‘next_page’ used but not defined > goto next_page; Thank you for the fix. This was actually introduced by the recent testing patch. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=ff963ad2bf54460431f517b5cae473997a29bf2a If you don't mind, please let me integrate this into the original patch. Let me know. Thanks, > > Signed-off-by: Randy Dunlap > Cc: Jaegeuk Kim > Cc: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net > --- > fs/f2fs/data.c | 2 -- > 1 file changed, 2 deletions(-) > > --- linux-next-20200630.orig/fs/f2fs/data.c > +++ linux-next-20200630/fs/f2fs/data.c > @@ -2366,9 +2366,7 @@ set_error_page: > zero_user_segment(page, 0, PAGE_SIZE); > unlock_page(page); > } > -#ifdef CONFIG_F2FS_FS_COMPRESSION > next_page: > -#endif > if (rac) > put_page(page); >