From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: [PATCH v10 2/2] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence Date: Wed, 1 Jul 2020 10:42:32 +0300 Message-ID: <20200701074232.13632-3-digetx@gmail.com> References: <20200701074232.13632-1-digetx@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200701074232.13632-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Sam Ravnborg , Laurent Pinchart , Rob Herring , Frank Rowand Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org When graph isn't defined in a device-tree, the of_graph_get_remote_node() prints a noisy error message, telling that port node is not found. This is undesirable behaviour in our case because absence of a panel/bridge graph is a valid case. Let's check the graph's presence in a device-tree before proceeding with parsing of the graph. Reviewed-by: Sam Ravnborg Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_of.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index b50b44e76279..fdb05fbf72a0 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -246,6 +246,15 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, if (panel) *panel = NULL; + /* + * of_graph_get_remote_node() produces a noisy error message if port + * node isn't found and the absence of the port is a legit case here, + * so at first we silently check whether graph presents in the + * device-tree node. + */ + if (!of_graph_is_present(np)) + return -ENODEV; + remote = of_graph_get_remote_node(np, port, endpoint); if (!remote) return -ENODEV; -- 2.26.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55166C433DF for ; Wed, 1 Jul 2020 07:43:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 350D120722 for ; Wed, 1 Jul 2020 07:43:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p2+CyBm3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728306AbgGAHnK (ORCPT ); Wed, 1 Jul 2020 03:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728322AbgGAHnF (ORCPT ); Wed, 1 Jul 2020 03:43:05 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58608C061755; Wed, 1 Jul 2020 00:43:04 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id t25so21186773lji.12; Wed, 01 Jul 2020 00:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vapTfDZ2f1tAvfpKmc+ZWDOZuBAyLK5G5gnKE1dsXng=; b=p2+CyBm3hryTHrZxURLXskWjQ/8tBPFEijkMuW7RW0ZeOWlUihpvWBa1f0/goGST4d /eeRaDMtMkY6I2Yx+CUMG1HaF9YPolELljK8KUxLZqnvpGxescuIgYoYrMsBENXKMnoN +DttfWVwAzh/o1j2XVIRrM8DxvRCnZAuO9a092SPAT4IztiLlF13xo+iHk1prupsrHi+ I2YLTgUM4mUfmsN+P66YuZb6qJc/dN7fZvl0DbCHQHJEq1RujEWdiZ+xRmn1/nbTGcco 8vdwMsb3m4SHR2tOaLylWAj9buhyOyS/jhoe7ZTXGZfFZ38GdmLpeWaZ4uiKw7RsqeyU BeMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vapTfDZ2f1tAvfpKmc+ZWDOZuBAyLK5G5gnKE1dsXng=; b=M1RgUuc1/xPaGXm6eVEsRa2BrYe/VmDjyew0U+uExWVyutbW7UerQ+OFx51CT5ztIw FYmRIFcCgZxFcJygnIUEbjDfLPdWwR1e1+LHipLhTKmeQE9sBNXw4SVglH75333BWSkJ ak/Ot+ToYVLBJFRDZYKBy5f/9wYa78M2yUqOTmSIKmgWmK89trAnEOQ1+sEMqkmYvjtE H2KAc75qf95M87o25NhQ3yPIVtgWcMjxIttXFOfwnkSMOaIaXga08ppdyOcZYZOBD/KJ z5+N++Pfb0PJyJnEB2ACelbYQ3tLafFzZ/fiqV/gYsGi53VmJygrG6mV2IbARMKvIhcR 8S7w== X-Gm-Message-State: AOAM530Qcy9H/ZhLjfDbfRIjzZOWJ2obf7FsFnxyMYnYw11WthmLBND1 ZJzVn5tQ2xrL4/LfMOrYBsg= X-Google-Smtp-Source: ABdhPJzQnoAy8VMG2guQ6rxw3JWQlodP3SToyfFNxeaRO3AZp9mee0BT7uQeSlEZTyyS++KM44v1lA== X-Received: by 2002:a05:651c:1057:: with SMTP id x23mr11651351ljm.116.1593589382903; Wed, 01 Jul 2020 00:43:02 -0700 (PDT) Received: from localhost.localdomain (79-139-237-54.dynamic.spd-mgts.ru. [79.139.237.54]) by smtp.gmail.com with ESMTPSA id e10sm1520881ljb.118.2020.07.01.00.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 00:43:02 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Sam Ravnborg , Laurent Pinchart , Rob Herring , Frank Rowand Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v10 2/2] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence Date: Wed, 1 Jul 2020 10:42:32 +0300 Message-Id: <20200701074232.13632-3-digetx@gmail.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200701074232.13632-1-digetx@gmail.com> References: <20200701074232.13632-1-digetx@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org When graph isn't defined in a device-tree, the of_graph_get_remote_node() prints a noisy error message, telling that port node is not found. This is undesirable behaviour in our case because absence of a panel/bridge graph is a valid case. Let's check the graph's presence in a device-tree before proceeding with parsing of the graph. Reviewed-by: Sam Ravnborg Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_of.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index b50b44e76279..fdb05fbf72a0 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -246,6 +246,15 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, if (panel) *panel = NULL; + /* + * of_graph_get_remote_node() produces a noisy error message if port + * node isn't found and the absence of the port is a legit case here, + * so at first we silently check whether graph presents in the + * device-tree node. + */ + if (!of_graph_is_present(np)) + return -ENODEV; + remote = of_graph_get_remote_node(np, port, endpoint); if (!remote) return -ENODEV; -- 2.26.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48245C433E0 for ; Thu, 2 Jul 2020 07:24:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20D8520884 for ; Thu, 2 Jul 2020 07:24:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p2+CyBm3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20D8520884 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 964D16E51A; Thu, 2 Jul 2020 07:24:24 +0000 (UTC) Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7418388130 for ; Wed, 1 Jul 2020 07:43:04 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id b25so22177582ljp.6 for ; Wed, 01 Jul 2020 00:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vapTfDZ2f1tAvfpKmc+ZWDOZuBAyLK5G5gnKE1dsXng=; b=p2+CyBm3hryTHrZxURLXskWjQ/8tBPFEijkMuW7RW0ZeOWlUihpvWBa1f0/goGST4d /eeRaDMtMkY6I2Yx+CUMG1HaF9YPolELljK8KUxLZqnvpGxescuIgYoYrMsBENXKMnoN +DttfWVwAzh/o1j2XVIRrM8DxvRCnZAuO9a092SPAT4IztiLlF13xo+iHk1prupsrHi+ I2YLTgUM4mUfmsN+P66YuZb6qJc/dN7fZvl0DbCHQHJEq1RujEWdiZ+xRmn1/nbTGcco 8vdwMsb3m4SHR2tOaLylWAj9buhyOyS/jhoe7ZTXGZfFZ38GdmLpeWaZ4uiKw7RsqeyU BeMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vapTfDZ2f1tAvfpKmc+ZWDOZuBAyLK5G5gnKE1dsXng=; b=DovR9gXFfyIyGnZuuZIeJp4jQjlo8AC3vWjXG8BBHgCYh8rExgi3pOBTI2QX74Og+5 l0o2iQEIikxGIi3KbUErV6taTzWZkn1LumiJfwoZq3urJrV7qXTgJctrZeqQYUpKQCWu Bghe+bDlwymq7dyk2Za8upQpjaaM454a1ixP5drcgUt+xdnoCkLtQwl7R4IaLRLR/7G0 QZyTBvtAGTndf/+eK6IuGtB4AC6SW87r67NIVmq5I3DfzBaWJG6EjDwujo1xd3pCipX6 7g0ucB8fZinKKkNkiFRZf0gVNFhTmFUhI+6eXAKxhFcbGGQBIvVsWEZsV0wxeSqVAByp Ohyw== X-Gm-Message-State: AOAM532BFCsGfG3b+vGo7LbiBqn3Biy3x5uS3QX8JD1vd3XWeiZx5K1G m/Pa8s9agUE/v4+UGBtWy28= X-Google-Smtp-Source: ABdhPJzQnoAy8VMG2guQ6rxw3JWQlodP3SToyfFNxeaRO3AZp9mee0BT7uQeSlEZTyyS++KM44v1lA== X-Received: by 2002:a05:651c:1057:: with SMTP id x23mr11651351ljm.116.1593589382903; Wed, 01 Jul 2020 00:43:02 -0700 (PDT) Received: from localhost.localdomain (79-139-237-54.dynamic.spd-mgts.ru. [79.139.237.54]) by smtp.gmail.com with ESMTPSA id e10sm1520881ljb.118.2020.07.01.00.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 00:43:02 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Sam Ravnborg , Laurent Pinchart , Rob Herring , Frank Rowand Subject: [PATCH v10 2/2] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence Date: Wed, 1 Jul 2020 10:42:32 +0300 Message-Id: <20200701074232.13632-3-digetx@gmail.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200701074232.13632-1-digetx@gmail.com> References: <20200701074232.13632-1-digetx@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 02 Jul 2020 07:24:22 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When graph isn't defined in a device-tree, the of_graph_get_remote_node() prints a noisy error message, telling that port node is not found. This is undesirable behaviour in our case because absence of a panel/bridge graph is a valid case. Let's check the graph's presence in a device-tree before proceeding with parsing of the graph. Reviewed-by: Sam Ravnborg Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_of.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index b50b44e76279..fdb05fbf72a0 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -246,6 +246,15 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, if (panel) *panel = NULL; + /* + * of_graph_get_remote_node() produces a noisy error message if port + * node isn't found and the absence of the port is a legit case here, + * so at first we silently check whether graph presents in the + * device-tree node. + */ + if (!of_graph_is_present(np)) + return -ENODEV; + remote = of_graph_get_remote_node(np, port, endpoint); if (!remote) return -ENODEV; -- 2.26.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel