From: Wolfram Sang <wsa@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used
Date: Wed, 1 Jul 2020 10:48:26 +0200 [thread overview]
Message-ID: <20200701084826.GA2261@ninjato> (raw)
In-Reply-To: <20200701083118.45744-27-lee.jones@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]
On Wed, Jul 01, 2020 at 09:31:14AM +0100, Lee Jones wrote:
> ... as is the case when !CONFIG_ACPI.
>
> Fixes the following W=1 kernel build warning:
>
> drivers/misc/eeprom/at24.c:228:36: warning: ‘at24_acpi_ids’ defined but not used [-Wunused-const-variable=]
>
> Cc: Wolfram Sang <wsa@kernel.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Please CC the maintainer (Bartosz Golaszewski
<bgolaszewski@baylibre.com>) and the I2C list. get_maintainer.pl will
help you doing that automatically. Please also mention if this is
planned to go in via a specific tree and want acks or if you want the
patches to be picked up individually.
> ---
> drivers/misc/eeprom/at24.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 9ff18d4961ceb..2591c21b2b5d8 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -225,7 +225,7 @@ static const struct of_device_id at24_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, at24_of_match);
>
> -static const struct acpi_device_id at24_acpi_ids[] = {
> +static const struct acpi_device_id __maybe_unused at24_acpi_ids[] = {
> { "INT3499", (kernel_ulong_t)&at24_data_INT3499 },
> { "TPF0001", (kernel_ulong_t)&at24_data_24c1024 },
> { /* END OF LIST */ }
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-01 8:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 8:30 [PATCH v2 00/30] Last batch of patches to clean up Misc Lee Jones
2020-07-01 8:30 ` [PATCH v2 01/30] misc: genwqe: card_ddcb: Fix a variety of kerneldoc issues Lee Jones
2020-07-01 8:30 ` [PATCH v2 02/30] misc: genwqe: card_sysfs: Demote function/file headers from kerneldoc Lee Jones
2020-07-01 8:30 ` [PATCH v2 03/30] misc: genwqe: card_debugfs: Demote file header " Lee Jones
2020-07-01 8:30 ` [PATCH v2 04/30] misc: sgi-xp: xp_main: Staticify local functions xp_init() and xp_exit() Lee Jones
2020-07-01 8:30 ` [PATCH v2 05/30] misc: ibmasm: event: Demote function headers from kerneldoc Lee Jones
2020-07-01 8:30 ` [PATCH v2 06/30] misc: ibmasm: command: " Lee Jones
2020-07-01 8:30 ` [PATCH v2 07/30] misc: vmw_vmci_defs: Mark 'struct vmci_handle VMCI_ANON_SRC_HANDLE' as __maybe_unused Lee Jones
2020-07-01 10:33 ` Lee Jones
2020-07-01 8:30 ` [PATCH v2 08/30] misc: ibmasm: r_heartbeat: Demote function headers from kerneldoc Lee Jones
2020-07-01 8:30 ` [PATCH v2 09/30] misc: mic: host: mic_x100: Move declaration of mic_x100_intr_init[] into c-file Lee Jones
2020-07-01 8:30 ` [PATCH v2 10/30] misc: ibmasm: dot_command: Demote function headers from kerneldoc Lee Jones
2020-07-01 8:30 ` [PATCH v2 11/30] misc: mic: host: mic_intr: Properly document function arguments Lee Jones
2020-07-01 8:31 ` [PATCH v2 12/30] misc: mic: host: mic_x100: Add missing descriptions to kerneldoc headers Lee Jones
2020-07-01 8:31 ` [PATCH v2 13/30] misc: mic: card: mic_debugfs: Demote function headers from kerneldoc Lee Jones
2020-07-01 8:31 ` [PATCH v2 14/30] misc: mic: host: " Lee Jones
2020-07-01 8:31 ` [PATCH v2 15/30] misc: mic: cosm: cosm_main: Document 'force' function argument Lee Jones
2020-07-01 8:31 ` [PATCH v2 16/30] misc: mic: scif: scif_ports: Fix copy 'n' paste error Lee Jones
2020-07-01 8:31 ` [PATCH v2 17/30] misc: mic: cosm: cosm_debugfs: Demote function headers from kerneldoc Lee Jones
2020-07-01 8:31 ` [PATCH v2 18/30] misc: mic: scif: scif_api: Remove set but unused variable 'read_size' Lee Jones
2020-07-01 8:31 ` [PATCH v2 19/30] misc: mic: scif: scif_api: Demote scif_accept() function header Lee Jones
2020-07-01 8:31 ` [PATCH v2 20/30] misc: mic: scif: scif_epd: Describe missing 'scifdev' argument(s) Lee Jones
2020-07-01 8:31 ` [PATCH v2 21/30] misc: mic: scif: scif_nodeqp: Fix a bunch of kerneldoc issues Lee Jones
2020-07-01 8:31 ` [PATCH v2 22/30] misc: mic: scif: scif_nm: Supply various kerneldoc fix-ups Lee Jones
2020-07-01 8:31 ` [PATCH v2 23/30] misc: mic: scif: scif_dma: Fix a couple of kerneldoc issues Lee Jones
2020-07-01 8:31 ` [PATCH v2 24/30] misc: mic: scif: scif_fence: Fix a bunch of different documentation issues Lee Jones
2020-07-01 8:31 ` [PATCH v2 25/30] misc: mic: scif: scif_rma: Repair a bunch of kerneldoc issues Lee Jones
2020-07-01 8:31 ` [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used Lee Jones
2020-07-01 8:48 ` Wolfram Sang [this message]
2020-07-01 9:36 ` Lee Jones
2020-07-06 17:16 ` Bartosz Golaszewski
2020-07-01 8:31 ` [PATCH v2 27/30] misc: cxl: hcalls: Demote half-assed kerneldoc attempt Lee Jones
2020-07-01 8:31 ` Lee Jones
2020-07-01 8:31 ` [PATCH v2 28/30] misc: ocxl: config: Provide correct formatting to function headers Lee Jones
2020-07-01 8:31 ` Lee Jones
2020-07-01 8:31 ` [PATCH v2 29/30] misc: ibmvmc: Repair ill-named function argument descriptions Lee Jones
2020-07-01 8:31 ` [PATCH v2 30/30] misc: cxl: flash: Remove unused pointer Lee Jones
2020-07-01 8:31 ` Lee Jones
2020-07-01 13:13 ` Greg KH
2020-07-01 13:13 ` Greg KH
2020-07-01 13:31 ` Lee Jones
2020-07-01 13:31 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701084826.GA2261@ninjato \
--to=wsa@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.