From: Ben Widawsky <ben.widawsky@intel.com>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
alex.shi@linux.alibaba.com, dwagner@suse.de, tobin@kernel.org,
cl@linux.com, akpm@linux-foundation.org, ying.huang@intel.com,
dan.j.williams@intel.com, cai@lca.pw
Subject: Re: [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI
Date: Wed, 1 Jul 2020 09:00:46 -0700 [thread overview]
Message-ID: <20200701160046.kvhsq43adcw46fbq@intel.com> (raw)
In-Reply-To: <20200701152621.D520E62B@viggo.jf.intel.com>
On 20-07-01 08:26:21, Dave Hansen wrote:
> A previous cleanup accidentally changed the vm.zone_reclaim_mode ABI.
>
> This series restores the ABI and then reorganizes the code to make
> the ABI more obvious. Since the single-patch v1[1], I've:
>
> * Restored the RECLAIM_ZONE naming, comment and Documentation now
> that the implicit checks for it are known.
> * Move RECLAIM_* definitions to a uapi header
> * Add a node_reclaim_enabled() helper
>
> Documentation/admin-guide/sysctl/vm.rst | 10 +++++-----
> include/linux/swap.h | 7 +++++++
> include/uapi/linux/mempolicy.h | 7 +++++++
> mm/khugepaged.c | 2 +-
> mm/page_alloc.c | 2 +-
> mm/vmscan.c | 3 ---
> 6 files changed, 21 insertions(+), 10 deletions(-)
>
> 1. https://lore.kernel.org/linux-mm/20200626003459.D8E015CA@viggo.jf.intel.com/
>
> Cc: Ben Widawsky <ben.widawsky@intel.com>
> Cc: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Daniel Wagner <dwagner@suse.de>
> Cc: "Tobin C. Harding" <tobin@kernel.org>
> Cc: Christoph Lameter <cl@linux.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Qian Cai <cai@lca.pw>
> Cc: Daniel Wagner <dwagner@suse.de>
Series is:
Reviewed-by: Ben Widawsky <ben.widawsky@intel.com>
I was more thorough this time in checking all uses of node_reclaim_mode :-). I
do think in patch 2/3, using an enum would be a little better, which I've
mentioned there.
prev parent reply other threads:[~2020-07-01 16:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 15:26 [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI Dave Hansen
2020-07-01 15:26 ` Dave Hansen
2020-07-01 15:26 ` [PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2020-07-01 15:26 ` Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-02 11:28 ` Huang, Ying
2020-07-02 14:36 ` Dave Hansen
2020-07-01 15:26 ` [PATCH 2/3] mm/vmscan: move RECLAIM* bits to uapi header Dave Hansen
2020-07-01 15:26 ` Dave Hansen
2020-07-01 15:46 ` Ben Widawsky
2020-07-01 15:56 ` Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-01 15:26 ` [PATCH 3/3] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks Dave Hansen
2020-07-01 15:26 ` Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-01 20:04 ` Ben Widawsky
2020-07-01 21:29 ` Dave Hansen
2020-07-01 22:01 ` David Rientjes
2020-07-01 16:00 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701160046.kvhsq43adcw46fbq@intel.com \
--to=ben.widawsky@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tobin@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.