All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, dan.carpenter@oracle.com,
	mike.leach@linaro.org
Subject: Re: [PATCH 2/2] coresight: etmv4: Fix CPU power management setup in probe() function
Date: Wed, 1 Jul 2020 18:45:30 +0200	[thread overview]
Message-ID: <20200701164530.GA3172565@kroah.com> (raw)
In-Reply-To: <20200701160852.2782823-3-mathieu.poirier@linaro.org>

On Wed, Jul 01, 2020 at 10:08:52AM -0600, Mathieu Poirier wrote:
> From: Mike Leach <mike.leach@linaro.org>
> 
> The current probe() function calls a pair of cpuhp_xxx API functions to
> setup CPU hotplug handling. The hotplug lock is held for the duration of
> the two calls and other CPU related code using cpus_read_lock() /
> cpus_read_unlock() calls.
> 
> The problem is that on error states, goto: statements bypass the
> cpus_read_unlock() call. This code has increased in complexity as the
> driver has developed.
> 
> This patch introduces a pair of helper functions etm4_pm_setup_cpuslocked()
> and etm4_pm_clear() which correct the issues above and group the PM code a
> little better.
> 
> The two functions etm4_cpu_pm_register() and etm4_cpu_pm_unregister() are
> dropped as these call cpu_pm_register_notifier() / ..unregister_notifier()
> dependent on CONFIG_CPU_PM - but this define is used to nop these functions
> out in the pm headers - so the wrapper functions are superfluous.
> 
> Fixes: f188b5e76aae ("coresight: etm4x: Save/restore state across CPU low power states")
> Fixes: e9f5d63f84fe ("hwtracing/coresight-etm4x: Use cpuhp_setup_state_nocalls_cpuslocked()")
> Fixes: 58eb457be028 ("etm4x: Convert to hotplug state machine")

That should be:
	Fixes: 58eb457be028 ("hwtracing/coresight-etm4x: Convert to hotplug state machine")

I'll go fix it up, but be careful, I don't know where you got that
from...


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2020-07-01 16:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 16:08 [PATCH 0/2] coresight: Fixes for v5.8-rc4 Mathieu Poirier
2020-07-01 16:08 ` [PATCH 1/2] coresight: cti: Fix error handling in probe Mathieu Poirier
2020-07-01 16:08 ` [PATCH 2/2] coresight: etmv4: Fix CPU power management setup in probe() function Mathieu Poirier
2020-07-01 16:45   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701164530.GA3172565@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.