From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA2D6C433E0 for ; Wed, 1 Jul 2020 17:12:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C40E220747 for ; Wed, 1 Jul 2020 17:12:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DOAOc949" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732593AbgGARMb (ORCPT ); Wed, 1 Jul 2020 13:12:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732562AbgGARMa (ORCPT ); Wed, 1 Jul 2020 13:12:30 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80485C08C5DB for ; Wed, 1 Jul 2020 10:12:30 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id a9so822480pjh.5 for ; Wed, 01 Jul 2020 10:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PIlFXACKoqWB73ZXLVGFX7w5yXzBN1zvDpdle+NdF80=; b=DOAOc949O9CUTB+Gk2mL29U2MdsMP2mbZoYw5KIirj1hGMX9xijMLGqUblzFwv/G/x zJLDTmWDlimFSXz69VV7pahROybrgOB8GTQiPcbvVRSnL2MgK3/feKTv1rmquCDZuzZm WYqptjyZpI0e2YgEWodOUQ/yOC56fvUSP9Ge8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PIlFXACKoqWB73ZXLVGFX7w5yXzBN1zvDpdle+NdF80=; b=a9R0ns5tuX+6X6v/vibzI8Fp7EMq904YwfmmvIUQyBaveMwYMepiwevdZnrCnb9f4k rvKxSZSPXVzqUlX0OSLjpSg/sODdAhYmu/EpsMRj9T0IFmlDjD6I9JMCEZi/GiX5emXx s4z/vt0+6GrsLcdpF3HPj699PNsYn/bL7Rl7A6iBvJU8entcFh7n4IynghpJGPyszpxX eRBod9SDEJHNMUcODgJ6HcuEr/PItFfK/+mUXNKQ30UogjMu2r6mzz1mMUPUHC35uDUj Ws/cJN+rvE+db59yGY4GJnoDCamwyfV6t1jSj7MTw9mBgwswFZKnKICh3u+/nAqhIcLj v/Qg== X-Gm-Message-State: AOAM531weFI8NAaR/Q2ERbynVcBUzLcPdPFa4BUA2ZhDn9Jml1EOJeDa +TlKnwtas7WyL0n51+1o/NiipXRE+Xk= X-Google-Smtp-Source: ABdhPJwFtwJvcus7uKKghQac5nLaOjUhOE2/wVY2iBvspvnGYTdn39aGqR8AXvaIifgh9x8exKT2bQ== X-Received: by 2002:a17:90b:4d06:: with SMTP id mw6mr30824966pjb.190.1593623550056; Wed, 01 Jul 2020 10:12:30 -0700 (PDT) Received: from localhost ([2620:15c:202:1:f693:9fff:fef4:e70a]) by smtp.gmail.com with ESMTPSA id a9sm6736188pfr.103.2020.07.01.10.12.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 10:12:29 -0700 (PDT) Date: Wed, 1 Jul 2020 10:12:28 -0700 From: Matthias Kaehlcke To: Jonathan Marek Cc: freedreno@lists.freedesktop.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , Bjorn Andersson , Brian Masney , Fabio Estevam , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list Subject: Re: [PATCH] drm/msm: handle for EPROBE_DEFER for of_icc_get Message-ID: <20200701171228.GC3191083@google.com> References: <20200701030842.24395-1-jonathan@marek.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200701030842.24395-1-jonathan@marek.ca> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Jonathan, On Tue, Jun 30, 2020 at 11:08:41PM -0400, Jonathan Marek wrote: > Check for EPROBE_DEFER instead of silently not using icc if the msm driver > probes before the interconnect driver. Agreed with supporting deferred ICC probing. > Only check for EPROBE_DEFER because of_icc_get can return other errors that > we want to ignore (ENODATA). What would be the -ENODATA case? If the 'interconnects' property is not specified of_icc_get() returns NULL, shouldn't all (or most) errors be propagated rather than staying silent? Thanks Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA143C433E3 for ; Wed, 1 Jul 2020 17:12:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FBDA20747 for ; Wed, 1 Jul 2020 17:12:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DOAOc949" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FBDA20747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 770C16E988; Wed, 1 Jul 2020 17:12:31 +0000 (UTC) Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by gabe.freedesktop.org (Postfix) with ESMTPS id 805F06E988 for ; Wed, 1 Jul 2020 17:12:30 +0000 (UTC) Received: by mail-pl1-x642.google.com with SMTP id x11so10152652plo.7 for ; Wed, 01 Jul 2020 10:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PIlFXACKoqWB73ZXLVGFX7w5yXzBN1zvDpdle+NdF80=; b=DOAOc949O9CUTB+Gk2mL29U2MdsMP2mbZoYw5KIirj1hGMX9xijMLGqUblzFwv/G/x zJLDTmWDlimFSXz69VV7pahROybrgOB8GTQiPcbvVRSnL2MgK3/feKTv1rmquCDZuzZm WYqptjyZpI0e2YgEWodOUQ/yOC56fvUSP9Ge8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PIlFXACKoqWB73ZXLVGFX7w5yXzBN1zvDpdle+NdF80=; b=tv/McXo7WfoWfMDclqBNdb4uTUq6/fVHZws/OYGFVeBGBS7B8utGYr1S1+aZ0qlY+8 E6B8/40QZv665SVNVjFtmRoZ75EIpLqX5CIxYIuqbXTo2zoxF7eK8VrP13cG94vUoCsL Kadn3q4/m2FrXpRAh2JLQmU82mcIcGqMO8g2+QF6QVX23RCuVzGHEEsco7GyecY7Lw+4 +CwF6+mus8wwtwBotH2ZDno7K1abjukO0Q6bbCvuKnpjRHfuM9hrPLVDFhwV9xJiD2fh NQzD7G3XQxYL2WrW2VqN+ZgPj4ahttzW8IFFRJ/mBZLkTZDI/BnvXaLIiGx7r9fnvtr9 QJ4Q== X-Gm-Message-State: AOAM5321qJq7Wv4y0dzM0iDBASFn7cmUq1LPg+LgoeW/pTUXGXlNtZui Av5tXwKXCM+I/WZRFr+y++qb7A== X-Google-Smtp-Source: ABdhPJwFtwJvcus7uKKghQac5nLaOjUhOE2/wVY2iBvspvnGYTdn39aGqR8AXvaIifgh9x8exKT2bQ== X-Received: by 2002:a17:90b:4d06:: with SMTP id mw6mr30824966pjb.190.1593623550056; Wed, 01 Jul 2020 10:12:30 -0700 (PDT) Received: from localhost ([2620:15c:202:1:f693:9fff:fef4:e70a]) by smtp.gmail.com with ESMTPSA id a9sm6736188pfr.103.2020.07.01.10.12.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 10:12:29 -0700 (PDT) Date: Wed, 1 Jul 2020 10:12:28 -0700 From: Matthias Kaehlcke To: Jonathan Marek Subject: Re: [PATCH] drm/msm: handle for EPROBE_DEFER for of_icc_get Message-ID: <20200701171228.GC3191083@google.com> References: <20200701030842.24395-1-jonathan@marek.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701030842.24395-1-jonathan@marek.ca> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , freedreno@lists.freedesktop.org, "open list:DRM DRIVER FOR MSM ADRENO GPU" , Bjorn Andersson , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Sean Paul , open list , Brian Masney Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jonathan, On Tue, Jun 30, 2020 at 11:08:41PM -0400, Jonathan Marek wrote: > Check for EPROBE_DEFER instead of silently not using icc if the msm driver > probes before the interconnect driver. Agreed with supporting deferred ICC probing. > Only check for EPROBE_DEFER because of_icc_get can return other errors that > we want to ignore (ENODATA). What would be the -ENODATA case? If the 'interconnects' property is not specified of_icc_get() returns NULL, shouldn't all (or most) errors be propagated rather than staying silent? Thanks Matthias _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel